Skip to contentSkip to conversation

IMA: Allow only ima-buf template for key measurement

PATCH Superseded Lakshmi Ramasubramanian 2 participants 6 messages Mar 14, 2021 – Mar 17, 2021 Keys-trusted

v2 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 IMA: Allow only ima-buf template for key measurement

ima-buf is the default IMA template used for all buffer measurements. Therefore, IMA policy rule for measuring keys need not specify an IMA template. But if a template is specified for key measurement rule then it must be only ima-buf.

Update keys tests to not require a template to be specified for key measurement rule, but if a template is specified verify it is only ima-buf.

---
 .../security/integrity/ima/tests/ima_keys.sh  | 20 ++++++++++++++++---
 1 file changed, 17 insertions(+), 3 deletions(-)
testcases/kernel/security/integrity/ima/tests/ima_keys.sh +17 -3
index c9eef4b68..b9bef4feb 100755
@@ -15,8 +15,7 @@ TST_CLEANUP=cleanup
 . ima_setup.sh
 
 FUNC_KEYCHECK='func=KEY_CHECK'
-TEMPLATE_BUF='template=ima-buf'
-REQUIRED_POLICY="^measure.*($FUNC_KEYCHECK.*$TEMPLATE_BUF|$TEMPLATE_BUF.*$FUNC_KEYCHECK)"
+REQUIRED_POLICY="^measure.*$FUNC_KEYCHECK"
 
 setup()
 {
@@ -28,12 +27,23 @@ cleanup()
 	tst_is_num $KEYRING_ID && keyctl clear $KEYRING_ID
 }
 
+check_policy_template()
+{
+	while read line; do
+	if ( echo $line | grep -q 'template=') && ( ! echo $line | grep -q 'template=ima-buf' ); then
+		tst_res TCONF "only template=ima-buf can be specified for KEY_CHECK"
+		return 1
+	fi
+	done < $TST_TMPDIR/policy.txt
+	return 0
+}
+
 check_keys_policy()
 {
 	local pattern="$1"
 
 	if ! grep -E "$pattern" $TST_TMPDIR/policy.txt; then
-		tst_res TCONF "IMA policy must specify $pattern, $FUNC_KEYCHECK, $TEMPLATE_BUF"
+		tst_res TCONF "IMA policy must specify $pattern, $FUNC_KEYCHECK"
 		return 1
 	fi
 	return 0
@@ -49,6 +59,8 @@ test1()
 
 	tst_res TINFO "verify key measurement for keyrings and templates specified in IMA policy"
 
+	check_policy_template || return
+
 	check_keys_policy "$pattern" > $tmp_file || return
 	keycheck_lines=$(cat $tmp_file)
 	keyrings=$(for i in $keycheck_lines; do echo "$i" | grep "keyrings" | \
@@ -101,6 +113,8 @@ test2()
 
 	tst_res TINFO "verify measurement of certificate imported into a keyring"
 
+	check_policy_template || return
+
 	check_keys_policy "$pattern" >/dev/null || return
 
 	KEYRING_ID=$(keyctl newring $keyring_name @s) || \
Signature · 1 line
2.30.1
Reviewed-by on v2 1/1
#1 lore raw

Hi Lakshmi, Mimi,

Quoted 8 lines

ima-buf is the default IMA template used for all buffer measurements. Therefore, IMA policy rule for measuring keys need not specify an IMA template. But if a template is specified for key measurement rule then it must be only ima-buf.

Update keys tests to not require a template to be specified for key measurement rule, but if a template is specified verify it is only ima-buf.

Just a double check does it always work without template=ima-buf for all kernel versions? Or only for kernels with dea87d0889dd ("ima: select ima-buf template for buffer measurement") i.e. v5.11-rc1 or backport?

Also, don't we want to change also keycheck.policy?
Currently it contains:
measure func=KEY_CHECK keyrings=.ima|.evm|.builtin_trusted_keys|.blacklist|key_import_test template=ima-buf Do we want to drop template=ima-buf to test the default value? Or have two rules
(one with template=ima-buf, other w/a?)

Mimi, any comment on this?

Kind regards,
Petr

#2 lore raw
Quoted 7 lines · Petr Vorel

Hi Lakshmi, Mimi,

Quoted 4 lines

ima-buf is the default IMA template used for all buffer measurements. Therefore, IMA policy rule for measuring keys need not specify an IMA template. But if a template is specified for key measurement rule then it must be only ima-buf.

Quoted 5 lines
Quoted 3 lines

Update keys tests to not require a template to be specified for key measurement rule, but if a template is specified verify it is only ima-buf.

Thanks Petr.

Quoted 4 lines

Just a double check does it always work without template=ima-buf for all kernel versions? Or only for kernels with dea87d0889dd ("ima: select ima-buf template for buffer measurement") i.e. v5.11-rc1 or backport?

The above change is required. Prior to this change, template has to be specified in the policy, otherwise the default template would be used.

Quoted 6 lines

Also, don't we want to change also keycheck.policy?
Currently it contains:
measure func=KEY_CHECK keyrings=.ima|.evm|.builtin_trusted_keys|.blacklist|key_import_test template=ima-buf Do we want to drop template=ima-buf to test the default value? Or have two rules
(one with template=ima-buf, other w/a?)

Good point.

I will send you the v3 patch - with two rules: one with template=buf and other without a template, like the following example:

measure func=KEY_CHECK keyrings=.builtin_trusted_keys|.blacklist|key_import_test template=ima-buf

measure func=KEY_CHECK keyrings=.ima|.evm

-lakshmi

Quoted 6 lines

Mimi, any comment on this?

Kind regards,
Petr

#3 lore raw

Hi Lakshmi,

Quoted 5 lines
Quoted 3 lines

Just a double check does it always work without template=ima-buf for all kernel versions? Or only for kernels with dea87d0889dd ("ima: select ima-buf template for buffer measurement") i.e. v5.11-rc1 or backport?

The above change is required. Prior to this change, template has to be specified in the policy, otherwise the default template would be used.

The default template is ima-ng, right?
From what you write I understand that "measure func=KEY_CHECK keyrings=.ima|.evm" will work only on newer kernel, thus we should always use template=ima-buf as the policy example so that it's working also on that few kernels between <v5.6,v5.10> (which have IMA key functionality, but not dea87d0889dd), right?

But we should mention that in the README.md.

Kind regards,
Petr

Quoted 16 lines
Quoted 5 lines

Also, don't we want to change also keycheck.policy?
Currently it contains:
measure func=KEY_CHECK keyrings=.ima|.evm|.builtin_trusted_keys|.blacklist|key_import_test template=ima-buf Do we want to drop template=ima-buf to test the default value? Or have two rules
(one with template=ima-buf, other w/a?)

Good point.

I will send you the v3 patch - with two rules: one with template=buf and other without a template, like the following example:

measure func=KEY_CHECK keyrings=.builtin_trusted_keys|.blacklist|key_import_test template=ima-buf

measure func=KEY_CHECK keyrings=.ima|.evm

-lakshmi

#4 lore raw

On 3/16/21 10:21 AM, Petr Vorel wrote:
Hi Petr,

Quoted 7 lines
Quoted 6 lines
Quoted 4 lines

Just a double check does it always work without template=ima-buf for all kernel versions? Or only for kernels with dea87d0889dd ("ima: select ima-buf template for buffer measurement") i.e. v5.11-rc1 or backport?

The above change is required. Prior to this change, template has to be specified in the policy, otherwise the default template would be used.

The default template is ima-ng, right?

Yes: ima-ng is the default template.

Quoted 5 lines
Quoted 1 line

From what you write I understand that "measure func=KEY_CHECK

keyrings=.ima|.evm" will work only on newer kernel, thus we should always use template=ima-buf as the policy example so that it's working also on that few kernels between <v5.6,v5.10> (which have IMA key functionality, but not dea87d0889dd), right?

Yes: In the kernels between v5.6 and v5.10, ima-buf template needs to be specified in the policy for KEY_CHECK.

Quoted 3 lines

But we should mention that in the README.md.

Agreed - will update the README.md

thanks,
-lakshmi

#5 lore raw

Hi Lakshmi,

Quoted 8 lines
Quoted 6 lines
Quoted 5 lines
Quoted 3 lines

Just a double check does it always work without template=ima-buf for all kernel versions? Or only for kernels with dea87d0889dd ("ima: select ima-buf template for buffer measurement") i.e. v5.11-rc1 or backport?

The above change is required. Prior to this change, template has to be specified in the policy, otherwise the default template would be used.

The default template is ima-ng, right?

Yes: ima-ng is the default template.

Quoted 7 lines
Quoted 5 lines
Quoted 1 line

From what you write I understand that "measure func=KEY_CHECK

keyrings=.ima|.evm" will work only on newer kernel, thus we should always use template=ima-buf as the policy example so that it's working also on that few kernels between <v5.6,v5.10> (which have IMA key functionality, but not dea87d0889dd), right?

Yes: In the kernels between v5.6 and v5.10, ima-buf template needs to be specified in the policy for KEY_CHECK.

OK, thus your original version - i.e. don't require template=ima-buf, but keep it in policy example is the best approach.

Quoted 3 lines
Quoted 1 line

But we should mention that in the README.md.

Agreed - will update the README.md

Thanks!

Kind regards,
Petr

Quoted 2 lines

thanks,
-lakshmi