Skip to contentSkip to conversation

clk: rockchip: drop parenthesis from ARM || COMPILE_TEST depends

PATCH Applied Heiko Stuebner 2 participants 5 messages Mar 15, 2021 – Mar 21, 2021

Subsystems (2)
lore
Share & tools
lore

Heiko Stuebner

author maintainer
#0 lore raw

PATCH 1/2 clk: rockchip: drop parenthesis from ARM || COMPILE_TEST depends

As suggested by Stephen in the series adding the rk3568 clock controller the depends works just as well without the parenthesis around the depends.

So to make everything look the same, drop them from existing entries too.

---
 drivers/clk/rockchip/Kconfig | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)
drivers/clk/rockchip/Kconfig +11 -11
index effd05032e85..067aacec96db 100644
@@ -11,77 +11,77 @@ config COMMON_CLK_ROCKCHIP
 if COMMON_CLK_ROCKCHIP
 config CLK_PX30
 	bool "Rockchip PX30 clock controller support"
-	depends on (ARM64 || COMPILE_TEST)
+	depends on ARM64 || COMPILE_TEST
 	default y
 	help
 	  Build the driver for PX30 Clock Driver.
 
 config CLK_RV110X
 	bool "Rockchip RV110x clock controller support"
-	depends on (ARM || COMPILE_TEST)
+	depends on ARM || COMPILE_TEST
 	default y
 	help
 	  Build the driver for RV110x Clock Driver.
 
 config CLK_RK3036
 	bool "Rockchip RK3036 clock controller support"
-	depends on (ARM || COMPILE_TEST)
+	depends on ARM || COMPILE_TEST
 	default y
 	help
 	  Build the driver for RK3036 Clock Driver.
 
 config CLK_RK312X
 	bool "Rockchip RK312x clock controller support"
-	depends on (ARM || COMPILE_TEST)
+	depends on ARM || COMPILE_TEST
 	default y
 	help
 	  Build the driver for RK312x Clock Driver.
 
 config CLK_RK3188
 	bool "Rockchip RK3188 clock controller support"
-	depends on (ARM || COMPILE_TEST)
+	depends on ARM || COMPILE_TEST
 	default y
 	help
 	  Build the driver for RK3188 Clock Driver.
 
 config CLK_RK322X
 	bool "Rockchip RK322x clock controller support"
-	depends on (ARM || COMPILE_TEST)
+	depends on ARM || COMPILE_TEST
 	default y
 	help
 	  Build the driver for RK322x Clock Driver.
 
 config CLK_RK3288
 	bool "Rockchip RK3288 clock controller support"
-	depends on (ARM || COMPILE_TEST)
+	depends on ARM || COMPILE_TEST
 	default y
 	help
 	  Build the driver for RK3288 Clock Driver.
 
 config CLK_RK3308
 	bool "Rockchip RK3308 clock controller support"
-	depends on (ARM64 || COMPILE_TEST)
+	depends on ARM64 || COMPILE_TEST
 	default y
 	help
 	  Build the driver for RK3308 Clock Driver.
 
 config CLK_RK3328
 	bool "Rockchip RK3328 clock controller support"
-	depends on (ARM64 || COMPILE_TEST)
+	depends on ARM64 || COMPILE_TEST
 	default y
 	help
 	  Build the driver for RK3328 Clock Driver.
 
 config CLK_RK3368
 	bool "Rockchip RK3368 clock controller support"
-	depends on (ARM64 || COMPILE_TEST)
+	depends on ARM64 || COMPILE_TEST
 	default y
 	help
 	  Build the driver for RK3368 Clock Driver.
 
 config CLK_RK3399
 	tristate "Rockchip RK3399 clock controller support"
-	depends on (ARM64 || COMPILE_TEST)
+	depends on ARM64 || COMPILE_TEST
 	default y
 	help
 	  Build the driver for RK3399 Clock Driver.
Signature · 7 lines
2.29.2


_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip
author maintainer
#1 lore raw

PATCH 2/2 clk: rockchip: drop MODULE_ALIAS from rk3399 clock controller

As suggested by Stephen during the rk3568 clock review, the MOUDLE_ALIAS doesn't serve any meaningful purpose, so drop it from the rk3399 as well.

---
 drivers/clk/rockchip/clk-rk3399.c | 1 -
 1 file changed, 1 deletion(-)
drivers/clk/rockchip/clk-rk3399.c +0 -1
index 7df2f1e00347..5fe40a2b5d2e 100644
@@ -1655,4 +1655,3 @@ builtin_platform_driver_probe(clk_rk3399_driver, clk_rk3399_probe);
 
 MODULE_DESCRIPTION("Rockchip RK3399 Clock Driver");
 MODULE_LICENSE("GPL");
-MODULE_ALIAS("platform:clk-rk3399");
Signature · 7 lines
2.29.2


_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip
maintainer Reviewed-by on v1 2/2
#2 lore raw

Re: [PATCH 2/2] clk: rockchip: drop MODULE_ALIAS from rk3399 clock controller

Quoting Heiko Stuebner (2021-03-15 04:25:02)

Quoted 6 lines

As suggested by Stephen during the rk3568 clock review, the MOUDLE_ALIAS doesn't serve any meaningful purpose, so drop it from the rk3399 as well.

---

_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip

maintainer Reviewed-by on v1 1/2
#3 lore raw
In reply to Heiko Stuebner

Quoting Heiko Stuebner (2021-03-15 04:25:01)

Quoted 8 lines

As suggested by Stephen in the series adding the rk3568 clock controller the depends works just as well without the parenthesis around the depends.

So to make everything look the same, drop them from existing entries too.

---

_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip

author maintainer Applied
#4 lore raw
In reply to Heiko Stuebner
Quoted 4 lines · Heiko Stuebner

As suggested by Stephen in the series adding the rk3568 clock controller the depends works just as well without the parenthesis around the depends.

So to make everything look the same, drop them from existing entries too.

Applied, thanks!

[1/2] clk: rockchip: drop parenthesis from ARM || COMPILE_TEST depends

      commit: e8c51b90f22031bf3f24d1f06d23bafac250bb62
[2/2] clk: rockchip: drop MODULE_ALIAS from rk3399 clock controller
      commit: 40f29839d8bef5aecaa772afa8e5f2ff8434b49f

Best regards,

Signature · 6 lines
Heiko Stuebner <[email protected]>

_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip