Skip to contentSkip to conversation

Add dax mount option to man xfs(5)

PATCH Superseded Carlos Maiolino 2 participants 4 messages Mar 15, 2021 – Apr 6, 2021

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Add dax mount option to man xfs(5)

Details are already in kernel's documentation, but make dax mount option information accessible through xfs(5) manpage.

---
 man/man5/xfs.5 | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
man/man5/xfs.5 +18 -0
index 7642662f..46b0558a 100644
@@ -133,6 +133,24 @@ by the filesystem.
 CRC enabled filesystems always use the attr2 format, and so
 will reject the noattr2 mount option if it is set.
 .TP
+.BR dax=value
+Set DAX behavior for the current filesystem. This mount option accepts the
+following values:
+
+"dax=inode" DAX will be enabled only on files with FS_XFLAG_DAX applied.
+
+"dax=never" DAX will be disabled by the whole filesystem including files with
+FS_XFLAG_DAX applied"
+
+"dax=always" DAX will be enabled to every file in the filesystem inclduing files
+without FS_XFLAG_DAX applied"
+
+If no option is used when mounting a pmem device, dax=inode will be used as
+default.
+
+For details regarding DAX behavior in kernel, please refer to kernel's
+documentation at filesystems/dax.txt
+.TP
 .BR discard | nodiscard
 Enable/disable the issuing of commands to let the block
 device reclaim space freed by the filesystem.  This is
Signature · 1 line
2.29.2
#1 lore raw
Quoted 5 lines · Carlos Maiolino

Details are already in kernel's documentation, but make dax mount option information accessible through xfs(5) manpage.

---

Polite ping :)

Quoted 35 lines
 man/man5/xfs.5 | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
man/man5/xfs.5 +18 -0
index 7642662f..46b0558a 100644
@@ -133,6 +133,24 @@ by the filesystem.
 CRC enabled filesystems always use the attr2 format, and so
 will reject the noattr2 mount option if it is set.
 .TP
+.BR dax=value
+Set DAX behavior for the current filesystem. This mount option accepts the
+following values:
+
+"dax=inode" DAX will be enabled only on files with FS_XFLAG_DAX applied.
+
+"dax=never" DAX will be disabled by the whole filesystem including files with
+FS_XFLAG_DAX applied"
+
+"dax=always" DAX will be enabled to every file in the filesystem inclduing files
+without FS_XFLAG_DAX applied"
+
+If no option is used when mounting a pmem device, dax=inode will be used as
+default.
+
+For details regarding DAX behavior in kernel, please refer to kernel's
+documentation at filesystems/dax.txt
+.TP
 .BR discard | nodiscard
 Enable/disable the issuing of commands to let the block
 device reclaim space freed by the filesystem.  This is
Signature · 1 line
2.29.2
Signature · 1 line
Carlos
#2 lore raw
In reply to Carlos Maiolino
Quoted 13 lines · Carlos Maiolino

Details are already in kernel's documentation, but make dax mount option information accessible through xfs(5) manpage.

---
 man/man5/xfs.5 | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
man/man5/xfs.5 +0 -0
index 7642662f..46b0558a 100644

man/man5/xfs.5 by the filesystem. · line 137

Quoted 5 lines
man/man5/xfs.5 +2 -0
@@ -133,6 +133,24 @@ by the filesystem.
 CRC enabled filesystems always use the attr2 format, and so
 will reject the noattr2 mount option if it is set.
 .TP
+.BR dax=value
+Set DAX behavior for the current filesystem. This mount option accepts the

It might be worth defining what DAX (the acronym) is...

"Set CPU direct access (DAX) behavior for regular files in the filesystem."

man/man5/xfs.5 by the filesystem. · line 140

Quoted 3 lines
man/man5/xfs.5 +3 -0
+following values:
+
+"dax=inode" DAX will be enabled only on files with FS_XFLAG_DAX applied.

"...enabled on regular files..."

man/man5/xfs.5 by the filesystem. · line 143

Quoted 3 lines
man/man5/xfs.5 +3 -0
+
+"dax=never" DAX will be disabled by the whole filesystem including files with
+FS_XFLAG_DAX applied"

"DAX will not be enabled for any files. FS_XFLAG_DAX will be ignored."

man/man5/xfs.5 by the filesystem. · line 145

Quoted 2 lines
man/man5/xfs.5 +2 -0
+
+"dax=always" DAX will be enabled to every file in the filesystem inclduing files

"DAX will be enabled for all regular files, regardless of the FS_XFLAG_DAX state."

man/man5/xfs.5 by the filesystem. · line 148

Quoted 3 lines
man/man5/xfs.5 +3 -0
+without FS_XFLAG_DAX applied"
+
+If no option is used when mounting a pmem device, dax=inode will be used as

"If no option is used when mounting a filesystem stored on a device capable of DAX access modes, dax=inode...."

(DAX is a possibility with more than just persistent memory now...)

--D

Quoted 11 lines
man/man5/xfs.5 +5 -0
+default.
+
+For details regarding DAX behavior in kernel, please refer to kernel's
+documentation at filesystems/dax.txt
+.TP
 .BR discard | nodiscard
 Enable/disable the issuing of commands to let the block
 device reclaim space freed by the filesystem.  This is
Signature · 1 line
2.29.2
#3 lore raw
Quoted 43 lines · Darrick J. Wong
Quoted 13 lines · Carlos Maiolino

Details are already in kernel's documentation, but make dax mount option information accessible through xfs(5) manpage.

---
 man/man5/xfs.5 | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
man/man5/xfs.5 +0 -0
index 7642662f..46b0558a 100644

man/man5/xfs.5 by the filesystem. · line 137

Quoted 5 lines
man/man5/xfs.5 +2 -0
@@ -133,6 +133,24 @@ by the filesystem.
 CRC enabled filesystems always use the attr2 format, and so
 will reject the noattr2 mount option if it is set.
 .TP
+.BR dax=value
+Set DAX behavior for the current filesystem. This mount option accepts the

It might be worth defining what DAX (the acronym) is...

"Set CPU direct access (DAX) behavior for regular files in the filesystem."

man/man5/xfs.5 by the filesystem. · line 140

Quoted 3 lines
man/man5/xfs.5 +3 -0
+following values:
+
+"dax=inode" DAX will be enabled only on files with FS_XFLAG_DAX applied.

"...enabled on regular files..."

man/man5/xfs.5 by the filesystem. · line 143

Quoted 3 lines
man/man5/xfs.5 +3 -0
+
+"dax=never" DAX will be disabled by the whole filesystem including files with
+FS_XFLAG_DAX applied"

"DAX will not be enabled for any files. FS_XFLAG_DAX will be ignored."

man/man5/xfs.5 by the filesystem. · line 145

Quoted 2 lines
man/man5/xfs.5 +2 -0
+
+"dax=always" DAX will be enabled to every file in the filesystem inclduing files

"DAX will be enabled for all regular files, regardless of the FS_XFLAG_DAX state."

Quoted 9 lines

man/man5/xfs.5 by the filesystem. · line 148

Quoted 3 lines
man/man5/xfs.5 +3 -0
+without FS_XFLAG_DAX applied"
+
+If no option is used when mounting a pmem device, dax=inode will be used as

"If no option is used when mounting a filesystem stored on a device capable of DAX access modes, dax=inode...."

(DAX is a possibility with more than just persistent memory now...)

Thanks for the review Darrick. All the changes make sense to me, I'll apply them and send a V2.

Cheers.

Signature · 1 line
Carlos