nvme-tcp: Fix misuse of __smp_processor_id with preemption enabled
Sagi Grimberg
maintainerPATCH 1/1 nvme-tcp: Fix misuse of __smp_processor_id with preemption enabled
For our pure advisory use-case, we only rely on this call as a hint so fix the warning complaints of using the smp_processor_id variants with preemption enabled.
--- drivers/nvme/host/tcp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/nvme/host/tcp.c +1 -1
@@ -287,7 +287,7 @@ static inline void nvme_tcp_queue_request(struct nvme_tcp_request *req,* directly, otherwise queue io_work. Also, only do that if we * are on the same cpu, so we don't introduce contention. */ -if (queue->io_cpu ==__smp_processor_id () && +if (queue->io_cpu ==raw_smp_processor_id () && sync && empty &&mutex_trylock (&queue->send_mutex)) { queue->more_requests = !last;nvme_tcp_send_all (queue);
Signature · 7 lines
2.27.0 _______________________________________________ Linux-nvme mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-nvme
Quoted 7 lines · Sagi Grimberg
For our pure advisory use-case, we only rely on this call as a hint so fix the warning complaints of using the
smp_processor_idvariants with preemption enabled.Fixes db5ad6b7f8cd ("nvme-tcp: try to send request in queue_rq context")Fixes ada831772188 ("nvme-tcp: Fix warning with CONFIG_DEBUG_PREEMPT")Signed-off-by Sagi Grimberg <[email protected]>
This patch adds the call that is discussed on the earlier thread.
Looks good.
_______________________________________________
Linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme
Thanks.
Quoted 16 lines · Sagi Grimberg
For our pure advisory use-case, we only rely on this call as a hint so fix the warning complaints of using the
smp_processor_idvariants with preemption enabled.Fixes db5ad6b7f8cd ("nvme-tcp: try to send request in queue_rq context")Fixes ada831772188 ("nvme-tcp: Fix warning with CONFIG_DEBUG_PREEMPT")Signed-off-by Sagi Grimberg <[email protected]>--- drivers/nvme/host/tcp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/nvme/host/tcp.c +0
-0
drivers/nvme/host/tcp.c static inline void nvme_tcp_queue_request(struct nvme_tcp_request *req, · line 293
Quoted 8 lines
drivers/nvme/host/tcp.c +1
-1@@ -287,7 +287,7 @@ static inline void nvme_tcp_queue_request(struct nvme_tcp_request *req,* directly, otherwise queue io_work. Also, only do that if we * are on the same cpu, so we don't introduce contention. */ -if (queue->io_cpu ==__smp_processor_id () && +if (queue->io_cpu ==raw_smp_processor_id () && sync && empty &&mutex_trylock (&queue->send_mutex)) { queue->more_requests = !last;nvme_tcp_send_all (queue);
_______________________________________________
Linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme
Applied to nvme-5.12.
_______________________________________________
Linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme