Skip to contentSkip to conversation

libbpf: use SOCK_CLOEXEC when opening the netlink socket

PATCH Applied Kumar Kartikeya Dwivedi 3 participants 3 messages Mar 17, 2021 – Mar 18, 2021

Subsystems (4)
Networking Network drivers BPF libbpf
lore
Share & tools
lore

Kumar Kartikeya Dwivedi

author maintainer
#0 lore raw

PATCH v2 1/1 libbpf: use SOCK_CLOEXEC when opening the netlink socket

Otherwise, there exists a small window between the opening and closing of the socket fd where it may leak into processes launched by some other thread.

Fixes 949abbe88436 ("libbpf: add function to setup XDP")
Signed-off-by Kumar Kartikeya Dwivedi <[email protected]>

---
Changelog:

v1 -> v2
Tag the bpf-next tree (Toke)
Add a Fixes: tag (Toke)

---
 tools/lib/bpf/netlink.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/lib/bpf/netlink.c +1 -1
index 4dd73de00..d2cb28e9e 100644
@@ -40,7 +40,7 @@ static int libbpf_netlink_open(__u32 *nl_pid)
 	memset(&sa, 0, sizeof(sa));
 	sa.nl_family = AF_NETLINK;
 
-	sock = socket(AF_NETLINK, SOCK_RAW, NETLINK_ROUTE);
+	sock = socket(AF_NETLINK, SOCK_RAW | SOCK_CLOEXEC, NETLINK_ROUTE);
 	if (sock < 0)
 		return -errno;
Signature · 1 line
2.30.2
CI Applied
#2 lore raw
In reply to Kumar Kartikeya Dwivedi
This patch was applied to bpf/bpf.git (refs/heads/master):

Hello:

This patch was applied to bpf/bpf.git (refs/heads/master):

Quoted 8 lines · On Wed, 17 Mar 2021 17:28:58 +0530 you wrote:

Otherwise, there exists a small window between the opening and closing of the socket fd where it may leak into processes launched by some other thread.

Fixes 949abbe88436 ("libbpf: add function to setup XDP")
Signed-off-by Kumar Kartikeya Dwivedi <[email protected]>

[...]

Here is the summary with links:
- [bpf-next,v2] libbpf: use SOCK_CLOEXEC when opening the netlink socket

    https://git.kernel.org/bpf/bpf/c/58bfd95b554f

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html