blk-mq: Trivial typo fix and sentence construction for better readability
PATCH v3 1/1 blk-mq: Trivial typo fix and sentence construction for better readability
A typo fix and sentence reconstruction for better readability.
---
Changes from V2:
Thanks, Randy and Tom for the suggestion,mould it. Missed the subject line prefix of pattern,so added back
block/blk-mq-tag.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
block/blk-mq-tag.c +2 -2
@@ -373,8 +373,8 @@ static bool blk_mq_tagset_count_completed_rqs(struct request *rq, }/** -* blk_mq_tagset_wait_completed_request - wait until all completed req's -* complete funtion is run +* blk_mq_tagset_wait_completed_request - wait until all the req's +* functions completed their run * @tagset: Tag set to drain completed request * * Note: This function has to be run after all IO queues are shutdown
--
2.26.2
Jens Axboe
maintainerQuoted 17 lines · Bhaskar Chowdhury
A typo fix and sentence reconstruction for better readability.
Signed-off-by Bhaskar Chowdhury <[email protected]>---
Changes from V2:
Thanks, Randy and Tom for the suggestion,mould it. Missed the subject line prefix of pattern,so added backblock/blk-mq-tag.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)block/blk-mq-tag.c +0
-0
block/blk-mq-tag.c static bool blk_mq_tagset_count_completed_rqs(struct request *rq, · line 377
Quoted 7 lines
block/blk-mq-tag.c +2
-2@@ -373,8 +373,8 @@ static bool blk_mq_tagset_count_completed_rqs(struct request *rq, }/** -* blk_mq_tagset_wait_completed_request - wait until all completed req's -* complete funtion is run +* blk_mq_tagset_wait_completed_request - wait until all the req's +* functions completed their run
This is still nonsense, see reply to previous version.
Signature · 1 line
Jens Axboe
Quoted 20 lines · Jens Axboe
Quoted 19 lines · Bhaskar Chowdhury
A typo fix and sentence reconstruction for better readability.
Signed-off-by Bhaskar Chowdhury <[email protected]>---
Changes from V2:
Thanks, Randy and Tom for the suggestion,mould it. Missed the subject line prefix of pattern,so added backblock/blk-mq-tag.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)block/blk-mq-tag.c +0
-0@@ -373,8 +373,8 @@ static bool blk_mq_tagset_count_completed_rqs(struct request *rq, }
Quoted 8 lines
block/blk-mq-tag.c static bool blk_mq_tagset_count_completed_rqs(struct request *rq, · line 377
Quoted 5 lines
block/blk-mq-tag.c +2
-2/** -* blk_mq_tagset_wait_completed_request - wait until all completed req's -* complete funtion is run +* blk_mq_tagset_wait_completed_request - wait until all the req's +* functions completed their run This is still nonsense, see reply to previous version.
Well, I was just trying get a sense of your sense...so ...it's all yours fella,take on ...
Quoted 3 lines
--
Jens Axboe
Jens Axboe
maintainerQuoted 29 lines · Bhaskar Chowdhury
Quoted 20 lines · Jens Axboe
Quoted 19 lines · Bhaskar Chowdhury
A typo fix and sentence reconstruction for better readability.
Signed-off-by Bhaskar Chowdhury <[email protected]>---
Changes from V2:
Thanks, Randy and Tom for the suggestion,mould it. Missed the subject line prefix of pattern,so added backblock/blk-mq-tag.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)block/blk-mq-tag.c +0
-0@@ -373,8 +373,8 @@ static bool blk_mq_tagset_count_completed_rqs(struct request *rq, }Quoted 8 lines
block/blk-mq-tag.c static bool blk_mq_tagset_count_completed_rqs(struct request *rq, · line 377
Quoted 5 lines
block/blk-mq-tag.c +2
-2/** -* blk_mq_tagset_wait_completed_request - wait until all completed req's -* complete funtion is run +* blk_mq_tagset_wait_completed_request - wait until all the req's +* functions completed their run This is still nonsense, see reply to previous version.
Quoted 2 lines
Well, I was just trying get a sense of your sense...so ...it's all yours fella,take on ...
It's not my sense, I didn't write that function or comment. Just seems pointless to me to update it and not get it actually legible and correct, which is why I sent you a suggestion to what should be. From that point of view, the suggested change actually makes it _worse_, because "requests functions completed their run" doesn't mean anything. At least the current one is kind of legible, since the "complete function" refers to the IPI completion function, which is what we're waiting for here.
In any case, what I replied in v2 should be generally readable, and avoids the weird req's thing too which I really dislike. Just uses requests, that's correct and avoids a nonsensical possessive.
So do send a v4 if you want with that wording.
Signature · 1 line
Jens Axboe
Quoted 42 lines · Jens Axboe
Quoted 29 lines · Bhaskar Chowdhury
Quoted 20 lines · Jens Axboe
Quoted 19 lines · Bhaskar Chowdhury
A typo fix and sentence reconstruction for better readability.
Signed-off-by Bhaskar Chowdhury <[email protected]>---
Changes from V2:
Thanks, Randy and Tom for the suggestion,mould it. Missed the subject line prefix of pattern,so added backblock/blk-mq-tag.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)block/blk-mq-tag.c +0
-0@@ -373,8 +373,8 @@ static bool blk_mq_tagset_count_completed_rqs(struct request *rq, }Quoted 8 lines
block/blk-mq-tag.c static bool blk_mq_tagset_count_completed_rqs(struct request *rq, · line 377
Quoted 5 lines
block/blk-mq-tag.c +2
-2/** -* blk_mq_tagset_wait_completed_request - wait until all completed req's -* complete funtion is run +* blk_mq_tagset_wait_completed_request - wait until all the req's +* functions completed their run This is still nonsense, see reply to previous version.
Quoted 2 lines
Well, I was just trying get a sense of your sense...so ...it's all yours fella,take on ...
It's not my sense, I didn't write that function or comment. Just seems pointless to me to update it and not get it actually legible and correct, which is why I sent you a suggestion to what should be. From that point of view, the suggested change actually makes it _worse_, because "requests functions completed their run" doesn't mean anything. At least the current one is kind of legible, since the "complete function" refers to the IPI completion function, which is what we're waiting for here.
Quoted 6 lines
In any case, what I replied in v2 should be generally readable, and avoids the weird req's thing too which I really dislike. Just uses requests, that's correct and avoids a nonsensical possessive.
So do send a v4 if you want with that wording.
I am apologetic about the pain I caused you to take this long route. I shall be
prudent in the future. Thanks for standing, Jens.
Quoted 3 lines
--
Jens Axboe
Jens Axboe
maintainerQuoted 43 lines · Bhaskar Chowdhury
Quoted 42 lines · Jens Axboe
Quoted 29 lines · Bhaskar Chowdhury
Quoted 20 lines · Jens Axboe
Quoted 19 lines · Bhaskar Chowdhury
A typo fix and sentence reconstruction for better readability.
Signed-off-by Bhaskar Chowdhury <[email protected]>---
Changes from V2:
Thanks, Randy and Tom for the suggestion,mould it. Missed the subject line prefix of pattern,so added backblock/blk-mq-tag.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)block/blk-mq-tag.c +0
-0@@ -373,8 +373,8 @@ static bool blk_mq_tagset_count_completed_rqs(struct request *rq, }Quoted 8 lines
block/blk-mq-tag.c static bool blk_mq_tagset_count_completed_rqs(struct request *rq, · line 377
Quoted 5 lines
block/blk-mq-tag.c +2
-2/** -* blk_mq_tagset_wait_completed_request - wait until all completed req's -* complete funtion is run +* blk_mq_tagset_wait_completed_request - wait until all the req's +* functions completed their run This is still nonsense, see reply to previous version.
Quoted 2 lines
Well, I was just trying get a sense of your sense...so ...it's all yours fella,take on ...
It's not my sense, I didn't write that function or comment. Just seems pointless to me to update it and not get it actually legible and correct, which is why I sent you a suggestion to what should be. From that point of view, the suggested change actually makes it _worse_, because "requests functions completed their run" doesn't mean anything. At least the current one is kind of legible, since the "complete function" refers to the IPI completion function, which is what we're waiting for here.
Quoted 8 lines
Quoted 6 lines
In any case, what I replied in v2 should be generally readable, and avoids the weird req's thing too which I really dislike. Just uses requests, that's correct and avoids a nonsensical possessive.
So do send a v4 if you want with that wording.
I am apologetic about the pain I caused you to take this long route. I shall be
prudent in the future. Thanks for standing, Jens.
Well, at least the end result pulled it to completion :-)
Signature · 1 line
Jens Axboe