Skip to contentSkip to conversation

KVM: x86: A typo fix

PATCH In review Bhaskar Chowdhury 3 participants 4 messages Mar 20, 2021 – Mar 22, 2021

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 KVM: x86: A typo fix

s/resued/resumed/

---
 arch/x86/include/asm/kvm_host.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/include/asm/kvm_host.h +1 -1
index 9bc091ecaaeb..eae82551acb1 100644
@@ -1470,7 +1470,7 @@ extern u64 kvm_mce_cap_supported;
 /*
  * EMULTYPE_NO_DECODE - Set when re-emulating an instruction (after completing
  *			userspace I/O) to indicate that the emulation context
- *			should be resued as is, i.e. skip initialization of
+ *			should be resumed as is, i.e. skip initialization of
  *			emulation context, instruction fetch and decode.
  *
  * EMULTYPE_TRAP_UD - Set when emulating an intercepted #UD from hardware.

--
2.26.2

Acked-by on v1 1/1
#1 lore raw
Quoted 4 lines · Bhaskar Chowdhury

s/resued/resumed/

Quoted 21 lines

---
arch/x86/include/asm/kvm_host.h | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/include/asm/kvm_host.h +1 -2
index 9bc091ecaaeb..eae82551acb1 100644
@@ -1470,7 +1470,7 @@ extern u64 kvm_mce_cap_supported;
 /*
 * EMULTYPE_NO_DECODE - Set when re-emulating an instruction (after completing
 *			userspace I/O) to indicate that the emulation context
- *			should be resued as is, i.e. skip initialization of
+ *			should be resumed as is, i.e. skip initialization of
 *			emulation context, instruction fetch and decode.
 *
 * EMULTYPE_TRAP_UD - Set when emulating an intercepted #UD from hardware.
--

2.26.2

#2 lore raw
Quoted 16 lines · Randy Dunlap
Quoted 4 lines · Bhaskar Chowdhury

s/resued/resumed/

Quoted 4 lines

---
arch/x86/include/asm/kvm_host.h | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 11 lines

arch/x86/include/asm/kvm_host.h extern u64 kvm_mce_cap_supported; · line 1474

Quoted 11 lines
arch/x86/include/asm/kvm_host.h +1 -1
index 9bc091ecaaeb..eae82551acb1 100644
@@ -1470,7 +1470,7 @@ extern u64 kvm_mce_cap_supported;
 /*
 * EMULTYPE_NO_DECODE - Set when re-emulating an instruction (after completing
 *			userspace I/O) to indicate that the emulation context
- *			should be resued as is, i.e. skip initialization of
+ *			should be resumed as is, i.e. skip initialization of
 *			emulation context, instruction fetch and decode.

This is the *wrong* fix, the correct word in this context is 'reused', not 'resumed' ...

See how I fixed most arch/x86/ typo fixes in tip:x86/cleanups:

d9f6e12fb0b7: ("x86: Fix various typos in comments") 163b099146b8: ("x86: Fix various typos in comments, take #2")

These single file typo fixes are a bad idea for another reason as well, as they create a lot of unnecessary churn.

Thanks,

Ingo

#3 lore raw
Quoted 5 lines · Ingo Molnar

These single file typo fixes are a bad idea for another reason as well, as they create a lot of unnecessary churn.

Huh! I was expecting it from the moment I started doing it ...finally it arrives.

I am not sure about "so called workflowo of others" ..I am gonna do it in my way as long as it providing good.

I think this is best way to do it.

~Bhaskar