Skip to contentSkip to conversation

Staging: rtl8723bs: Remove unreferenced struct's

PATCH New Marco Cesati 1 participant 20 messages Mar 22, 2021 Staging

lore
Share & tools
lore
#0 lore raw

cover Staging: rtl8723bs: Remove unreferenced struct's

The staging/rtl8723bs driver includes 83 struct definifions that are never referenced in the code. This patchset removes all of them.

[PATCH 01/19] Staging: rtl8723bs: remove useless structs in rtw_mlme.h [PATCH 02/19] Staging: rtl8723bs: remove useless structs in rtw_cmd.h [PATCH 03/19] Staging: rtl8723bs: remove useless structs in rtw_recv.h [PATCH 04/19] Staging: rtl8723bs: remove useless structs in drv_types.h [PATCH 05/19] Staging: rtl8723bs: remove useless structs in rtw_ioctl_set.h [PATCH 06/19] Staging: rtl8723bs: remove useless structs in wlan_bssdef.h [PATCH 07/19] Staging: rtl8723bs: remove useless structs in rtw_mp.h [PATCH 08/19] Staging: rtl8723bs: remove useless structs in hal_intf.h [PATCH 09/19] Staging: rtl8723bs: remove useless structs in rtw_event.h [PATCH 10/19] Staging: rtl8723bs: remove useless structs in rtl8723b_recv.h [PATCH 11/19] Staging: rtl8723bs: remove useless structs in rtw_security.h [PATCH 12/19] Staging: rtl8723bs: remove useless structs in rtw_wifi_regd.h [PATCH 13/19] Staging: rtl8723bs: remove useless structs in rtw_io.h [PATCH 14/19] Staging: rtl8723bs: remove useless structs in wifi.h [PATCH 15/19] Staging: rtl8723bs: remove useless structs in hal_phy.h [PATCH 16/19] Staging: rtl8723bs: remove useless structs in rtw_xmit.h [PATCH 17/19] Staging: rtl8723bs: remove useless structs in ieee80211.h [PATCH 18/19] Staging: rtl8723bs: remove useless structs in odm_HWConfig.h [PATCH 19/19] Staging: rtl8723bs: remove useless structs in odm.h

 drivers/staging/rtl8723bs/hal/odm.h           |  61 -----
 drivers/staging/rtl8723bs/hal/odm_HWConfig.h  |  45 ----
 drivers/staging/rtl8723bs/include/drv_types.h |   9 -
 drivers/staging/rtl8723bs/include/hal_intf.h  |   8 -
 drivers/staging/rtl8723bs/include/hal_phy.h   |  24 --
 drivers/staging/rtl8723bs/include/ieee80211.h |  94 -------
 .../staging/rtl8723bs/include/rtl8723b_recv.h |  44 ----
 drivers/staging/rtl8723bs/include/rtw_cmd.h   | 231 ------------------
 drivers/staging/rtl8723bs/include/rtw_event.h |  11 -
 drivers/staging/rtl8723bs/include/rtw_io.h    | 111 ---------
 .../staging/rtl8723bs/include/rtw_ioctl_set.h |   6 -
 drivers/staging/rtl8723bs/include/rtw_mlme.h  |  38 ---
 drivers/staging/rtl8723bs/include/rtw_mp.h    |  17 --
 drivers/staging/rtl8723bs/include/rtw_recv.h  |   7 -
 .../staging/rtl8723bs/include/rtw_security.h  |   6 -
 .../staging/rtl8723bs/include/rtw_wifi_regd.h |   5 -
 drivers/staging/rtl8723bs/include/rtw_xmit.h  |   5 -
 drivers/staging/rtl8723bs/include/wifi.h      |  15 --
 .../staging/rtl8723bs/include/wlan_bssdef.h   |  26 --
 19 files changed, 763 deletions(-)
Signature · 1 line
2.30.2
#1 lore raw

PATCH 1/19 Staging: rtl8723bs: remove useless structs in rtw_mlme.h

Remove the following unreferenced struct's in include/rtw_mlme.h:

struct cfg80211_wifidirect_info
struct tdls_info
struct tdls_txmgmt

---
 drivers/staging/rtl8723bs/include/rtw_mlme.h | 38 --------------------
 1 file changed, 38 deletions(-)
drivers/staging/rtl8723bs/include/rtw_mlme.h +0 -38
index 02d973a5aed2..25cfb4cc021b 100644
@@ -202,16 +202,6 @@ struct scan_limit_info {
 	u8 			operation_ch[2];				/* 	Store the operation channel of invitation request frame */
 };
 
-struct cfg80211_wifidirect_info {
-	struct timer_list					remain_on_ch_timer;
-	u8 				restore_channel;
-	struct ieee80211_channel	remain_on_ch_channel;
-	enum nl80211_channel_type	remain_on_ch_type;
-	u64						remain_on_ch_cookie;
-	bool is_ro_ch;
-	unsigned long last_ro_ch_time; /* this will be updated at the beginning and end of ro_ch */
-};
-
 struct wifidirect_info {
 	struct adapter				*padapter;
 	struct timer_list					find_phase_timer;
@@ -292,34 +282,6 @@ struct tdls_ss_record {	/* signal strength record */
 	u8 is_tdls_sta;	/*  true: direct link sta, false: else */
 };
 
-struct tdls_info {
-	u8 			ap_prohibited;
-	u8 			link_established;
-	u8 			sta_cnt;
-	u8 			sta_maximum;	/*  1:tdls sta is equal (NUM_STA-1), reach max direct link number; 0: else; */
-	struct tdls_ss_record	ss_record;
-	u8 			ch_sensing;
-	u8 			cur_channel;
-	u8 			candidate_ch;
-	u8 			collect_pkt_num[MAX_CHANNEL_NUM];
-	spinlock_t				cmd_lock;
-	spinlock_t				hdl_lock;
-	u8 			watchdog_count;
-	u8 			dev_discovered;		/* WFD_TDLS: for sigma test */
-	u8 			tdls_enable;
-	u8 			external_setup;	/*  true: setup is handled by wpa_supplicant */
-};
-
-struct tdls_txmgmt {
-	u8 peer[ETH_ALEN];
-	u8 action_code;
-	u8 dialog_token;
-	u16 status_code;
-	u8 *buf;
-	size_t len;
-	u8 external_support;
-};
-
 /* used for mlme_priv.roam_flags */
 enum {
 	RTW_ROAM_ON_EXPIRED = BIT0,
Signature · 1 line
2.30.2
#2 lore raw

PATCH 2/19 Staging: rtl8723bs: remove useless structs in rtw_cmd.h

In reply to Marco Cesati

Remove the following unreferenced struct's in include/rtw_cmd.h:

struct P2P_PS_Offload_t
struct P2P_PS_CTWPeriod_t
struct usb_suspend_parm
struct getbasicrate_rsp
struct getdatarate_rsp
struct readBB_parm
struct readBB_rsp
struct readTSSI_parm
struct readTSSI_rsp
struct writeBB_parm
struct readRF_parm
struct readRF_rsp
struct writeRF_parm
struct getrfintfs_parm
struct settxagctbl_parm
struct gettxagctbl_parm
struct gettxagctbl_rsp
struct setagcctrl_parm
struct setssup_parm
struct getssup_parm
struct getssup_rsp
struct setssdlevel_parm
struct getssdlevel_parm
struct getssdlevel_rsp
struct setssulevel_parm
struct getssulevel_parm
struct getssulevel_rsp
struct setratable_parm
struct getratable_parm
struct getratable_rsp
struct gettxretrycnt_parm
struct gettxretrycnt_rsp
struct getrxretrycnt_parm
struct getrxretrycnt_rsp
struct getbcnokcnt_parm
struct getbcnokcnt_rsp
struct getbcnerrcnt_parm
struct getbcnerrcnt_rsp
struct getcurtxpwrlevel_parm
struct getcurtxpwrlevel_rsp
struct setprobereqextraie_parm
struct setassocreqextraie_parm
struct setproberspextraie_parm
struct setassocrspextraie_parm

---
 drivers/staging/rtl8723bs/include/rtw_cmd.h | 231 --------------------
 1 file changed, 231 deletions(-)
drivers/staging/rtl8723bs/include/rtw_cmd.h +0 -231
index 6f3b018463e4..88cbc12ce5d4 100644
@@ -107,21 +107,6 @@ struct c2h_evt_hdr_88xx {
 
 #define c2h_evt_valid(c2h_evt) ((c2h_evt)->id || (c2h_evt)->plen)
 
-struct P2P_PS_Offload_t {
-	u8 Offload_En:1;
-	u8 role:1; /*  1: Owner, 0: Client */
-	u8 CTWindow_En:1;
-	u8 NoA0_En:1;
-	u8 NoA1_En:1;
-	u8 AllStaSleep:1; /*  Only valid in Owner */
-	u8 discovery:1;
-	u8 rsvd:1;
-};
-
-struct P2P_PS_CTWPeriod_t {
-	u8 CTWPeriod;	/* TU */
-};
-
 int rtw_enqueue_cmd(struct cmd_priv *pcmdpriv, struct cmd_obj *obj);
 extern struct cmd_obj *rtw_dequeue_cmd(struct cmd_priv *pcmdpriv);
 extern void rtw_free_cmd_obj(struct cmd_obj *pcmd);
@@ -174,18 +159,6 @@ enum rfintfs {
 	HWPI,
 };
 
-/*
-Caller Mode: Infra, Ad-HoC(C)
-
-Notes: To enter USB suspend mode
-
-Command Mode
-
-*/
-struct usb_suspend_parm {
-	u32 action;/*  1: sleep, 0:resume */
-};
-
 /*
 Caller Mode: Infra, Ad-HoC
 
@@ -399,10 +372,6 @@ struct getbasicrate_parm {
 	u32 rsvd;
 };
 
-struct getbasicrate_rsp {
-	u8 basicrates[NumRates];
-};
-
 /*
 Caller Mode: Any
 
@@ -428,10 +397,6 @@ struct getdatarate_parm {
 	u32 rsvd;
 
 };
-struct getdatarate_rsp {
-	u8 datarates[NumRates];
-};
-
 
 /*
 Caller Mode: Any
@@ -456,11 +421,6 @@ struct	getphyinfo_parm {
 	u32 rsvd;
 };
 
-struct	getphyinfo_rsp {
-	struct regulatory_class class_sets[NUM_REGULATORYS];
-	u8 status;
-};
-
 /*
 Caller Mode: Any
 
@@ -487,46 +447,6 @@ struct	getphy_parm {
 	u32 rsvd;
 
 };
-struct	getphy_rsp {
-	u8 rfchannel;
-	u8 modem;
-};
-
-struct readBB_parm {
-	u8 offset;
-};
-struct readBB_rsp {
-	u8 value;
-};
-
-struct readTSSI_parm {
-	u8 offset;
-};
-struct readTSSI_rsp {
-	u8 value;
-};
-
-struct writeBB_parm {
-	u8 offset;
-	u8 value;
-};
-
-struct readRF_parm {
-	u8 offset;
-};
-struct readRF_rsp {
-	u32 value;
-};
-
-struct writeRF_parm {
-	u32 offset;
-	u32 value;
-};
-
-struct getrfintfs_parm {
-	u8 rfintfs;
-};
-
 
 struct Tx_Beacon_param {
 	struct wlan_bssid_ex network;
@@ -596,161 +516,10 @@ struct drvextra_cmd_parm {
 
 /*------------------- Below are used for RF/BB tunning ---------------------*/
 
-struct	setantenna_parm {
-	u8 tx_antset;
-	u8 rx_antset;
-	u8 tx_antenna;
-	u8 rx_antenna;
-};
-
-struct	enrateadaptive_parm {
-	u32 en;
-};
-
-struct settxagctbl_parm {
-	u32 txagc[MAX_RATES_LENGTH];
-};
-
-struct gettxagctbl_parm {
-	u32 rsvd;
-};
-struct gettxagctbl_rsp {
-	u32 txagc[MAX_RATES_LENGTH];
-};
-
-struct setagcctrl_parm {
-	u32 agcctrl;		/*  0: pure hw, 1: fw */
-};
-
-
-struct setssup_parm	{
-	u32 ss_ForceUp[MAX_RATES_LENGTH];
-};
-
-struct getssup_parm	{
-	u32 rsvd;
-};
-struct getssup_rsp	{
-	u8 ss_ForceUp[MAX_RATES_LENGTH];
-};
-
-
-struct setssdlevel_parm	{
-	u8 ss_DLevel[MAX_RATES_LENGTH];
-};
-
-struct getssdlevel_parm	{
-	u32 rsvd;
-};
-struct getssdlevel_rsp	{
-	u8 ss_DLevel[MAX_RATES_LENGTH];
-};
-
-struct setssulevel_parm	{
-	u8 ss_ULevel[MAX_RATES_LENGTH];
-};
-
-struct getssulevel_parm	{
-	u32 rsvd;
-};
-struct getssulevel_rsp	{
-	u8 ss_ULevel[MAX_RATES_LENGTH];
-};
-
-
-struct	setcountjudge_parm {
-	u8 count_judge[MAX_RATES_LENGTH];
-};
-
-struct	getcountjudge_parm {
-	u32 rsvd;
-};
 struct	getcountjudge_rsp {
 	u8 count_judge[MAX_RATES_LENGTH];
 };
 
-
-struct setratable_parm {
-	u8 ss_ForceUp[NumRates];
-	u8 ss_ULevel[NumRates];
-	u8 ss_DLevel[NumRates];
-	u8 count_judge[NumRates];
-};
-
-struct getratable_parm {
-                uint rsvd;
-};
-struct getratable_rsp {
-        u8 ss_ForceUp[NumRates];
-        u8 ss_ULevel[NumRates];
-        u8 ss_DLevel[NumRates];
-        u8 count_judge[NumRates];
-};
-
-
-/* to get TX, RX retry count */
-struct gettxretrycnt_parm {
-	unsigned int rsvd;
-};
-struct gettxretrycnt_rsp {
-	unsigned long tx_retrycnt;
-};
-
-struct getrxretrycnt_parm {
-	unsigned int rsvd;
-};
-struct getrxretrycnt_rsp {
-	unsigned long rx_retrycnt;
-};
-
-/* to get BCNOK, BCNERR count */
-struct getbcnokcnt_parm {
-	unsigned int rsvd;
-};
-struct getbcnokcnt_rsp {
-	unsigned long  bcnokcnt;
-};
-
-struct getbcnerrcnt_parm {
-	unsigned int rsvd;
-};
-struct getbcnerrcnt_rsp {
-	unsigned long bcnerrcnt;
-};
-
-/*  to get current TX power level */
-struct getcurtxpwrlevel_parm {
-	unsigned int rsvd;
-};
-struct getcurtxpwrlevel_rsp {
-	unsigned short tx_power;
-};
-
-struct setprobereqextraie_parm {
-	unsigned char e_id;
-	unsigned char ie_len;
-	unsigned char ie[0];
-};
-
-struct setassocreqextraie_parm {
-	unsigned char e_id;
-	unsigned char ie_len;
-	unsigned char ie[0];
-};
-
-struct setproberspextraie_parm {
-	unsigned char e_id;
-	unsigned char ie_len;
-	unsigned char ie[0];
-};
-
-struct setassocrspextraie_parm {
-	unsigned char e_id;
-	unsigned char ie_len;
-	unsigned char ie[0];
-};
-
-
 struct addBaReq_parm {
 	unsigned int tid;
 	u8 addr[ETH_ALEN];
Signature · 1 line
2.30.2
#3 lore raw

PATCH 3/19 Staging: rtl8723bs: remove useless structs in rtw_recv.h

In reply to Marco Cesati

Remove the following unreferenced struct in include/rtw_recv.h:

struct smooth_rssi_data

---
 drivers/staging/rtl8723bs/include/rtw_recv.h | 7 -------
 1 file changed, 7 deletions(-)
drivers/staging/rtl8723bs/include/rtw_recv.h +0 -7
index 3e2ee7f75e8c..2709c9413dbc 100644
@@ -69,13 +69,6 @@ struct	stainfo_rxcache	{
 };
 
 
-struct smooth_rssi_data {
-	u32 elements[100];	/* array to store values */
-	u32 index;			/* index to current array to store */
-	u32 total_num;		/* num of valid elements */
-	u32 total_val;		/* sum of valid elements */
-};
-
 struct signal_stat {
 	u8 update_req;		/* used to indicate */
 	u8 avg_val;		/* avg of valid elements */
Signature · 1 line
2.30.2
#4 lore raw

PATCH 4/19 Staging: rtl8723bs: remove useless structs in drv_types.h

In reply to Marco Cesati

Remove the following unreferenced struct in include/drv_types.h:

struct specific_device_id

---
 drivers/staging/rtl8723bs/include/drv_types.h | 9 ---------
 1 file changed, 9 deletions(-)
drivers/staging/rtl8723bs/include/drv_types.h +0 -9
index 3119acea4389..1658450b386e 100644
@@ -77,15 +77,6 @@ enum _nic_version {
 #define SPEC_DEV_ID_RF_CONFIG_2T2R BIT(4)
 #define SPEC_DEV_ID_ASSIGN_IFNAME BIT(5)
 
-struct specific_device_id {
-
-	u32 	flags;
-
-	u16 	idVendor;
-	u16 	idProduct;
-
-};
-
 struct registry_priv {
 	u8 chip_version;
 	u8 rfintfs;
Signature · 1 line
2.30.2
#5 lore raw

PATCH 5/19 Staging: rtl8723bs: remove useless structs in rtw_ioctl_set.h

In reply to Marco Cesati

Remove the following unreferenced struct in include/rtw_ioctl_set.h:

struct BSSIDInfo

---
 drivers/staging/rtl8723bs/include/rtw_ioctl_set.h | 6 ------
 1 file changed, 6 deletions(-)
drivers/staging/rtl8723bs/include/rtw_ioctl_set.h +0 -6
index 4b929b84040a..d6d3c39a69c6 100644
@@ -10,12 +10,6 @@
 
 typedef u8 NDIS_802_11_PMKID_VALUE[16];
 
-struct BSSIDInfo {
-	NDIS_802_11_MAC_ADDRESS  BSSID;
-	NDIS_802_11_PMKID_VALUE  PMKID;
-};
-
-
 u8 rtw_set_802_11_authentication_mode(struct adapter *pdapter, enum ndis_802_11_authentication_mode authmode);
 u8 rtw_set_802_11_bssid(struct adapter *padapter, u8 *bssid);
 u8 rtw_set_802_11_add_wep(struct adapter *padapter, struct ndis_802_11_wep *wep);
Signature · 1 line
2.30.2
#6 lore raw

PATCH 6/19 Staging: rtl8723bs: remove useless structs in wlan_bssdef.h

In reply to Marco Cesati

Remove the following unreferenced struct's in include/wlan_bssdef.h:

	struct ndis_802_11_association_information
	struct ndis_802_11_key
	struct ndis_802_11_remove_key
---
 .../staging/rtl8723bs/include/wlan_bssdef.h   | 26 -------------------
 1 file changed, 26 deletions(-)
drivers/staging/rtl8723bs/include/wlan_bssdef.h +0 -26
index 259835386597..9d63dc003795 100644
@@ -127,38 +127,12 @@ struct ndis_801_11_ai_resfi {
 	u16 AssociationId;
 };
 
-struct ndis_802_11_association_information {
-	u32                   Length;
-	u16                  AvailableRequestFixedIEs;
-	struct ndis_802_11_ai_reqfi    RequestFixedIEs;
-	u32                   RequestIELength;
-	u32                   OffsetRequestIEs;
-	u16                  AvailableResponseFixedIEs;
-	struct ndis_801_11_ai_resfi    ResponseFixedIEs;
-	u32                   ResponseIELength;
-	u32                   OffsetResponseIEs;
-};
-
 enum ndis_802_11_reload_defaults {
 	Ndis802_11ReloadWEPKeys
 };
 
 
 /*  Key mapping keys require a BSSID */
-struct ndis_802_11_key {
-	u32           Length;             /*  Length of this structure */
-	u32           KeyIndex;
-	u32           KeyLength;          /*  length of key in bytes */
-	NDIS_802_11_MAC_ADDRESS BSSID;
-	unsigned long long KeyRSC;
-	u8           KeyMaterial[32];     /*  variable length depending on above field */
-};
-
-struct ndis_802_11_remove_key {
-	u32                   Length;        /*  Length of this structure */
-	u32                   KeyIndex;
-	NDIS_802_11_MAC_ADDRESS BSSID;
-};
 
 struct ndis_802_11_wep {
 	u32 Length;        /*  Length of this structure */
Signature · 1 line
2.30.2
#7 lore raw

PATCH 7/19 Staging: rtl8723bs: remove useless structs in rtw_mp.h

In reply to Marco Cesati

Remove the following unreferenced struct's in include/rtw_mp.h:

struct iocmd_struct
struct rf_reg_param
struct bb_reg_param

---
 drivers/staging/rtl8723bs/include/rtw_mp.h | 17 -----------------
 1 file changed, 17 deletions(-)
drivers/staging/rtl8723bs/include/rtw_mp.h +0 -17
index 75171d30bcda..ead63cf09fe0 100644
@@ -259,23 +259,6 @@ struct mp_priv {
 	u8 *TXradomBuffer;
 };
 
-struct iocmd_struct {
-	u8 cmdclass;
-	u16 value;
-	u8 index;
-};
-
-struct rf_reg_param {
-	u32 path;
-	u32 offset;
-	u32 value;
-};
-
-struct bb_reg_param {
-	u32 offset;
-	u32 value;
-};
-
 #define LOWER	true
 #define RAISE	false
 
Signature · 1 line
2.30.2
#8 lore raw

PATCH 8/19 Staging: rtl8723bs: remove useless structs in hal_intf.h

In reply to Marco Cesati

Remove the following unreferenced struct in include/hal_intf.h:

struct wowlan_ioctl_param

---
 drivers/staging/rtl8723bs/include/hal_intf.h | 8 --------
 1 file changed, 8 deletions(-)
drivers/staging/rtl8723bs/include/hal_intf.h +0 -8
index 5cae87782059..3cd46a670e6d 100644
@@ -288,14 +288,6 @@ enum wowlan_subcode {
 	WOWLAN_AP_DISABLE		= 13
 };
 
-struct wowlan_ioctl_param {
-	unsigned int subcode;
-	unsigned int subcode_value;
-	unsigned int wakeup_reason;
-	unsigned int len;
-	unsigned char pattern[0];
-};
-
 #define Rx_Pairwisekey			0x01
 #define Rx_GTK					0x02
 #define Rx_DisAssoc				0x04
Signature · 1 line
2.30.2
#9 lore raw

PATCH 9/19 Staging: rtl8723bs: remove useless structs in rtw_event.h

In reply to Marco Cesati

Remove the following unreferenced struct's in include/rtw_event.h:

struct addba_event
struct c2hevent_queue

---
 drivers/staging/rtl8723bs/include/rtw_event.h | 11 -----------
 1 file changed, 11 deletions(-)
drivers/staging/rtl8723bs/include/rtw_event.h +0 -11
index 560521c80ace..d48bae5416fe 100644
@@ -60,10 +60,6 @@ struct stadel_event {
  int mac_id;
 };
 
-struct addba_event {
-	unsigned int tid;
-};
-
 struct wmm_event {
 	unsigned char wmm;
 };
@@ -88,13 +84,6 @@ struct event_node {
 	int	caller_ff_sz;
 };
 
-struct c2hevent_queue {
-	volatile int	head;
-	volatile int	tail;
-	struct	event_node	nodes[C2HEVENT_SZ];
-	unsigned char seq;
-};
-
 #define NETWORK_QUEUE_SZ	4
 
 struct network_queue {
Signature · 1 line
2.30.2
#10 lore raw

PATCH 10/19 Staging: rtl8723bs: remove useless structs in rtl8723b_recv.h

In reply to Marco Cesati

Remove the following unreferenced struct in include/rtl8723b_recv.h:

struct phystatus_8723b

---
 .../staging/rtl8723bs/include/rtl8723b_recv.h | 44 -------------------
 1 file changed, 44 deletions(-)
drivers/staging/rtl8723bs/include/rtl8723b_recv.h +0 -44
index 60a1df703c8e..a108ce89bce4 100644
@@ -81,50 +81,6 @@ struct rxreport_8723b {
 	u32 tsfl;
 };
 
-struct phystatus_8723b {
-	u32 rxgain_a:7;
-	u32 trsw_a:1;
-	u32 rxgain_b:7;
-	u32 trsw_b:1;
-	u32 chcorr_l:16;
-
-	u32 sigqualcck:8;
-	u32 cfo_a:8;
-	u32 cfo_b:8;
-	u32 chcorr_h:8;
-
-	u32 noisepwrdb_h:8;
-	u32 cfo_tail_a:8;
-	u32 cfo_tail_b:8;
-	u32 rsvd0824:8;
-
-	u32 rsvd1200:8;
-	u32 rxevm_a:8;
-	u32 rxevm_b:8;
-	u32 rxsnr_a:8;
-
-	u32 rxsnr_b:8;
-	u32 noisepwrdb_l:8;
-	u32 rsvd1616:8;
-	u32 postsnr_a:8;
-
-	u32 postsnr_b:8;
-	u32 csi_a:8;
-	u32 csi_b:8;
-	u32 targetcsi_a:8;
-
-	u32 targetcsi_b:8;
-	u32 sigevm:8;
-	u32 maxexpwr:8;
-	u32 exintflag:1;
-	u32 sgien:1;
-	u32 rxsc:2;
-	u32 idlelong:1;
-	u32 anttrainen:1;
-	u32 antselb:1;
-	u32 antsel:1;
-};
-
 s32 rtl8723bs_init_recv_priv(struct adapter *padapter);
 void rtl8723bs_free_recv_priv(struct adapter *padapter);
 
Signature · 1 line
2.30.2
#11 lore raw

PATCH 11/19 Staging: rtl8723bs: remove useless structs in rtw_security.h

In reply to Marco Cesati

Remove the following unreferenced struct in include/rtw_security.h:

struct sha256_state

---
 drivers/staging/rtl8723bs/include/rtw_security.h | 6 ------
 1 file changed, 6 deletions(-)
drivers/staging/rtl8723bs/include/rtw_security.h +0 -6
index 0d3f7d46c33f..60b05a620eee 100644
@@ -193,12 +193,6 @@ struct security_priv {
 #endif /* DBG_SW_SEC_CNT */
 };
 
-struct sha256_state {
-	u64 length;
-	u32 state[8], curlen;
-	u8 buf[64];
-};
-
 #define GET_ENCRY_ALGO(psecuritypriv, psta, encry_algo, bmcst)\
 do {\
 	switch (psecuritypriv->dot11AuthAlgrthm)\
Signature · 1 line
2.30.2
#12 lore raw

PATCH 12/19 Staging: rtl8723bs: remove useless structs in rtw_wifi_regd.h

In reply to Marco Cesati

Remove the following unreferenced struct in include/rtw_wifi_regd.h:

struct country_code_to_enum_rd

---
 drivers/staging/rtl8723bs/include/rtw_wifi_regd.h | 5 -----
 1 file changed, 5 deletions(-)
drivers/staging/rtl8723bs/include/rtw_wifi_regd.h +0 -5
index f798b0c744a4..66bf3d1b1d5a 100644
@@ -8,11 +8,6 @@
 #ifndef __RTW_WIFI_REGD_H__
 #define __RTW_WIFI_REGD_H__
 
-struct country_code_to_enum_rd {
-	u16 countrycode;
-	const char *iso_name;
-};
-
 enum country_code_type_t {
 	COUNTRY_CODE_USER = 0,
 
Signature · 1 line
2.30.2
#13 lore raw

PATCH 13/19 Staging: rtl8723bs: remove useless structs in rtw_io.h

In reply to Marco Cesati

Remove the following unreferenced struct's in include/rtw_io.h:

struct reg_protocol_rd
struct reg_protocol_wt

---
 drivers/staging/rtl8723bs/include/rtw_io.h | 111 ---------------------
 1 file changed, 111 deletions(-)
drivers/staging/rtl8723bs/include/rtw_io.h +0 -111
index c83d8c66bd86..fbb73e698e09 100644
@@ -127,117 +127,6 @@ struct	intf_hdl {
 	struct _io_ops	io_ops;
 };
 
-struct reg_protocol_rd {
-
-#ifdef __LITTLE_ENDIAN
-
-	/* DW1 */
-	u32 	NumOfTrans:4;
-	u32 	Reserved1:4;
-	u32 	Reserved2:24;
-	/* DW2 */
-	u32 	ByteCount:7;
-	u32 	WriteEnable:1;		/* 0:read, 1:write */
-	u32 	FixOrContinuous:1;	/* 0:continuous, 1: Fix */
-	u32 	BurstMode:1;
-	u32 	Byte1Access:1;
-	u32 	Byte2Access:1;
-	u32 	Byte4Access:1;
-	u32 	Reserved3:3;
-	u32 	Reserved4:16;
-	/* DW3 */
-	u32 	BusAddress;
-	/* DW4 */
-	/* u32 	Value; */
-#else
-
-
-/* DW1 */
-	u32 Reserved1  :4;
-	u32 NumOfTrans :4;
-
-	u32 Reserved2  :24;
-
-	/* DW2 */
-	u32 WriteEnable : 1;
-	u32 ByteCount :7;
-
-
-	u32 Reserved3 : 3;
-	u32 Byte4Access : 1;
-
-	u32 Byte2Access : 1;
-	u32 Byte1Access : 1;
-	u32 BurstMode :1;
-	u32 FixOrContinuous : 1;
-
-	u32 Reserved4 : 16;
-
-	/* DW3 */
-	u32 	BusAddress;
-
-	/* DW4 */
-	/* u32 	Value; */
-
-#endif
-
-};
-
-
-struct reg_protocol_wt {
-
-
-#ifdef __LITTLE_ENDIAN
-
-	/* DW1 */
-	u32 	NumOfTrans:4;
-	u32 	Reserved1:4;
-	u32 	Reserved2:24;
-	/* DW2 */
-	u32 	ByteCount:7;
-	u32 	WriteEnable:1;		/* 0:read, 1:write */
-	u32 	FixOrContinuous:1;	/* 0:continuous, 1: Fix */
-	u32 	BurstMode:1;
-	u32 	Byte1Access:1;
-	u32 	Byte2Access:1;
-	u32 	Byte4Access:1;
-	u32 	Reserved3:3;
-	u32 	Reserved4:16;
-	/* DW3 */
-	u32 	BusAddress;
-	/* DW4 */
-	u32 	Value;
-
-#else
-	/* DW1 */
-	u32 Reserved1  :4;
-	u32 NumOfTrans :4;
-
-	u32 Reserved2  :24;
-
-	/* DW2 */
-	u32 WriteEnable : 1;
-	u32 ByteCount :7;
-
-	u32 Reserved3 : 3;
-	u32 Byte4Access : 1;
-
-	u32 Byte2Access : 1;
-	u32 Byte1Access : 1;
-	u32 BurstMode :1;
-	u32 FixOrContinuous : 1;
-
-	u32 Reserved4 : 16;
-
-	/* DW3 */
-	u32 	BusAddress;
-
-	/* DW4 */
-	u32 	Value;
-
-#endif
-
-};
 #define SD_IO_TRY_CNT (8)
 #define MAX_CONTINUAL_IO_ERR SD_IO_TRY_CNT
 
Signature · 1 line
2.30.2
#14 lore raw

PATCH 14/19 Staging: rtl8723bs: remove useless structs in wifi.h

In reply to Marco Cesati

Remove the following unreferenced struct in include/wifi.h:

	struct rtw_ieee80211_bar
---
 drivers/staging/rtl8723bs/include/wifi.h | 15 ---------------
 1 file changed, 15 deletions(-)
drivers/staging/rtl8723bs/include/wifi.h +0 -15
index f9815411321c..efef549bf811 100644
@@ -435,21 +435,6 @@ static inline int IsFrameTypeCtrl(unsigned char *pframe)
 
 #define ACT_CAT_VENDOR				0x7F/* 127 */
 
-/**
- * struct rtw_ieee80211_bar - HT Block Ack Request
- *
- * This structure refers to "HT BlockAckReq" as
- * described in 802.11n draft section 7.2.1.7.1
- */
-struct rtw_ieee80211_bar {
-	__le16 frame_control;
-	__le16 duration;
-	unsigned char ra[6];
-	unsigned char ta[6];
-	__le16 control;
-	__le16 start_seq_num;
-} __attribute__((packed));
-
 /**
  * struct rtw_ieee80211_ht_cap - HT additional information
  *
Signature · 1 line
2.30.2
#15 lore raw

PATCH 15/19 Staging: rtl8723bs: remove useless structs in hal_phy.h

In reply to Marco Cesati

Remove the following unreferenced struct in include/hal_phy.h:

struct r_antenna_select_ofdm

---
 drivers/staging/rtl8723bs/include/hal_phy.h | 24 ---------------------
 1 file changed, 24 deletions(-)
drivers/staging/rtl8723bs/include/hal_phy.h +0 -24
index d2f5e7afcd64..90bb5d784674 100644
@@ -146,30 +146,6 @@ struct SwChnlCmd {
 	u32 			msDelay;
 };
 
-struct r_antenna_select_ofdm {
-#ifdef __LITTLE_ENDIAN
-	u32 		r_tx_antenna:4;
-	u32 		r_ant_l:4;
-	u32 		r_ant_non_ht:4;
-	u32 		r_ant_ht1:4;
-	u32 		r_ant_ht2:4;
-	u32 		r_ant_ht_s1:4;
-	u32 		r_ant_non_ht_s1:4;
-	u32 		OFDM_TXSC:2;
-	u32 		Reserved:2;
-#else
-	u32 		Reserved:2;
-	u32 		OFDM_TXSC:2;
-	u32 		r_ant_non_ht_s1:4;
-	u32 		r_ant_ht_s1:4;
-	u32 		r_ant_ht2:4;
-	u32 		r_ant_ht1:4;
-	u32 		r_ant_non_ht:4;
-	u32 		r_ant_l:4;
-	u32 		r_tx_antenna:4;
-#endif
-};
-
 /*--------------------------Exported Function prototype---------------------*/
 
 #endif /* __HAL_COMMON_H__ */
Signature · 1 line
2.30.2
#16 lore raw

PATCH 16/19 Staging: rtl8723bs: remove useless structs in rtw_xmit.h

In reply to Marco Cesati

Remove the following unreferenced struct in include/rtw_xmit.h:

struct agg_pkt_info

---
 drivers/staging/rtl8723bs/include/rtw_xmit.h | 5 -----
 1 file changed, 5 deletions(-)
drivers/staging/rtl8723bs/include/rtw_xmit.h +0 -5
index f7d6ac0ff865..4d4fa157daa9 100644
@@ -346,11 +346,6 @@ struct	hw_txqueue	{
 	signed int	ac_tag;
 };
 
-struct agg_pkt_info {
-	u16 offset;
-	u16 pkt_len;
-};
-
 enum cmdbuf_type {
 	CMDBUF_BEACON = 0x00,
 	CMDBUF_RSVD,
Signature · 1 line
2.30.2
#17 lore raw

PATCH 17/19 Staging: rtl8723bs: remove useless structs in ieee80211.h

In reply to Marco Cesati

Remove the following unreferenced struct's in include/ieee80211.h:

	struct ieee_ibss_seq
	struct ieee80211_rx_stats
	struct ieee80211_frag_entry
	struct ieee80211_stats
	struct ieee80211_softmac_stats
	struct ieee80211_security
	struct ieee80211_header_data
---
 drivers/staging/rtl8723bs/include/ieee80211.h | 94 -------------------
 1 file changed, 94 deletions(-)
drivers/staging/rtl8723bs/include/ieee80211.h +0 -94
index a7cbd04059f8..8a10bca876b8 100644
@@ -266,14 +266,6 @@ struct sta_data {
 /* this is stolen from ipw2200 driver */
 #define IEEE_IBSS_MAC_HASH_SIZE 31
 
-struct ieee_ibss_seq {
-	u8 mac[ETH_ALEN];
-	u16 seq_num;
-	u16 frag_num;
-	unsigned long packet_time;
-	struct list_head	list;
-};
-
 struct eapol {
 	u8 snap[6];
 	u16 ethertype;
@@ -521,16 +513,6 @@ enum mgn_rate {
 /* NOTE: This data is for statistical purposes; not all hardware provides this
  *       information for frames received.  Not setting these will not cause
  *       any adverse affects. */
-struct ieee80211_rx_stats {
-	s8 rssi;
-	u8 signal;
-	u8 noise;
-	u8 received_channel;
-	u16 rate; /* in 100 kbps */
-	u8 mask;
-	u8 freq;
-	u16 len;
-};
 
 /* IEEE 802.11 requires that STA supports concurrent reception of at least
  * three fragmented frames. This define can be increased to support more
@@ -538,61 +520,6 @@ struct ieee80211_rx_stats {
  * 2 kB of RAM and increasing cache size will slow down frame reassembly. */
 #define IEEE80211_FRAG_CACHE_LEN 4
 
-struct ieee80211_frag_entry {
-	u32 first_frag_time;
-	uint seq;
-	uint last_frag;
-	uint qos;   /* jackson */
-	uint tid;	/* jackson */
-	struct sk_buff *skb;
-	u8 src_addr[ETH_ALEN];
-	u8 dst_addr[ETH_ALEN];
-};
-
-struct ieee80211_stats {
-	uint tx_unicast_frames;
-	uint tx_multicast_frames;
-	uint tx_fragments;
-	uint tx_unicast_octets;
-	uint tx_multicast_octets;
-	uint tx_deferred_transmissions;
-	uint tx_single_retry_frames;
-	uint tx_multiple_retry_frames;
-	uint tx_retry_limit_exceeded;
-	uint tx_discards;
-	uint rx_unicast_frames;
-	uint rx_multicast_frames;
-	uint rx_fragments;
-	uint rx_unicast_octets;
-	uint rx_multicast_octets;
-	uint rx_fcs_errors;
-	uint rx_discards_no_buffer;
-	uint tx_discards_wrong_sa;
-	uint rx_discards_undecryptable;
-	uint rx_message_in_msg_fragments;
-	uint rx_message_in_bad_msg_fragments;
-};
-
-struct ieee80211_softmac_stats {
-	uint rx_ass_ok;
-	uint rx_ass_err;
-	uint rx_probe_rq;
-	uint tx_probe_rs;
-	uint tx_beacons;
-	uint rx_auth_rq;
-	uint rx_auth_rs_ok;
-	uint rx_auth_rs_err;
-	uint tx_auth_rq;
-	uint no_auth_rs;
-	uint no_ass_rs;
-	uint tx_ass_rq;
-	uint rx_ass_rq;
-	uint tx_probe_rq;
-	uint reassoc;
-	uint swtxstop;
-	uint swtxawake;
-};
-
 #define SEC_KEY_1         (1<<0)
 #define SEC_KEY_2         (1<<1)
 #define SEC_KEY_3         (1<<2)
@@ -615,18 +542,6 @@ struct ieee80211_softmac_stats {
 #define BIP_MAX_KEYID 5
 #define BIP_AAD_SIZE  20
 
-struct ieee80211_security {
-	u16 active_key:2,
-            enabled:1,
-	    auth_mode:2,
-            auth_algo:4,
-            unicast_uses_group:1;
-	u8 key_sizes[WEP_KEYS];
-	u8 keys[WEP_KEYS][WEP_KEY_LEN];
-	u8 level;
-	u16 flags;
-} __attribute__ ((packed));
-
 /*
 
  802.11 data frame from AP
@@ -642,15 +557,6 @@ Total: 28-2340 bytes
 
 */
 
-struct ieee80211_header_data {
-	u16 frame_ctl;
-	u16 duration_id;
-	u8 addr1[6];
-	u8 addr2[6];
-	u8 addr3[6];
-	u16 seq_ctrl;
-};
-
 #define BEACON_PROBE_SSID_ID_POSITION 12
 
 /* Management Frame Information Element Types */
Signature · 1 line
2.30.2
#18 lore raw

PATCH 18/19 Staging: rtl8723bs: remove useless structs in odm_HWConfig.h

In reply to Marco Cesati

Remove the following unreferenced struct in hal/odm_HWConfig.h:

	struct phy_status_rpt_8812_t
---
 drivers/staging/rtl8723bs/hal/odm_HWConfig.h | 45 --------------------
 1 file changed, 45 deletions(-)
drivers/staging/rtl8723bs/hal/odm_HWConfig.h +0 -45
index eda35d2e7d29..574f9cfe8190 100644
@@ -76,51 +76,6 @@ struct phy_status_rpt_8192cd_t {
 #endif
 };
 
-
-struct phy_status_rpt_8812_t {
-	/* 2012.05.24 LukeLee: This structure should take big/little endian in consideration later..... */
-
-	/* DWORD 0 */
-	u8 gain_trsw[2];
-#if (ODM_ENDIAN_TYPE == ODM_ENDIAN_LITTLE)
-	u16 chl_num:10;
-	u16 sub_chnl:4;
-	u16 r_RFMOD:2;
-#else	/*  _BIG_ENDIAN_ */
-	u16 r_RFMOD:2;
-	u16 sub_chnl:4;
-	u16 chl_num:10;
-#endif
-
-	/* DWORD 1 */
-	u8 pwdb_all;
-	u8 cfosho[4];	/*  DW 1 byte 1 DW 2 byte 0 */
-
-	/* DWORD 2 */
-	s8 cfotail[4]; /*  DW 2 byte 1 DW 3 byte 0 */
-
-	/* DWORD 3 */
-	s8 rxevm[2]; /*  DW 3 byte 1 DW 3 byte 2 */
-	s8 rxsnr[2]; /*  DW 3 byte 3 DW 4 byte 0 */
-
-	/* DWORD 4 */
-	u8 PCTS_MSK_RPT[2];
-	u8 pdsnr[2]; /*  DW 4 byte 3 DW 5 Byte 0 */
-
-	/* DWORD 5 */
-	u8 csi_current[2];
-	u8 rx_gain_c;
-
-	/* DWORD 6 */
-	u8 rx_gain_d;
-	s8 sigevm;
-	u8 resvd_0;
-	u8 antidx_anta:3;
-	u8 antidx_antb:3;
-	u8 resvd_1:2;
-};
-
-
 void ODM_PhyStatusQuery(
 	struct dm_odm_t *pDM_Odm,
 	struct odm_phy_info *pPhyInfo,
Signature · 1 line
2.30.2
#19 lore raw

PATCH 19/19 Staging: rtl8723bs: remove useless structs in odm.h

In reply to Marco Cesati

Remove the following unreferenced struct's in hal/odm.h:

struct odm_sta_info_t
struct odm_ra_info_t

---
 drivers/staging/rtl8723bs/hal/odm.h | 61 -----------------------------
 1 file changed, 61 deletions(-)
drivers/staging/rtl8723bs/hal/odm.h +0 -61
index 3c8d76e42c99..981de3710709 100644
@@ -293,35 +293,6 @@ enum ODM_Ability_E { /* tag_Dynamic_ODM_Support_Ability_Type */
 	ODM_PSD2AFH			= 0x00000800
 };
 
-/*  */
-/*  2011/20/20 MH For MP driver RT_WLAN_STA =  STA_INFO_T */
-/*  Please declare below ODM relative info in your STA info structure. */
-/*  */
-struct odm_sta_info_t {
-	/*  Driver Write */
-	bool bUsed;				/*  record the sta status link or not? */
-	/* u8 WirelessMode;		 */
-	u8 IOTPeer;			/*  Enum value.	HT_IOT_PEER_E */
-
-	/*  ODM Write */
-	/* 1 PHY_STATUS_INFO */
-	u8 RSSI_Path[4];		/*  */
-	u8 RSSI_Ave;
-	u8 RXEVM[4];
-	u8 RXSNR[4];
-
-	/*  ODM Write */
-	/* 1 TX_INFO (may changed by IC) */
-	/* TX_INFO_T		pTxInfo;		Define in IC folder. Move lower layer. */
-
-	/*  */
-	/* 	Please use compile flag to disabe the strcutrue for other IC except 88E. */
-	/* 	Move To lower layer. */
-	/*  */
-	/*  ODM Write Wilson will handle this part(said by Luke.Lee) */
-	/* TX_RPT_T		pTxRpt;			Define in IC folder. Move lower layer. */
-};
-
 /*  */
 /*  2011/10/20 MH Define Common info enum for all team. */
 /*  */
@@ -640,38 +611,6 @@ enum odm_cca_path_e { /* tag_CCA_Path */
 	ODM_CCA_1R_B		= 2,
 };
 
-struct odm_ra_info_t { /* _ODM_RA_Info_ */
-	u8 RateID;
-	u32 RateMask;
-	u32 RAUseRate;
-	u8 RateSGI;
-	u8 RssiStaRA;
-	u8 PreRssiStaRA;
-	u8 SGIEnable;
-	u8 DecisionRate;
-	u8 PreRate;
-	u8 HighestRate;
-	u8 LowestRate;
-	u32 NscUp;
-	u32 NscDown;
-	u16 RTY[5];
-	u32 TOTAL;
-	u16 DROP;
-	u8 Active;
-	u16 RptTime;
-	u8 RAWaitingCounter;
-	u8 RAPendingCounter;
-	u8 PTActive;  /*  on or off */
-	u8 PTTryState;  /*  0 trying state, 1 for decision state */
-	u8 PTStage;  /*  0~6 */
-	u8 PTStopCount; /* Stop PT counter */
-	u8 PTPreRate;  /*  if rate change do PT */
-	u8 PTPreRssi; /*  if RSSI change 5% do PT */
-	u8 PTModeSS;  /*  decide whitch rate should do PT */
-	u8 RAstage;  /*  StageRA, decide how many times RA will be done between PT */
-	u8 PTSmoothFactor;
-};
-
 struct iqk_matrix_regs_setting { /* _IQK_MATRIX_REGS_SETTING */
 	bool bIQKDone;
 	s32 Value[3][IQK_Matrix_REG_NUM];
Signature · 1 line
2.30.2