Skip to contentSkip to conversation

btrfs-progs: qgroup: remove outdated comment

PATCH Superseded Sidong Yang 3 participants 4 messages Mar 22, 2021 – Mar 23, 2021 Btrfs file system

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 btrfs-progs: qgroup: remove outdated comment

This comment is outdated and this patch remove
it to avoid confusion.

---
 cmds/qgroup.c | 3 ---
 1 file changed, 3 deletions(-)
cmds/qgroup.c +0 -3
index 2da83ffd..b33f77fa 100644
@@ -81,9 +81,6 @@ static int _cmd_qgroup_assign(const struct cmd_struct *cmd, int assign,
 
 	path = argv[optind + 2];
 
-	/*
-	 * FIXME src should accept subvol path
-	 */
 	if (btrfs_qgroup_level(args.src) >= btrfs_qgroup_level(args.dst)) {
 		error("bad relation requested: %s", path);
 		return 1;
Signature · 1 line
2.25.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 4 lines · Sidong Yang

This comment is outdated and this patch remove
it to avoid confusion.

Thanks,
Qu

Quoted 19 lines
---
  cmds/qgroup.c | 3 ---
  1 file changed, 3 deletions(-)
cmds/qgroup.c +0 -3
index 2da83ffd..b33f77fa 100644
@@ -81,9 +81,6 @@ static int _cmd_qgroup_assign(const struct cmd_struct *cmd, int assign,
 
  	path = argv[optind + 2];
 
-	/*
-	 * FIXME src should accept subvol path
-	 */
  	if (btrfs_qgroup_level(args.src) >= btrfs_qgroup_level(args.dst)) {
  		error("bad relation requested: %s", path);
  		return 1;
#2 lore raw
In reply to Sidong Yang
Quoted 2 lines · Sidong Yang

This comment is outdated and this patch remove
it to avoid confusion.

Even if it's just a comment removal, changelog should say why it's outated, I have no idea and would have to do the research myself.

#3 lore raw
Quoted 6 lines · David Sterba
Quoted 2 lines · Sidong Yang

This comment is outdated and this patch remove
it to avoid confusion.

Even if it's just a comment removal, changelog should say why it's outated, I have no idea and would have to do the research myself.

Understood, Thanks for advice. I'll fix changelog for patch v2.

Thanks,
Sidong