Skip to contentSkip to conversation

thermal/core: avoid memory leak

PATCH New Muhammad Usama Anjum 1 participant 1 message Mar 22, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 thermal/core: avoid memory leak

When memory allocation for cdev is successful but ida_simple_get fails, branch to out_kfree_cdev label happens and cdev isn't freed. There are also some other cases in which the memory can leak. Fix it by freeing cdev.

---
Fix description

 drivers/thermal/thermal_core.c | 1 +
 1 file changed, 1 insertion(+)
drivers/thermal/thermal_core.c +1 -0
index c8d4010940ef..3566fd291399 100644
@@ -1017,6 +1017,7 @@ __thermal_cooling_device_register(struct device_node *np,
 out_ida_remove:
 	ida_simple_remove(&thermal_cdev_ida, cdev->id);
 out_kfree_cdev:
+	kfree(cdev);
 	return ERR_PTR(ret);
 }
 
Signature · 1 line
2.25.1