Skip to contentSkip to conversation

kernel: kcov: fix a typo in comment

PATCH In review tl455047 4 participants 5 messages Mar 23, 2021 – Mar 24, 2021

Subsystems (2)
lore
Share & tools
lore

tl455047

author
#0 lore raw

PATCH 1/1 kernel: kcov: fix a typo in comment

Fixed a typo in comment.

---
 kernel/kcov.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/kcov.c +1 -1
index 80bfe71bbe13..6f59842f2caf 100644
@@ -527,7 +527,7 @@ static int kcov_get_mode(unsigned long arg)
 
 /*
  * Fault in a lazily-faulted vmalloc area before it can be used by
- * __santizer_cov_trace_pc(), to avoid recursion issues if any code on the
+ * __sanitizer_cov_trace_pc(), to avoid recursion issues if any code on the
  * vmalloc fault handling path is instrumented.
  */
 static void kcov_fault_in_area(struct kcov *kcov)
Signature · 1 line
2.25.1
reviewer Reviewed-by on v1 1/1
#1 lore raw
Quoted 4 lines · On Tue, Mar 23, 2021 at 7:24 AM tl455047 <[email protected]> wrote:

Fixed a typo in comment.

+Andrew, linux-mm as KCOV patches are generally merged into mm.

Thanks for the fix

Quoted 20 lines
---
 kernel/kcov.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/kcov.c +1 -2
index 80bfe71bbe13..6f59842f2caf 100644
@@ -527,7 +527,7 @@ static int kcov_get_mode(unsigned long arg)
 
 /*
  * Fault in a lazily-faulted vmalloc area before it can be used by
- * __santizer_cov_trace_pc(), to avoid recursion issues if any code on the
+ * __sanitizer_cov_trace_pc(), to avoid recursion issues if any code on the
  * vmalloc fault handling path is instrumented.
  */
 static void kcov_fault_in_area(struct kcov *kcov)
--

2.25.1

#2 lore raw
Quoted 11 lines · Dmitry Vyukov' via kasan-dev
Quoted 4 lines · On Tue, Mar 23, 2021 at 7:24 AM tl455047 <[email protected]> wrote:

Fixed a typo in comment.

+Andrew, linux-mm as KCOV patches are generally merged into mm.

Thanks for the fix

FYI, I believe this code may not be accepted due to this:

"[...] It is imperative that all code contributed to the kernel be legitimately free software. For that reason, code from anonymous (or pseudonymous) contributors will not be accepted."

See Documentation/process/1.Intro.rst

maintainer
#3 lore raw
Quoted 14 lines · On Tue, 23 Mar 2021 23:32:57 +0100 Marco Elver <[email protected]> wrote:
Quoted 11 lines · Dmitry Vyukov' via kasan-dev
Quoted 4 lines · On Tue, Mar 23, 2021 at 7:24 AM tl455047 <[email protected]> wrote:

Fixed a typo in comment.

+Andrew, linux-mm as KCOV patches are generally merged into mm.

Thanks for the fix

Quoted 7 lines

FYI, I believe this code may not be accepted due to this:

"[...] It is imperative that all code contributed to the kernel be legitimately free software. For that reason, code from anonymous (or pseudonymous) contributors will not be accepted."

See Documentation/process/1.Intro.rst

Correct. I let this one pass because the patch is so minor. But yes, a real name would be preferred, please.

#4 lore raw
Quoted 17 lines · Andrew Morton
Quoted 16 lines · On Tue, 23 Mar 2021 23:32:57 +0100 Marco Elver <[email protected]> wrote:
Quoted 11 lines · Dmitry Vyukov' via kasan-dev
Quoted 4 lines · On Tue, Mar 23, 2021 at 7:24 AM tl455047 <[email protected]> wrote:

Fixed a typo in comment.

+Andrew, linux-mm as KCOV patches are generally merged into mm.

Thanks for the fix

FYI, I believe this code may not be accepted due to this:

Quoted 8 lines
Quoted 5 lines

"[...] It is imperative that all code contributed to the kernel be legitimately free software. For that reason, code from anonymous (or pseudonymous) contributors will not be accepted."

See Documentation/process/1.Intro.rst

Correct. I let this one pass because the patch is so minor. But yes, a real name would be preferred, please.

I've just seen that the author sent
https://lkml.kernel.org/r/[email protected]