selftests: kvm: make hardware_disable_test less verbose
PATCH 1/1 selftests: kvm: make hardware_disable_test less verbose
hardware_disable_test produces 512 snippets like
...
main: [511] waiting semaphore
run_test: [511] start vcpus
run_test: [511] all threads launched
main: [511] waiting 368us
main: [511] killing child
and this doesn't have much value, let's just drop these fprintf(). Restoring them for debugging purposes shouldn't be too hard.
--- tools/testing/selftests/kvm/hardware_disable_test.c | 5 ----- 1 file changed, 5 deletions(-)
tools/testing/selftests/kvm/hardware_disable_test.c +0 -5
@@ -108,7 +108,6 @@ static void run_test(uint32_t run)kvm_vm_elf_load (vm, program_invocation_name,0 ,0 );vm_create_irqchip (vm); -fprintf (stderr,"%s: [%d] start vcpus\n" , __func__, run);for (i =0 ; i <VCPU_NUM ; ++i) {vm_vcpu_add_default (vm, i, guest_code); payloads[i].vm = vm;
@@ -124,7 +123,6 @@ static void run_test(uint32_t run)check_set_affinity (throw_away, &cpu_set); } } -fprintf (stderr,"%s: [%d] all threads launched\n" , __func__, run);sem_post (sem);for (i =0 ; i <VCPU_NUM ; ++i)check_join (threads[i], &b);
@@ -147,16 +145,13 @@ int main(int argc, char **argv)if (pid ==0 )run_test (i);/* This function always exits */ -fprintf (stderr,"%s: [%d] waiting semaphore\n" , __func__, i);sem_wait (sem); r = (rand () %DELAY_US_MAX ) +1 ; -fprintf (stderr,"%s: [%d] waiting %dus\n" , __func__, i, r);usleep (r); r =waitpid (pid, &s,WNOHANG );TEST_ASSERT (r != pid,"%s: [%d] child exited unexpectedly status: [%d]" , __func__, i, s); -fprintf (stderr,"%s: [%d] killing child\n" , __func__, i);kill (pid,SIGKILL ); }
Signature · 1 line
2.30.2
Quoted 10 lines · Vitaly Kuznetsov
hardware_disable_testproduces 512 snippets like
...
main: [511] waiting semaphore
run_test: [511] start vcpus
run_test: [511] all threads launched
main: [511] waiting 368us
main: [511] killing childand this doesn't have much value, let's just drop these
fprintf(). Restoring them for debugging purposes shouldn't be too hard.
Changing them to pr_debug() allows you to keep them and restore with -DDEBUG
Thanks,
drew
Quoted 46 lines
Signed-off-by Vitaly Kuznetsov <[email protected]>--- tools/testing/selftests/kvm/hardware_disable_test.c | 5 ----- 1 file changed, 5 deletions(-)tools/testing/selftests/kvm/hardware_disable_test.c +0
-5@@ -108,7 +108,6 @@ static void run_test(uint32_t run)kvm_vm_elf_load (vm, program_invocation_name,0 ,0 );vm_create_irqchip (vm); -fprintf (stderr,"%s: [%d] start vcpus\n" , __func__, run);for (i =0 ; i <VCPU_NUM ; ++i) {vm_vcpu_add_default (vm, i, guest_code); payloads[i].vm = vm;@@ -124,7 +123,6 @@ static void run_test(uint32_t run)check_set_affinity (throw_away, &cpu_set); } } -fprintf (stderr,"%s: [%d] all threads launched\n" , __func__, run);sem_post (sem);for (i =0 ; i <VCPU_NUM ; ++i)check_join (threads[i], &b);@@ -147,16 +145,13 @@ int main(int argc, char **argv)if (pid ==0 )run_test (i);/* This function always exits */ -fprintf (stderr,"%s: [%d] waiting semaphore\n" , __func__, i);sem_wait (sem); r = (rand () %DELAY_US_MAX ) +1 ; -fprintf (stderr,"%s: [%d] waiting %dus\n" , __func__, i, r);usleep (r); r =waitpid (pid, &s,WNOHANG );TEST_ASSERT (r != pid,"%s: [%d] child exited unexpectedly status: [%d]" , __func__, i, s); -fprintf (stderr,"%s: [%d] killing child\n" , __func__, i);kill (pid,SIGKILL ); }Signature · 1 line
2.30.2
Quoted 9 lines · Andrew Jones
Quoted 8 lines · Vitaly Kuznetsov
hardware_disable_testproduces 512 snippets like
...
main: [511] waiting semaphore
run_test: [511] start vcpus
run_test: [511] all threads launched
main: [511] waiting 368us
main: [511] killing child
Quoted 5 lines
Quoted 2 lines
and this doesn't have much value, let's just drop these
fprintf(). Restoring them for debugging purposes shouldn't be too hard.Changing them to
pr_debug()allows you to keep them and restore with -DDEBUG
Ah, missed that we have this for selftests! v2 is coming.
Signature · 1 line
Vitaly