i2c: tegra: bpmp: Implement better error handling
Subsystems (2)
PATCH 1/1 i2c: tegra: bpmp: Implement better error handling
From: Thierry Reding <[email protected]>
Inspect a message's return value upon successful IVC transaction to determine if the I2C transaction on the BPMP side was successful.
Heavily based on work by Timo Alho <[email protected]>.
Signed-off-by Thierry Reding <[email protected]>
--- drivers/i2c/busses/i2c-tegra-bpmp.c | 27 ++++++++++++++++++++++++++- 1 file changed, 26 insertions(+), 1 deletion(-)
drivers/i2c/busses/i2c-tegra-bpmp.c +26 -1
@@ -217,7 +217,32 @@ static int tegra_bpmp_i2c_msg_xfer(struct tegra_bpmp_i2c *i2c,else err =tegra_bpmp_transfer (i2c->bpmp, &msg); -return err; +if (err <0 ) { +dev_err (i2c->dev,"failed to transfer message: %d\n" , err); +return err; + } + +if (msg.rx.ret !=0 ) { +if (msg.rx.ret == -BPMP_EAGAIN ) { +dev_dbg (i2c->dev,"arbitration lost\n" ); +return -EAGAIN ; + } + +if (msg.rx.ret == -BPMP_ETIMEDOUT ) { +dev_dbg (i2c->dev,"timeout\n" ); +return -ETIMEDOUT ; + } + +if (msg.rx.ret == -BPMP_ENXIO ) { +dev_dbg (i2c->dev,"NAK\n" ); +return -ENXIO ; + } + +dev_err (i2c->dev,"transaction failed: %d\n" , msg.rx.ret); +return -EIO ; + } + +return 0 ; } static int tegra_bpmp_i2c_xfer_common(struct i2c_adapter *adapter,
Signature · 1 line
2.30.2
Wolfram Sang
AppliedQuoted 8 lines · Thierry Reding
From: Thierry Reding <[email protected]>
Inspect a message's return value upon successful IVC transaction to determine if the I2C transaction on the BPMP side was successful.
Heavily based on work by Timo Alho <[email protected]>.
Signed-off-by Thierry Reding <[email protected]>
Applied to for-next, thanks!