Skip to contentSkip to conversation

ALSA: usb-audio: Don't store returned value and check for errors

PATCH In review Muhammad Usama Anjum 2 participants 2 messages Mar 25, 2021 – Mar 26, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ALSA: usb-audio: Don't store returned value and check for errors

The returned value by create_autodetect_quirk isn't being used other than in the success check on next line. Remove the return value assignement. Check for error values instead of success check.

---
 sound/usb/quirks.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
sound/usb/quirks.c +3 -3
index 9e5e37eff10e..5ce5f4ecb9d0 100644
@@ -425,9 +425,9 @@ static int create_autodetect_quirks(struct snd_usb_audio *chip,
 							USB_CLASS_VENDOR_SPEC)
 			continue;
 
-		err = create_autodetect_quirk(chip, iface, driver);
-		if (err >= 0)
-			usb_driver_claim_interface(driver, iface, (void *)-1L);
+		if (create_autodetect_quirk(chip, iface, driver) < 0)
+			continue;
+		usb_driver_claim_interface(driver, iface, (void *)-1L);
 	}
 
 	return 0;
Signature · 1 line
2.25.1
#1 lore raw
Quoted 15 lines · Muhammad Usama Anjum

The returned value by create_autodetect_quirk isn't being used other than in the success check on next line. Remove the return value assignement. Check for error values instead of success check.

---
 sound/usb/quirks.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
sound/usb/quirks.c +0 -0
index 9e5e37eff10e..5ce5f4ecb9d0 100644

sound/usb/quirks.c static int create_autodetect_quirks(struct snd_usb_audio *chip, · line 430

Quoted 9 lines
sound/usb/quirks.c +3 -3
@@ -425,9 +425,9 @@ static int create_autodetect_quirks(struct snd_usb_audio *chip,
 							USB_CLASS_VENDOR_SPEC)
 			continue;
 
-		err = create_autodetect_quirk(chip, iface, driver);
-		if (err >= 0)
-			usb_driver_claim_interface(driver, iface, (void *)-1L);
+		if (create_autodetect_quirk(chip, iface, driver) < 0)
+			continue;
+		usb_driver_claim_interface(driver, iface, (void *)-1L);

Hm, basically this change is only for readability (the code optimization makes almost no sense), and the readability itself isn't improved significantly by this change, either.

That is, I'm fine to take this, but OTOH, I see no compelling reason to do so...

thanks,

Takashi