Skip to contentSkip to conversation

ACPICA: Fix a typo

PATCH In review Bhaskar Chowdhury 4 participants 7 messages Mar 26, 2021 – Mar 30, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ACPICA: Fix a typo

s/optimzation/optimization/

---
 include/acpi/acoutput.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/acpi/acoutput.h +1 -1
index 1538a6853822..1b4c45815695 100644
@@ -362,7 +362,7 @@
  *
  * A less-safe version of the macros is provided for optional use if the
  * compiler uses excessive CPU stack (for example, this may happen in the
- * debug case if code optimzation is disabled.)
+ * debug case if code optimization is disabled.)
  */
 
 /* Exit trace helper macro */

--
2.26.2

#1 lore raw

Please make a pull request for this on our github. Thanks,
Bob

-----Original Message-----
From: Bhaskar Chowdhury <unixbhaskar(a)gmail.com>
Sent: Thursday, March 25, 2021 5:19 PM
To: Moore, Robert <robert.moore(a)intel.com>; Kaneda, Erik <erik.kaneda(a)intel.com>; Wysocki, Rafael J <rafael.j.wysocki(a)intel.com>; lenb(a)kernel.org; linux-acpi(a)vger.kernel.org; devel(a)acpica.org; linux-kernel(a)vger.kernel.org
Cc: rdunlap(a)infradead.org; Bhaskar Chowdhury <unixbhaskar(a)gmail.com>
Subject: [PATCH] ACPICA: Fix a typo

s/optimzation/optimization/

Signed-off-by Bhaskar Chowdhury <unixbhaskar(a)gmail.com>
---
 include/acpi/acoutput.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/acpi/acoutput.h +1 -1
@@ -362,7 +362,7 @@
  *
  * A less-safe version of the macros is provided for optional use if the
  * compiler uses excessive CPU stack (for example, this may happen in the
- * debug case if code optimzation is disabled.)
+ * debug case if code optimization is disabled.)
  */
 
 /* Exit trace helper macro */

--
2.26.2

#2 lore raw
Quoted 4 lines · Robert

Please make a pull request for this on our github. Thanks,
Bob

A pull request for this trivial spelling fix? Kindly be reasonable , it is just a single spelling fix, had it been many ,the suggestion could stand.

Kindly, also , let me know aren't we applying patches from the ML , or is there some specific rule for this project. I might be missing the basic stuff.

Thanks,
Bhaskar

Quoted 31 lines

-----Original Message-----
From: Bhaskar Chowdhury <[email protected]>
Sent: Thursday, March 25, 2021 5:19 PM
To: Moore, Robert <[email protected]>; Kaneda, Erik <[email protected]>; Wysocki, Rafael J <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]
Cc: [email protected]; Bhaskar Chowdhury <[email protected]>
Subject: [PATCH] ACPICA: Fix a typo

s/optimzation/optimization/

---
include/acpi/acoutput.h | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
include/acpi/acoutput.h +1 -2
@@ -362,7 +362,7 @@
 *
 * A less-safe version of the macros is provided for optional use if the
 * compiler uses excessive CPU stack (for example, this may happen in the
- * debug case if code optimzation is disabled.)
+ * debug case if code optimization is disabled.)
 */
 
 /* Exit trace helper macro */
--

2.26.2

#3 lore raw
Quoted 17 lines

-----Original Message-----
From: Bhaskar Chowdhury <[email protected]>
Sent: Friday, March 26, 2021 12:49 PM
To: Moore, Robert <[email protected]>
Cc: Kaneda, Erik <[email protected]>; Wysocki, Rafael J <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]
Subject: Re: [PATCH] ACPICA: Fix a typo

Quoted 4 lines · Robert

Please make a pull request for this on our github. Thanks,
Bob

Quoted 5 lines

A pull request for this trivial spelling fix? Kindly be reasonable , it is just a single spelling fix, had it been many ,the suggestion could stand.

Kindly, also , let me know aren't we applying patches from the ML , or is there some specific rule for this project. I might be missing the basic stuff.

The code under drivers/acpi/acpica is from a separate open source project located here:

https://github.com/acpica/acpica

You submitting a pull request on the github facilitates our maintenance. Please make the pull request there so that the codebases are easy to maintain.

For more info, read Documentation/driver-api/acpi/linuxized-acpica.rst

Erik

Quoted 38 lines

Thanks,
Bhaskar

Quoted 5 lines

-----Original Message-----
From: Bhaskar Chowdhury <[email protected]>
Sent: Thursday, March 25, 2021 5:19 PM
To: Moore, Robert <[email protected]>; Kaneda, Erik

<[email protected]>; Wysocki, Rafael J <[email protected]>; [email protected]; [email protected]; [email protected]; linux- [email protected]

include/acpi/acoutput.h index

Quoted 12 lines

Cc: [email protected]; Bhaskar Chowdhury <[email protected]>
Subject: [PATCH] ACPICA: Fix a typo

s/optimzation/optimization/

---
include/acpi/acoutput.h | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
include/acpi/acoutput.h index renamed from include/acpi/acoutput.h +0 -0

1538a6853822..1b4c45815695 100644

Quoted 14 lines
include/acpi/acoutput.h +1 -2
@@ -362,7 +362,7 @@
 *
 * A less-safe version of the macros is provided for optional use if the
 * compiler uses excessive CPU stack (for example, this may happen in the
- * debug case if code optimzation is disabled.)
+ * debug case if code optimization is disabled.)
 */
 
 /* Exit trace helper macro */
--

2.26.2

#4 lore raw
In reply to Bhaskar Chowdhury
Quoted 14 lines · Bhaskar Chowdhury

s/optimzation/optimization/

Signed-off-by Bhaskar Chowdhury <unixbhaskar(a)gmail.com>
---
 include/acpi/acoutput.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/acpi/acoutput.h +0 -0
index 1538a6853822..1b4c45815695 100644

include/acpi/acoutput.h

Quoted 9 lines
include/acpi/acoutput.h +1 -2
@@ -362,7 +362,7 @@
  *
  * A less-safe version of the macros is provided for optional use if the
  * compiler uses excessive CPU stack (for example, this may happen in the
- * debug case if code optimzation is disabled.)
+ * debug case if code optimization is disabled.)
  */
 
 /* Exit trace helper macro */
--

Erik, could you pick up this patch, please? It is simple enough IMV ...

#5 lore raw
Quoted 36 lines

-----Original Message-----
From: Rafael J. Wysocki <[email protected]>
Sent: Monday, March 29, 2021 5:48 AM
To: Bhaskar Chowdhury <[email protected]>; Kaneda, Erik <[email protected]>
Cc: Wysocki, Rafael J <[email protected]>; ACPI Devel Maling List <[email protected]>; open list:ACPI COMPONENT ARCHITECTURE (ACPICA) <[email protected]>; Linux Kernel Mailing List <linux- [email protected]>; Randy Dunlap <[email protected]>
Subject: [Devel] Re: [PATCH] ACPICA: Fix a typo

Quoted 21 lines · Bhaskar Chowdhury

s/optimzation/optimization/

---
 include/acpi/acoutput.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/acpi/acoutput.h +1 -1
index 1538a6853822..1b4c45815695 100644
@@ -362,7 +362,7 @@
  *
  * A less-safe version of the macros is provided for optional use if the
  * compiler uses excessive CPU stack (for example, this may happen in the
- * debug case if code optimzation is disabled.)
+ * debug case if code optimization is disabled.)
  */
 
Quoted 4 lines

include/acpi/acoutput.h

Quoted 2 lines
include/acpi/acoutput.h +0 -1
 /* Exit trace helper macro */
--

Erik, could you pick up this patch, please? It is simple enough IMV ...

No problem, I'll pick it up

Erik

Quoted 4 lines

_______________________________________________
Devel mailing list -- [email protected]
To unsubscribe send an email to [email protected] %(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

#6 lore raw
Quoted 37 lines · Erik
Quoted 37 lines

-----Original Message-----
From: Rafael J. Wysocki <rafael(a)kernel.org>
Sent: Monday, March 29, 2021 5:48 AM
To: Bhaskar Chowdhury <unixbhaskar(a)gmail.com>; Kaneda, Erik <erik.kaneda(a)intel.com>
Cc: Wysocki, Rafael J <rafael.j.wysocki(a)intel.com>; ACPI Devel Maling List <linux-acpi(a)vger.kernel.org>; open list:ACPI COMPONENT ARCHITECTURE (ACPICA) <devel(a)acpica.org>; Linux Kernel Mailing List <linux- kernel(a)vger.kernel.org>; Randy Dunlap <rdunlap(a)infradead.org>
Subject: [Devel] Re: [PATCH] ACPICA: Fix a typo

Quoted 21 lines · Bhaskar Chowdhury

s/optimzation/optimization/

Signed-off-by Bhaskar Chowdhury <unixbhaskar(a)gmail.com>
---
 include/acpi/acoutput.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/acpi/acoutput.h +1 -1
index 1538a6853822..1b4c45815695 100644
@@ -362,7 +362,7 @@
  *
  * A less-safe version of the macros is provided for optional use if the
  * compiler uses excessive CPU stack (for example, this may happen in the
- * debug case if code optimzation is disabled.)
+ * debug case if code optimization is disabled.)
  */
 
Quoted 6 lines
Quoted 4 lines

include/acpi/acoutput.h

Quoted 2 lines
include/acpi/acoutput.h +0 -1
 /* Exit trace helper macro */
--

Erik, could you pick up this patch, please? It is simple enough IMV ...

No problem, I'll pick it up

Thanks!