Skip to contentSkip to conversation

sparc32: add stub pud_page define for walking huge vmalloc page tables

PATCH In review Nicholas Piggin 3 participants 3 messages Mar 24, 2021 – Mar 25, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sparc32: add stub pud_page define for walking huge vmalloc page tables

Similarly to the stub p4d_page in sparc64, add a stub pud_page, this is needed for hugepages in the vmap page tables to be walked without ifdefs, which should be no functional change for sparc32.

---

This should go in Andrew's mm tree which has a compile error on sparc32 introduced by the huge vmalloc pages, noticed by Stephen.

Thanks,
Nick

 arch/sparc/include/asm/pgtable_32.h | 3 +++
 1 file changed, 3 insertions(+)
arch/sparc/include/asm/pgtable_32.h +3 -0
index 632cdb959542..a5cf79c149fe 100644
@@ -321,6 +321,9 @@ static inline pte_t pte_modify(pte_t pte, pgprot_t newprot)
 		pgprot_val(newprot));
 }
 
+/* only used by the huge vmap code, should never be called */
+#define pud_page(pud)			NULL
+
 struct seq_file;
 void mmu_info(struct seq_file *m);
 
Signature · 1 line
2.23.0
#2 lore raw
In reply to Nicholas Piggin

Hi all,

Quoted 34 lines · On Thu, 25 Mar 2021 09:28:25 +1000 Nicholas Piggin <[email protected]> wrote:

Similarly to the stub p4d_page in sparc64, add a stub pud_page, this is needed for hugepages in the vmap page tables to be walked without ifdefs, which should be no functional change for sparc32.

---

This should go in Andrew's mm tree which has a compile error on sparc32 introduced by the huge vmalloc pages, noticed by Stephen.

Thanks,
Nick

 arch/sparc/include/asm/pgtable_32.h | 3 +++
 1 file changed, 3 insertions(+)
arch/sparc/include/asm/pgtable_32.h +3 -0
index 632cdb959542..a5cf79c149fe 100644
@@ -321,6 +321,9 @@ static inline pte_t pte_modify(pte_t pte, pgprot_t newprot)
 		pgprot_val(newprot));
 }
 
+/* only used by the huge vmap code, should never be called */
+#define pud_page(pud)			NULL
+
 struct seq_file;
 void mmu_info(struct seq_file *m);
 
Signature · 1 line
2.23.0

I have used this instead of my hack fix in linux-next today.

Signature · 2 lines
Cheers,
Stephen Rothwell