Skip to contentSkip to conversation

livepatch: Replace the fake signal sending with TIF_NOTIFY_SIGNAL infrastructure

PATCH In review Miroslav Benes 3 participants 3 messages Mar 29, 2021 – Mar 30, 2021 Live patching

lore
Share & tools
lore

Miroslav Benes

author maintainer
#0 lore raw

PATCH v2 1/1 livepatch: Replace the fake signal sending with TIF_NOTIFY_SIGNAL infrastructure

Livepatch sends a fake signal to all remaining blocking tasks of a running transition after a set period of time. It uses TIF_SIGPENDING flag for the purpose. Commit 12db8b690010 ("entry: Add support for TIF_NOTIFY_SIGNAL") added a generic infrastructure to achieve the same. Replace our bespoke solution with the generic one.

---
v2:
- #include from kernel/signal.c removed [Petr]

 kernel/livepatch/transition.c | 5 ++---
 kernel/signal.c               | 4 +---
 2 files changed, 3 insertions(+), 6 deletions(-)
kernel/livepatch/transition.c +2 -3
index f6310f848f34..3a4beb9395c4 100644
@@ -9,6 +9,7 @@
 
 #include <linux/cpu.h>
 #include <linux/stacktrace.h>
+#include <linux/tracehook.h>
 #include "core.h"
 #include "patch.h"
 #include "transition.h"
@@ -369,9 +370,7 @@ static void klp_send_signals(void)
 			 * Send fake signal to all non-kthread tasks which are
 			 * still not migrated.
 			 */
-			spin_lock_irq(&task->sighand->siglock);
-			signal_wake_up(task, 0);
-			spin_unlock_irq(&task->sighand->siglock);
+			set_notify_signal(task);
 		}
 	}
 	read_unlock(&tasklist_lock);
kernel/signal.c +1 -3
index f2a1b898da29..604290a8ca89 100644
@@ -43,7 +43,6 @@
 #include <linux/cn_proc.h>
 #include <linux/compiler.h>
 #include <linux/posix-timers.h>
-#include <linux/livepatch.h>
 #include <linux/cgroup.h>
 #include <linux/audit.h>
 
@@ -181,8 +180,7 @@ void recalc_sigpending_and_wake(struct task_struct *t)
 
 void recalc_sigpending(void)
 {
-	if (!recalc_sigpending_tsk(current) && !freezing(current) &&
-	    !klp_patch_pending(current))
+	if (!recalc_sigpending_tsk(current) && !freezing(current))
 		clear_thread_flag(TIF_SIGPENDING);
 
 }
Signature · 1 line
2.30.2
maintainer Acked-by on v2 1/1
#1 lore raw
Quoted 54 lines · Miroslav Benes

Livepatch sends a fake signal to all remaining blocking tasks of a running transition after a set period of time. It uses TIF_SIGPENDING flag for the purpose. Commit 12db8b690010 ("entry: Add support for TIF_NOTIFY_SIGNAL") added a generic infrastructure to achieve the same. Replace our bespoke solution with the generic one.

---
v2:
- #include from kernel/signal.c removed [Petr]

  kernel/livepatch/transition.c | 5 ++---
  kernel/signal.c               | 4 +---
  2 files changed, 3 insertions(+), 6 deletions(-)
kernel/livepatch/transition.c +2 -3
index f6310f848f34..3a4beb9395c4 100644
@@ -9,6 +9,7 @@
 
  #include <linux/cpu.h>
  #include <linux/stacktrace.h>
+#include <linux/tracehook.h>
  #include "core.h"
  #include "patch.h"
  #include "transition.h"
@@ -369,9 +370,7 @@ static void klp_send_signals(void)
  			 * Send fake signal to all non-kthread tasks which are
  			 * still not migrated.
  			 */
-			spin_lock_irq(&task->sighand->siglock);
-			signal_wake_up(task, 0);
-			spin_unlock_irq(&task->sighand->siglock);
+			set_notify_signal(task);
  		}
  	}
  	read_unlock(&tasklist_lock);
kernel/signal.c +0 -1
index f2a1b898da29..604290a8ca89 100644
@@ -43,7 +43,6 @@
  #include <linux/cn_proc.h>
  #include <linux/compiler.h>
  #include <linux/posix-timers.h>
-#include <linux/livepatch.h>
  #include <linux/cgroup.h>
  #include <linux/audit.h>
 

kernel/signal.c void recalc_sigpending_and_wake(struct task_struct *t) · line 186

Quoted 9 lines
kernel/signal.c +1 -2
@@ -181,8 +180,7 @@ void recalc_sigpending_and_wake(struct task_struct *t)
 
  void recalc_sigpending(void)
  {
-	if (!recalc_sigpending_tsk(current) && !freezing(current) &&
-	    !klp_patch_pending(current))
+	if (!recalc_sigpending_tsk(current) && !freezing(current))
  		clear_thread_flag(TIF_SIGPENDING);
 
  }

Looks good to me. Thanks for checking on this and updating.

-- Joe

#2 lore raw
In reply to Miroslav Benes
Quoted 9 lines · Miroslav Benes

Livepatch sends a fake signal to all remaining blocking tasks of a running transition after a set period of time. It uses TIF_SIGPENDING flag for the purpose. Commit 12db8b690010 ("entry: Add support for TIF_NOTIFY_SIGNAL") added a generic infrastructure to achieve the same. Replace our bespoke solution with the generic one.

Pushed out to livepatching#for-5.13/signal.

Signature · 2 lines
Jiri Kosina
SUSE Labs