Skip to contentSkip to conversation

arm: ptdump: convert to DEFINE_SHOW_ATTRIBUTE

PATCH In review Jisheng Zhang 2 participants 2 messages Mar 30, 2021 – Apr 7, 2021 Arm (32-bit)

lore
Share & tools
lore

Jisheng Zhang

author
#0 lore raw

PATCH 1/1 arm: ptdump: convert to DEFINE_SHOW_ATTRIBUTE

Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.

Signed-off-by Jisheng Zhang <[email protected]>
---
 arch/arm/mm/ptdump_debugfs.c | 13 +------------
 1 file changed, 1 insertion(+), 12 deletions(-)
arch/arm/mm/ptdump_debugfs.c +1 -12
index 8df9afac8d81..318de969ae0f 100644
@@ -11,18 +11,7 @@ static int ptdump_show(struct seq_file *m, void *v)
 	ptdump_walk_pgd(m, info);
 	return 0;
 }
-
-static int ptdump_open(struct inode *inode, struct file *file)
-{
-	return single_open(file, ptdump_show, inode->i_private);
-}
-
-static const struct file_operations ptdump_fops = {
-	.open		= ptdump_open,
-	.read		= seq_read,
-	.llseek		= seq_lseek,
-	.release	= single_release,
-};
+DEFINE_SHOW_ATTRIBUTE(ptdump);
 
 void __init ptdump_debugfs_register(struct ptdump_info *info, const char *name)
 {
Signature · 1 line
2.31.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 3 lines · Jisheng Zhang

Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.

Signed-off-by Jisheng Zhang <[email protected]>
Reviewed-by Steven Price <[email protected]>
Quoted 29 lines
---
  arch/arm/mm/ptdump_debugfs.c | 13 +------------
  1 file changed, 1 insertion(+), 12 deletions(-)
arch/arm/mm/ptdump_debugfs.c +1 -12
index 8df9afac8d81..318de969ae0f 100644
@@ -11,18 +11,7 @@ static int ptdump_show(struct seq_file *m, void *v)
  	ptdump_walk_pgd(m, info);
  	return 0;
  }
-
-static int ptdump_open(struct inode *inode, struct file *file)
-{
-	return single_open(file, ptdump_show, inode->i_private);
-}
-
-static const struct file_operations ptdump_fops = {
-	.open		= ptdump_open,
-	.read		= seq_read,
-	.llseek		= seq_lseek,
-	.release	= single_release,
-};
+DEFINE_SHOW_ATTRIBUTE(ptdump);
 
  void __init ptdump_debugfs_register(struct ptdump_info *info, const char *name)
  {