net/i40e: fix inappropriate config during flow validate
PATCH 1/1 net/i40e: fix inappropriate config during flow validate
The configuration of FDIR input set should not be set during flow validate. It should be set when flow create.
--- drivers/net/i40e/i40e_ethdev.h | 1 + drivers/net/i40e/i40e_fdir.c | 88 +++++++++++++++++++++++++++++++ drivers/net/i40e/i40e_flow.c | 95 +++------------------------------- 3 files changed, 96 insertions(+), 88 deletions(-)
drivers/net/i40e/i40e_ethdev.h +1 -0
@@ -631,6 +631,7 @@ struct i40e_fdir_flow_ext {uint8_t raw_id;uint8_t is_vf;/* 1 for VF, 0 for port dev */ uint16_t dst_id;/* VF ID, available when is_vf is 1*/ +uint64_t input_set;bool inner_ip;/* If there is inner ip */ enum i40e_fdir_ip_type iip_type;/* ip type for inner ip */ enum i40e_fdir_ip_type oip_type;/* ip type for outer ip */
drivers/net/i40e/i40e_fdir.c +88 -0
100 lines not on this page · raw message
drivers/net/i40e/i40e_flow.c +7 -88
108 lines not on this page · raw message
Signature · 1 line
2.17.1
Quoted 12 lines
-----Original Message-----
From: Yang, MurphyX <[email protected]>
Sent: Friday, March 19, 2021 10:44 AM
To: [email protected]
Cc: Yang, Qiming <[email protected]>; Guo, Jia <[email protected]>; Xing, Beilei <[email protected]>; Yang, SteveX <[email protected]>; Zhang, RobinX <[email protected]>; Yang, MurphyX <[email protected]>
Subject: [PATCH] net/i40e: fix inappropriate config during flow validate
Quoted 7 lines
The configuration of FDIR input set should not be set during flow validate. It should be set when flow create.
Fixes fe5d0e85b713 ("net/i40e: fix flow director flex configuration")Fixes 15018d79f0be ("net/i40e: add FDIR support for GTP-C and GTP-U")Signed-off-by Murphy Yang <[email protected]>
PATCH v2 1/1 net/i40e: fix inappropriate config during flow validate
In reply to Murphy YangThe configuration of FDIR input set should not be set during flow validate. It should be set when flow create.
---
v2:
- fix merge conflict
drivers/net/i40e/i40e_ethdev.h | 1 + drivers/net/i40e/i40e_fdir.c | 88 +++++++++++++++++++++++++++++++ drivers/net/i40e/i40e_flow.c | 94 +++------------------------------- 3 files changed, 96 insertions(+), 87 deletions(-)
drivers/net/i40e/i40e_ethdev.h +1 -0
@@ -631,6 +631,7 @@ struct i40e_fdir_flow_ext {uint8_t raw_id;uint8_t is_vf;/* 1 for VF, 0 for port dev */ uint16_t dst_id;/* VF ID, available when is_vf is 1*/ +uint64_t input_set;bool inner_ip;/* If there is inner ip */ enum i40e_fdir_ip_type iip_type;/* ip type for inner ip */ enum i40e_fdir_ip_type oip_type;/* ip type for outer ip */
drivers/net/i40e/i40e_fdir.c +88 -0
100 lines not on this page · raw message
drivers/net/i40e/i40e_flow.c +7 -87
107 lines not on this page · raw message
Signature · 1 line
2.17.1
Quoted 13 lines
-----Original Message-----
From: dev <[email protected]> On Behalf Of Murphy Yang
Sent: Thursday, April 1, 2021 11:24 AM
To: [email protected]
Cc: Yang, Qiming <[email protected]>; Guo, Jia <[email protected]>; Xing, Beilei <[email protected]>; Yang, SteveX <[email protected]>; Zhang, RobinX <[email protected]>; Yang, MurphyX <[email protected]>
Subject: [dpdk-dev] [PATCH v2] net/i40e: fix inappropriate config during flow validate
Quoted 7 lines
The configuration of FDIR input set should not be set during flow validate. It should be set when flow create.
Fixes fe5d0e85b713 ("net/i40e: fix flow director flex configuration")Fixes 15018d79f0be ("net/i40e: add FDIR support for GTP-C and GTP-U")Signed-off-by Murphy Yang <[email protected]>
Added ack in v1
Applied to dpdk-next-net-intel.
Thanks
Qi