Skip to contentSkip to conversation

fs: btrfs: Remove repeated struct declaration

PATCH In review Wan Jiabing 3 participants 3 messages Apr 1, 2021 – Apr 6, 2021 Btrfs file system

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fs: btrfs: Remove repeated struct declaration

struct btrfs_inode is declared twice. One is declared at 67th line. The blew declaration is not needed. Remove the duplicate. struct btrfs_fs_info should be declared in the forward declarations. Move it to the forward declarations.

---
 fs/btrfs/extent_io.h | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
fs/btrfs/extent_io.h +1 -3
index 824640cb0ace..227215a5722c 100644
@@ -66,6 +66,7 @@ enum {
 struct btrfs_root;
 struct btrfs_inode;
 struct btrfs_io_bio;
+struct btrfs_fs_info;
 struct io_failure_record;
 struct extent_io_tree;
 
@@ -270,9 +271,6 @@ struct bio *btrfs_io_bio_alloc(unsigned int nr_iovecs);
 struct bio *btrfs_bio_clone(struct bio *bio);
 struct bio *btrfs_bio_clone_partial(struct bio *orig, int offset, int size);
 
-struct btrfs_fs_info;
-struct btrfs_inode;
-
 int repair_io_failure(struct btrfs_fs_info *fs_info, u64 ino, u64 start,
 		      u64 length, u64 logical, struct page *page,
 		      unsigned int pg_offset, int mirror_num);
Signature · 1 line
2.25.1
#2 lore raw
In reply to Wan Jiabing
Quoted 4 lines · Wan Jiabing

struct btrfs_inode is declared twice. One is declared at 67th line. The blew declaration is not needed. Remove the duplicate. struct btrfs_fs_info should be declared in the forward declarations. Move it to the forward declarations.

I've reworded the changelog a bit, patch added to misc-next, thanks.