Skip to contentSkip to conversation

gem_watchdog: Fix autotools build

PATCH In review Tvrtko Ursulin 4 participants 5 messages Apr 1, 2021 – Apr 9, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gem_watchdog: Fix autotools build

From: Tvrtko Ursulin <[email protected]>

Correcting a brain malfunction while typing in Makefile.sources.

---
 tests/Makefile.sources | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/Makefile.sources +1 -1
index e992285fedc5..194df8e27dd0 100644
@@ -464,7 +464,7 @@ TESTS_progs += gem_wait
 gem_wait_SOURCES = i915/gem_wait.c
 
 TESTS_progs += gem_watchdog
-gem_exec_watchdog_SOURCES = i915/gem_watchdog.c
+gem_watchdog_SOURCES = i915/gem_watchdog.c
 
 TESTS_progs += gem_workarounds
 gem_workarounds_SOURCES = i915/gem_workarounds.c
Signature · 6 lines
2.27.0

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Reviewed-by on v1 1/1
#1 lore raw
Quoted 5 lines · Tvrtko Ursulin

From: Tvrtko Ursulin <[email protected]>

Correcting a brain malfunction while typing in Makefile.sources.

Quoted 24 lines
---
 tests/Makefile.sources | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/Makefile.sources +1 -1
index e992285fedc5..194df8e27dd0 100644
@@ -464,7 +464,7 @@ TESTS_progs += gem_wait
 gem_wait_SOURCES = i915/gem_wait.c
 
 TESTS_progs += gem_watchdog
-gem_exec_watchdog_SOURCES = i915/gem_watchdog.c
+gem_watchdog_SOURCES = i915/gem_watchdog.c
 
 TESTS_progs += gem_workarounds
 gem_workarounds_SOURCES = i915/gem_workarounds.c
Signature · 6 lines
2.27.0

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#2 lore raw
Quoted 8 lines · Petri Latvala
Quoted 5 lines · Tvrtko Ursulin

From: Tvrtko Ursulin <[email protected]>

Correcting a brain malfunction while typing in Makefile.sources.

Isn't autotools now going away with Arek's series? -Daniel

Quoted 30 lines
Quoted 26 lines

---
 tests/Makefile.sources | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/Makefile.sources +1 -1
index e992285fedc5..194df8e27dd0 100644
@@ -464,7 +464,7 @@ TESTS_progs += gem_wait
 gem_wait_SOURCES = i915/gem_wait.c
 
 TESTS_progs += gem_watchdog
-gem_exec_watchdog_SOURCES = i915/gem_watchdog.c
+gem_watchdog_SOURCES = i915/gem_watchdog.c
 
 TESTS_progs += gem_workarounds
 gem_workarounds_SOURCES = i915/gem_workarounds.c
Signature · 6 lines
2.27.0

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Signature · 7 lines
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#3 lore raw
Quoted 11 lines · Daniel Vetter
Quoted 8 lines · Petri Latvala
Quoted 5 lines · Tvrtko Ursulin

From: Tvrtko Ursulin <[email protected]>

Correcting a brain malfunction while typing in Makefile.sources.

Isn't autotools now going away with Arek's series?

Yes. But this breakage happened before autotools removal landed.

Signature · 1 line
Petri Latvala
Quoted 24 lines

-Daniel

Quoted 22 lines
Quoted 22 lines

---
 tests/Makefile.sources | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/Makefile.sources +1 -1
index e992285fedc5..194df8e27dd0 100644
@@ -464,7 +464,7 @@ TESTS_progs += gem_wait
 gem_wait_SOURCES = i915/gem_wait.c
 
 TESTS_progs += gem_watchdog
-gem_exec_watchdog_SOURCES = i915/gem_watchdog.c
+gem_watchdog_SOURCES = i915/gem_watchdog.c
 
 TESTS_progs += gem_workarounds
 gem_workarounds_SOURCES = i915/gem_workarounds.c
Signature · 1 line
2.27.0
Quoted 13 lines
Quoted 8 lines
Quoted 4 lines

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Signature · 3 lines
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#4 lore raw

[igt-dev] ✗ Fi.CI.BAT: failure for gem_watchdog: Fix autotools build

In reply to Tvrtko Ursulin
== Series Details ==

== Series Details ==

Series: gem_watchdog: Fix autotools build
URL : https://patchwork.freedesktop.org/series/88656/
State : failure

== Summary ==

CI Bug Log - changes from IGT_6053 -> IGTPW_5686
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with IGTPW_5686 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in IGTPW_5686, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5686/index.html

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_5686:

### IGT changes ###

#### Possible regressions ####

* igt@i915_selftest@live@coherency:
- fi-icl-y: NOTRUN -> [DMESG-WARN][1] +5 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5686/fi-icl-y/igt@i915_selftest@[email protected]

Known issues
------------

Here are the changes found in IGTPW_5686 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@amdgpu/amd_basic@semaphore:
- fi-icl-y: NOTRUN -> [SKIP][2] ([fdo#109315]) +17 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5686/fi-icl-y/igt@amdgpu/[email protected]
- fi-bdw-5557u: NOTRUN -> [SKIP][3] ([fdo#109271]) +27 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5686/fi-bdw-5557u/igt@amdgpu/[email protected]

* igt@core_hotunplug@unbind-rebind:
- fi-bdw-5557u: NOTRUN -> [WARN][4] ([i915#2283])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5686/fi-bdw-5557u/igt@[email protected]

* igt@gem_exec_gttfill@basic:
- fi-tgl-y: [PASS][5] -> [DMESG-WARN][6] ([i915#402]) +2 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6053/fi-tgl-y/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5686/fi-tgl-y/igt@[email protected]
- fi-bsw-n3050: NOTRUN -> [SKIP][7] ([fdo#109271])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5686/fi-bsw-n3050/igt@[email protected]

* igt@gem_exec_suspend@basic-s3:
- fi-bsw-n3050: NOTRUN -> [INCOMPLETE][8] ([i915#3159])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5686/fi-bsw-n3050/igt@[email protected]

* igt@gem_huc_copy@huc-copy:
- fi-icl-y: NOTRUN -> [SKIP][9] ([i915#2190])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5686/fi-icl-y/igt@[email protected]

* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-tgl-y: [PASS][10] -> [DMESG-WARN][11] ([i915#1982] / [i915#2411])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6053/fi-tgl-y/igt@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5686/fi-tgl-y/igt@[email protected]

* igt@kms_chamelium@dp-crc-fast:
- fi-bdw-5557u: NOTRUN -> [SKIP][12] ([fdo#109271] / [fdo#111827]) +8 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5686/fi-bdw-5557u/igt@[email protected]
- fi-icl-y: NOTRUN -> [SKIP][13] ([fdo#109284] / [fdo#111827]) +8 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5686/fi-icl-y/igt@[email protected]

* igt@kms_force_connector_basic@force-load-detect:
- fi-icl-y: NOTRUN -> [SKIP][14] ([fdo#109285])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5686/fi-icl-y/igt@[email protected]

* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- fi-icl-y: NOTRUN -> [SKIP][15] ([fdo#109278])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5686/fi-icl-y/igt@[email protected]

* igt@kms_psr@primary_mmap_gtt:
- fi-icl-y: NOTRUN -> [SKIP][16] ([fdo#110189]) +3 similar issues
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5686/fi-icl-y/igt@kms_psr@primary_mmap_gtt.html

* igt@prime_vgem@basic-userptr:
- fi-icl-y: NOTRUN -> [SKIP][17] ([i915#3301])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5686/fi-icl-y/igt@[email protected]

#### Possible fixes ####

* igt@prime_vgem@basic-gtt:
- fi-tgl-y: [DMESG-WARN][18] ([i915#402]) -> [PASS][19] +2 similar issues
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6053/fi-tgl-y/igt@[email protected]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5686/fi-tgl-y/igt@[email protected]

#### Warnings ####

* igt@i915_pm_rpm@module-reload:
- fi-glk-dsi: [DMESG-WARN][20] ([i915#3143]) -> [DMESG-WARN][21] ([i915#1982] / [i915#3143])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6053/fi-glk-dsi/igt@[email protected]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5686/fi-glk-dsi/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2283]: https://gitlab.freedesktop.org/drm/intel/issues/2283
[i915#2411]: https://gitlab.freedesktop.org/drm/intel/issues/2411
[i915#3143]: https://gitlab.freedesktop.org/drm/intel/issues/3143
[i915#3159]: https://gitlab.freedesktop.org/drm/intel/issues/3159
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#541]: https://gitlab.freedesktop.org/drm/intel/issues/541

Participating hosts (45 -> 41)
------------------------------

Additional (2): fi-icl-y fi-bsw-n3050
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-ctg-p8600 fi-dg1-1 fi-bdw-samus

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_6053 -> IGTPW_5686

CI-20190529: 20190529
CI_DRM_9921: 803306c8496d8269b49debd0bccb37a3c7cf4070 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_5686: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5686/index.html
IGT_6053: c37c8443313a9de4d6a286f755702524e00bae1b @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5686/index.html

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev