Skip to contentSkip to conversation

ARM: dts: clps711x: Add SYSCON nodes where it is used

PATCH RESEND Superseded Alexander Shiyan 2 participants 6 messages Apr 2, 2021 – Apr 3, 2021 Device tree bindings

lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/5 ARM: dts: clps711x: Add SYSCON nodes where it is used

This patch adds SYSCON descriptors to framebuffer, SPI, DAI and modem control GPIO nodes to further rework these drivers to remove the call to the syscon_regmap_lookup_by_compatible() function.

---
 arch/arm/boot/dts/ep7209.dtsi | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm/boot/dts/ep7209.dtsi +4 -0
index 365931f8b48d..dacbe0d8e67a 100644
@@ -108,6 +108,7 @@ fb: fb@800002c0 {
 			compatible = "cirrus,ep7209-fb";
 			reg = <0x800002c0 0xd44>, <0x60000000 0xc000>;
 			clocks = <&clks CLPS711X_CLK_BUS>;
+			syscon = <&syscon1>;
 			status = "disabled";
 		};
 
@@ -147,6 +148,7 @@ spi: spi@80000500 {
 			reg = <0x80000500 0x4>;
 			interrupts = <15>;
 			clocks = <&clks CLPS711X_CLK_SPI>;
+			syscon = <&syscon3>;
 			status = "disabled";
 		};
 
@@ -170,6 +172,7 @@ dai: dai@80002000 {
 			clocks = <&clks CLPS711X_CLK_PLL>;
 			clock-names = "pll";
 			interrupts = <32>;
+			syscon = <&syscon3>;
 			status = "disabled";
 		};
 
@@ -181,6 +184,7 @@ syscon3: syscon@80002200 {
 
 	mctrl: mctrl {
 		compatible = "cirrus,ep7209-mctrl-gpio";
+		gpio,syscon-dev = <&syscon1 0 0>;
 		gpio-controller;
 		#gpio-cells = <2>;
 	};
Signature · 1 line
2.26.2
#1 lore raw

PATCH RESEND 2/5 ARM: dts: clps711x: Add keypad node

This adds missing keypad node to basic clps711x DT.

---
 arch/arm/boot/dts/ep7209.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)
arch/arm/boot/dts/ep7209.dtsi +7 -0
index dacbe0d8e67a..02606547bdc5 100644
@@ -182,6 +182,13 @@ syscon3: syscon@80002200 {
 		};
 	};
 
+	keypad: keypad {
+		compatible = "cirrus,ep7209-keypad";
+		interrupts = <16>;
+		syscon = <&syscon1>;
+		status = "disabled";
+	};
+
 	mctrl: mctrl {
 		compatible = "cirrus,ep7209-mctrl-gpio";
 		gpio,syscon-dev = <&syscon1 0 0>;
Signature · 1 line
2.26.2
#2 lore raw

PATCH RESEND 3/5 ARM: dts: clps711x: Fix serial port names

In reply to Alexander Shiyan

Preferred node name for serial ports is "serial".

---
 arch/arm/boot/dts/ep7209.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/ep7209.dtsi +2 -2
index 02606547bdc5..9350497c1805 100644
@@ -133,7 +133,7 @@ pwm: pwm@80000400 {
 			#pwm-cells = <1>;
 		};
 
-		uart1: uart@80000480 {
+		uart1: serial@80000480 {
 			compatible = "cirrus,ep7209-uart";
 			reg = <0x80000480 0x80>;
 			interrupts = <12 13>;
@@ -157,7 +157,7 @@ syscon2: syscon@80001100 {
 			reg = <0x80001100 0x80>;
 		};
 
-		uart2: uart@80001480 {
+		uart2: serial@80001480 {
 			compatible = "cirrus,ep7209-uart";
 			reg = <0x80001480 0x80>;
 			interrupts = <28 29>;
Signature · 1 line
2.26.2
#3 lore raw

PATCH RESEND 4/5 ARM: dts: clps711x: edb7211: Add unit-address to memory node

In reply to Alexander Shiyan

The memory node requires a unit-address, add it.

---
 arch/arm/boot/dts/ep7211-edb7211.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/ep7211-edb7211.dts +1 -1
index da076479c8e2..7fb532f227af 100644
@@ -7,7 +7,7 @@ / {
 	model = "Cirrus Logic EP7211 Development Board";
 	compatible = "cirrus,edb7211", "cirrus,ep7211", "cirrus,ep7209";
 
-	memory {
+	memory@c0000000 {
 		device_type = "memory";
 		reg = <0xc0000000 0x02000000>;
 	};
Signature · 7 lines
2.26.2


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#4 lore raw

PATCH RESEND 5/5 ARM: dts: clps711x: Add an empty chosen node to top level DTSI

In reply to Alexander Shiyan

Missing "chosen" node can cause issues when booting a kernel with a boot-loader that doesn't create a chosen node if this isn't present in the DTB since the decompressor relies on a pre-existing chosen node to be available to insert the command line and merge other ATAGS info.

---
 arch/arm/boot/dts/ep7209.dtsi | 2 ++
 1 file changed, 2 insertions(+)
arch/arm/boot/dts/ep7209.dtsi +2 -0
index 9350497c1805..40a277370fd0 100644
@@ -10,6 +10,8 @@ / {
 	model = "Cirrus Logic EP7209";
 	compatible = "cirrus,ep7209";
 
+	chosen { };
+
 	aliases {
 		gpio0 = &porta;
 		gpio1 = &portb;
Signature · 1 line
2.26.2
#5 lore raw
In reply to Alexander Shiyan
Quoted 9 lines · Alexander Shiyan

This patch adds SYSCON descriptors to framebuffer, SPI, DAI and modem control GPIO nodes to further rework these drivers to remove the call to the syscon_regmap_lookup_by_compatible() function.

---
 arch/arm/boot/dts/ep7209.dtsi | 4 ++++
 1 file changed, 4 insertions(+)

The patches all look good. Can you resend them to [email protected] to make them end up in patchwork for me to pick them up into the soc tree?

Thanks,

Arnd