nvmet-tcp: fix a segmentation fault during io parsing error
Subsystems (2)
PATCH v4 1/1 nvmet-tcp: fix a segmentation fault during io parsing error
From: Elad Grupi <[email protected]>
In case there is an io that contains inline data and it goes to parsing error flow, command response will free command and iov before clearing the data on the socket buffer.
This will delay the command response until receive flow is completed.
--- drivers/nvme/target/tcp.c | 37 ++++++++++++++++++++++++++++--------- 1 file changed, 28 insertions(+), 9 deletions(-)
drivers/nvme/target/tcp.c +28 -9
@@ -38,7 +38,8 @@ enum nvmet_tcp_send_state {NVMET_TCP_SEND_DATA ,NVMET_TCP_SEND_R2T ,NVMET_TCP_SEND_DDGST , -NVMET_TCP_SEND_RESPONSE +NVMET_TCP_SEND_RESPONSE , +NVMET_TCP_SEND_POSTPONED }; enum nvmet_tcp_recv_state {
@@ -530,6 +531,14 @@ static void nvmet_tcp_queue_response(struct nvmet_req *req)queue_work_on (queue_cpu (queue), nvmet_tcp_wq, &cmd->queue->io_work); } +static void nvmet_tcp_execute_request (struct nvmet_tcp_cmd *cmd) +{ +if (unlikely (cmd->state ==NVMET_TCP_SEND_POSTPONED )) +nvmet_tcp_queue_response (&cmd->req); +else + cmd->req.execute (&cmd->req); +} +static int nvmet_try_send_data_pdu (struct nvmet_tcp_cmd *cmd) {u8 hdgst =nvmet_tcp_hdgst_len (cmd->queue);
@@ -702,6 +711,18 @@ static int nvmet_tcp_try_send_one(struct nvmet_tcp_queue *queue,return 0 ; } +if (unlikely ((cmd->flags &NVMET_TCP_F_INIT_FAILED ) && +nvmet_tcp_has_data_in (cmd) && +nvmet_tcp_has_inline_data (cmd))) { +/* +* wait for inline data before processing the response +* so the iov will not be freed +*/ + cmd->state =NVMET_TCP_SEND_POSTPONED ; + queue->snd_cmd =NULL ; + goto done_send; + } +if (cmd->state ==NVMET_TCP_SEND_DATA_PDU ) { ret =nvmet_try_send_data_pdu (cmd);if (ret <=0 )
@@ -960,7 +981,7 @@ static int nvmet_tcp_done_recv_pdu(struct nvmet_tcp_queue *queue) le32_to_cpu(req->cmd->common.dptr.sgl.length));nvmet_tcp_handle_req_failure (queue, queue->cmd, req); -return -EAGAIN ; +return 0 ; } ret =nvmet_tcp_map_data (queue->cmd);
@@ -1103,10 +1124,8 @@ static int nvmet_tcp_try_recv_data(struct nvmet_tcp_queue *queue)return 0 ; } -if (!(cmd->flags &NVMET_TCP_F_INIT_FAILED ) && - cmd->rbytes_done == cmd->req.transfer_len) { - cmd->req.execute (&cmd->req); - } +if (cmd->rbytes_done == cmd->req.transfer_len) +nvmet_tcp_execute_request (cmd);nvmet_prepare_receive_pdu (queue);return 0 ;
@@ -1143,9 +1162,9 @@ static int nvmet_tcp_try_recv_ddgst(struct nvmet_tcp_queue *queue) goto out; } -if (!(cmd->flags &NVMET_TCP_F_INIT_FAILED ) && - cmd->rbytes_done == cmd->req.transfer_len) - cmd->req.execute (&cmd->req); +if (cmd->rbytes_done == cmd->req.transfer_len) +nvmet_tcp_execute_request (cmd); + ret =0 ; out:nvmet_prepare_receive_pdu (queue);
Signature · 7 lines
2.18.2 _______________________________________________ Linux-nvme mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-nvme
drivers/nvme/target/tcp.c static int nvmet_tcp_done_recv_pdu(struct nvmet_tcp_queue *queue) · line 987
Quoted 9 lines · Elad
drivers/nvme/target/tcp.c +1
-1@@ -960,7 +981,7 @@ static int nvmet_tcp_done_recv_pdu(struct nvmet_tcp_queue *queue) le32_to_cpu(req->cmd->common.dptr.sgl.length));nvmet_tcp_handle_req_failure (queue, queue->cmd, req); -return -EAGAIN ; +return 0 ; } ret =nvmet_tcp_map_data (queue->cmd);
Hi Elad
By returning 0, the response is queued twice before it is get off from the list. Even still returning -EAGAIN, the cmd still could be queued twice potentially.
I think we'd better not queue the failed cmd in first place. Please see my following fix later.
Thanks,
Hou
_______________________________________________
Linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme
Not sure I'm following.
Once req_init is failed, nvmet_tcp_handle_req_failure is called and changes the state to NVMET_TCP_RECV_DATA. In state NVMET_TCP_RECV_DATA we should not queue the response before it is get off from the list.
Am I missing something here?
-----Original Message-----
From: Hou Pu <[email protected]>
Sent: Wednesday, 31 March 2021 10:49
To: Grupi, Elad
Cc: [email protected]; [email protected]
Subject: Re: [PATCH v4] nvmet-tcp: fix a segmentation fault during io parsing error
[EXTERNAL EMAIL]
drivers/nvme/target/tcp.c static int nvmet_tcp_done_recv_pdu(struct nvmet_tcp_queue *queue) · line 987
Quoted 9 lines · Elad
drivers/nvme/target/tcp.c +1
-1@@ -960,7 +981,7 @@ static int nvmet_tcp_done_recv_pdu(struct nvmet_tcp_queue *queue) le32_to_cpu(req->cmd->common.dptr.sgl.length));nvmet_tcp_handle_req_failure (queue, queue->cmd, req); -return -EAGAIN ; +return 0 ; } ret =nvmet_tcp_map_data (queue->cmd);
Hi Elad
By returning 0, the response is queued twice before it is get off from the list. Even still returning -EAGAIN, the cmd still could be queued twice potentially.
I think we'd better not queue the failed cmd in first place. Please see my following fix later.
Thanks,
Hou
_______________________________________________
Linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme
Quoted 6 lines · Elad
Not sure I'm following.
Once
req_initis failed,nvmet_tcp_handle_req_failureis called and changes the state toNVMET_TCP_RECV_DATA. In stateNVMET_TCP_RECV_DATAwe should not queue the response before it is get off from the list.Am I missing something here?
1. nvmet_tcp_handle_req_failure is called,
2. Return 0 from nvmet_tcp_done_recv_pdu
3. nvmet_tcp_try_recv_data() from nvmet_tcp_try_recv_one(), After finish consume inline data, nvmet_tcp_execute_request() is called. Here NVMET_TCP_SEND_POSTPONED is not set. As nvmet_try_send_data_pdu() is not called yet. (it will be called after we return from nvmet_tcp_try_recv_one()).
Thanks,
Hou
_______________________________________________
Linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme
Right. Thank you for the clarification.
Elad
-----Original Message-----
From: Hou Pu <[email protected]>
Sent: Wednesday, 31 March 2021 12:08
To: Grupi, Elad
Cc: [email protected]; [email protected]; [email protected]
Subject: Re: [PATCH v4] nvmet-tcp: fix a segmentation fault during io parsing error
[EXTERNAL EMAIL]
Quoted 6 lines · Elad
Not sure I'm following.
Once
req_initis failed,nvmet_tcp_handle_req_failureis called and changes the state toNVMET_TCP_RECV_DATA. In stateNVMET_TCP_RECV_DATAwe should not queue the response before it is get off from the list.Am I missing something here?
1. nvmet_tcp_handle_req_failure is called, 2. Return 0 from nvmet_tcp_done_recv_pdu 3. nvmet_tcp_try_recv_data() from nvmet_tcp_try_recv_one(), After finish consume inline data, nvmet_tcp_execute_request() is called. Here
NVMET_TCP_SEND_POSTPONED is not set. As nvmet_try_send_data_pdu()
is not called yet. (it will be called after we return from
nvmet_tcp_try_recv_one()).
Thanks,
Hou
_______________________________________________
Linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme
PATCH v5 1/1 nvmet-tcp: fix a segmentation fault during io parsing error
In reply to Hou PuFrom: Elad Grupi <[email protected]>
In case there is an io that contains inline data and it goes to parsing error flow, command response will free command and iov before clearing the data on the socket buffer.
This will delay the command response until receive flow is completed.
--- drivers/nvme/target/tcp.c | 39 +++++++++++++++++++++++++++++++-------- 1 file changed, 31 insertions(+), 8 deletions(-)
drivers/nvme/target/tcp.c +31 -8
@@ -525,11 +525,36 @@ static void nvmet_tcp_queue_response(struct nvmet_req *req)struct nvmet_tcp_cmd *cmd = container_of(req, struct nvmet_tcp_cmd, req);struct nvmet_tcp_queue *queue = cmd->queue; +struct nvme_sgl_desc *sgl; +u32 len; + +if (unlikely (cmd == queue->cmd)) { + sgl = &cmd->req.cmd->common.dptr.sgl; + len =le32_to_cpu (sgl->length); + +/* +* Wait for inline data before processing the response. +* Avoid using helpers, this might happen before +* nvmet_req_init is completed. +*/ +if (queue->rcv_state ==NVMET_TCP_RECV_PDU && + len && len < cmd->req.port->inline_data_size && +nvme_is_write (cmd->req.cmd)) +return ; + }llist_add (&cmd->lentry, &queue->resp_list);queue_work_on (queue_cpu (queue), nvmet_tcp_wq, &cmd->queue->io_work); } +static void nvmet_tcp_execute_request (struct nvmet_tcp_cmd *cmd) +{ +if (unlikely (cmd->flags &NVMET_TCP_F_INIT_FAILED )) +nvmet_tcp_queue_response (&cmd->req); +else + cmd->req.execute (&cmd->req); +} +static int nvmet_try_send_data_pdu (struct nvmet_tcp_cmd *cmd) {u8 hdgst =nvmet_tcp_hdgst_len (cmd->queue);
@@ -961,7 +986,7 @@ static int nvmet_tcp_done_recv_pdu(struct nvmet_tcp_queue *queue) le32_to_cpu(req->cmd->common.dptr.sgl.length));nvmet_tcp_handle_req_failure (queue, queue->cmd, req); -return -EAGAIN ; +return 0 ; } ret =nvmet_tcp_map_data (queue->cmd);
@@ -1104,10 +1129,8 @@ static int nvmet_tcp_try_recv_data(struct nvmet_tcp_queue *queue)return 0 ; } -if (!(cmd->flags &NVMET_TCP_F_INIT_FAILED ) && - cmd->rbytes_done == cmd->req.transfer_len) { - cmd->req.execute (&cmd->req); - } +if (cmd->rbytes_done == cmd->req.transfer_len) +nvmet_tcp_execute_request (cmd);nvmet_prepare_receive_pdu (queue);return 0 ;
@@ -1144,9 +1167,9 @@ static int nvmet_tcp_try_recv_ddgst(struct nvmet_tcp_queue *queue) goto out; } -if (!(cmd->flags &NVMET_TCP_F_INIT_FAILED ) && - cmd->rbytes_done == cmd->req.transfer_len) - cmd->req.execute (&cmd->req); +if (cmd->rbytes_done == cmd->req.transfer_len) +nvmet_tcp_execute_request (cmd); + ret =0 ; out:nvmet_prepare_receive_pdu (queue);
Signature · 7 lines
2.28.0 _______________________________________________ Linux-nvme mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-nvme
Looks good to me.
Thanks,
Elad
-----Original Message-----
From: Hou Pu <[email protected]>
Sent: Wednesday, 31 March 2021 12:13
To: [email protected]; Grupi, Elad
Cc: [email protected]; [email protected]
Subject: [PATCH v5] nvmet-tcp: fix a segmentation fault during io parsing error
[EXTERNAL EMAIL]
From: Elad Grupi <[email protected]>
In case there is an io that contains inline data and it goes to parsing error flow, command response will free command and iov before clearing the data on the socket buffer. This will delay the command response until receive flow is completed.
--- drivers/nvme/target/tcp.c | 39 +++++++++++++++++++++++++++++++-------- 1 file changed, 31 insertions(+), 8 deletions(-)
drivers/nvme/target/tcp.c +24 -0
@@ -525,11 +525,36 @@ static void nvmet_tcp_queue_response(struct nvmet_req *req)struct nvmet_tcp_cmd *cmd = container_of(req, struct nvmet_tcp_cmd, req);struct nvmet_tcp_queue *queue = cmd->queue; +struct nvme_sgl_desc *sgl; +u32 len; + +if (unlikely (cmd == queue->cmd)) { + sgl = &cmd->req.cmd->common.dptr.sgl; + len =le32_to_cpu (sgl->length); + +/* +* Wait for inline data before processing the response. +* Avoid using helpers, this might happen before +* nvmet_req_init is completed. +*/ +if (queue->rcv_state ==NVMET_TCP_RECV_PDU && + len && len < cmd->req.port->inline_data_size && +nvme_is_write (cmd->req.cmd)) +return ; + }llist_add (&cmd->lentry, &queue->resp_list);queue_work_on (queue_cpu (queue), nvmet_tcp_wq, &cmd->queue->io_work); } +static void nvmet_tcp_execute_request (struct nvmet_tcp_cmd *cmd) { +if (unlikely (cmd->flags &NVMET_TCP_F_INIT_FAILED )) +nvmet_tcp_queue_response (&cmd->req); +else + cmd->req.execute (&cmd->req); +} +static int nvmet_try_send_data_pdu (struct nvmet_tcp_cmd *cmd) { u8 hdgst = nvmet_tcp_hdgst_len(cmd->queue); @@ -961,7 +986,7 @@ static int nvmet_tcp_done_recv_pdu(struct nvmet_tcp_queue *queue) le32_to_cpu(req->cmd->common.dptr.sgl.length));
nvmet_tcp_handle_req_failure(queue, queue->cmd, req);
- return -EAGAIN;
+ return 0;
}
ret = nvmet_tcp_map_data(queue->cmd);
@@ -1104,10 +1129,8 @@ static int nvmet_tcp_try_recv_data(struct nvmet_tcp_queue *queue)
return 0;
}
- if (!(cmd->flags & NVMET_TCP_F_INIT_FAILED) &&
- cmd->rbytes_done == cmd->req.transfer_len) {
- cmd->req.execute(&cmd->req);
- }
+ if (cmd->rbytes_done == cmd->req.transfer_len)
+ nvmet_tcp_execute_request(cmd);
nvmet_prepare_receive_pdu(queue);
return 0;
@@ -1144,9 +1167,9 @@ static int nvmet_tcp_try_recv_ddgst(struct nvmet_tcp_queue *queue)
goto out;
}
- if (!(cmd->flags & NVMET_TCP_F_INIT_FAILED) &&
- cmd->rbytes_done == cmd->req.transfer_len)
- cmd->req.execute(&cmd->req);
+ if (cmd->rbytes_done == cmd->req.transfer_len)
+ nvmet_tcp_execute_request(cmd);
+
ret = 0;
out:
nvmet_prepare_receive_pdu(queue);
--
2.28.0
_______________________________________________
Linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme
Quoted 1 line · Elad
Looks good to me.
Is that a Reviewed-by?
_______________________________________________
Linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme
Let's have @[email protected] take another look please.
Thanks,
Elad
-----Original Message-----
From: Christoph Hellwig <[email protected]>
Sent: Friday, 2 April 2021 19:18
To: Grupi, Elad
Cc: Hou Pu; [email protected]; [email protected]
Subject: Re: [PATCH v5] nvmet-tcp: fix a segmentation fault during io parsing error
[EXTERNAL EMAIL]
Quoted 1 line · Elad
Looks good to me.
Is that a Reviewed-by?
_______________________________________________
Linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme
Hi Hou.
I tested this patch on our system and it solved the issue.
I think there is a minor issue with the spaces indentation in the patch:
+ len && len < cmd->req.port->inline_data_size &&
+ nvme_is_write(cmd->req.cmd))
Thanks,
Elad
-----Original Message-----
From: Hou Pu <[email protected]>
Sent: Wednesday, 31 March 2021 12:13
To: [email protected]; Grupi, Elad
Cc: [email protected]; [email protected]
Subject: [PATCH v5] nvmet-tcp: fix a segmentation fault during io parsing error
[EXTERNAL EMAIL]
From: Elad Grupi <[email protected]>
In case there is an io that contains inline data and it goes to parsing error flow, command response will free command and iov before clearing the data on the socket buffer. This will delay the command response until receive flow is completed.
--- drivers/nvme/target/tcp.c | 39 +++++++++++++++++++++++++++++++-------- 1 file changed, 31 insertions(+), 8 deletions(-)
drivers/nvme/target/tcp.c +24 -0
@@ -525,11 +525,36 @@ static void nvmet_tcp_queue_response(struct nvmet_req *req)struct nvmet_tcp_cmd *cmd = container_of(req, struct nvmet_tcp_cmd, req);struct nvmet_tcp_queue *queue = cmd->queue; +struct nvme_sgl_desc *sgl; +u32 len; + +if (unlikely (cmd == queue->cmd)) { + sgl = &cmd->req.cmd->common.dptr.sgl; + len =le32_to_cpu (sgl->length); + +/* +* Wait for inline data before processing the response. +* Avoid using helpers, this might happen before +* nvmet_req_init is completed. +*/ +if (queue->rcv_state ==NVMET_TCP_RECV_PDU && + len && len < cmd->req.port->inline_data_size && +nvme_is_write (cmd->req.cmd)) +return ; + }llist_add (&cmd->lentry, &queue->resp_list);queue_work_on (queue_cpu (queue), nvmet_tcp_wq, &cmd->queue->io_work); } +static void nvmet_tcp_execute_request (struct nvmet_tcp_cmd *cmd) { +if (unlikely (cmd->flags &NVMET_TCP_F_INIT_FAILED )) +nvmet_tcp_queue_response (&cmd->req); +else + cmd->req.execute (&cmd->req); +} +static int nvmet_try_send_data_pdu (struct nvmet_tcp_cmd *cmd) { u8 hdgst = nvmet_tcp_hdgst_len(cmd->queue); @@ -961,7 +986,7 @@ static int nvmet_tcp_done_recv_pdu(struct nvmet_tcp_queue *queue) le32_to_cpu(req->cmd->common.dptr.sgl.length));
nvmet_tcp_handle_req_failure(queue, queue->cmd, req);
- return -EAGAIN;
+ return 0;
}
ret = nvmet_tcp_map_data(queue->cmd);
@@ -1104,10 +1129,8 @@ static int nvmet_tcp_try_recv_data(struct nvmet_tcp_queue *queue)
return 0;
}
- if (!(cmd->flags & NVMET_TCP_F_INIT_FAILED) &&
- cmd->rbytes_done == cmd->req.transfer_len) {
- cmd->req.execute(&cmd->req);
- }
+ if (cmd->rbytes_done == cmd->req.transfer_len)
+ nvmet_tcp_execute_request(cmd);
nvmet_prepare_receive_pdu(queue);
return 0;
@@ -1144,9 +1167,9 @@ static int nvmet_tcp_try_recv_ddgst(struct nvmet_tcp_queue *queue)
goto out;
}
- if (!(cmd->flags & NVMET_TCP_F_INIT_FAILED) &&
- cmd->rbytes_done == cmd->req.transfer_len)
- cmd->req.execute(&cmd->req);
+ if (cmd->rbytes_done == cmd->req.transfer_len)
+ nvmet_tcp_execute_request(cmd);
+
ret = 0;
out:
nvmet_prepare_receive_pdu(queue);
--
2.28.0
_______________________________________________
Linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme
Quoted 4 lines · Elad
Hi Hou.
I tested this patch on our system and it solved the issue.
Thanks.
drivers/nvme/target/tcp.c static void nvmet_tcp_queue_response(struct nvmet_req *req) · line 542
Quoted 4 lines
I think there is a minor issue with the spaces indentation in the patch:
drivers/nvme/target/tcp.c +2
-0+ len && len < cmd->req.port->inline_data_size && + nvme_is_write(cmd->req.cmd))
Hi Elad,
I run scripts/checkpatch.pl, there are no errors or warnings. We could find such indentation style in many places in tcp.c or other files.
Thanks,
Hou
Quoted 98 lines
Thanks,
Elad-----Original Message-----
From: Hou Pu <[email protected]>
Sent: Wednesday, 31 March 2021 12:13
To: [email protected]; Grupi, Elad
Cc: [email protected]; [email protected]
Subject: [PATCH v5] nvmet-tcp: fix a segmentation fault during io parsing error[EXTERNAL EMAIL]
From: Elad Grupi <[email protected]>
In case there is an io that contains inline data and it goes to parsing error flow, command response will free command and iov before clearing the data on the socket buffer. This will delay the command response until receive flow is completed.
Fixes 872d26a391da ("nvmet-tcp: add NVMe over TCP target driver")Signed-off-by Elad Grupi <[email protected]>Signed-off-by Hou Pu <[email protected]>--- drivers/nvme/target/tcp.c | 39 +++++++++++++++++++++++++++++++-------- 1 file changed, 31 insertions(+), 8 deletions(-)drivers/nvme/target/tcp.c +30
-9@@ -525,11 +525,36 @@ static void nvmet_tcp_queue_response(struct nvmet_req *req)struct nvmet_tcp_cmd *cmd = container_of(req, struct nvmet_tcp_cmd, req);struct nvmet_tcp_queue *queue = cmd->queue; +struct nvme_sgl_desc *sgl; +u32 len; + +if (unlikely (cmd == queue->cmd)) { + sgl = &cmd->req.cmd->common.dptr.sgl; + len =le32_to_cpu (sgl->length); + +/* +* Wait for inline data before processing the response. +* Avoid using helpers, this might happen before +* nvmet_req_init is completed. +*/ +if (queue->rcv_state ==NVMET_TCP_RECV_PDU && + len && len < cmd->req.port->inline_data_size && +nvme_is_write (cmd->req.cmd)) +return ; + }llist_add (&cmd->lentry, &queue->resp_list);queue_work_on (queue_cpu (queue), nvmet_tcp_wq, &cmd->queue->io_work); } +static void nvmet_tcp_execute_request (struct nvmet_tcp_cmd *cmd) { +if (unlikely (cmd->flags &NVMET_TCP_F_INIT_FAILED )) +nvmet_tcp_queue_response (&cmd->req); +else + cmd->req.execute (&cmd->req); +} +static int nvmet_try_send_data_pdu (struct nvmet_tcp_cmd *cmd) { u8 hdgst = nvmet_tcp_hdgst_len(cmd->queue); @@ -961,7 +986,7 @@ static int nvmet_tcp_done_recv_pdu(struct nvmet_tcp_queue *queue) le32_to_cpu(req->cmd->common.dptr.sgl.length));nvmet_tcp_handle_req_failure (queue, queue->cmd, req); -return -EAGAIN ; +return 0 ; } ret =nvmet_tcp_map_data (queue->cmd);@@ -1104,10 +1129,8 @@ static int nvmet_tcp_try_recv_data(struct nvmet_tcp_queue *queue)return 0 ; } -if (!(cmd->flags &NVMET_TCP_F_INIT_FAILED ) && - cmd->rbytes_done == cmd->req.transfer_len) { - cmd->req.execute (&cmd->req); - } +if (cmd->rbytes_done == cmd->req.transfer_len) +nvmet_tcp_execute_request (cmd);nvmet_prepare_receive_pdu (queue);return 0 ;@@ -1144,9 +1167,9 @@ static int nvmet_tcp_try_recv_ddgst(struct nvmet_tcp_queue *queue) goto out; } -if (!(cmd->flags &NVMET_TCP_F_INIT_FAILED ) && - cmd->rbytes_done == cmd->req.transfer_len) - cmd->req.execute (&cmd->req); +if (cmd->rbytes_done == cmd->req.transfer_len) +nvmet_tcp_execute_request (cmd); + ret =0 ; out:nvmet_prepare_receive_pdu (queue); --
Quoted 2 lines
2.28.0
_______________________________________________
Linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme
Quoted 11 lines
From: Elad Grupi <[email protected]>
In case there is an io that contains inline data and it goes to parsing error flow, command response will free command and iov before clearing the data on the socket buffer.
This will delay the command response until receive flow is completed.Fixes 872d26a391da ("nvmet-tcp: add NVMe over TCP target driver")Signed-off-by Elad Grupi <[email protected]>Signed-off-by Hou Pu <[email protected]>
This looks fine to me:
_______________________________________________
Linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme
Christoph Hellwig
AppliedThanks,
applied to nvme-5.13.
_______________________________________________
Linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme