staging: rtl8188eu: core: add comma within a comment
PATCH 1/1 staging: rtl8188eu: core: add comma within a comment
Add a comma to separate repeated words in a comment. The comma preserves the meaning of the comment while also stopping the checkpatch warning:
WARNING: Possible repeated word: 'very'.
--- drivers/staging/rtl8188eu/core/rtw_xmit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8188eu/core/rtw_xmit.c +1 -1
@@ -1243,7 +1243,7 @@ s32 rtw_free_xmitbuf(struct xmit_priv *pxmitpriv, struct xmit_buf *pxmitbuf)* If we turn on USE_RXTHREAD, then, no need for critical section. * Otherwise, we must use _enter/_exit critical to protect free_xmit_queue... * -* Must be very very cautious... +* Must be very, very cautious... * */
Signature · 1 line
2.17.1
Quoted 3 lines · Deborah Brouwer
Add a comma to separate repeated words in a comment. The comma preserves the meaning of the comment while also stopping the checkpatch warning:
WARNING: Possible repeated word: 'very'.
Thanks. That is more understandable. Isn't this a v2? If so, there should be v2 after PATCH and an explanation of the change under the ---
julia
Quoted 27 lines
Signed-off-by Deborah Brouwer <[email protected]>--- drivers/staging/rtl8188eu/core/rtw_xmit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/rtl8188eu/core/rtw_xmit.c +1
-2@@ -1243,7 +1243,7 @@ s32 rtw_free_xmitbuf(struct xmit_priv *pxmitpriv, struct xmit_buf *pxmitbuf)* If we turn on USE_RXTHREAD, then, no need for critical section. * Otherwise, we must use _enter/_exit critical to protect free_xmit_queue... * -* Must be very very cautious... +* Must be very, very cautious... * */ --2.17.1
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20210403210930.17781-1-deborahbrouwer3563%40gmail.com.
Quoted 4 lines · Julia Lawall
On Sat, 3 Apr 2021, Deborah Brouwer wrote:
Quoted 8 lines
Quoted 3 lines
Add a comma to separate repeated words in a comment. The comma preserves the meaning of the comment while also stopping the checkpatch warning:
WARNING: Possible repeated word: 'very'.Thanks. That is more understandable. Isn't this a v2? If so, there should be v2 after PATCH and an explanation of the change under the ---
julia
Hi Julia, no this is not a v2. I found the same comment, generating the same error, in a different file. Since I changed it in rtl8723bs/core/rtw_xmit.c [1], I thought I should be consistent and change it here as well.
Quoted 29 lines
Quoted 29 lines
Signed-off-by Deborah Brouwer <[email protected]>--- drivers/staging/rtl8188eu/core/rtw_xmit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/rtl8188eu/core/rtw_xmit.c +1
-2@@ -1243,7 +1243,7 @@ s32 rtw_free_xmitbuf(struct xmit_priv *pxmitpriv, struct xmit_buf *pxmitbuf)* If we turn on USE_RXTHREAD, then, no need for critical section. * Otherwise, we must use _enter/_exit critical to protect free_xmit_queue... * -* Must be very very cautious... +* Must be very, very cautious... * */ --2.17.1
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20210403210930.17781-1-deborahbrouwer3563%40gmail.com.
Quoted 9 lines · Deborah Brouwer
Quoted 8 lines · Julia Lawall
Quoted 3 lines · Deborah Brouwer
Add a comma to separate repeated words in a comment. The comma preserves the meaning of the comment while also stopping the checkpatch warning:
WARNING: Possible repeated word: 'very'.
Quoted 8 lines
Quoted 4 lines
Thanks. That is more understandable. Isn't this a v2? If so, there should be v2 after PATCH and an explanation of the change under the ---
julia
Hi Julia, no this is not a v2. I found the same comment, generating the same error, in a different file. Since I changed it in
rtl8723bs/core/rtw_xmit.c[1], I thought I should be consistent and change it here as well.
OK, thanks for the explanation :)
julia
Quoted 33 lines
Quoted 29 lines
Quoted 29 lines
Signed-off-by Deborah Brouwer <[email protected]>--- drivers/staging/rtl8188eu/core/rtw_xmit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/rtl8188eu/core/rtw_xmit.c +1
-2@@ -1243,7 +1243,7 @@ s32 rtw_free_xmitbuf(struct xmit_priv *pxmitpriv, struct xmit_buf *pxmitbuf)* If we turn on USE_RXTHREAD, then, no need for critical section. * Otherwise, we must use _enter/_exit critical to protect free_xmit_queue... * -* Must be very very cautious... +* Must be very, very cautious... * */ --2.17.1
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20210403210930.17781-1-deborahbrouwer3563%40gmail.com.