Skip to contentSkip to conversation

fstests: Do not execute xfs/{532,533,538} when realtime feature is enabled

PATCH In review Chandan Babu R 2 participants 2 messages Apr 5, 2021 – Apr 7, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fstests: Do not execute xfs/{532,533,538} when realtime feature is enabled

The minimum length space allocator (i.e. xfs_bmap_exact_minlen_extent_alloc()) depends on the underlying filesystem to be fragmented so that there are enough one block sized extents available to satify space allocation requests.

xfs/{532,533,538} tests issue space allocation requests for metadata (e.g. for blocks holding directory and xattr information). With realtime filesystem instances, these tests would end up fragmenting the space on realtime device. Hence minimum length space allocator fails since the regular filesystem space is not fragmented and hence there are no one block sized extents available.

Thus, this commit disables execution of xfs/{532,533,538} when realtime feature is enabled on the filesystem instance.

---
 tests/xfs/532 | 1 +
 tests/xfs/533 | 1 +
 tests/xfs/538 | 1 +
 3 files changed, 3 insertions(+)
tests/xfs/532 +1 -0
index 2bed574a..5359add5 100755
@@ -37,6 +37,7 @@ _supported_fs xfs
 _require_scratch
 _require_attrs
 _require_xfs_debug
+_require_no_realtime
 _require_test_program "punch-alternating"
 _require_xfs_io_error_injection "reduce_max_iextents"
 _require_xfs_io_error_injection "bmap_alloc_minlen_extent"
tests/xfs/533 +1 -0
index be909fcc..4826cccc 100755
@@ -35,6 +35,7 @@ rm -f $seqres.full
 _supported_fs xfs
 _require_scratch
 _require_xfs_debug
+_require_no_realtime
 _require_test_program "punch-alternating"
 _require_xfs_io_error_injection "reduce_max_iextents"
 _require_xfs_io_error_injection "bmap_alloc_minlen_extent"
tests/xfs/538 +1 -0
index 90eb1637..53a2c060 100755
@@ -35,6 +35,7 @@ rm -f $seqres.full
 _supported_fs xfs
 _require_scratch
 _require_xfs_debug
+_require_no_realtime
 _require_test_program "punch-alternating"
 _require_xfs_io_error_injection "bmap_alloc_minlen_extent"
 
Signature · 1 line
2.29.2
#1 lore raw
Quoted 27 lines · Chandan Babu R

The minimum length space allocator (i.e. xfs_bmap_exact_minlen_extent_alloc()) depends on the underlying filesystem to be fragmented so that there are enough one block sized extents available to satify space allocation requests.

xfs/{532,533,538} tests issue space allocation requests for metadata (e.g. for blocks holding directory and xattr information). With realtime filesystem instances, these tests would end up fragmenting the space on realtime device. Hence minimum length space allocator fails since the regular filesystem space is not fragmented and hence there are no one block sized extents available.

Thus, this commit disables execution of xfs/{532,533,538} when realtime feature is enabled on the filesystem instance.

---
 tests/xfs/532 | 1 +
 tests/xfs/533 | 1 +
 tests/xfs/538 | 1 +
 3 files changed, 3 insertions(+)
tests/xfs/532 +0 -0
index 2bed574a..5359add5 100755

tests/xfs/532 _supported_fs xfs · line 40

Quoted 4 lines
tests/xfs/532 +1 -0
@@ -37,6 +37,7 @@ _supported_fs xfs
 _require_scratch
 _require_attrs
 _require_xfs_debug
+_require_no_realtime

Alternately, you could do:

$XFS_IO_PROG -c 'chattr -t' $SCRATCH_MNT

and not reduce test coverage.

--D

Quoted 30 lines
tests/xfs/532 +0 -0
 _require_test_program "punch-alternating"
 _require_xfs_io_error_injection "reduce_max_iextents"
 _require_xfs_io_error_injection "bmap_alloc_minlen_extent"
tests/xfs/533 +1 -0
index be909fcc..4826cccc 100755
@@ -35,6 +35,7 @@ rm -f $seqres.full
 _supported_fs xfs
 _require_scratch
 _require_xfs_debug
+_require_no_realtime
 _require_test_program "punch-alternating"
 _require_xfs_io_error_injection "reduce_max_iextents"
 _require_xfs_io_error_injection "bmap_alloc_minlen_extent"
tests/xfs/538 +1 -0
index 90eb1637..53a2c060 100755
@@ -35,6 +35,7 @@ rm -f $seqres.full
 _supported_fs xfs
 _require_scratch
 _require_xfs_debug
+_require_no_realtime
 _require_test_program "punch-alternating"
 _require_xfs_io_error_injection "bmap_alloc_minlen_extent"
 
Signature · 1 line
2.29.2