Skip to contentSkip to conversation

media: siano: use DEFINE_MUTEX() for mutex lock

PATCH In review Muhammad Usama Anjum 1 participant 2 messages Apr 5, 2021 – Apr 28, 2021

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 media: siano: use DEFINE_MUTEX() for mutex lock

mutex lock can be initialized with DEFINE_MUTEX() rather than explicitly calling mutex_init().

---
 drivers/media/common/siano/smscoreapi.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)
drivers/media/common/siano/smscoreapi.c +2 -5
index 410cc3ac6f94..7f5b638d2458 100644
@@ -414,10 +414,10 @@ struct smscore_registry_entry_t {
 
 static struct list_head g_smscore_notifyees;
 static struct list_head g_smscore_devices;
-static struct mutex g_smscore_deviceslock;
+static DEFINE_MUTEX(g_smscore_deviceslock);
 
 static struct list_head g_smscore_registry;
-static struct mutex g_smscore_registrylock;
+static DEFINE_MUTEX(g_smscore_registrylock);
 
 static int default_mode = DEVICE_MODE_NONE;
 
@@ -2123,10 +2123,7 @@ static int __init smscore_module_init(void)
 {
 	INIT_LIST_HEAD(&g_smscore_notifyees);
 	INIT_LIST_HEAD(&g_smscore_devices);
-	mutex_init(&g_smscore_deviceslock);
-
 	INIT_LIST_HEAD(&g_smscore_registry);
-	mutex_init(&g_smscore_registrylock);
 
 	return 0;
 }
Signature · 1 line
2.25.1
#1 lore raw

Reminder!

Quoted 36 lines · Muhammad Usama Anjum

mutex lock can be initialized with DEFINE_MUTEX() rather than explicitly calling mutex_init().

---
 drivers/media/common/siano/smscoreapi.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)
drivers/media/common/siano/smscoreapi.c +2 -5
index 410cc3ac6f94..7f5b638d2458 100644
@@ -414,10 +414,10 @@ struct smscore_registry_entry_t {
 
 static struct list_head g_smscore_notifyees;
 static struct list_head g_smscore_devices;
-static struct mutex g_smscore_deviceslock;
+static DEFINE_MUTEX(g_smscore_deviceslock);
 
 static struct list_head g_smscore_registry;
-static struct mutex g_smscore_registrylock;
+static DEFINE_MUTEX(g_smscore_registrylock);
 
 static int default_mode = DEVICE_MODE_NONE;
 
@@ -2123,10 +2123,7 @@ static int __init smscore_module_init(void)
 {
 	INIT_LIST_HEAD(&g_smscore_notifyees);
 	INIT_LIST_HEAD(&g_smscore_devices);
-	mutex_init(&g_smscore_deviceslock);
-
 	INIT_LIST_HEAD(&g_smscore_registry);
-	mutex_init(&g_smscore_registrylock);
 
 	return 0;
 }