ext4: Fix ext4_error_err save negative errno into superblock

PATCH Applied Ye Bin 2 participants 2 messages Apr 6, 2021 – Apr 10, 2021 ext4 file system

lore

Share & tools

lore

Ye Bin

author

2021-04-06 02:45 UTC #0 lore raw

PATCH v3 1/1 ext4: Fix ext4_error_err save negative errno into superblock

As write_mmp_block return 1 when buffer isn't uptodate, return -EIO is more appropriate.

Fixes 54d3adbc29f0 ("ext4: save all error info in save_error_info() and drop ext4_set_errno()")

Reported-by Liu Zhi Qiang <[email protected]>

Signed-off-by Ye Bin <[email protected]>

Reviewed-by Andreas Dilger <[email protected]>

---
 fs/ext4/mmp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

fs/ext4/mmp.c +1 -1

index 795c3ff2907c..68fbeedd627b 100644
@@ -56,7 +56,7 @@ static int write_mmp_block(struct super_block *sb, struct buffer_head *bh)
 	wait_on_buffer(bh);
 	sb_end_write(sb);
 	if (unlikely(!buffer_uptodate(bh)))
-		return 1;
+		return -EIO;
 
 	return 0;
 }

Signature · 1 line

2.25.4

Theodore Ts'o

maintainer Applied

2021-04-10 00:54 UTC #1 lore raw

Quoted 7 lines · Ye Bin

As write_mmp_block return 1 when buffer isn't uptodate, return -EIO is more appropriate.
Fixes 54d3adbc29f0 ("ext4: save all error info in save_error_info() and drop ext4_set_errno()")
Reported-by Liu Zhi Qiang <[email protected]>
Signed-off-by Ye Bin <[email protected]>
Reviewed-by Andreas Dilger <[email protected]>

Thanks, applied.

- Ted