Skip to contentSkip to conversation

arm64: dts: qcom: Update iommu property for simultaneous playback

PATCH Applied Srinivasa Rao Mandadapu 3 participants 6 messages Apr 6, 2021 – Apr 19, 2021

Subsystems (4)
Device tree bindings Arm Qualcomm mailing list Arm Qualcomm support Arm/Qualcomm chromebook support
lore
Share & tools
lore

Srinivasa Rao Mandadapu

author
#0 lore raw

PATCH v2 1/1 arm64: dts: qcom: Update iommu property for simultaneous playback

From: V Sujith Kumar Reddy <[email protected]>

Update iommu property in lpass cpu node for supporting simultaneous playback on headset and speaker.

Signed-off-by V Sujith Kumar Reddy <[email protected]>
Signed-off-by Srinivasa Rao Mandadapu <[email protected]>

---
Changes since v1:
-- Commit messge header change

 arch/arm64/boot/dts/qcom/sc7180.dtsi | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
arch/arm64/boot/dts/qcom/sc7180.dtsi +2 -1
index a6da78d31fdd..6228ba2d8513 100644
@@ -3566,7 +3566,8 @@ lpass_cpu: lpass@62f00000 {
 			reg = <0 0x62f00000 0 0x29000>;
 			reg-names = "lpass-lpaif";
 
-			iommus = <&apps_smmu 0x1020 0>;
+			iommus = <&apps_smmu 0x1020 0>,
+				<&apps_smmu 0x1021 0>;
 
 			power-domains = <&lpass_hm LPASS_CORE_HM_GDSCR>;
Signature · 2 lines
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.,
is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
#1 lore raw

Quoting Srinivasa Rao Mandadapu (2021-04-06 09:33:30)

Quoted 19 lines

From: V Sujith Kumar Reddy <[email protected]>

Update iommu property in lpass cpu node for supporting simultaneous playback on headset and speaker.

Signed-off-by V Sujith Kumar Reddy <[email protected]>
Signed-off-by Srinivasa Rao Mandadapu <[email protected]>

---
Changes since v1:
-- Commit messge header change

 arch/arm64/boot/dts/qcom/sc7180.dtsi | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
arch/arm64/boot/dts/qcom/sc7180.dtsi +0 -0
index a6da78d31fdd..6228ba2d8513 100644

arch/arm64/boot/dts/qcom/sc7180.dtsi lpass_cpu: lpass@62f00000 { · line 3570

Quoted 6 lines
arch/arm64/boot/dts/qcom/sc7180.dtsi +2 -1
@@ -3566,7 +3566,8 @@ lpass_cpu: lpass@62f00000 {
                        reg = <0 0x62f00000 0 0x29000>;
                        reg-names = "lpass-lpaif";
 
-                       iommus = <&apps_smmu 0x1020 0>;
+                       iommus = <&apps_smmu 0x1020 0>,
+                               <&apps_smmu 0x1021 0>;

The stream ID 0x1032 was also dropped in this version but there's no mention of that in the changelog. Why?

Quoted 3 lines
arch/arm64/boot/dts/qcom/sc7180.dtsi +0 -0
                        power-domains = <&lpass_hm LPASS_CORE_HM_GDSCR>;
author
#2 lore raw

Hi Stephen.

Thanks for your time!!!

Quoted 23 lines · Stephen Boyd

Quoting Srinivasa Rao Mandadapu (2021-04-06 09:33:30)

Quoted 22 lines

From: V Sujith Kumar Reddy <[email protected]>

Update iommu property in lpass cpu node for supporting simultaneous playback on headset and speaker.

Signed-off-by V Sujith Kumar Reddy <[email protected]>
Signed-off-by Srinivasa Rao Mandadapu <[email protected]>

---
Changes since v1:
-- Commit messge header change

  arch/arm64/boot/dts/qcom/sc7180.dtsi | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
arch/arm64/boot/dts/qcom/sc7180.dtsi +0 -0
index a6da78d31fdd..6228ba2d8513 100644
@@ -3566,7 +3566,8 @@ lpass_cpu: lpass@62f00000 {
                         reg = <0 0x62f00000 0 0x29000>;
                         reg-names = "lpass-lpaif";
Quoted 5 lines

arch/arm64/boot/dts/qcom/sc7180.dtsi lpass_cpu: lpass@62f00000 { · line 3570

Quoted 3 lines
arch/arm64/boot/dts/qcom/sc7180.dtsi +2 -1
-                       iommus = <&apps_smmu 0x1020 0>;
+                       iommus = <&apps_smmu 0x1020 0>,
+                               <&apps_smmu 0x1021 0>;

The stream ID 0x1032 was also dropped in this version but there's no mention of that in the changelog. Why?

That is ID is for HDMI Stream, so as part of DP patches that will be added.

Quoted 4 lines
Quoted 4 lines
arch/arm64/boot/dts/qcom/sc7180.dtsi +0 -0
                         power-domains = <&lpass_hm LPASS_CORE_HM_GDSCR>;
Signature · 2 lines
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.,
is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
#3 lore raw

Quoting Srinivasa Rao Mandadapu (2021-04-09 22:17:07)

Quoted 29 lines

Hi Stephen.

Thanks for your time!!!

Quoted 23 lines · Stephen Boyd

Quoting Srinivasa Rao Mandadapu (2021-04-06 09:33:30)

Quoted 22 lines

From: V Sujith Kumar Reddy <[email protected]>

Update iommu property in lpass cpu node for supporting simultaneous playback on headset and speaker.

Signed-off-by V Sujith Kumar Reddy <[email protected]>
Signed-off-by Srinivasa Rao Mandadapu <[email protected]>

---
Changes since v1:
-- Commit messge header change

  arch/arm64/boot/dts/qcom/sc7180.dtsi | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
arch/arm64/boot/dts/qcom/sc7180.dtsi +0 -0
index a6da78d31fdd..6228ba2d8513 100644
@@ -3566,7 +3566,8 @@ lpass_cpu: lpass@62f00000 {
                         reg = <0 0x62f00000 0 0x29000>;
                         reg-names = "lpass-lpaif";
Quoted 6 lines
Quoted 5 lines

arch/arm64/boot/dts/qcom/sc7180.dtsi lpass_cpu: lpass@62f00000 { · line 3570

Quoted 3 lines
arch/arm64/boot/dts/qcom/sc7180.dtsi +2 -1
-                       iommus = <&apps_smmu 0x1020 0>;
+                       iommus = <&apps_smmu 0x1020 0>,
+                               <&apps_smmu 0x1021 0>;

The stream ID 0x1032 was also dropped in this version but there's no mention of that in the changelog. Why?

That is ID is for HDMI Stream, so as part of DP patches that will be added.

Ok, got it.

CI Applied
#5 lore raw
In reply to Srinivasa Rao Mandadapu
This patch was applied to qcom/linux.git (refs/heads/for-next):

Hello:

This patch was applied to qcom/linux.git (refs/heads/for-next):

Quoted 9 lines · On Tue, 6 Apr 2021 22:03:30 +0530 you wrote:

From: V Sujith Kumar Reddy <[email protected]>

Update iommu property in lpass cpu node for supporting simultaneous playback on headset and speaker.

Signed-off-by V Sujith Kumar Reddy <[email protected]>
Signed-off-by Srinivasa Rao Mandadapu <[email protected]>

[...]

Here is the summary with links:
- [v2] arm64: dts: qcom: Update iommu property for simultaneous playback

    https://git.kernel.org/qcom/c/367a8230fc88

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html