Skip to contentSkip to conversation

staging: axis-fifo: media/meson: remove redundant dev_err call

PATCH In review Muhammad Usama Anjum 2 participants 3 messages Apr 7, 2021

Subsystems (5)
Media (V4L/DVB) Staging Kernel janitors Arm/Amlogic Meson SoC support +1 more subsystems
lore
Share & tools
lore

Muhammad Usama Anjum

author
#0 lore raw

PATCH 1/1 staging: axis-fifo: media/meson: remove redundant dev_err call

devm_ioremap_resource() prints error message in itself. Remove the dev_err call to avoid redundant error message.

Signed-off-by Muhammad Usama Anjum <[email protected]>
---
 drivers/staging/axis-fifo/axis-fifo.c   | 1 -
 drivers/staging/media/meson/vdec/vdec.c | 8 ++------
 2 files changed, 2 insertions(+), 7 deletions(-)
drivers/staging/axis-fifo/axis-fifo.c +0 -1
index 2bb1c2e9cb57..ed9281089738 100644
@@ -853,7 +853,6 @@ static int axis_fifo_probe(struct platform_device *pdev)
 	fifo->base_addr = devm_ioremap_resource(fifo->dt_device, r_mem);
 	if (IS_ERR(fifo->base_addr)) {
 		rc = PTR_ERR(fifo->base_addr);
-		dev_err(fifo->dt_device, "can't remap IO resource (%d)\n", rc);
 		goto err_initial;
 	}
drivers/staging/media/meson/vdec/vdec.c +2 -6
index 5d4db7a5b4b5..e51d69c4729d 100644
@@ -1008,17 +1008,13 @@ static int vdec_probe(struct platform_device *pdev)
 
 	r = platform_get_resource_byname(pdev, IORESOURCE_MEM, "dos");
 	core->dos_base = devm_ioremap_resource(dev, r);
-	if (IS_ERR(core->dos_base)) {
-		dev_err(dev, "Couldn't remap DOS memory\n");
+	if (IS_ERR(core->dos_base))
 		return PTR_ERR(core->dos_base);
-	}
 
 	r = platform_get_resource_byname(pdev, IORESOURCE_MEM, "esparser");
 	core->esparser_base = devm_ioremap_resource(dev, r);
-	if (IS_ERR(core->esparser_base)) {
-		dev_err(dev, "Couldn't remap ESPARSER memory\n");
+	if (IS_ERR(core->esparser_base))
 		return PTR_ERR(core->esparser_base);
-	}
 
 	core->regmap_ao =
 		syscon_regmap_lookup_by_phandle(dev->of_node,
Signature · 1 line
2.25.1
#1 lore raw

Hi Muhammad,

Quoted 2 lines · Muhammad Usama Anjum

devm_ioremap_resource() prints error message in itself. Remove the dev_err call to avoid redundant error message.

Please split this up into two separate patches! They are independent changes and these two drivers are maintained by different people as well.

The patch itself looks OK, but it really has to be two separate patches.

Regards,

Hans

Quoted 44 lines
Signed-off-by Muhammad Usama Anjum <[email protected]>
---
 drivers/staging/axis-fifo/axis-fifo.c   | 1 -
 drivers/staging/media/meson/vdec/vdec.c | 8 ++------
 2 files changed, 2 insertions(+), 7 deletions(-)
drivers/staging/axis-fifo/axis-fifo.c +0 -1
index 2bb1c2e9cb57..ed9281089738 100644
@@ -853,7 +853,6 @@ static int axis_fifo_probe(struct platform_device *pdev)
 	fifo->base_addr = devm_ioremap_resource(fifo->dt_device, r_mem);
 	if (IS_ERR(fifo->base_addr)) {
 		rc = PTR_ERR(fifo->base_addr);
-		dev_err(fifo->dt_device, "can't remap IO resource (%d)\n", rc);
 		goto err_initial;
 	}
drivers/staging/media/meson/vdec/vdec.c +2 -6
index 5d4db7a5b4b5..e51d69c4729d 100644
@@ -1008,17 +1008,13 @@ static int vdec_probe(struct platform_device *pdev)
 
 	r = platform_get_resource_byname(pdev, IORESOURCE_MEM, "dos");
 	core->dos_base = devm_ioremap_resource(dev, r);
-	if (IS_ERR(core->dos_base)) {
-		dev_err(dev, "Couldn't remap DOS memory\n");
+	if (IS_ERR(core->dos_base))
 		return PTR_ERR(core->dos_base);
-	}
 
 	r = platform_get_resource_byname(pdev, IORESOURCE_MEM, "esparser");
 	core->esparser_base = devm_ioremap_resource(dev, r);
-	if (IS_ERR(core->esparser_base)) {
-		dev_err(dev, "Couldn't remap ESPARSER memory\n");
+	if (IS_ERR(core->esparser_base))
 		return PTR_ERR(core->esparser_base);
-	}
 
 	core->regmap_ao =
 		syscon_regmap_lookup_by_phandle(dev->of_node,
author
#2 lore raw
Quoted 11 lines · Hans Verkuil

Hi Muhammad,

Quoted 2 lines · Muhammad Usama Anjum

devm_ioremap_resource() prints error message in itself. Remove the dev_err call to avoid redundant error message.

Please split this up into two separate patches! They are independent changes and these two drivers are maintained by different people as well.

The patch itself looks OK, but it really has to be two separate patches.

Okay. I'll send two separate patches. Thank you.

Regards,
Usama

Quoted 47 lines

Regards,

Hans

Quoted 43 lines
Signed-off-by Muhammad Usama Anjum <[email protected]>
---
 drivers/staging/axis-fifo/axis-fifo.c   | 1 -
 drivers/staging/media/meson/vdec/vdec.c | 8 ++------
 2 files changed, 2 insertions(+), 7 deletions(-)
drivers/staging/axis-fifo/axis-fifo.c +0 -1
index 2bb1c2e9cb57..ed9281089738 100644
@@ -853,7 +853,6 @@ static int axis_fifo_probe(struct platform_device *pdev)
 	fifo->base_addr = devm_ioremap_resource(fifo->dt_device, r_mem);
 	if (IS_ERR(fifo->base_addr)) {
 		rc = PTR_ERR(fifo->base_addr);
-		dev_err(fifo->dt_device, "can't remap IO resource (%d)\n", rc);
 		goto err_initial;
 	}
drivers/staging/media/meson/vdec/vdec.c +2 -6
index 5d4db7a5b4b5..e51d69c4729d 100644
@@ -1008,17 +1008,13 @@ static int vdec_probe(struct platform_device *pdev)
 
 	r = platform_get_resource_byname(pdev, IORESOURCE_MEM, "dos");
 	core->dos_base = devm_ioremap_resource(dev, r);
-	if (IS_ERR(core->dos_base)) {
-		dev_err(dev, "Couldn't remap DOS memory\n");
+	if (IS_ERR(core->dos_base))
 		return PTR_ERR(core->dos_base);
-	}
 
 	r = platform_get_resource_byname(pdev, IORESOURCE_MEM, "esparser");
 	core->esparser_base = devm_ioremap_resource(dev, r);
-	if (IS_ERR(core->esparser_base)) {
-		dev_err(dev, "Couldn't remap ESPARSER memory\n");
+	if (IS_ERR(core->esparser_base))
 		return PTR_ERR(core->esparser_base);
-	}
 
 	core->regmap_ao =
 		syscon_regmap_lookup_by_phandle(dev->of_node,