Skip to contentSkip to conversation

MIPS: select ARCH_KEEP_MEMBLOCK unconditionally

PATCH Guenter Roeck 1 participant 1 message Apr 7, 2021

Subsystems (2)
lore
Share & tools
lore

Guenter Roeck

author Tested-by
#0 lore raw
Quoted 13 lines · Nick Desaulniers

While removing allnoconfig_y from Kconfig, ARCH=mips allnoconfig builds started failing with the error:

WARNING: modpost: vmlinux.o(.text+0x9c70): Section mismatch in reference from the function reserve_exception_space() to the function .meminit.text:memblock_reserve()
The function reserve_exception_space() references the function __meminit memblock_reserve().
This is often because reserve_exception_space lacks a __meminit annotation or the annotation of memblock_reserve is wrong.
ERROR: modpost: Section mismatches detected.
Set CONFIG_SECTION_MISMATCH_WARN_ONLY=y to allow them.

Quoted 6 lines

allnoconfig disables DEBUG_KERNEL and thus ARCH_KEEP_MEMBLOCK, which changes __init_memblock to be equivalent to __meminit triggering the above error.

Fixes commit a8c0f1c634507 ("MIPS: Select ARCH_KEEP_MEMBLOCK if

s/commit //

Quoted 4 lines

DEBUG_KERNEL to enable sysfs memblock debug")

Guenter

Quoted 20 lines
---
 arch/mips/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/mips/Kconfig +1 -1
index e9893cd34992..702648f60e41 100644
@@ -12,7 +12,7 @@ config MIPS
 	select ARCH_HAS_TICK_BROADCAST if GENERIC_CLOCKEVENTS_BROADCAST
 	select ARCH_HAS_UBSAN_SANITIZE_ALL
 	select ARCH_HAS_GCOV_PROFILE_ALL
-	select ARCH_KEEP_MEMBLOCK if DEBUG_KERNEL
+	select ARCH_KEEP_MEMBLOCK
 	select ARCH_SUPPORTS_UPROBES
 	select ARCH_USE_BUILTIN_BSWAP
 	select ARCH_USE_CMPXCHG_LOCKREF if 64BIT
Signature · 1 line
2.31.1.295.g9ea45b61b8-goog