Skip to contentSkip to conversation

ASoC: meson: axg-frddr: fix fifo depth on g12 and sm1

PATCH In review Jerome Brunet 2 participants 2 messages Apr 12, 2021 – Apr 13, 2021

Subsystems (4)
lore
Share & tools
lore

Jerome Brunet

author maintainer
#0 lore raw

PATCH 1/1 ASoC: meson: axg-frddr: fix fifo depth on g12 and sm1

Previous fifo depth patch was only tested on axg, not g12 or sm1. Of course, while adding hw_params dai callback for the axg, I forgot to do the same for g12 and sm1, leaving the depth unset and breaking playback on these SoCs.

Add hw_params callback to the g12 dai_ops to fix the problem.

Fixes 6f68accaa864 ("ASoC: meson: axg-frddr: set fifo depth according to the period")
---
 sound/soc/meson/axg-frddr.c | 1 +
 1 file changed, 1 insertion(+)
sound/soc/meson/axg-frddr.c +1 -0
index 8ed114de0bdf..37f4bb3469b5 100644
@@ -171,6 +171,7 @@ static const struct axg_fifo_match_data axg_frddr_match_data = {
 
 static const struct snd_soc_dai_ops g12a_frddr_ops = {
 	.prepare	= g12a_frddr_dai_prepare,
+	.hw_params	= axg_frddr_dai_hw_params,
 	.startup	= axg_frddr_dai_startup,
 	.shutdown	= axg_frddr_dai_shutdown,
 };
Signature · 1 line
2.30.2
maintainer
#1 lore raw
Quoted 6 lines · Jerome Brunet

Previous fifo depth patch was only tested on axg, not g12 or sm1. Of course, while adding hw_params dai callback for the axg, I forgot to do the same for g12 and sm1, leaving the depth unset and breaking playback on these SoCs.

Add hw_params callback to the g12 dai_ops to fix the problem.

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: meson: axg-frddr: fix fifo depth on g12 and sm1

      commit: 858066864a6383d1eecd2fa96a0b8e69935632f8

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark