Skip to contentSkip to conversation

Remove spaces and blank lines

PATCH In review Fabio M. De Francesco 2 participants 4 messages Apr 12, 2021 – Apr 13, 2021 Staging

lore
Share & tools
lore
#0 lore raw

cover Remove spaces and blank lines

Removed spaces before tabs and multiple blank lines from Hal8723BReg.h for readability improvement. Issues detected by checkpatch.pl.

Fabio M. De Francesco (2):
staging: rtl8723bs: hal Remove spaces before tabs
staging: rtl8723bs: hal: Remove multiple blank lines

 drivers/staging/rtl8723bs/hal/Hal8723BReg.h | 43 +++++++++------------
 1 file changed, 18 insertions(+), 25 deletions(-)
Signature · 1 line
2.31.1
#1 lore raw

PATCH 1/2 staging: rtl8723bs: hal: Remove spaces before tabs

Removed spaces before tabs. Issue detected by checkpatch.pl.

---
 drivers/staging/rtl8723bs/hal/Hal8723BReg.h | 36 ++++++++++-----------
 1 file changed, 18 insertions(+), 18 deletions(-)
drivers/staging/rtl8723bs/hal/Hal8723BReg.h +18 -18
index 616d20106392..1ff2043fb2e2 100644
@@ -27,7 +27,7 @@
 
 /*  */
 /*  */
-/* 	0x0000h ~ 0x00FFh	System Configuration */
+/*	0x0000h ~ 0x00FFh	System Configuration */
 /*  */
 /*  */
 #define REG_SYS_ISO_CTRL_8723B			0x0000	/*  2 Byte */
@@ -84,7 +84,7 @@
 
 /*  */
 /*  */
-/* 	0x0100h ~ 0x01FFh	MACTOP General Configuration */
+/*	0x0100h ~ 0x01FFh	MACTOP General Configuration */
 /*  */
 /*  */
 #define REG_CR_8723B						0x0100
@@ -131,7 +131,7 @@
 
 /*  */
 /*  */
-/* 	0x0200h ~ 0x027Fh	TXDMA Configuration */
+/*	0x0200h ~ 0x027Fh	TXDMA Configuration */
 /*  */
 /*  */
 #define REG_RQPN_8723B					0x0200
@@ -145,7 +145,7 @@
 
 /*  */
 /*  */
-/* 	0x0280h ~ 0x02FFh	RXDMA Configuration */
+/*	0x0280h ~ 0x02FFh	RXDMA Configuration */
 /*  */
 /*  */
 #define REG_RXDMA_AGG_PG_TH_8723B		0x0280
@@ -161,7 +161,7 @@
 
 /*  */
 /*  */
-/* 	0x0300h ~ 0x03FFh	PCIe */
+/*	0x0300h ~ 0x03FFh	PCIe */
 /*  */
 /*  */
 #define	REG_PCIE_CTRL_REG_8723B		0x0300
@@ -189,7 +189,7 @@
 /*  spec version 11 */
 /*  */
 /*  */
-/* 	0x0400h ~ 0x047Fh	Protocol Configuration */
+/*	0x0400h ~ 0x047Fh	Protocol Configuration */
 /*  */
 /*  */
 #define REG_VOQ_INFORMATION_8723B		0x0400
@@ -243,7 +243,7 @@
 
 /*  */
 /*  */
-/* 	0x0500h ~ 0x05FFh	EDCA Configuration */
+/*	0x0500h ~ 0x05FFh	EDCA Configuration */
 /*  */
 /*  */
 #define REG_EDCA_VO_PARAM_8723B		0x0500
@@ -263,15 +263,15 @@
 #define REG_RD_CTRL_8723B				0x0524
 /*  */
 /*  Format for offset 540h-542h: */
-/* 	[3:0]:   TBTT prohibit setup in unit of 32us. The time for HW getting beacon content before TBTT. */
-/* 	[7:4]:   Reserved. */
-/* 	[19:8]:  TBTT prohibit hold in unit of 32us. The time for HW holding to send the beacon packet. */
-/* 	[23:20]: Reserved */
+/*	[3:0]:   TBTT prohibit setup in unit of 32us. The time for HW getting beacon content before TBTT. */
+/*	[7:4]:   Reserved. */
+/*	[19:8]:  TBTT prohibit hold in unit of 32us. The time for HW holding to send the beacon packet. */
+/*	[23:20]: Reserved */
 /*  Description: */
-/* 	              | */
+/*			| */
 /*      |<--Setup--|--Hold------------>| */
-/* 	--------------|---------------------- */
-/*                 | */
+/*	--------------|---------------------- */
+/*			| */
 /*                TBTT */
 /*  Note: We cannot update beacon content to HW or send any AC packets during the time between Setup and Hold. */
 /*  Described by Designer Tim and Bruce, 2011-01-14. */
@@ -300,7 +300,7 @@
 #define REG_ACMHWCTRL_8723B		0x05C0
 #define REG_SCH_TXCMD_8723B		0x05F8
 
-/* 	0x0600h ~ 0x07FFh	WMAC Configuration */
+/*	0x0600h ~ 0x07FFh	WMAC Configuration */
 #define REG_MAC_CR_8723B		0x0600
 #define REG_TCR_8723B			0x0604
 #define REG_RCR_8723B			0x0608
@@ -356,10 +356,10 @@
 #define REG_SND_PTCL_CTRL_8723B		0x0718
 
 
-/* 	Redifine 8192C register definition for compatibility */
+/*	Redifine 8192C register definition for compatibility */
 
-/*  TODO: use these definition when using REG_xxx naming rule. */
-/*  NOTE: DO NOT Remove these definition. Use later. */
+/*	TODO: use these definition when using REG_xxx naming rule. */
+/*	NOTE: DO NOT Remove these definition. Use later. */
 #define	EFUSE_CTRL_8723B	REG_EFUSE_CTRL_8723B	/*  E-Fuse Control. */
 #define	EFUSE_TEST_8723B	REG_EFUSE_TEST_8723B	/*  E-Fuse Test. */
 #define	MSR_8723B		(REG_CR_8723B + 2)	/*  Media Status register */
Signature · 1 line
2.31.1
#2 lore raw

PATCH 2/2 staging: rtl8723bs: hal: Remove multiple blank lines

In reply to Fabio M. De Francesco

Removed unnecessary multiple blank lines. Issue detected by checkpatch.pl.

---
 drivers/staging/rtl8723bs/hal/Hal8723BReg.h | 7 -------
 1 file changed, 7 deletions(-)
drivers/staging/rtl8723bs/hal/Hal8723BReg.h +0 -7
index 1ff2043fb2e2..4a91913e20bf 100644
@@ -19,12 +19,9 @@
 #ifndef __INC_HAL8723BREG_H
 #define __INC_HAL8723BREG_H
 
-
-
 /*  */
 /*  */
 /*  */
-
 /*  */
 /*  */
 /*	0x0000h ~ 0x00FFh	System Configuration */
@@ -142,7 +139,6 @@
 #define REG_RQPN_NPQ_8723B			0x0214
 #define REG_DWBCN1_CTRL_8723B			0x0228
 
-
 /*  */
 /*  */
 /*	0x0280h ~ 0x02FFh	RXDMA Configuration */
@@ -158,7 +154,6 @@
 #define REG_RSVD5_8723B					0x02F0
 #define REG_RSVD6_8723B					0x02F4
 
-
 /*  */
 /*  */
 /*	0x0300h ~ 0x03FFh	PCIe */
@@ -355,7 +350,6 @@
 #define REG_BFMEE_SEL_8723B		0x0714
 #define REG_SND_PTCL_CTRL_8723B		0x0718
 
-
 /*	Redifine 8192C register definition for compatibility */
 
 /*	TODO: use these definition when using REG_xxx naming rule. */
@@ -365,7 +359,6 @@
 #define	MSR_8723B		(REG_CR_8723B + 2)	/*  Media Status register */
 #define	ISR_8723B		REG_HISR0_8723B
 #define	TSFR_8723B		REG_TSFTR_8723B		/*  Timing Sync Function Timer Register. */
-
 #define PBP_8723B		REG_PBP_8723B
 
 /*  Redifine MACID register, to compatible prior ICs. */
Signature · 1 line
2.31.1
#3 lore raw
In reply to Fabio M. De Francesco
Quoted 9 lines · Fabio M. De Francesco

Removed spaces before tabs and multiple blank lines from Hal8723BReg.h for readability improvement. Issues detected by checkpatch.pl.

Fabio M. De Francesco (2):
staging: rtl8723bs: hal Remove spaces before tabs
staging: rtl8723bs: hal: Remove multiple blank lines

 drivers/staging/rtl8723bs/hal/Hal8723BReg.h | 43 +++++++++------------
 1 file changed, 18 insertions(+), 25 deletions(-)

This series does not apply to my tree, please rebase and resend.

thanks,

greg k-h