Replace macro function by static inline function in file iss.c
Subsystems (2)
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH 1/4 Replace macro function by static inline function in file iss.c
Replace macro function by static inline function.
Issue suggested by Julia.
--- drivers/staging/media/omap4iss/iss.c | 24 +++++++++++++----------- 1 file changed, 13 insertions(+), 11 deletions(-)
drivers/staging/media/omap4iss/iss.c +13 -11
@@ -27,22 +27,24 @@#include "iss.h" #include "iss_regs.h" -#define ISS_PRINT_REGISTER (iss, name)\ - dev_dbg(iss->dev, "###ISS " #name "=0x%08x\n", \ - iss_reg_read(iss, OMAP4_ISS_MEM_TOP, ISS_##name)) +static inline iss_print_register(iss, name) +{ + dev_dbg(iss->dev, "###ISS " #name "=0x%08x\n", + iss_reg_read(iss, OMAP4_ISS_MEM_TOP, ISS_##name)); +}static void iss_print_status (struct iss_device *iss) {dev_dbg (iss->dev,"-------------ISS HL Register dump-------------\n" ); -ISS_PRINT_REGISTER (iss,HL_REVISION ); -ISS_PRINT_REGISTER (iss,HL_SYSCONFIG ); -ISS_PRINT_REGISTER (iss,HL_IRQSTATUS (5 )); -ISS_PRINT_REGISTER (iss,HL_IRQENABLE_SET (5 )); -ISS_PRINT_REGISTER (iss,HL_IRQENABLE_CLR (5 )); -ISS_PRINT_REGISTER (iss,CTRL ); -ISS_PRINT_REGISTER (iss,CLKCTRL ); -ISS_PRINT_REGISTER (iss,CLKSTAT ); +iss_print_register (iss,HL_REVISION ); +iss_print_register (iss,HL_SYSCONFIG ); +iss_print_register (iss,HL_IRQSTATUS (5 )); +iss_print_register (iss,HL_IRQENABLE_SET (5 )); +iss_print_register (iss,HL_IRQENABLE_CLR (5 )); +iss_print_register (iss,CTRL ); +iss_print_register (iss,CLKCTRL ); +iss_print_register (iss,CLKSTAT );dev_dbg (iss->dev,"-----------------------------------------------\n" ); }
Signature · 1 line
2.7.4
kernel test robot
build botThank you for the patch! Perhaps something to improve:
Hi Aline,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linuxtv-media/master]
[also build test WARNING on v5.12-rc7 next-20210412]
[If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Aline-Santana-Cordeiro/Replace-macro-function-by-static-inline-function-in-file-iss-c/20210412-213252 base: git://linuxtv.org/media_tree.git master config: arc-allyesconfig (attached as .config) compiler: arceb-elf-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/31032f2aa94de36a70de87f425eac62a2000367d
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Aline-Santana-Cordeiro/Replace-macro-function-by-static-inline-function-in-file-iss-c/20210412-213252 git checkout 31032f2aa94de36a70de87f425eac62a2000367d
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arc
If you fix the issue, kindly add following tag as appropriate
All warnings (new ones prefixed by >>):
drivers/staging/media/omap4iss/iss.c:30:15: error: return type defaults to 'int' [-Werror=return-type]
30 | static inline iss_print_register(iss, name)
| ^~~~~~~~~~~~~~~~~~
drivers/staging/media/omap4iss/iss.c:30:15: error: function declaration isn't a prototype [-Werror=strict-prototypes] drivers/staging/media/omap4iss/iss.c: In function 'iss_print_register':
>> drivers/staging/media/omap4iss/iss.c:30:15: warning: old-style function definition [-Wold-style-definition]
>> drivers/staging/media/omap4iss/iss.c:30:15: warning: type of 'iss' defaults to 'int' [-Wmissing-parameter-type]
>> drivers/staging/media/omap4iss/iss.c:30:15: warning: type of 'name' defaults to 'int' [-Wmissing-parameter-type]
In file included from include/linux/printk.h:409,
from include/linux/kernel.h:16,
from include/linux/clk.h:13,
from drivers/staging/media/omap4iss/iss.c:10:
drivers/staging/media/omap4iss/iss.c:32:30: error: stray '#' in program
32 | dev_dbg(iss->dev, "###ISS " #name "=0x%08x\n",
| ^
include/linux/dynamic_debug.h:91:14: note: in definition of macro 'DEFINE_DYNAMIC_DEBUG_METADATA'
91 | .format = (fmt), \
| ^~~
include/linux/dynamic_debug.h:147:2: note: in expansion of macro '__dynamic_func_call'
147 | __dynamic_func_call(__UNIQUE_ID(ddebug), fmt, func, ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~~~~~
include/linux/dynamic_debug.h:161:2: note: in expansion of macro '_dynamic_func_call'
161 | _dynamic_func_call(fmt,__dynamic_dev_dbg, \
| ^~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:123:2: note: in expansion of macro 'dynamic_dev_dbg'
123 | dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~
include/linux/dev_printk.h:123:23: note: in expansion of macro 'dev_fmt'
123 | dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~
drivers/staging/media/omap4iss/iss.c:32:2: note: in expansion of macro 'dev_dbg'
32 | dev_dbg(iss->dev, "###ISS " #name "=0x%08x\n",
| ^~~~~~~
drivers/staging/media/omap4iss/iss.c:32:31: error: expected ')' before 'name'
32 | dev_dbg(iss->dev, "###ISS " #name "=0x%08x\n",
| ^~~~
include/linux/dynamic_debug.h:91:14: note: in definition of macro 'DEFINE_DYNAMIC_DEBUG_METADATA'
91 | .format = (fmt), \
| ^~~
include/linux/dynamic_debug.h:147:2: note: in expansion of macro '__dynamic_func_call'
147 | __dynamic_func_call(__UNIQUE_ID(ddebug), fmt, func, ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~~~~~
include/linux/dynamic_debug.h:161:2: note: in expansion of macro '_dynamic_func_call'
161 | _dynamic_func_call(fmt,__dynamic_dev_dbg, \
| ^~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:123:2: note: in expansion of macro 'dynamic_dev_dbg'
123 | dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~
include/linux/dev_printk.h:123:23: note: in expansion of macro 'dev_fmt'
123 | dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~
drivers/staging/media/omap4iss/iss.c:32:2: note: in expansion of macro 'dev_dbg'
32 | dev_dbg(iss->dev, "###ISS " #name "=0x%08x\n",
| ^~~~~~~
include/linux/dynamic_debug.h:91:13: note: to match this '('
91 | .format = (fmt), \
| ^
include/linux/dynamic_debug.h:127:2: note: in expansion of macro 'DEFINE_DYNAMIC_DEBUG_METADATA'
127 | DEFINE_DYNAMIC_DEBUG_METADATA(id, fmt); \
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dynamic_debug.h:147:2: note: in expansion of macro '__dynamic_func_call'
147 | __dynamic_func_call(__UNIQUE_ID(ddebug), fmt, func, ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~~~~~
include/linux/dynamic_debug.h:161:2: note: in expansion of macro '_dynamic_func_call'
161 | _dynamic_func_call(fmt,__dynamic_dev_dbg, \
| ^~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:123:2: note: in expansion of macro 'dynamic_dev_dbg'
123 | dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~
drivers/staging/media/omap4iss/iss.c:32:2: note: in expansion of macro 'dev_dbg'
32 | dev_dbg(iss->dev, "###ISS " #name "=0x%08x\n",
| ^~~~~~~
drivers/staging/media/omap4iss/iss.c:32:13: error: invalid type argument of '->' (have 'int')
32 | dev_dbg(iss->dev, "###ISS " #name "=0x%08x\n",
| ^~
include/linux/dynamic_debug.h:129:15: note: in definition of macro '__dynamic_func_call'
129 | func(&id, ##__VA_ARGS__); \
| ^~~~~~~~~~~
include/linux/dynamic_debug.h:161:2: note: in expansion of macro '_dynamic_func_call'
161 | _dynamic_func_call(fmt,__dynamic_dev_dbg, \
| ^~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:123:2: note: in expansion of macro 'dynamic_dev_dbg'
123 | dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~
drivers/staging/media/omap4iss/iss.c:32:2: note: in expansion of macro 'dev_dbg'
32 | dev_dbg(iss->dev, "###ISS " #name "=0x%08x\n",
| ^~~~~~~
drivers/staging/media/omap4iss/iss.c:32:30: error: stray '#' in program
32 | dev_dbg(iss->dev, "###ISS " #name "=0x%08x\n",
| ^
include/linux/dynamic_debug.h:129:15: note: in definition of macro '__dynamic_func_call'
129 | func(&id, ##__VA_ARGS__); \
| ^~~~~~~~~~~
include/linux/dynamic_debug.h:161:2: note: in expansion of macro '_dynamic_func_call'
161 | _dynamic_func_call(fmt,__dynamic_dev_dbg, \
| ^~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:123:2: note: in expansion of macro 'dynamic_dev_dbg'
123 | dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~
include/linux/dev_printk.h:123:23: note: in expansion of macro 'dev_fmt'
123 | dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~
drivers/staging/media/omap4iss/iss.c:32:2: note: in expansion of macro 'dev_dbg'
32 | dev_dbg(iss->dev, "###ISS " #name "=0x%08x\n",
| ^~~~~~~
drivers/staging/media/omap4iss/iss.c:32:31: error: expected ')' before 'name'
32 | dev_dbg(iss->dev, "###ISS " #name "=0x%08x\n",
| ^~~~vim +30 drivers/staging/media/omap4iss/iss.c
29
> 30 static inline iss_print_register(iss, name)
31 {
32 dev_dbg(iss->dev, "###ISS " #name "=0x%08x\n",
33 iss_reg_read(iss, OMAP4_ISS_MEM_TOP, ISS_##name));
34 }
35 ---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
PATCH 2/4 Replace macro function by static inline function in file iss_ipipe.c
In reply to a message not in the archiveReplace macro function by static inline function.
Issue suggested by Julia.
--- drivers/staging/media/omap4iss/iss_ipipe.c | 28 +++++++++++++++------------- 1 file changed, 15 insertions(+), 13 deletions(-)
drivers/staging/media/omap4iss/iss_ipipe.c +15 -13
@@ -38,9 +38,11 @@ static const unsigned int ipipe_fmts[] = {* * Also prints other debug information stored in the IPIPE module. */ -#define IPIPE_PRINT_REGISTER (iss, name)\ - dev_dbg(iss->dev, "###IPIPE " #name "=0x%08x\n", \ - iss_reg_read(iss, OMAP4_ISS_MEM_ISP_IPIPE, IPIPE_##name)) +static inline ipipe_print_register(iss, name) +{ + dev_dbg(iss->dev, "###IPIPE " #name "=0x%08x\n", + iss_reg_read(iss, OMAP4_ISS_MEM_ISP_IPIPE, IPIPE_##name)); +}static void ipipe_print_status (struct iss_ipipe_device *ipipe) {
@@ -48,16 +50,16 @@ static void ipipe_print_status(struct iss_ipipe_device *ipipe)dev_dbg (iss->dev,"-------------IPIPE Register dump-------------\n" ); -IPIPE_PRINT_REGISTER (iss,SRC_EN ); -IPIPE_PRINT_REGISTER (iss,SRC_MODE ); -IPIPE_PRINT_REGISTER (iss,SRC_FMT ); -IPIPE_PRINT_REGISTER (iss,SRC_COL ); -IPIPE_PRINT_REGISTER (iss,SRC_VPS ); -IPIPE_PRINT_REGISTER (iss,SRC_VSZ ); -IPIPE_PRINT_REGISTER (iss,SRC_HPS ); -IPIPE_PRINT_REGISTER (iss,SRC_HSZ ); -IPIPE_PRINT_REGISTER (iss,GCK_MMR ); -IPIPE_PRINT_REGISTER (iss,YUV_PHS ); +ipipe_print_register (iss,SRC_EN ); +ipipe_print_register (iss,SRC_MODE ); +ipipe_print_register (iss,SRC_FMT ); +ipipe_print_register (iss,SRC_COL ); +ipipe_print_register (iss,SRC_VPS ); +ipipe_print_register (iss,SRC_VSZ ); +ipipe_print_register (iss,SRC_HPS ); +ipipe_print_register (iss,SRC_HSZ ); +ipipe_print_register (iss,GCK_MMR ); +ipipe_print_register (iss,YUV_PHS );dev_dbg (iss->dev,"-----------------------------------------------\n" ); }
Signature · 1 line
2.7.4
kernel test robot
build botRe: [Outreachy kernel][PATCH 2/4] Replace macro function by static inline function in file iss_ipipe.c
Thank you for the patch! Perhaps something to improve:
Hi Aline,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linuxtv-media/master]
[also build test WARNING on v5.12-rc7 next-20210412]
[If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Aline-Santana-Cordeiro/Replace-macro-function-by-static-inline-function-in-file-iss-c/20210412-213252 base: git://linuxtv.org/media_tree.git master config: arc-allyesconfig (attached as .config) compiler: arceb-elf-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/be8ef400d02afa928839bd6264ba2100ac02986d
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Aline-Santana-Cordeiro/Replace-macro-function-by-static-inline-function-in-file-iss-c/20210412-213252 git checkout be8ef400d02afa928839bd6264ba2100ac02986d
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arc
If you fix the issue, kindly add following tag as appropriate
All warnings (new ones prefixed by >>):
drivers/staging/media/omap4iss/iss_ipipe.c:41:15: error: return type defaults to 'int' [-Werror=return-type]
41 | static inline ipipe_print_register(iss, name)
| ^~~~~~~~~~~~~~~~~~~~
drivers/staging/media/omap4iss/iss_ipipe.c:41:15: error: function declaration isn't a prototype [-Werror=strict-prototypes] drivers/staging/media/omap4iss/iss_ipipe.c: In function 'ipipe_print_register':
>> drivers/staging/media/omap4iss/iss_ipipe.c:41:15: warning: old-style function definition [-Wold-style-definition]
>> drivers/staging/media/omap4iss/iss_ipipe.c:41:15: warning: type of 'iss' defaults to 'int' [-Wmissing-parameter-type]
>> drivers/staging/media/omap4iss/iss_ipipe.c:41:15: warning: type of 'name' defaults to 'int' [-Wmissing-parameter-type]
In file included from include/linux/printk.h:409,
from include/linux/kernel.h:16,
from include/linux/list.h:9,
from include/linux/module.h:12,
from drivers/staging/media/omap4iss/iss_ipipe.c:10:
drivers/staging/media/omap4iss/iss_ipipe.c:43:32: error: stray '#' in program
43 | dev_dbg(iss->dev, "###IPIPE " #name "=0x%08x\n",
| ^
include/linux/dynamic_debug.h:91:14: note: in definition of macro 'DEFINE_DYNAMIC_DEBUG_METADATA'
91 | .format = (fmt), \
| ^~~
include/linux/dynamic_debug.h:147:2: note: in expansion of macro '__dynamic_func_call'
147 | __dynamic_func_call(__UNIQUE_ID(ddebug), fmt, func, ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~~~~~
include/linux/dynamic_debug.h:161:2: note: in expansion of macro '_dynamic_func_call'
161 | _dynamic_func_call(fmt,__dynamic_dev_dbg, \
| ^~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:123:2: note: in expansion of macro 'dynamic_dev_dbg'
123 | dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~
include/linux/dev_printk.h:123:23: note: in expansion of macro 'dev_fmt'
123 | dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~
drivers/staging/media/omap4iss/iss_ipipe.c:43:2: note: in expansion of macro 'dev_dbg'
43 | dev_dbg(iss->dev, "###IPIPE " #name "=0x%08x\n",
| ^~~~~~~
drivers/staging/media/omap4iss/iss_ipipe.c:43:33: error: expected ')' before 'name'
43 | dev_dbg(iss->dev, "###IPIPE " #name "=0x%08x\n",
| ^~~~
include/linux/dynamic_debug.h:91:14: note: in definition of macro 'DEFINE_DYNAMIC_DEBUG_METADATA'
91 | .format = (fmt), \
| ^~~
include/linux/dynamic_debug.h:147:2: note: in expansion of macro '__dynamic_func_call'
147 | __dynamic_func_call(__UNIQUE_ID(ddebug), fmt, func, ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~~~~~
include/linux/dynamic_debug.h:161:2: note: in expansion of macro '_dynamic_func_call'
161 | _dynamic_func_call(fmt,__dynamic_dev_dbg, \
| ^~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:123:2: note: in expansion of macro 'dynamic_dev_dbg'
123 | dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~
include/linux/dev_printk.h:123:23: note: in expansion of macro 'dev_fmt'
123 | dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~
drivers/staging/media/omap4iss/iss_ipipe.c:43:2: note: in expansion of macro 'dev_dbg'
43 | dev_dbg(iss->dev, "###IPIPE " #name "=0x%08x\n",
| ^~~~~~~
include/linux/dynamic_debug.h:91:13: note: to match this '('
91 | .format = (fmt), \
| ^
include/linux/dynamic_debug.h:127:2: note: in expansion of macro 'DEFINE_DYNAMIC_DEBUG_METADATA'
127 | DEFINE_DYNAMIC_DEBUG_METADATA(id, fmt); \
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dynamic_debug.h:147:2: note: in expansion of macro '__dynamic_func_call'
147 | __dynamic_func_call(__UNIQUE_ID(ddebug), fmt, func, ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~~~~~
include/linux/dynamic_debug.h:161:2: note: in expansion of macro '_dynamic_func_call'
161 | _dynamic_func_call(fmt,__dynamic_dev_dbg, \
| ^~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:123:2: note: in expansion of macro 'dynamic_dev_dbg'
123 | dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~
drivers/staging/media/omap4iss/iss_ipipe.c:43:2: note: in expansion of macro 'dev_dbg'
43 | dev_dbg(iss->dev, "###IPIPE " #name "=0x%08x\n",
| ^~~~~~~
drivers/staging/media/omap4iss/iss_ipipe.c:43:13: error: invalid type argument of '->' (have 'int')
43 | dev_dbg(iss->dev, "###IPIPE " #name "=0x%08x\n",
| ^~
include/linux/dynamic_debug.h:129:15: note: in definition of macro '__dynamic_func_call'
129 | func(&id, ##__VA_ARGS__); \
| ^~~~~~~~~~~
include/linux/dynamic_debug.h:161:2: note: in expansion of macro '_dynamic_func_call'
161 | _dynamic_func_call(fmt,__dynamic_dev_dbg, \
| ^~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:123:2: note: in expansion of macro 'dynamic_dev_dbg'
123 | dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~
drivers/staging/media/omap4iss/iss_ipipe.c:43:2: note: in expansion of macro 'dev_dbg'
43 | dev_dbg(iss->dev, "###IPIPE " #name "=0x%08x\n",
| ^~~~~~~
drivers/staging/media/omap4iss/iss_ipipe.c:43:32: error: stray '#' in program
43 | dev_dbg(iss->dev, "###IPIPE " #name "=0x%08x\n",
| ^
include/linux/dynamic_debug.h:129:15: note: in definition of macro '__dynamic_func_call'
129 | func(&id, ##__VA_ARGS__); \
| ^~~~~~~~~~~
include/linux/dynamic_debug.h:161:2: note: in expansion of macro '_dynamic_func_call'
161 | _dynamic_func_call(fmt,__dynamic_dev_dbg, \
| ^~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:123:2: note: in expansion of macro 'dynamic_dev_dbg'
123 | dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~
include/linux/dev_printk.h:123:23: note: in expansion of macro 'dev_fmt'
123 | dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~
drivers/staging/media/omap4iss/iss_ipipe.c:43:2: note: in expansion of macro 'dev_dbg'
43 | dev_dbg(iss->dev, "###IPIPE " #name "=0x%08x\n",
| ^~~~~~~
drivers/staging/media/omap4iss/iss_ipipe.c:43:33: error: expected ')' before 'name'
43 | dev_dbg(iss->dev, "###IPIPE " #name "=0x%08x\n",vim +41 drivers/staging/media/omap4iss/iss_ipipe.c
34
35 /*
36 * ipipe_print_status - Print current IPIPE Module register values.
37 * @ipipe: Pointer to ISS ISP IPIPE device.
38 *
39 * Also prints other debug information stored in the IPIPE module.
40 */
> 41 static inline ipipe_print_register(iss, name)
42 {
43 dev_dbg(iss->dev, "###IPIPE " #name "=0x%08x\n",
44 iss_reg_read(iss, OMAP4_ISS_MEM_ISP_IPIPE, IPIPE_##name));
45 }
46 ---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
PATCH 3/4 Replace macro function by static inline function in file iss_ipipeif.c
In reply to a message not in the archiveReplace macro function by static inline function.
Issue suggested by Julia.
--- drivers/staging/media/omap4iss/iss_ipipeif.c | 62 +++++++++++++++------------- 1 file changed, 34 insertions(+), 28 deletions(-)
drivers/staging/media/omap4iss/iss_ipipeif.c +34 -28
@@ -34,17 +34,23 @@ static const unsigned int ipipeif_fmts[] = {* * Also prints other debug information stored in the IPIPEIF module. */ -#define IPIPEIF_PRINT_REGISTER (iss, name)\ - dev_dbg(iss->dev, "###IPIPEIF " #name "=0x%08x\n", \ - iss_reg_read(iss, OMAP4_ISS_MEM_ISP_IPIPEIF, IPIPEIF_##name)) +static inline ipipeif_print_register(iss, name) +{ + dev_dbg(iss->dev, "###IPIPEIF " #name "=0x%08x\n", + iss_reg_read(iss, OMAP4_ISS_MEM_ISP_IPIPEIF, IPIPEIF_##name)); +} -#define ISIF_PRINT_REGISTER (iss, name)\ - dev_dbg(iss->dev, "###ISIF " #name "=0x%08x\n", \ - iss_reg_read(iss, OMAP4_ISS_MEM_ISP_ISIF, ISIF_##name)) +static inline isif_print_register(iss, name) +{ + dev_dbg(iss->dev, "###ISIF " #name "=0x%08x\n", + iss_reg_read(iss, OMAP4_ISS_MEM_ISP_ISIF, ISIF_##name)); +} -#define ISP5_PRINT_REGISTER (iss, name)\ - dev_dbg(iss->dev, "###ISP5 " #name "=0x%08x\n", \ - iss_reg_read(iss, OMAP4_ISS_MEM_ISP_SYS1, ISP5_##name)) +static inline isp5_print_register(iss, name) +{ + dev_dbg(iss->dev, "###ISP5 " #name "=0x%08x\n", + iss_reg_read(iss, OMAP4_ISS_MEM_ISP_SYS1, ISP5_##name)); +}static void ipipeif_print_status (struct iss_ipipeif_device *ipipeif) {
@@ -52,25 +58,25 @@ static void ipipeif_print_status(struct iss_ipipeif_device *ipipeif)dev_dbg (iss->dev,"-------------IPIPEIF Register dump-------------\n" ); -IPIPEIF_PRINT_REGISTER (iss,CFG1 ); -IPIPEIF_PRINT_REGISTER (iss,CFG2 ); - -ISIF_PRINT_REGISTER (iss,SYNCEN ); -ISIF_PRINT_REGISTER (iss,CADU ); -ISIF_PRINT_REGISTER (iss,CADL ); -ISIF_PRINT_REGISTER (iss,MODESET ); -ISIF_PRINT_REGISTER (iss,CCOLP ); -ISIF_PRINT_REGISTER (iss,SPH ); -ISIF_PRINT_REGISTER (iss,LNH ); -ISIF_PRINT_REGISTER (iss,LNV ); -ISIF_PRINT_REGISTER (iss,VDINT (0 )); -ISIF_PRINT_REGISTER (iss,HSIZE ); - -ISP5_PRINT_REGISTER (iss,SYSCONFIG ); -ISP5_PRINT_REGISTER (iss,CTRL ); -ISP5_PRINT_REGISTER (iss,IRQSTATUS (0 )); -ISP5_PRINT_REGISTER (iss,IRQENABLE_SET (0 )); -ISP5_PRINT_REGISTER (iss,IRQENABLE_CLR (0 )); +ipipeif_print_register (iss,CFG1 ); +ipipeif_print_register (iss,CFG2 ); + +isif_print_register (iss,SYNCEN ); +isif_print_register (iss,CADU ); +isif_print_register (iss,CADL ); +isif_print_register (iss,MODESET ); +isif_print_register (iss,CCOLP ); +isif_print_register (iss,SPH ); +isif_print_register (iss,LNH ); +isif_print_register (iss,LNV ); +isif_print_register (iss,VDINT (0 )); +isif_print_register (iss,HSIZE ); + +isp5_print_register (iss,SYSCONFIG ); +isp5_print_register (iss,CTRL ); +isp5_print_register (iss,IRQSTATUS (0 )); +isp5_print_register (iss,IRQENABLE_SET (0 )); +isp5_print_register (iss,IRQENABLE_CLR (0 ));dev_dbg (iss->dev,"-----------------------------------------------\n" ); }
Signature · 1 line
2.7.4
kernel test robot
build botRe: [Outreachy kernel][PATCH 3/4] Replace macro function by static inline function in file iss_ipipeif.c
Thank you for the patch! Perhaps something to improve:
Hi Aline,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linuxtv-media/master]
[also build test WARNING on v5.12-rc7 next-20210412]
[If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Aline-Santana-Cordeiro/Replace-macro-function-by-static-inline-function-in-file-iss-c/20210412-213252 base: git://linuxtv.org/media_tree.git master config: arc-allyesconfig (attached as .config) compiler: arceb-elf-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/8845073e7a4b434b2bc32818bfa172e91075a167
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Aline-Santana-Cordeiro/Replace-macro-function-by-static-inline-function-in-file-iss-c/20210412-213252 git checkout 8845073e7a4b434b2bc32818bfa172e91075a167
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arc
If you fix the issue, kindly add following tag as appropriate
All warnings (new ones prefixed by >>):
drivers/staging/media/omap4iss/iss_ipipeif.c:37:15: error: return type defaults to 'int' [-Werror=return-type]
37 | static inline ipipeif_print_register(iss, name)
| ^~~~~~~~~~~~~~~~~~~~~~
drivers/staging/media/omap4iss/iss_ipipeif.c:37:15: error: function declaration isn't a prototype [-Werror=strict-prototypes] drivers/staging/media/omap4iss/iss_ipipeif.c: In function 'ipipeif_print_register':
>> drivers/staging/media/omap4iss/iss_ipipeif.c:37:15: warning: old-style function definition [-Wold-style-definition]
>> drivers/staging/media/omap4iss/iss_ipipeif.c:37:15: warning: type of 'iss' defaults to 'int' [-Wmissing-parameter-type]
>> drivers/staging/media/omap4iss/iss_ipipeif.c:37:15: warning: type of 'name' defaults to 'int' [-Wmissing-parameter-type]
In file included from include/linux/printk.h:409,
from include/linux/kernel.h:16,
from include/linux/list.h:9,
from include/linux/module.h:12,
from drivers/staging/media/omap4iss/iss_ipipeif.c:10:
drivers/staging/media/omap4iss/iss_ipipeif.c:39:34: error: stray '#' in program
39 | dev_dbg(iss->dev, "###IPIPEIF " #name "=0x%08x\n",
| ^
include/linux/dynamic_debug.h:91:14: note: in definition of macro 'DEFINE_DYNAMIC_DEBUG_METADATA'
91 | .format = (fmt), \
| ^~~
include/linux/dynamic_debug.h:147:2: note: in expansion of macro '__dynamic_func_call'
147 | __dynamic_func_call(__UNIQUE_ID(ddebug), fmt, func, ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~~~~~
include/linux/dynamic_debug.h:161:2: note: in expansion of macro '_dynamic_func_call'
161 | _dynamic_func_call(fmt,__dynamic_dev_dbg, \
| ^~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:123:2: note: in expansion of macro 'dynamic_dev_dbg'
123 | dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~
include/linux/dev_printk.h:123:23: note: in expansion of macro 'dev_fmt'
123 | dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~
drivers/staging/media/omap4iss/iss_ipipeif.c:39:2: note: in expansion of macro 'dev_dbg'
39 | dev_dbg(iss->dev, "###IPIPEIF " #name "=0x%08x\n",
| ^~~~~~~
drivers/staging/media/omap4iss/iss_ipipeif.c:39:35: error: expected ')' before 'name'
39 | dev_dbg(iss->dev, "###IPIPEIF " #name "=0x%08x\n",
| ^~~~
include/linux/dynamic_debug.h:91:14: note: in definition of macro 'DEFINE_DYNAMIC_DEBUG_METADATA'
91 | .format = (fmt), \
| ^~~
include/linux/dynamic_debug.h:147:2: note: in expansion of macro '__dynamic_func_call'
147 | __dynamic_func_call(__UNIQUE_ID(ddebug), fmt, func, ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~~~~~
include/linux/dynamic_debug.h:161:2: note: in expansion of macro '_dynamic_func_call'
161 | _dynamic_func_call(fmt,__dynamic_dev_dbg, \
| ^~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:123:2: note: in expansion of macro 'dynamic_dev_dbg'
123 | dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~
include/linux/dev_printk.h:123:23: note: in expansion of macro 'dev_fmt'
123 | dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~
drivers/staging/media/omap4iss/iss_ipipeif.c:39:2: note: in expansion of macro 'dev_dbg'
39 | dev_dbg(iss->dev, "###IPIPEIF " #name "=0x%08x\n",
| ^~~~~~~
include/linux/dynamic_debug.h:91:13: note: to match this '('
91 | .format = (fmt), \
| ^
include/linux/dynamic_debug.h:127:2: note: in expansion of macro 'DEFINE_DYNAMIC_DEBUG_METADATA'
127 | DEFINE_DYNAMIC_DEBUG_METADATA(id, fmt); \
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dynamic_debug.h:147:2: note: in expansion of macro '__dynamic_func_call'
147 | __dynamic_func_call(__UNIQUE_ID(ddebug), fmt, func, ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~~~~~
include/linux/dynamic_debug.h:161:2: note: in expansion of macro '_dynamic_func_call'
161 | _dynamic_func_call(fmt,__dynamic_dev_dbg, \
| ^~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:123:2: note: in expansion of macro 'dynamic_dev_dbg'
123 | dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~
drivers/staging/media/omap4iss/iss_ipipeif.c:39:2: note: in expansion of macro 'dev_dbg'
39 | dev_dbg(iss->dev, "###IPIPEIF " #name "=0x%08x\n",
| ^~~~~~~
drivers/staging/media/omap4iss/iss_ipipeif.c:39:13: error: invalid type argument of '->' (have 'int')
39 | dev_dbg(iss->dev, "###IPIPEIF " #name "=0x%08x\n",
| ^~
include/linux/dynamic_debug.h:129:15: note: in definition of macro '__dynamic_func_call'
129 | func(&id, ##__VA_ARGS__); \
| ^~~~~~~~~~~
include/linux/dynamic_debug.h:161:2: note: in expansion of macro '_dynamic_func_call'
161 | _dynamic_func_call(fmt,__dynamic_dev_dbg, \
| ^~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:123:2: note: in expansion of macro 'dynamic_dev_dbg'
123 | dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~
drivers/staging/media/omap4iss/iss_ipipeif.c:39:2: note: in expansion of macro 'dev_dbg'
39 | dev_dbg(iss->dev, "###IPIPEIF " #name "=0x%08x\n",
| ^~~~~~~
drivers/staging/media/omap4iss/iss_ipipeif.c:39:34: error: stray '#' in program
39 | dev_dbg(iss->dev, "###IPIPEIF " #name "=0x%08x\n",
| ^
include/linux/dynamic_debug.h:129:15: note: in definition of macro '__dynamic_func_call'
129 | func(&id, ##__VA_ARGS__); \
| ^~~~~~~~~~~
include/linux/dynamic_debug.h:161:2: note: in expansion of macro '_dynamic_func_call'
161 | _dynamic_func_call(fmt,__dynamic_dev_dbg, \
| ^~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:123:2: note: in expansion of macro 'dynamic_dev_dbg'
123 | dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~
include/linux/dev_printk.h:123:23: note: in expansion of macro 'dev_fmt'
123 | dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~
drivers/staging/media/omap4iss/iss_ipipeif.c:39:2: note: in expansion of macro 'dev_dbg'
39 | dev_dbg(iss->dev, "###IPIPEIF " #name "=0x%08x\n",
| ^~~~~~~
drivers/staging/media/omap4iss/iss_ipipeif.c:39:35: error: expected ')' before 'name'
39 | dev_dbg(iss->dev, "###IPIPEIF " #name "=0x%08x\n",vim +37 drivers/staging/media/omap4iss/iss_ipipeif.c
30
31 /*
32 * ipipeif_print_status - Print current IPIPEIF Module register values.
33 * @ipipeif: Pointer to ISS ISP IPIPEIF device.
34 *
35 * Also prints other debug information stored in the IPIPEIF module.
36 */
> 37 static inline ipipeif_print_register(iss, name)
38 {
39 dev_dbg(iss->dev, "###IPIPEIF " #name "=0x%08x\n",
40 iss_reg_read(iss, OMAP4_ISS_MEM_ISP_IPIPEIF, IPIPEIF_##name));
41 }
42 ---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
PATCH 4/4 Replace macro function by static inline function in file iss_resizer.c
In reply to a message not in the archiveReplace macro function by static inline function.
Issue suggested by Julia.
--- drivers/staging/media/omap4iss/iss_resizer.c | 126 ++++++++++++++------------- 1 file changed, 65 insertions(+), 61 deletions(-)
drivers/staging/media/omap4iss/iss_resizer.c +65 -61
@@ -30,13 +30,17 @@ static const unsigned int resizer_fmts[] = {* * Also prints other debug information stored in the RESIZER module. */ -#define RSZ_PRINT_REGISTER (iss, name)\ - dev_dbg(iss->dev, "###RSZ " #name "=0x%08x\n", \ - iss_reg_read(iss, OMAP4_ISS_MEM_ISP_RESIZER, RSZ_##name)) +static inline rsz_print_register(iss, name) +{ + dev_dbg(iss->dev, "###RSZ " #name "=0x%08x\n", + iss_reg_read(iss, OMAP4_ISS_MEM_ISP_RESIZER, RSZ_##name)); +} -#define RZA_PRINT_REGISTER (iss, name)\ - dev_dbg(iss->dev, "###RZA " #name "=0x%08x\n", \ - iss_reg_read(iss, OMAP4_ISS_MEM_ISP_RESIZER, RZA_##name)) +static inline rza_print_register(iss, name) +{ + dev_dbg(iss->dev, "###RZA " #name "=0x%08x\n", + iss_reg_read(iss, OMAP4_ISS_MEM_ISP_RESIZER, RZA_##name)); +}static void resizer_print_status (struct iss_resizer_device *resizer) {
@@ -44,61 +48,61 @@ static void resizer_print_status(struct iss_resizer_device *resizer)dev_dbg (iss->dev,"-------------RESIZER Register dump-------------\n" ); -RSZ_PRINT_REGISTER (iss,SYSCONFIG ); -RSZ_PRINT_REGISTER (iss,IN_FIFO_CTRL ); -RSZ_PRINT_REGISTER (iss,FRACDIV ); -RSZ_PRINT_REGISTER (iss,SRC_EN ); -RSZ_PRINT_REGISTER (iss,SRC_MODE ); -RSZ_PRINT_REGISTER (iss,SRC_FMT0 ); -RSZ_PRINT_REGISTER (iss,SRC_FMT1 ); -RSZ_PRINT_REGISTER (iss,SRC_VPS ); -RSZ_PRINT_REGISTER (iss,SRC_VSZ ); -RSZ_PRINT_REGISTER (iss,SRC_HPS ); -RSZ_PRINT_REGISTER (iss,SRC_HSZ ); -RSZ_PRINT_REGISTER (iss,DMA_RZA ); -RSZ_PRINT_REGISTER (iss,DMA_RZB ); -RSZ_PRINT_REGISTER (iss,DMA_STA ); -RSZ_PRINT_REGISTER (iss,GCK_MMR ); -RSZ_PRINT_REGISTER (iss,GCK_SDR ); -RSZ_PRINT_REGISTER (iss,IRQ_RZA ); -RSZ_PRINT_REGISTER (iss,IRQ_RZB ); -RSZ_PRINT_REGISTER (iss,YUV_Y_MIN ); -RSZ_PRINT_REGISTER (iss,YUV_Y_MAX ); -RSZ_PRINT_REGISTER (iss,YUV_C_MIN ); -RSZ_PRINT_REGISTER (iss,YUV_C_MAX ); -RSZ_PRINT_REGISTER (iss,SEQ ); - -RZA_PRINT_REGISTER (iss,EN ); -RZA_PRINT_REGISTER (iss,MODE ); -RZA_PRINT_REGISTER (iss,420 ); -RZA_PRINT_REGISTER (iss,I_VPS ); -RZA_PRINT_REGISTER (iss,I_HPS ); -RZA_PRINT_REGISTER (iss,O_VSZ ); -RZA_PRINT_REGISTER (iss,O_HSZ ); -RZA_PRINT_REGISTER (iss,V_PHS_Y ); -RZA_PRINT_REGISTER (iss,V_PHS_C ); -RZA_PRINT_REGISTER (iss,V_DIF ); -RZA_PRINT_REGISTER (iss,V_TYP ); -RZA_PRINT_REGISTER (iss,V_LPF ); -RZA_PRINT_REGISTER (iss,H_PHS ); -RZA_PRINT_REGISTER (iss,H_DIF ); -RZA_PRINT_REGISTER (iss,H_TYP ); -RZA_PRINT_REGISTER (iss,H_LPF ); -RZA_PRINT_REGISTER (iss,DWN_EN ); -RZA_PRINT_REGISTER (iss,SDR_Y_BAD_H ); -RZA_PRINT_REGISTER (iss,SDR_Y_BAD_L ); -RZA_PRINT_REGISTER (iss,SDR_Y_SAD_H ); -RZA_PRINT_REGISTER (iss,SDR_Y_SAD_L ); -RZA_PRINT_REGISTER (iss,SDR_Y_OFT ); -RZA_PRINT_REGISTER (iss,SDR_Y_PTR_S ); -RZA_PRINT_REGISTER (iss,SDR_Y_PTR_E ); -RZA_PRINT_REGISTER (iss,SDR_C_BAD_H ); -RZA_PRINT_REGISTER (iss,SDR_C_BAD_L ); -RZA_PRINT_REGISTER (iss,SDR_C_SAD_H ); -RZA_PRINT_REGISTER (iss,SDR_C_SAD_L ); -RZA_PRINT_REGISTER (iss,SDR_C_OFT ); -RZA_PRINT_REGISTER (iss,SDR_C_PTR_S ); -RZA_PRINT_REGISTER (iss,SDR_C_PTR_E ); +rsz_print_register (iss,SYSCONFIG ); +rsz_print_register (iss,IN_FIFO_CTRL ); +rsz_print_register (iss,FRACDIV ); +rsz_print_register (iss,SRC_EN ); +rsz_print_register (iss,SRC_MODE ); +rsz_print_register (iss,SRC_FMT0 ); +rsz_print_register (iss,SRC_FMT1 ); +rsz_print_register (iss,SRC_VPS ); +rsz_print_register (iss,SRC_VSZ ); +rsz_print_register (iss,SRC_HPS ); +rsz_print_register (iss,SRC_HSZ ); +rsz_print_register (iss,DMA_RZA ); +rsz_print_register (iss,DMA_RZB ); +rsz_print_register (iss,DMA_STA ); +rsz_print_register (iss,GCK_MMR ); +rsz_print_register (iss,GCK_SDR ); +rsz_print_register (iss,IRQ_RZA ); +rsz_print_register (iss,IRQ_RZB ); +rsz_print_register (iss,YUV_Y_MIN ); +rsz_print_register (iss,YUV_Y_MAX ); +rsz_print_register (iss,YUV_C_MIN ); +rsz_print_register (iss,YUV_C_MAX ); +rsz_print_register (iss,SEQ ); + +rza_print_register (iss,EN ); +rza_print_register (iss,MODE ); +rza_print_register (iss,420 ); +rza_print_register (iss,I_VPS ); +rza_print_register (iss,I_HPS ); +rza_print_register (iss,O_VSZ ); +rza_print_register (iss,O_HSZ ); +rza_print_register (iss,V_PHS_Y ); +rza_print_register (iss,V_PHS_C ); +rza_print_register (iss,V_DIF ); +rza_print_register (iss,V_TYP ); +rza_print_register (iss,V_LPF ); +rza_print_register (iss,H_PHS ); +rza_print_register (iss,H_DIF ); +rza_print_register (iss,H_TYP ); +rza_print_register (iss,H_LPF ); +rza_print_register (iss,DWN_EN ); +rza_print_register (iss,SDR_Y_BAD_H ); +rza_print_register (iss,SDR_Y_BAD_L ); +rza_print_register (iss,SDR_Y_SAD_H ); +rza_print_register (iss,SDR_Y_SAD_L ); +rza_print_register (iss,SDR_Y_OFT ); +rza_print_register (iss,SDR_Y_PTR_S ); +rza_print_register (iss,SDR_Y_PTR_E ); +rza_print_register (iss,SDR_C_BAD_H ); +rza_print_register (iss,SDR_C_BAD_L ); +rza_print_register (iss,SDR_C_SAD_H ); +rza_print_register (iss,SDR_C_SAD_L ); +rza_print_register (iss,SDR_C_OFT ); +rza_print_register (iss,SDR_C_PTR_S ); +rza_print_register (iss,SDR_C_PTR_E );dev_dbg (iss->dev,"-----------------------------------------------\n" ); }
Signature · 1 line
2.7.4