perf ftrace: Command fails on s390
PATCH 1/1 perf ftrace: Command fails on s390
Command 'perf ftrace -v -- ls' fails in s390 (at least 5.12.0rc6).
The root cause is a missing pointer dereference which causes an array element address to be used as PID.
Fix this by extracting the PID.
Output before:
# ./perf ftrace -v -- ls function_graph tracer is used write '-263732416' to tracing/set_ftrace_pid failed: Invalid argument failed to set ftrace pid #
Output after:
./perf ftrace -v -- ls
function_graph tracer is used
# tracer: function_graph
#
# CPU DURATION FUNCTION CALLS
# | | | | | | |
4) | rcu_read_lock_sched_held() {
4) 0.552 us | rcu_lockdep_current_cpu_online();
4) 6.124 us | }Signed-off-by Thomas Richter <[email protected]>
Reported-by Alexander Schmidt <[email protected]>
--- tools/perf/builtin-ftrace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/builtin-ftrace.c +1 -1
@@ -289,7 +289,7 @@ static int set_tracing_pid(struct perf_ftrace *ftrace)for (i =0 ; i <perf_thread_map__nr (ftrace->evlist->core.threads); i++) {scnprintf (buf,sizeof (buf),"%d" , - ftrace->evlist->core.threads->map[i]); +perf_thread_map__pid (ftrace->evlist->core.threads, i));if (append_tracing_file ("set_ftrace_pid" , buf) <0 )return -1 ; }
Signature · 1 line
2.30.2