drivers: pinctrl: qcom: fix Kconfig dependency on GPIOLIB
Subsystems (5)
PATCH v2 1/1 drivers: pinctrl: qcom: fix Kconfig dependency on GPIOLIB
When PINCTRL_MSM is enabled, and GPIOLIB is disabled, Kbuild gives the following warning:
WARNING: unmet direct dependencies detected for GPIOLIB_IRQCHIP
Depends on [n]: GPIOLIB [=n]
Selected by [y]:
- PINCTRL_MSM [=y] && PINCTRL [=y] && (ARCH_QCOM || COMPILE_TEST [=y])
This is because PINCTRL_MSM selects GPIOLIB_IRQCHIP, without selecting or depending on GPIOLIB, despite GPIOLIB_IRQCHIP depending on GPIOLIB. Having PINCTRL_MSM select GPIOLIB will cause a recursive dependency error.
--- drivers/pinctrl/qcom/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pinctrl/qcom/Kconfig +1 -1
@@ -3,7 +3,7 @@ if (ARCH_QCOM || COMPILE_TEST) config PINCTRL_MSM tristate "Qualcomm core pin controller driver" - depends on QCOM_SCM || !QCOM_SCM #if QCOM_SCM=m this can't be =y + depends on GPIOLIB && (QCOM_SCM || !QCOM_SCM) #if QCOM_SCM=m this can't be =y select PINMUX select PINCONF select GENERIC_PINCONF
Signature · 1 line
2.27.0
Quoted 8 lines · Julian Braha
When
PINCTRL_MSMis enabled, and GPIOLIB is disabled,Kbuildgives the following warning:WARNING: unmet direct dependencies detected for
GPIOLIB_IRQCHIP
Depends on [n]: GPIOLIB [=n]
Selected by [y]:
-PINCTRL_MSM[=y] && PINCTRL [=y] && (ARCH_QCOM||COMPILE_TEST[=y])
Quoted 5 lines
This is because
PINCTRL_MSMselectsGPIOLIB_IRQCHIP, without selecting or depending on GPIOLIB, despiteGPIOLIB_IRQCHIPdepending on GPIOLIB. HavingPINCTRL_MSMselect GPIOLIB will cause a recursive dependency error.
Quoted 21 lines
Signed-off-by Julian Braha <[email protected]>--- drivers/pinctrl/qcom/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/pinctrl/qcom/Kconfig +1
-1@@ -3,7 +3,7 @@ if (ARCH_QCOM || COMPILE_TEST) config PINCTRL_MSM tristate "Qualcomm core pin controller driver" - depends on QCOM_SCM || !QCOM_SCM #if QCOM_SCM=m this can't be =y + depends on GPIOLIB && (QCOM_SCM || !QCOM_SCM) #if QCOM_SCM=m this can't be =y select PINMUX select PINCONF select GENERIC_PINCONFSignature · 1 line
2.27.0
Quoted 8 lines · Julian Braha
When
PINCTRL_MSMis enabled, and GPIOLIB is disabled,Kbuildgives the following warning:WARNING: unmet direct dependencies detected for
GPIOLIB_IRQCHIP
Depends on [n]: GPIOLIB [=n]
Selected by [y]:
-PINCTRL_MSM[=y] && PINCTRL [=y] && (ARCH_QCOM||COMPILE_TEST[=y])
Quoted 6 lines
This is because
PINCTRL_MSMselectsGPIOLIB_IRQCHIP, without selecting or depending on GPIOLIB, despiteGPIOLIB_IRQCHIPdepending on GPIOLIB. HavingPINCTRL_MSMselect GPIOLIB will cause a recursive dependency error.Signed-off-by Julian Braha <[email protected]>
Patch applied.
Yours,
Linus Walleij
This patch was applied to qcom/linux.git (refs/heads/for-next):
Hello:
This patch was applied to qcom/linux.git (refs/heads/for-next):
Quoted 9 lines · On Tue, 13 Apr 2021 22:51:38 -0400 you wrote:
When
PINCTRL_MSMis enabled, and GPIOLIB is disabled,Kbuildgives the following warning:WARNING: unmet direct dependencies detected for
GPIOLIB_IRQCHIP
Depends on [n]: GPIOLIB [=n]
Selected by [y]:
-PINCTRL_MSM[=y] && PINCTRL [=y] && (ARCH_QCOM||COMPILE_TEST[=y])[...]
Here is the summary with links:
- [v2] drivers: pinctrl: qcom: fix Kconfig dependency on GPIOLIB
https://git.kernel.org/qcom/c/376f9e34c10f
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html