Skip to contentSkip to conversation

KVM: x86/mmu: Remove duplicate MMU trace log

PATCH In review Yang Weijiang 2 participants 2 messages Apr 15, 2021

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 KVM: x86/mmu: Remove duplicate MMU trace log

---
 arch/x86/kvm/mmu/tdp_mmu.c | 2 --
 1 file changed, 2 deletions(-)
arch/x86/kvm/mmu/tdp_mmu.c +0 -2
index 018d82e73e31..0bd4c9972fc8 100644
@@ -781,8 +781,6 @@ static int tdp_mmu_map_handle_target_level(struct kvm_vcpu *vcpu, int write,
 		trace_kvm_mmu_set_spte(iter->level, iter->gfn,
 				       rcu_dereference(iter->sptep));
 
-	trace_kvm_mmu_set_spte(iter->level, iter->gfn,
-			       rcu_dereference(iter->sptep));
 	if (!prefault)
 		vcpu->stat.pf_fixed++;
 
Signature · 1 line
2.17.2
#1 lore raw
Quoted 10 lines · Yang Weijiang
---
 arch/x86/kvm/mmu/tdp_mmu.c | 2 --
 1 file changed, 2 deletions(-)
arch/x86/kvm/mmu/tdp_mmu.c +0 -0
index 018d82e73e31..0bd4c9972fc8 100644

arch/x86/kvm/mmu/tdp_mmu.c static int tdp_mmu_map_handle_target_level(struct kvm_vcpu *vcpu, int write, · line 785

Quoted 7 lines
arch/x86/kvm/mmu/tdp_mmu.c +0 -2
@@ -781,8 +781,6 @@ static int tdp_mmu_map_handle_target_level(struct kvm_vcpu *vcpu, int write,
 		trace_kvm_mmu_set_spte(iter->level, iter->gfn,
 				       rcu_dereference(iter->sptep));
 
-	trace_kvm_mmu_set_spte(iter->level, iter->gfn,
-			       rcu_dereference(iter->sptep));
 	if (!prefault)
 		vcpu->stat.pf_fixed++;

Already queued in kvm/next, commit 3849e0924ef1 ("KVM: x86/mmu: Drop redundant trace_kvm_mmu_set_spte() in the TDP MMU").

Thanks!