drm/tegra: Fix shift overflow in tegra_shared_plane_atomic_update
PATCH 1/1 drm/tegra: Fix shift overflow in tegra_shared_plane_atomic_update
Clang warns:
drivers/gpu/drm/tegra/hub.c:513:11: warning: shift count >= width of type [-Wshift-count-overflow]
base |= BIT(39);
^~~~~~~BIT is unsigned long, which is 32-bit on ARCH=arm, hence the overflow warning. Switch to BIT_ULL, which is 64-bit and will not overflow.
--- drivers/gpu/drm/tegra/hub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/tegra/hub.c +1 -1
@@ -510,7 +510,7 @@ static void tegra_shared_plane_atomic_update(struct drm_plane *plane,* dGPU sector layout. */ if (tegra_plane_state->tiling.sector_layout ==TEGRA_BO_SECTOR_LAYOUT_GPU ) - base |=BIT (39 ); + base |=BIT_ULL (39 );#endif tegra_plane_writel (p, tegra_plane_state->format,DC_WIN_COLOR_DEPTH );
base-commit: 0265531f0897f890da3f9c2958707af099c7d974
Signature · 6 lines
2.31.1.272.g89b43f80a5 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Thierry Reding
AppliedQuoted 10 lines · Nathan Chancellor
Clang warns:
drivers/gpu/drm/tegra/hub.c:513:11: warning: shift count >= width of type [-Wshift-count-overflow]base |= BIT(39); ^~~~~~~BIT is unsigned long, which is 32-bit on ARCH=arm, hence the overflow warning. Switch to
BIT_ULL, which is 64-bit and will not overflow.
Quoted 6 lines
Fixes 7b6f846785f4 ("drm/tegra: Support sector layout on Tegra194")Signed-off-by Nathan Chancellor <[email protected]>--- drivers/gpu/drm/tegra/hub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
This code never runs on 32-bit platforms, so another option would be to not try and build this on 32-bit configurations either. But none of the rest of the code is built conditionally, so fixing this is preferable.
Applied, thanks.
Thierry
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel