Skip to contentSkip to conversation

media: atomisp: pci: remove unneeded variable 'err'

PATCH In review Saurav Girepunje 2 participants 3 messages Apr 18, 2021 – Apr 28, 2021

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 media: atomisp: pci: remove unneeded variable 'err'

Fix the following coccicheck warning:

drivers/staging/media/atomisp/pci/sh_css_mipi.c:39:5-8:
Unneeded variable: "err". Return "0" on line 44

---
 drivers/staging/media/atomisp/pci/sh_css_mipi.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/staging/media/atomisp/pci/sh_css_mipi.c +1 -2
index d5ae7f0b5864..708903a31b08 100644
@@ -36,12 +36,11 @@ ref_count_mipi_allocation[N_CSI_PORTS]; /* Initialized in mipi_init */
 int
 ia_css_mipi_frame_specify(const unsigned int size_mem_words,
 			  const bool contiguous) {
-	int err = 0;
 
 	my_css.size_mem_words = size_mem_words;
 	(void)contiguous;
 
-	return err;
+	return 0;
 }
 
 /*
Signature · 1 line
2.25.1
#1 lore raw
Quoted 32 lines · Saurav Girepunje

Fix the following coccicheck warning:

drivers/staging/media/atomisp/pci/sh_css_mipi.c:39:5-8:
Unneeded variable: "err". Return "0" on line 44

---
 drivers/staging/media/atomisp/pci/sh_css_mipi.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/staging/media/atomisp/pci/sh_css_mipi.c +1 -2
index d5ae7f0b5864..708903a31b08 100644
@@ -36,12 +36,11 @@ ref_count_mipi_allocation[N_CSI_PORTS]; /* Initialized in mipi_init */
 int
 ia_css_mipi_frame_specify(const unsigned int size_mem_words,
 			  const bool contiguous) {
-	int err = 0;
 
 	my_css.size_mem_words = size_mem_words;
 	(void)contiguous;
 
-	return err;
+	return 0;
 }
 
 /*
Signature · 1 line
2.25.1

Hi Saurav,

this ia_css_mipi_frame_specify seems to be unused. On header file, before the prototype it is said that it could be removed only when all drivers moved to a new API.

Is that comment obsolete?

thank you,

fabio

#2 lore raw

Re: [PATCH] media: atomisp: pci: remove unneeded variable 'err'[email protected],

Quoted 40 lines · Fabio Aiuto
Quoted 32 lines · Saurav Girepunje

Fix the following coccicheck warning:

drivers/staging/media/atomisp/pci/sh_css_mipi.c:39:5-8:
Unneeded variable: "err". Return "0" on line 44

---
 drivers/staging/media/atomisp/pci/sh_css_mipi.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/staging/media/atomisp/pci/sh_css_mipi.c +1 -2
index d5ae7f0b5864..708903a31b08 100644
@@ -36,12 +36,11 @@ ref_count_mipi_allocation[N_CSI_PORTS]; /* Initialized in mipi_init */
 int
 ia_css_mipi_frame_specify(const unsigned int size_mem_words,
 			  const bool contiguous) {
-	int err = 0;
 
 	my_css.size_mem_words = size_mem_words;
 	(void)contiguous;
 
-	return err;
+	return 0;
 }
 
 /*
Signature · 1 line
2.25.1

Hi Saurav,

this ia_css_mipi_frame_specify seems to be unused. On header file, before the prototype it is said that it could be removed only when all drivers moved to a new API.

Quoted 5 lines

Is that comment obsolete?

thank you,

fabio

yes this ia_css_mipi_frame_specify is unused. On header file

/* Backward compatible for CSS API 2.0 only
* TO BE REMOVED when all drivers move to CSS API 2.1. */

deprecated{Use ia_css_mipi_buffer_config instead.}

new api also suggested on comment.

saurav