iio: accel: st_accel: Move platform data from header to C file
Subsystems (2)
PATCH 1/7 iio: accel: st_accel: Move platform data from header to C file
Platform data is solely used by one file. Don't share it with others.
While at it, drop unneeded anymore __maybe_unused and fix kernel doc to avoid warning:
st_accel_core.c:1079: error: Cannot parse struct or union!
by converting to a simple comment. It is described at the declaration.
--- drivers/iio/accel/st_accel.h | 8 -------- drivers/iio/accel/st_accel_core.c | 5 +++++ 2 files changed, 5 insertions(+), 8 deletions(-)
drivers/iio/accel/st_accel.h +0 -8
@@ -62,14 +62,6 @@ enum st_accel_type {#define LIS2DE12_ACCEL_DEV_NAME "lis2de12"#define LIS2HH12_ACCEL_DEV_NAME "lis2hh12" -/** -* struct st_sensors_platform_data - default accel platform data -* @drdy_int_pin: default accel DRDY is available on INT1 pin. -*/ -static __maybe_unused const struct st_sensors_platform_data default_accel_pdata = { - .drdy_int_pin =1 , -}; -const struct st_sensor_settings *st_accel_get_settings (const char *name);int st_accel_common_probe (struct iio_dev *indio_dev);void st_accel_common_remove (struct iio_dev *indio_dev);
drivers/iio/accel/st_accel_core.c +5 -0
@@ -983,6 +983,11 @@ static const struct st_sensor_settings st_accel_sensors_settings[] = { }; +/* Default accel DRDY is available on INT1 pin */ +static const struct st_sensors_platform_data default_accel_pdata = { + .drdy_int_pin =1 , +}; +static int st_accel_read_raw (struct iio_dev *indio_dev,struct iio_chan_spec const *ch,int *val,int *val2,long mask)
Signature · 1 line
2.30.2
PATCH 2/7 iio: gyro: st_gyro: Move platform data from header to C file
Platform data is solely used by one file. Don't share it with others.
While at it, drop unneeded anymore __maybe_unused and fix kernel doc to avoid warning:
st_gyro_core.c:366: error: Cannot parse struct or union!
by converting to a simple comment. It is described at the declaration.
--- drivers/iio/gyro/st_gyro.h | 8 -------- drivers/iio/gyro/st_gyro_core.c | 5 +++++ 2 files changed, 5 insertions(+), 8 deletions(-)
drivers/iio/gyro/st_gyro.h +0 -8
@@ -24,14 +24,6 @@#define LSM330_GYRO_DEV_NAME "lsm330_gyro"#define LSM9DS0_GYRO_DEV_NAME "lsm9ds0_gyro" -/** -* struct st_sensors_platform_data - gyro platform data -* @drdy_int_pin: DRDY on gyros is available only on INT2 pin. -*/ -static __maybe_unused const struct st_sensors_platform_data gyro_pdata = { - .drdy_int_pin =2 , -}; -const struct st_sensor_settings *st_gyro_get_settings (const char *name);int st_gyro_common_probe (struct iio_dev *indio_dev);void st_gyro_common_remove (struct iio_dev *indio_dev);
drivers/iio/gyro/st_gyro_core.c +5 -0
@@ -357,6 +357,11 @@ static const struct st_sensor_settings st_gyro_sensors_settings[] = { }, }; +/* DRDY on gyros is available only on INT2 pin */ +static const struct st_sensors_platform_data gyro_pdata = { + .drdy_int_pin =2 , +}; +static int st_gyro_read_raw (struct iio_dev *indio_dev,struct iio_chan_spec const *ch,int *val,int *val2,long mask)
Signature · 1 line
2.30.2
PATCH 3/7 iio: magnetometer: st_magn: Provide default platform data
In reply to Andy ShevchenkoProvide default platform data for magnetometer in case it supports DRDY.
One case is LSM9DS0 IMU, on which it is the case. Since accelerometer is using INT1, default magnetometer to INT2.
While at it, update description of the drdy_int_pin field.
--- drivers/iio/magnetometer/st_magn_core.c | 11 ++++++++++- include/linux/platform_data/st_sensors_pdata.h | 3 ++- 2 files changed, 12 insertions(+), 2 deletions(-)
drivers/iio/magnetometer/st_magn_core.c +10 -1
@@ -382,6 +382,11 @@ static const struct st_sensor_settings st_magn_sensors_settings[] = { }, }; +/* Default magn DRDY is available on INT2 pin */ +static const struct st_sensors_platform_data default_magn_pdata = { + .drdy_int_pin =2 , +}; +static int st_magn_read_raw (struct iio_dev *indio_dev,struct iio_chan_spec const *ch,int *val,int *val2,long mask)
@@ -489,6 +494,7 @@ EXPORT_SYMBOL(st_magn_get_settings);int st_magn_common_probe (struct iio_dev *indio_dev) {struct st_sensor_data *mdata =iio_priv (indio_dev); +struct st_sensors_platform_data *pdata =dev_get_platdata (mdata->dev);int err; indio_dev->modes =INDIO_DIRECT_MODE ;
@@ -509,7 +515,10 @@ int st_magn_common_probe(struct iio_dev *indio_dev) mdata->current_fullscale = &mdata->sensor_settings->fs.fs_avl[0 ]; mdata->odr = mdata->sensor_settings->odr.odr_avl[0 ].hz; - err =st_sensors_init_sensor (indio_dev,NULL ); +if (!pdata) + pdata = (struct st_sensors_platform_data *)&default_magn_pdata; + + err =st_sensors_init_sensor (indio_dev, pdata);if (err <0 ) goto st_magn_power_off;
include/linux/platform_data/st_sensors_pdata.h +2 -1
@@ -13,8 +13,9 @@/** * struct st_sensors_platform_data - Platform data for the ST sensors * @drdy_int_pin: Redirect DRDY on pin 1 (1) or pin 2 (2). -* Available only for accelerometer and pressure sensors. +* Available only for accelerometer, magnetometer and pressure sensors. * Accelerometer DRDY on LSM330 available only on pin 1 (see datasheet). +* Magnetometer DRDY is supported only on LSM9DS0. * @open_drain: set the interrupt line to be open drain if possible. * @spi_3wire: enable spi-3wire mode. * @pullups: enable/disable i2c controller pullup resistors.
Signature · 1 line
2.30.2
PATCH 4/7 iio: st_sensors: Call st_sensors_power_enable() from bus drivers
In reply to Andy ShevchenkoIn case we would initialize two IIO devices from one physical device, we shouldn't have a clash on regulators. That's why move st_sensors_power_enable() call from core to bus drivers.
--- drivers/iio/accel/st_accel_core.c | 21 +++++---------------- drivers/iio/accel/st_accel_i2c.c | 17 +++++++++++++++-- drivers/iio/accel/st_accel_spi.c | 17 +++++++++++++++-- drivers/iio/gyro/st_gyro_core.c | 15 +++------------ drivers/iio/gyro/st_gyro_i2c.c | 17 +++++++++++++++-- drivers/iio/gyro/st_gyro_spi.c | 17 +++++++++++++++-- drivers/iio/magnetometer/st_magn_core.c | 15 +++------------ drivers/iio/magnetometer/st_magn_i2c.c | 14 +++++++++++++- drivers/iio/magnetometer/st_magn_spi.c | 14 +++++++++++++- drivers/iio/pressure/st_pressure_core.c | 15 +++------------ drivers/iio/pressure/st_pressure_i2c.c | 17 +++++++++++++++-- drivers/iio/pressure/st_pressure_spi.c | 17 +++++++++++++++-- 12 files changed, 130 insertions(+), 66 deletions(-)
drivers/iio/accel/st_accel_core.c +5 -16
@@ -1260,13 +1260,9 @@ int st_accel_common_probe(struct iio_dev *indio_dev) indio_dev->modes =INDIO_DIRECT_MODE ; indio_dev->info = &accel_info; - err =st_sensors_power_enable (indio_dev); -if (err) -return err; - err =st_sensors_verify_id (indio_dev);if (err <0 ) - goto st_accel_power_off; +return err; adata->num_data_channels =ST_ACCEL_NUMBER_DATA_CHANNELS ; indio_dev->num_channels =ST_SENSORS_NUMBER_ALL_CHANNELS ;
@@ -1275,10 +1271,8 @@ int st_accel_common_probe(struct iio_dev *indio_dev) channels =devm_kmemdup (&indio_dev->dev, adata->sensor_settings->ch, channels_size,GFP_KERNEL ); -if (!channels) { - err = -ENOMEM ; - goto st_accel_power_off; - } +if (!channels) +return -ENOMEM ;if (apply_acpi_orientation (indio_dev, channels)) dev_warn(&indio_dev->dev,
@@ -1293,11 +1287,11 @@ int st_accel_common_probe(struct iio_dev *indio_dev) err =st_sensors_init_sensor (indio_dev, pdata);if (err <0 ) - goto st_accel_power_off; +return err; err =st_accel_allocate_ring (indio_dev);if (err <0 ) - goto st_accel_power_off; +return err;if (adata->irq >0 ) { err = st_sensors_allocate_trigger(indio_dev,
@@ -1320,9 +1314,6 @@ int st_accel_common_probe(struct iio_dev *indio_dev)st_sensors_deallocate_trigger (indio_dev); st_accel_probe_trigger_error:st_accel_deallocate_ring (indio_dev); -st_accel_power_off: -st_sensors_power_disable (indio_dev); -return err; }EXPORT_SYMBOL (st_accel_common_probe);
@@ -1331,8 +1322,6 @@ void st_accel_common_remove(struct iio_dev *indio_dev) {struct st_sensor_data *adata =iio_priv (indio_dev); -st_sensors_power_disable (indio_dev); -iio_device_unregister (indio_dev);if (adata->irq >0 )st_sensors_deallocate_trigger (indio_dev);
drivers/iio/accel/st_accel_i2c.c +15 -2
@@ -174,16 +174,29 @@ static int st_accel_i2c_probe(struct i2c_client *client)if (ret <0 )return ret; + ret =st_sensors_power_enable (indio_dev); +if (ret) +return ret; + ret =st_accel_common_probe (indio_dev);if (ret <0 ) -return ret; + goto st_accel_power_off;return 0 ; + +st_accel_power_off: +st_sensors_power_disable (indio_dev); + +return ret; }static int st_accel_i2c_remove (struct i2c_client *client) { -st_accel_common_remove (i2c_get_clientdata (client)); +struct iio_dev *indio_dev =i2c_get_clientdata (client); + +st_sensors_power_disable (indio_dev); + +st_accel_common_remove (indio_dev);return 0 ; }
drivers/iio/accel/st_accel_spi.c +15 -2
@@ -123,16 +123,29 @@ static int st_accel_spi_probe(struct spi_device *spi)if (err <0 )return err; + err =st_sensors_power_enable (indio_dev); +if (err) +return err; + err =st_accel_common_probe (indio_dev);if (err <0 ) -return err; + goto st_accel_power_off;return 0 ; + +st_accel_power_off: +st_sensors_power_disable (indio_dev); + +return err; }static int st_accel_spi_remove (struct spi_device *spi) { -st_accel_common_remove (spi_get_drvdata (spi)); +struct iio_dev *indio_dev =spi_get_drvdata (spi); + +st_sensors_power_disable (indio_dev); + +st_accel_common_remove (indio_dev);return 0 ; }
drivers/iio/gyro/st_gyro_core.c +3 -12
@@ -471,13 +471,9 @@ int st_gyro_common_probe(struct iio_dev *indio_dev) indio_dev->modes =INDIO_DIRECT_MODE ; indio_dev->info = &gyro_info; - err =st_sensors_power_enable (indio_dev); -if (err) -return err; - err =st_sensors_verify_id (indio_dev);if (err <0 ) - goto st_gyro_power_off; +return err; gdata->num_data_channels =ST_GYRO_NUMBER_DATA_CHANNELS ; indio_dev->channels = gdata->sensor_settings->ch;
@@ -490,11 +486,11 @@ int st_gyro_common_probe(struct iio_dev *indio_dev) err =st_sensors_init_sensor (indio_dev, pdata);if (err <0 ) - goto st_gyro_power_off; +return err; err =st_gyro_allocate_ring (indio_dev);if (err <0 ) - goto st_gyro_power_off; +return err;if (gdata->irq >0 ) { err = st_sensors_allocate_trigger(indio_dev,
@@ -517,9 +513,6 @@ int st_gyro_common_probe(struct iio_dev *indio_dev)st_sensors_deallocate_trigger (indio_dev); st_gyro_probe_trigger_error:st_gyro_deallocate_ring (indio_dev); -st_gyro_power_off: -st_sensors_power_disable (indio_dev); -return err; }EXPORT_SYMBOL (st_gyro_common_probe);
@@ -528,8 +521,6 @@ void st_gyro_common_remove(struct iio_dev *indio_dev) {struct st_sensor_data *gdata =iio_priv (indio_dev); -st_sensors_power_disable (indio_dev); -iio_device_unregister (indio_dev);if (gdata->irq >0 )st_sensors_deallocate_trigger (indio_dev);
drivers/iio/gyro/st_gyro_i2c.c +15 -2
@@ -86,16 +86,29 @@ static int st_gyro_i2c_probe(struct i2c_client *client,if (err <0 )return err; + err =st_sensors_power_enable (indio_dev); +if (err) +return err; + err =st_gyro_common_probe (indio_dev);if (err <0 ) -return err; + goto st_gyro_power_off;return 0 ; + +st_gyro_power_off: +st_sensors_power_disable (indio_dev); + +return err; }static int st_gyro_i2c_remove (struct i2c_client *client) { -st_gyro_common_remove (i2c_get_clientdata (client)); +struct iio_dev *indio_dev =i2c_get_clientdata (client); + +st_sensors_power_disable (indio_dev); + +st_gyro_common_remove (indio_dev);return 0 ; }
drivers/iio/gyro/st_gyro_spi.c +15 -2
@@ -90,16 +90,29 @@ static int st_gyro_spi_probe(struct spi_device *spi)if (err <0 )return err; + err =st_sensors_power_enable (indio_dev); +if (err) +return err; + err =st_gyro_common_probe (indio_dev);if (err <0 ) -return err; + goto st_gyro_power_off;return 0 ; + +st_gyro_power_off: +st_sensors_power_disable (indio_dev); + +return err; }static int st_gyro_spi_remove (struct spi_device *spi) { -st_gyro_common_remove (spi_get_drvdata (spi)); +struct iio_dev *indio_dev =spi_get_drvdata (spi); + +st_sensors_power_disable (indio_dev); + +st_gyro_common_remove (indio_dev);return 0 ; }
drivers/iio/magnetometer/st_magn_core.c +3 -12
@@ -500,13 +500,9 @@ int st_magn_common_probe(struct iio_dev *indio_dev) indio_dev->modes =INDIO_DIRECT_MODE ; indio_dev->info = &magn_info; - err =st_sensors_power_enable (indio_dev); -if (err) -return err; - err =st_sensors_verify_id (indio_dev);if (err <0 ) - goto st_magn_power_off; +return err; mdata->num_data_channels =ST_MAGN_NUMBER_DATA_CHANNELS ; indio_dev->channels = mdata->sensor_settings->ch;
@@ -520,11 +516,11 @@ int st_magn_common_probe(struct iio_dev *indio_dev) err =st_sensors_init_sensor (indio_dev, pdata);if (err <0 ) - goto st_magn_power_off; +return err; err =st_magn_allocate_ring (indio_dev);if (err <0 ) - goto st_magn_power_off; +return err;if (mdata->irq >0 ) { err = st_sensors_allocate_trigger(indio_dev,
@@ -547,9 +543,6 @@ int st_magn_common_probe(struct iio_dev *indio_dev)st_sensors_deallocate_trigger (indio_dev); st_magn_probe_trigger_error:st_magn_deallocate_ring (indio_dev); -st_magn_power_off: -st_sensors_power_disable (indio_dev); -return err; }EXPORT_SYMBOL (st_magn_common_probe);
@@ -558,8 +551,6 @@ void st_magn_common_remove(struct iio_dev *indio_dev) {struct st_sensor_data *mdata =iio_priv (indio_dev); -st_sensors_power_disable (indio_dev); -iio_device_unregister (indio_dev);if (mdata->irq >0 )st_sensors_deallocate_trigger (indio_dev);
drivers/iio/magnetometer/st_magn_i2c.c +13 -1
@@ -78,16 +78,28 @@ static int st_magn_i2c_probe(struct i2c_client *client,if (err <0 )return err; + err =st_sensors_power_enable (indio_dev); +if (err) +return err; + err =st_magn_common_probe (indio_dev);if (err <0 ) -return err; + goto st_magn_power_off;return 0 ; + +st_magn_power_off: +st_sensors_power_disable (indio_dev); + +return err; }static int st_magn_i2c_remove (struct i2c_client *client) {struct iio_dev *indio_dev =i2c_get_clientdata (client); + +st_sensors_power_disable (indio_dev); +st_magn_common_remove (indio_dev);return 0 ;
drivers/iio/magnetometer/st_magn_spi.c +13 -1
@@ -72,16 +72,28 @@ static int st_magn_spi_probe(struct spi_device *spi)if (err <0 )return err; + err =st_sensors_power_enable (indio_dev); +if (err) +return err; + err =st_magn_common_probe (indio_dev);if (err <0 ) -return err; + goto st_magn_power_off;return 0 ; + +st_magn_power_off: +st_sensors_power_disable (indio_dev); + +return err; }static int st_magn_spi_remove (struct spi_device *spi) {struct iio_dev *indio_dev =spi_get_drvdata (spi); + +st_sensors_power_disable (indio_dev); +st_magn_common_remove (indio_dev);return 0 ;
drivers/iio/pressure/st_pressure_core.c +3 -12
@@ -689,13 +689,9 @@ int st_press_common_probe(struct iio_dev *indio_dev) indio_dev->modes =INDIO_DIRECT_MODE ; indio_dev->info = &press_info; - err =st_sensors_power_enable (indio_dev); -if (err) -return err; - err =st_sensors_verify_id (indio_dev);if (err <0 ) - goto st_press_power_off; +return err;/* * Skip timestamping channel while declaring available channels to
@@ -718,11 +714,11 @@ int st_press_common_probe(struct iio_dev *indio_dev) err =st_sensors_init_sensor (indio_dev, pdata);if (err <0 ) - goto st_press_power_off; +return err; err =st_press_allocate_ring (indio_dev);if (err <0 ) - goto st_press_power_off; +return err;if (press_data->irq >0 ) { err = st_sensors_allocate_trigger(indio_dev,
@@ -745,9 +741,6 @@ int st_press_common_probe(struct iio_dev *indio_dev)st_sensors_deallocate_trigger (indio_dev); st_press_probe_trigger_error:st_press_deallocate_ring (indio_dev); -st_press_power_off: -st_sensors_power_disable (indio_dev); -return err; }EXPORT_SYMBOL (st_press_common_probe);
@@ -756,8 +749,6 @@ void st_press_common_remove(struct iio_dev *indio_dev) {struct st_sensor_data *press_data =iio_priv (indio_dev); -st_sensors_power_disable (indio_dev); -iio_device_unregister (indio_dev);if (press_data->irq >0 )st_sensors_deallocate_trigger (indio_dev);
drivers/iio/pressure/st_pressure_i2c.c +15 -2
@@ -98,16 +98,29 @@ static int st_press_i2c_probe(struct i2c_client *client,if (ret <0 )return ret; + ret =st_sensors_power_enable (indio_dev); +if (ret) +return ret; + ret =st_press_common_probe (indio_dev);if (ret <0 ) -return ret; + goto st_press_power_off;return 0 ; + +st_press_power_off: +st_sensors_power_disable (indio_dev); + +return ret; }static int st_press_i2c_remove (struct i2c_client *client) { -st_press_common_remove (i2c_get_clientdata (client)); +struct iio_dev *indio_dev =i2c_get_clientdata (client); + +st_sensors_power_disable (indio_dev); + +st_press_common_remove (indio_dev);return 0 ; }
drivers/iio/pressure/st_pressure_spi.c +15 -2
@@ -82,16 +82,29 @@ static int st_press_spi_probe(struct spi_device *spi)if (err <0 )return err; + err =st_sensors_power_enable (indio_dev); +if (err) +return err; + err =st_press_common_probe (indio_dev);if (err <0 ) -return err; + goto st_press_power_off;return 0 ; + +st_press_power_off: +st_sensors_power_disable (indio_dev); + +return err; }static int st_press_spi_remove (struct spi_device *spi) { -st_press_common_remove (spi_get_drvdata (spi)); +struct iio_dev *indio_dev =spi_get_drvdata (spi); + +st_sensors_power_disable (indio_dev); + +st_press_common_remove (indio_dev);return 0 ; }
Signature · 1 line
2.30.2
Jonathan Cameron
maintainerRe: [PATCH v1 4/7] iio: st_sensors: Call st_sensors_power_enable() from bus drivers
Quoted 3 lines · On Wed, 14 Apr 2021 22:54:51 +0300 Andy Shevchenko…
In case we would initialize two IIO devices from one physical device, we shouldn't have a clash on regulators. That's why move
st_sensors_power_enable()call from core to bus drivers.
Why is this a problem? The two instances would double up and both get + enable + disable the regulators. However, that shouldn't matter as they are reference counted anyway.
Perhaps an example? Even in patch 6 I can only see that it is wasteful to do it twice, rather than wrong as such.
Jonathan
Quoted 522 lines
Signed-off-by Andy Shevchenko <[email protected]>--- drivers/iio/accel/st_accel_core.c | 21 +++++---------------- drivers/iio/accel/st_accel_i2c.c | 17 +++++++++++++++-- drivers/iio/accel/st_accel_spi.c | 17 +++++++++++++++-- drivers/iio/gyro/st_gyro_core.c | 15 +++------------ drivers/iio/gyro/st_gyro_i2c.c | 17 +++++++++++++++-- drivers/iio/gyro/st_gyro_spi.c | 17 +++++++++++++++-- drivers/iio/magnetometer/st_magn_core.c | 15 +++------------ drivers/iio/magnetometer/st_magn_i2c.c | 14 +++++++++++++- drivers/iio/magnetometer/st_magn_spi.c | 14 +++++++++++++- drivers/iio/pressure/st_pressure_core.c | 15 +++------------ drivers/iio/pressure/st_pressure_i2c.c | 17 +++++++++++++++-- drivers/iio/pressure/st_pressure_spi.c | 17 +++++++++++++++-- 12 files changed, 130 insertions(+), 66 deletions(-)drivers/iio/accel/st_accel_core.c +5
-16@@ -1260,13 +1260,9 @@ int st_accel_common_probe(struct iio_dev *indio_dev) indio_dev->modes =INDIO_DIRECT_MODE ; indio_dev->info = &accel_info; - err =st_sensors_power_enable (indio_dev); -if (err) -return err; - err =st_sensors_verify_id (indio_dev);if (err <0 ) - goto st_accel_power_off; +return err; adata->num_data_channels =ST_ACCEL_NUMBER_DATA_CHANNELS ; indio_dev->num_channels =ST_SENSORS_NUMBER_ALL_CHANNELS ;@@ -1275,10 +1271,8 @@ int st_accel_common_probe(struct iio_dev *indio_dev) channels =devm_kmemdup (&indio_dev->dev, adata->sensor_settings->ch, channels_size,GFP_KERNEL ); -if (!channels) { - err = -ENOMEM ; - goto st_accel_power_off; - } +if (!channels) +return -ENOMEM ;if (apply_acpi_orientation (indio_dev, channels)) dev_warn(&indio_dev->dev,@@ -1293,11 +1287,11 @@ int st_accel_common_probe(struct iio_dev *indio_dev) err =st_sensors_init_sensor (indio_dev, pdata);if (err <0 ) - goto st_accel_power_off; +return err; err =st_accel_allocate_ring (indio_dev);if (err <0 ) - goto st_accel_power_off; +return err;if (adata->irq >0 ) { err = st_sensors_allocate_trigger(indio_dev,@@ -1320,9 +1314,6 @@ int st_accel_common_probe(struct iio_dev *indio_dev)st_sensors_deallocate_trigger (indio_dev); st_accel_probe_trigger_error:st_accel_deallocate_ring (indio_dev); -st_accel_power_off: -st_sensors_power_disable (indio_dev); -return err; }EXPORT_SYMBOL (st_accel_common_probe);@@ -1331,8 +1322,6 @@ void st_accel_common_remove(struct iio_dev *indio_dev) {struct st_sensor_data *adata =iio_priv (indio_dev); -st_sensors_power_disable (indio_dev); -iio_device_unregister (indio_dev);if (adata->irq >0 )st_sensors_deallocate_trigger (indio_dev);drivers/iio/accel/st_accel_i2c.c +15
-2@@ -174,16 +174,29 @@ static int st_accel_i2c_probe(struct i2c_client *client)if (ret <0 )return ret; + ret =st_sensors_power_enable (indio_dev); +if (ret) +return ret; + ret =st_accel_common_probe (indio_dev);if (ret <0 ) -return ret; + goto st_accel_power_off;return 0 ; + +st_accel_power_off: +st_sensors_power_disable (indio_dev); + +return ret; }static int st_accel_i2c_remove (struct i2c_client *client) { -st_accel_common_remove (i2c_get_clientdata (client)); +struct iio_dev *indio_dev =i2c_get_clientdata (client); + +st_sensors_power_disable (indio_dev); + +st_accel_common_remove (indio_dev);return 0 ; }drivers/iio/accel/st_accel_spi.c +15
-2@@ -123,16 +123,29 @@ static int st_accel_spi_probe(struct spi_device *spi)if (err <0 )return err; + err =st_sensors_power_enable (indio_dev); +if (err) +return err; + err =st_accel_common_probe (indio_dev);if (err <0 ) -return err; + goto st_accel_power_off;return 0 ; + +st_accel_power_off: +st_sensors_power_disable (indio_dev); + +return err; }static int st_accel_spi_remove (struct spi_device *spi) { -st_accel_common_remove (spi_get_drvdata (spi)); +struct iio_dev *indio_dev =spi_get_drvdata (spi); + +st_sensors_power_disable (indio_dev); + +st_accel_common_remove (indio_dev);return 0 ; }drivers/iio/gyro/st_gyro_core.c +3
-12@@ -471,13 +471,9 @@ int st_gyro_common_probe(struct iio_dev *indio_dev) indio_dev->modes =INDIO_DIRECT_MODE ; indio_dev->info = &gyro_info; - err =st_sensors_power_enable (indio_dev); -if (err) -return err; - err =st_sensors_verify_id (indio_dev);if (err <0 ) - goto st_gyro_power_off; +return err; gdata->num_data_channels =ST_GYRO_NUMBER_DATA_CHANNELS ; indio_dev->channels = gdata->sensor_settings->ch;@@ -490,11 +486,11 @@ int st_gyro_common_probe(struct iio_dev *indio_dev) err =st_sensors_init_sensor (indio_dev, pdata);if (err <0 ) - goto st_gyro_power_off; +return err; err =st_gyro_allocate_ring (indio_dev);if (err <0 ) - goto st_gyro_power_off; +return err;if (gdata->irq >0 ) { err = st_sensors_allocate_trigger(indio_dev,@@ -517,9 +513,6 @@ int st_gyro_common_probe(struct iio_dev *indio_dev)st_sensors_deallocate_trigger (indio_dev); st_gyro_probe_trigger_error:st_gyro_deallocate_ring (indio_dev); -st_gyro_power_off: -st_sensors_power_disable (indio_dev); -return err; }EXPORT_SYMBOL (st_gyro_common_probe);@@ -528,8 +521,6 @@ void st_gyro_common_remove(struct iio_dev *indio_dev) {struct st_sensor_data *gdata =iio_priv (indio_dev); -st_sensors_power_disable (indio_dev); -iio_device_unregister (indio_dev);if (gdata->irq >0 )st_sensors_deallocate_trigger (indio_dev);drivers/iio/gyro/st_gyro_i2c.c +15
-2@@ -86,16 +86,29 @@ static int st_gyro_i2c_probe(struct i2c_client *client,if (err <0 )return err; + err =st_sensors_power_enable (indio_dev); +if (err) +return err; + err =st_gyro_common_probe (indio_dev);if (err <0 ) -return err; + goto st_gyro_power_off;return 0 ; + +st_gyro_power_off: +st_sensors_power_disable (indio_dev); + +return err; }static int st_gyro_i2c_remove (struct i2c_client *client) { -st_gyro_common_remove (i2c_get_clientdata (client)); +struct iio_dev *indio_dev =i2c_get_clientdata (client); + +st_sensors_power_disable (indio_dev); + +st_gyro_common_remove (indio_dev);return 0 ; }drivers/iio/gyro/st_gyro_spi.c +15
-2@@ -90,16 +90,29 @@ static int st_gyro_spi_probe(struct spi_device *spi)if (err <0 )return err; + err =st_sensors_power_enable (indio_dev); +if (err) +return err; + err =st_gyro_common_probe (indio_dev);if (err <0 ) -return err; + goto st_gyro_power_off;return 0 ; + +st_gyro_power_off: +st_sensors_power_disable (indio_dev); + +return err; }static int st_gyro_spi_remove (struct spi_device *spi) { -st_gyro_common_remove (spi_get_drvdata (spi)); +struct iio_dev *indio_dev =spi_get_drvdata (spi); + +st_sensors_power_disable (indio_dev); + +st_gyro_common_remove (indio_dev);return 0 ; }drivers/iio/magnetometer/st_magn_core.c +3
-12@@ -500,13 +500,9 @@ int st_magn_common_probe(struct iio_dev *indio_dev) indio_dev->modes =INDIO_DIRECT_MODE ; indio_dev->info = &magn_info; - err =st_sensors_power_enable (indio_dev); -if (err) -return err; - err =st_sensors_verify_id (indio_dev);if (err <0 ) - goto st_magn_power_off; +return err; mdata->num_data_channels =ST_MAGN_NUMBER_DATA_CHANNELS ; indio_dev->channels = mdata->sensor_settings->ch;@@ -520,11 +516,11 @@ int st_magn_common_probe(struct iio_dev *indio_dev) err =st_sensors_init_sensor (indio_dev, pdata);if (err <0 ) - goto st_magn_power_off; +return err; err =st_magn_allocate_ring (indio_dev);if (err <0 ) - goto st_magn_power_off; +return err;if (mdata->irq >0 ) { err = st_sensors_allocate_trigger(indio_dev,@@ -547,9 +543,6 @@ int st_magn_common_probe(struct iio_dev *indio_dev)st_sensors_deallocate_trigger (indio_dev); st_magn_probe_trigger_error:st_magn_deallocate_ring (indio_dev); -st_magn_power_off: -st_sensors_power_disable (indio_dev); -return err; }EXPORT_SYMBOL (st_magn_common_probe);@@ -558,8 +551,6 @@ void st_magn_common_remove(struct iio_dev *indio_dev) {struct st_sensor_data *mdata =iio_priv (indio_dev); -st_sensors_power_disable (indio_dev); -iio_device_unregister (indio_dev);if (mdata->irq >0 )st_sensors_deallocate_trigger (indio_dev);drivers/iio/magnetometer/st_magn_i2c.c +13
-1@@ -78,16 +78,28 @@ static int st_magn_i2c_probe(struct i2c_client *client,if (err <0 )return err; + err =st_sensors_power_enable (indio_dev); +if (err) +return err; + err =st_magn_common_probe (indio_dev);if (err <0 ) -return err; + goto st_magn_power_off;return 0 ; + +st_magn_power_off: +st_sensors_power_disable (indio_dev); + +return err; }static int st_magn_i2c_remove (struct i2c_client *client) {struct iio_dev *indio_dev =i2c_get_clientdata (client); + +st_sensors_power_disable (indio_dev); +st_magn_common_remove (indio_dev);return 0 ;drivers/iio/magnetometer/st_magn_spi.c +13
-1@@ -72,16 +72,28 @@ static int st_magn_spi_probe(struct spi_device *spi)if (err <0 )return err; + err =st_sensors_power_enable (indio_dev); +if (err) +return err; + err =st_magn_common_probe (indio_dev);if (err <0 ) -return err; + goto st_magn_power_off;return 0 ; + +st_magn_power_off: +st_sensors_power_disable (indio_dev); + +return err; }static int st_magn_spi_remove (struct spi_device *spi) {struct iio_dev *indio_dev =spi_get_drvdata (spi); + +st_sensors_power_disable (indio_dev); +st_magn_common_remove (indio_dev);return 0 ;drivers/iio/pressure/st_pressure_core.c +3
-12@@ -689,13 +689,9 @@ int st_press_common_probe(struct iio_dev *indio_dev) indio_dev->modes =INDIO_DIRECT_MODE ; indio_dev->info = &press_info; - err =st_sensors_power_enable (indio_dev); -if (err) -return err; - err =st_sensors_verify_id (indio_dev);if (err <0 ) - goto st_press_power_off; +return err;/* * Skip timestamping channel while declaring available channels to @@ -718,11 +714,11 @@ int st_press_common_probe(struct iio_dev *indio_dev) err =st_sensors_init_sensor (indio_dev, pdata);if (err <0 ) - goto st_press_power_off; +return err; err =st_press_allocate_ring (indio_dev);if (err <0 ) - goto st_press_power_off; +return err;if (press_data->irq >0 ) { err = st_sensors_allocate_trigger(indio_dev,@@ -745,9 +741,6 @@ int st_press_common_probe(struct iio_dev *indio_dev)st_sensors_deallocate_trigger (indio_dev); st_press_probe_trigger_error:st_press_deallocate_ring (indio_dev); -st_press_power_off: -st_sensors_power_disable (indio_dev); -return err; }EXPORT_SYMBOL (st_press_common_probe);@@ -756,8 +749,6 @@ void st_press_common_remove(struct iio_dev *indio_dev) {struct st_sensor_data *press_data =iio_priv (indio_dev); -st_sensors_power_disable (indio_dev); -iio_device_unregister (indio_dev);if (press_data->irq >0 )st_sensors_deallocate_trigger (indio_dev);drivers/iio/pressure/st_pressure_i2c.c +15
-2@@ -98,16 +98,29 @@ static int st_press_i2c_probe(struct i2c_client *client,if (ret <0 )return ret; + ret =st_sensors_power_enable (indio_dev); +if (ret) +return ret; + ret =st_press_common_probe (indio_dev);if (ret <0 ) -return ret; + goto st_press_power_off;return 0 ; + +st_press_power_off: +st_sensors_power_disable (indio_dev); + +return ret; }static int st_press_i2c_remove (struct i2c_client *client) { -st_press_common_remove (i2c_get_clientdata (client)); +struct iio_dev *indio_dev =i2c_get_clientdata (client); + +st_sensors_power_disable (indio_dev); + +st_press_common_remove (indio_dev);return 0 ; }drivers/iio/pressure/st_pressure_spi.c +15
-2@@ -82,16 +82,29 @@ static int st_press_spi_probe(struct spi_device *spi)if (err <0 )return err; + err =st_sensors_power_enable (indio_dev); +if (err) +return err; + err =st_press_common_probe (indio_dev);if (err <0 ) -return err; + goto st_press_power_off;return 0 ; + +st_press_power_off: +st_sensors_power_disable (indio_dev); + +return err; }static int st_press_spi_remove (struct spi_device *spi) { -st_press_common_remove (spi_get_drvdata (spi)); +struct iio_dev *indio_dev =spi_get_drvdata (spi); + +st_sensors_power_disable (indio_dev); + +st_press_common_remove (indio_dev);return 0 ; }
Re: [PATCH v1 4/7] iio: st_sensors: Call st_sensors_power_enable() from bus drivers
Quoted 8 lines · Jonathan Cameron
Quoted 3 lines · On Wed, 14 Apr 2021 22:54:51 +0300 Andy Shevchenko…
In case we would initialize two IIO devices from one physical device, we shouldn't have a clash on regulators. That's why move
st_sensors_power_enable()call from core to bus drivers.Why is this a problem?
You can't have two regulators of the same name on the same device. IIRC the regulator framework produces a good splat for this.
Quoted 6 lines
The two instances would double up and both get +
enable + disable the regulators. However, that shouldn't matter as they are reference counted anyway.Perhaps an example? Even in patch 6 I can only see that it is wasteful to do it twice, rather than wrong as such.
Believe me, I would like to avoid that, but it seems a limitation of the regulator framework. It simply produces a splat. I'll try to reproduce it again (because this series started like a couple of years ago, just eventually I found a time to clean up and submit) and will tell you how it is going.
Signature · 2 lines
With Best Regards, Andy Shevchenko
Re: [PATCH v1 4/7] iio: st_sensors: Call st_sensors_power_enable() from bus drivers
In reply to Jonathan CameronQuoted 8 lines · Jonathan Cameron
Quoted 3 lines · On Wed, 14 Apr 2021 22:54:51 +0300 Andy Shevchenko…
In case we would initialize two IIO devices from one physical device, we shouldn't have a clash on regulators. That's why move
st_sensors_power_enable()call from core to bus drivers.
Quoted 6 lines
Why is this a problem? The two instances would double up and both get + enable + disable the regulators. However, that shouldn't matter as they are reference counted anyway.
Perhaps an example? Even in patch 6 I can only see that it is wasteful to do it twice, rather than wrong as such.
Yep, now I also understand that I do it twice after this patch. But lemme check next week this all
P.S. I have real hardware to test on. But my tests I guess are limited to iio_info or so.
Signature · 2 lines
With Best Regards, Andy Shevchenko
PATCH 5/7 iio: st_sensors: Make accel, gyro, magn and pressure probe shared
In reply to Andy ShevchenkoSome IMUs may utilize existing library code for STMicro accelerometer, gyroscope, magnetometer and pressure. Let's share them via st_sensors.h.
--- drivers/iio/accel/st_accel.h | 4 ---- drivers/iio/gyro/st_gyro.h | 4 ---- drivers/iio/magnetometer/st_magn.h | 4 ---- drivers/iio/pressure/st_pressure.h | 4 ---- include/linux/iio/common/st_sensors.h | 20 ++++++++++++++++++++ 5 files changed, 20 insertions(+), 16 deletions(-)
drivers/iio/accel/st_accel.h +0 -4
@@ -62,10 +62,6 @@ enum st_accel_type {#define LIS2DE12_ACCEL_DEV_NAME "lis2de12"#define LIS2HH12_ACCEL_DEV_NAME "lis2hh12" -const struct st_sensor_settings *st_accel_get_settings (const char *name); -int st_accel_common_probe (struct iio_dev *indio_dev); -void st_accel_common_remove (struct iio_dev *indio_dev); -#ifdef CONFIG_IIO_BUFFER int st_accel_allocate_ring (struct iio_dev *indio_dev);void st_accel_deallocate_ring (struct iio_dev *indio_dev);
drivers/iio/gyro/st_gyro.h +0 -4
@@ -24,10 +24,6 @@#define LSM330_GYRO_DEV_NAME "lsm330_gyro"#define LSM9DS0_GYRO_DEV_NAME "lsm9ds0_gyro" -const struct st_sensor_settings *st_gyro_get_settings (const char *name); -int st_gyro_common_probe (struct iio_dev *indio_dev); -void st_gyro_common_remove (struct iio_dev *indio_dev); -#ifdef CONFIG_IIO_BUFFER int st_gyro_allocate_ring (struct iio_dev *indio_dev);void st_gyro_deallocate_ring (struct iio_dev *indio_dev);
drivers/iio/magnetometer/st_magn.h +0 -4
@@ -22,10 +22,6 @@#define LIS2MDL_MAGN_DEV_NAME "lis2mdl"#define LSM9DS1_MAGN_DEV_NAME "lsm9ds1_magn" -const struct st_sensor_settings *st_magn_get_settings (const char *name); -int st_magn_common_probe (struct iio_dev *indio_dev); -void st_magn_common_remove (struct iio_dev *indio_dev); -#ifdef CONFIG_IIO_BUFFER int st_magn_allocate_ring (struct iio_dev *indio_dev);void st_magn_deallocate_ring (struct iio_dev *indio_dev);
drivers/iio/pressure/st_pressure.h +0 -4
@@ -41,10 +41,6 @@ static __maybe_unused const struct st_sensors_platform_data default_press_pdata .drdy_int_pin = 1, }; -const struct st_sensor_settings *st_press_get_settings (const char *name); -int st_press_common_probe (struct iio_dev *indio_dev); -void st_press_common_remove (struct iio_dev *indio_dev); -#ifdef CONFIG_IIO_BUFFER int st_press_allocate_ring (struct iio_dev *indio_dev);void st_press_deallocate_ring (struct iio_dev *indio_dev);
include/linux/iio/common/st_sensors.h +20 -0
@@ -317,4 +317,24 @@ ssize_t st_sensors_sysfs_scale_avail(struct device *dev,void st_sensors_dev_name_probe (struct device *dev,char *name,int len); +/* Accelerometer */ +const struct st_sensor_settings *st_accel_get_settings (const char *name); +int st_accel_common_probe (struct iio_dev *indio_dev); +void st_accel_common_remove (struct iio_dev *indio_dev); + +/* Gyroscope */ +const struct st_sensor_settings *st_gyro_get_settings (const char *name); +int st_gyro_common_probe (struct iio_dev *indio_dev); +void st_gyro_common_remove (struct iio_dev *indio_dev); + +/* Magnetometer */ +const struct st_sensor_settings *st_magn_get_settings (const char *name); +int st_magn_common_probe (struct iio_dev *indio_dev); +void st_magn_common_remove (struct iio_dev *indio_dev); + +/* Pressure */ +const struct st_sensor_settings *st_press_get_settings (const char *name); +int st_press_common_probe (struct iio_dev *indio_dev); +void st_press_common_remove (struct iio_dev *indio_dev); +#endif /* ST_SENSORS_H */
Signature · 1 line
2.30.2
PATCH 6/7 iio: st_sensors: Add lsm9ds0 IMU support
In reply to Andy ShevchenkoWe can utilize separate drivers for accelerometer and magnetometer, so here is the glue driver to enable LSM9DS0 IMU support.
The idea was suggested by Crestez Dan Leonard in [1]. The proposed change was sent as RFC due to race condition concerns, which are indeed possible.
In order to amend the initial change, I went further by providing a specific multi-instantiate probe driver that reuses existing accelerometer and magnetometer.
[1]: https://lore.kernel.org/patchwork/patch/670353/
--- drivers/iio/accel/st_accel_core.c | 89 +++++++++- drivers/iio/imu/Kconfig | 1 + drivers/iio/imu/Makefile | 1 + drivers/iio/imu/st_lsm9ds0/Kconfig | 28 ++++ drivers/iio/imu/st_lsm9ds0/Makefile | 5 + drivers/iio/imu/st_lsm9ds0/st_lsm9ds0.h | 23 +++ drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_core.c | 163 +++++++++++++++++++ drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_i2c.c | 84 ++++++++++ drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_spi.c | 83 ++++++++++ drivers/iio/magnetometer/st_magn_core.c | 98 +++++++++++ include/linux/iio/common/st_sensors.h | 2 + 11 files changed, 576 insertions(+), 1 deletion(-) create mode 100644 drivers/iio/imu/st_lsm9ds0/Kconfig create mode 100644 drivers/iio/imu/st_lsm9ds0/Makefile create mode 100644 drivers/iio/imu/st_lsm9ds0/st_lsm9ds0.h create mode 100644 drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_core.c create mode 100644 drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_i2c.c create mode 100644 drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_spi.c
drivers/iio/accel/st_accel_core.c +88 -1
@@ -980,7 +980,94 @@ static const struct st_sensor_settings st_accel_sensors_settings[] = { .multi_read_bit = true, .bootime = 2, }, - + { + .wai = 0x49, + .wai_addr = ST_SENSORS_DEFAULT_WAI_ADDRESS, + .sensors_supported = { + [0] = LSM9DS0_IMU_DEV_NAME, + }, + .ch = (struct iio_chan_spec *)st_accel_16bit_channels, + .odr = { + .addr = 0x20, + .mask = GENMASK(7, 4), + .odr_avl = { + { 3, 0x01, }, + { 6, 0x02, }, + { 12, 0x03, }, + { 25, 0x04, }, + { 50, 0x05, }, + { 100, 0x06, }, + { 200, 0x07, }, + { 400, 0x08, }, + { 800, 0x09, }, + { 1600, 0x0a, }, + }, + }, + .pw = { + .addr = 0x20, + .mask = GENMASK(7, 4), + .value_off = ST_SENSORS_DEFAULT_POWER_OFF_VALUE, + }, + .enable_axis = { + .addr = ST_SENSORS_DEFAULT_AXIS_ADDR, + .mask = ST_SENSORS_DEFAULT_AXIS_MASK, + }, + .fs = { + .addr = 0x21, + .mask = GENMASK(5, 3), + .fs_avl = { + [0] = { + .num = ST_ACCEL_FS_AVL_2G, + .value = 0x00, + .gain = IIO_G_TO_M_S_2(61), + }, + [1] = { + .num = ST_ACCEL_FS_AVL_4G, + .value = 0x01, + .gain = IIO_G_TO_M_S_2(122), + }, + [2] = { + .num = ST_ACCEL_FS_AVL_6G, + .value = 0x02, + .gain = IIO_G_TO_M_S_2(183), + }, + [3] = { + .num = ST_ACCEL_FS_AVL_8G, + .value = 0x03, + .gain = IIO_G_TO_M_S_2(244), + }, + [4] = { + .num = ST_ACCEL_FS_AVL_16G, + .value = 0x04, + .gain = IIO_G_TO_M_S_2(732), + }, + }, + }, + .bdu = { + .addr = 0x20, + .mask = BIT(3), + }, + .drdy_irq = { + .int1 = { + .addr = 0x22, + .mask = BIT(2), + }, + .int2 = { + .addr = 0x23, + .mask = BIT(3), + }, + .stat_drdy = { + .addr = ST_SENSORS_DEFAULT_STAT_ADDR, + .mask = GENMASK(2, 0), + }, + }, + .sim = { + .addr = 0x21, + .value = BIT(0), + }, + .multi_read_bit = true, + .bootime = 2, + }, }; /* Default accel DRDY is available on INT1 pin */
drivers/iio/imu/Kconfig +1 -0
@@ -94,6 +94,7 @@ config KMX61 source "drivers/iio/imu/inv_icm42600/Kconfig" source "drivers/iio/imu/inv_mpu6050/Kconfig" source "drivers/iio/imu/st_lsm6dsx/Kconfig" +source "drivers/iio/imu/st_lsm9ds0/Kconfig" endmenu
drivers/iio/imu/Makefile +1 -0
@@ -26,3 +26,4 @@ obj-y += inv_mpu6050/ obj-$(CONFIG_KMX61) += kmx61.o obj-y += st_lsm6dsx/ +obj-y += st_lsm9ds0/
drivers/iio/imu/st_lsm9ds0/Kconfig new file +28 -0
@@ -0,0 +1,28 @@ +# SPDX-License-Identifier: GPL-2.0-only + +config IIO_ST_LSM9DS0 + tristate "STMicroelectronics LSM9DS0 IMU driver" + depends on (I2C || SPI_MASTER) && SYSFS + depends on !SENSORS_LIS3_I2C + depends on !SENSORS_LIS3_SPI + select IIO_ST_LSM9DS0_I2C if I2C + select IIO_ST_LSM9DS0_SPI if SPI_MASTER + select IIO_ST_ACCEL_3AXIS + select IIO_ST_MAGN_3AXIS + + help + Say yes here to build support for STMicroelectronics LSM9DS0 IMU + sensor. Supported devices: accelerometer/magnetometer of lsm9ds0. + + To compile this driver as a module, choose M here: the module + will be called st_lsm9ds0. + +config IIO_ST_LSM9DS0_I2C + tristate + depends on IIO_ST_LSM9DS0 + select REGMAP_I2C + +config IIO_ST_LSM9DS0_SPI + tristate + depends on IIO_ST_LSM9DS0 + select REGMAP_SPI
drivers/iio/imu/st_lsm9ds0/Makefile new file +5 -0
@@ -0,0 +1,5 @@ +# SPDX-License-Identifier: GPL-2.0-only +obj-$(CONFIG_IIO_ST_LSM9DS0) += st_lsm9ds0.o +st_lsm9ds0-y := st_lsm9ds0_core.o +obj-$(CONFIG_IIO_ST_LSM9DS0_I2C) += st_lsm9ds0_i2c.o +obj-$(CONFIG_IIO_ST_LSM9DS0_SPI) += st_lsm9ds0_spi.o
drivers/iio/imu/st_lsm9ds0/st_lsm9ds0.h new file +23 -0
@@ -0,0 +1,23 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +// STMicroelectronics LSM9DS0 IMU driver + +#ifndef ST_LSM9DS0_H +#define ST_LSM9DS0_H + +struct iio_dev ; +struct regulator ; + +struct st_lsm9ds0 { +struct device *dev; +const char *name; +int irq; +struct iio_dev *accel; +struct iio_dev *magn; +struct regulator *vdd; +struct regulator *vdd_io; +}; + +int st_lsm9ds0_probe (struct st_lsm9ds0 *lsm9ds0,struct regmap *regmap); +int st_lsm9ds0_remove (struct st_lsm9ds0 *lsm9ds0); + +#endif /* ST_LSM9DS0_H */
drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_core.c new file +163 -0
163 lines not on this page · raw message
drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_i2c.c new file +84 -0
84 lines not on this page · raw message
drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_spi.c new file +83 -0
83 lines not on this page · raw message
drivers/iio/magnetometer/st_magn_core.c +98 -0
122 lines not on this page · raw message
include/linux/iio/common/st_sensors.h +2 -0
@@ -20,6 +20,8 @@#include <linux/platform_data/st_sensors_pdata.h> +#define LSM9DS0_IMU_DEV_NAME "lsm9ds0" +/* * Buffer size max case: 2bytes per channel, 3 channels in total + * 8bytes timestamp channel (s64)
Signature · 1 line
2.30.2
Jonathan Cameron
maintainerRe: [PATCH v1 6/7] iio: st_sensors: Add lsm9ds0 IMU support
Quoted 5 lines · On Wed, 14 Apr 2021 22:54:53 +0300 Andy Shevchenko…
We can utilize separate drivers for accelerometer and magnetometer, so here is the glue driver to enable LSM9DS0 IMU support.
The idea was suggested by Crestez Dan Leonard in [1]. The proposed change was sent as RFC due to race condition concerns, which are indeed possible.
If you are going to mention races, good to give some flavour in here!
This driver makes me very nervous indeed. I haven't 'found' any places where the fact we'll write the same registers from each of the drivers causes problems (e.g. int pin setup etc) but perhaps I'm missing something.
Shall we say that makes me rather keener to get eyes (and thought) on this patch than normal :)
Quoted 5 lines
In order to amend the initial change, I went further by providing a specific multi-instantiate probe driver that reuses existing accelerometer and magnetometer.
Quoted 7 lines
[1]: https://lore.kernel.org/patchwork/patch/670353/
Suggested-by Crestez Dan Leonard <[email protected]>Cc Matija Podravec <[email protected]>Cc Sergey Borishchenko <[email protected]>Signed-off-by Andy Shevchenko <[email protected]>
A few comments in here, though mostly about stuff related to the origin code you are copying so perhaps not tidying them up is preferable because it would complicate comparison of the two cases.
Quoted 25 lines
--- drivers/iio/accel/st_accel_core.c | 89 +++++++++- drivers/iio/imu/Kconfig | 1 + drivers/iio/imu/Makefile | 1 + drivers/iio/imu/st_lsm9ds0/Kconfig | 28 ++++ drivers/iio/imu/st_lsm9ds0/Makefile | 5 + drivers/iio/imu/st_lsm9ds0/st_lsm9ds0.h | 23 +++ drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_core.c | 163 +++++++++++++++++++ drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_i2c.c | 84 ++++++++++ drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_spi.c | 83 ++++++++++ drivers/iio/magnetometer/st_magn_core.c | 98 +++++++++++ include/linux/iio/common/st_sensors.h | 2 + 11 files changed, 576 insertions(+), 1 deletion(-) create mode 100644 drivers/iio/imu/st_lsm9ds0/Kconfig create mode 100644 drivers/iio/imu/st_lsm9ds0/Makefile create mode 100644 drivers/iio/imu/st_lsm9ds0/st_lsm9ds0.h create mode 100644 drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_core.c create mode 100644 drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_i2c.c create mode 100644 drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_spi.cdrivers/iio/accel/st_accel_core.c +0
-0
drivers/iio/accel/st_accel_core.c static const struct st_sensor_settings st_accel_sensors_settings[] = { · line 987
Quoted 9 lines
drivers/iio/accel/st_accel_core.c +5
-1@@ -980,7 +980,94 @@ static const struct st_sensor_settings st_accel_sensors_settings[] = { .multi_read_bit = true, .bootime = 2, }, - + { + .wai = 0x49, + .wai_addr = ST_SENSORS_DEFAULT_WAI_ADDRESS, + .sensors_supported = { + [0] = LSM9DS0_IMU_DEV_NAME,
What does the name attribute report for these?
Previously we've had the _accel etc postfix to differentiate the devices. I don't suppose it matters to much though as easy enough to identify the accelerometer etc from what channels are present.
Of course driver may get name from somewhere different anyway, I haven't checked, just noticed this was different and wondered what the affect might be.
Quoted 117 lines
drivers/iio/accel/st_accel_core.c +0
-0/* Default accel DRDY is available on INT1 pin */ drivers/iio/imu/Kconfig +1
-0@@ -94,6 +94,7 @@ config KMX61 source "drivers/iio/imu/inv_icm42600/Kconfig" source "drivers/iio/imu/inv_mpu6050/Kconfig" source "drivers/iio/imu/st_lsm6dsx/Kconfig" +source "drivers/iio/imu/st_lsm9ds0/Kconfig" endmenudrivers/iio/imu/Makefile +1
-0@@ -26,3 +26,4 @@ obj-y += inv_mpu6050/ obj-$(CONFIG_KMX61) += kmx61.o obj-y += st_lsm6dsx/ +obj-y += st_lsm9ds0/drivers/iio/imu/st_lsm9ds0/Kconfig new file +28
-0@@ -0,0 +1,28 @@ +# SPDX-License-Identifier: GPL-2.0-only + +config IIO_ST_LSM9DS0 + tristate "STMicroelectronics LSM9DS0 IMU driver" + depends on (I2C || SPI_MASTER) && SYSFS + depends on !SENSORS_LIS3_I2C + depends on !SENSORS_LIS3_SPI + select IIO_ST_LSM9DS0_I2C if I2C + select IIO_ST_LSM9DS0_SPI if SPI_MASTER + select IIO_ST_ACCEL_3AXIS + select IIO_ST_MAGN_3AXIS + + help + Say yes here to build support for STMicroelectronics LSM9DS0 IMU + sensor. Supported devices: accelerometer/magnetometer of lsm9ds0. + + To compile this driver as a module, choose M here: the module + will be called st_lsm9ds0. + +config IIO_ST_LSM9DS0_I2C + tristate + depends on IIO_ST_LSM9DS0 + select REGMAP_I2C + +config IIO_ST_LSM9DS0_SPI + tristate + depends on IIO_ST_LSM9DS0 + select REGMAP_SPIdrivers/iio/imu/st_lsm9ds0/Makefile new file +5
-0@@ -0,0 +1,5 @@ +# SPDX-License-Identifier: GPL-2.0-only +obj-$(CONFIG_IIO_ST_LSM9DS0) += st_lsm9ds0.o +st_lsm9ds0-y := st_lsm9ds0_core.o +obj-$(CONFIG_IIO_ST_LSM9DS0_I2C) += st_lsm9ds0_i2c.o +obj-$(CONFIG_IIO_ST_LSM9DS0_SPI) += st_lsm9ds0_spi.odrivers/iio/imu/st_lsm9ds0/st_lsm9ds0.h new file +23
-0@@ -0,0 +1,23 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +// STMicroelectronics LSM9DS0 IMU driver + +#ifndef ST_LSM9DS0_H +#define ST_LSM9DS0_H + +struct iio_dev ; +struct regulator ; + +struct st_lsm9ds0 { +struct device *dev; +const char *name; +int irq; +struct iio_dev *accel; +struct iio_dev *magn; +struct regulator *vdd; +struct regulator *vdd_io; +}; + +int st_lsm9ds0_probe (struct st_lsm9ds0 *lsm9ds0,struct regmap *regmap); +int st_lsm9ds0_remove (struct st_lsm9ds0 *lsm9ds0); + +#endif /* ST_LSM9DS0_H */ drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_core.c new file +14
-0@@ -0,0 +1,163 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* +* STMicroelectronics LSM9DS0 IMU driver +* +* Copyright (C) 2021, Intel Corporation +* +* Author: Andy Shevchenko <[email protected]> +*/ + +#include <linux/device.h> +#include <linux/err.h> +#include <linux/module.h> +#include <linux/regulator/consumer.h> +
drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_core.c line 24
Quoted 10 lines
drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_core.c new file +10
-0+#include <linux/iio/common/st_sensors.h> +#include <linux/iio/iio.h> + +#include "st_lsm9ds0.h" + +static int st_lsm9ds0_power_enable (struct device *dev,struct st_lsm9ds0 *lsm9ds0) +{ +int ret; + +/* Regulators not mandatory, but if requested we should enable them. */
That's a bit of a missleading comment though cut and paste from the other driver code. Key is that they will be handled by stub regulators if we don't provide the which is not really what that comment implies.
drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_core.c line 32
Quoted 8 lines
drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_core.c new file +8
-0+ lsm9ds0->vdd =devm_regulator_get (dev,"vdd" ); +if (IS_ERR (lsm9ds0->vdd)) { +dev_err (dev,"unable to get Vdd supply\n" ); +return PTR_ERR (lsm9ds0->vdd); + } + ret =regulator_enable (lsm9ds0->vdd); +if (ret) { +dev_warn (dev,"Failed to enable specified Vdd supply\n" );
Given we fail to probe if this is true, dev_warn seems a bit soft.
Quoted 8 lines
drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_core.c new file +8
-0+return ret; + } + + lsm9ds0->vdd_io =devm_regulator_get (dev,"vddio" ); +if (IS_ERR (lsm9ds0->vdd_io)) { +dev_err (dev,"unable to get Vdd_IO supply\n" ); +regulator_disable (lsm9ds0->vdd); +return PTR_ERR (lsm9ds0->vdd_io);
drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_core.c line 50
Quoted 10 lines
drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_core.c new file +10
-0+ } + ret =regulator_enable (lsm9ds0->vdd_io); +if (ret) { +dev_warn (dev,"Failed to enable specified Vdd_IO supply\n" ); +regulator_disable (lsm9ds0->vdd); +return ret; + } + +return 0 ; +}
+
Quoted 202 lines
drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_core.c new file +112
-0+static void st_lsm9ds0_power_disable (void *data) +{ +struct st_lsm9ds0 *lsm9ds0 = data; + +regulator_disable (lsm9ds0->vdd_io); +regulator_disable (lsm9ds0->vdd); +} + +static int devm_st_lsm9ds0_power_enable (struct st_lsm9ds0 *lsm9ds0) +{ +struct device *dev = lsm9ds0->dev; +int ret; + + ret =st_lsm9ds0_power_enable (dev, lsm9ds0); +if (ret) +return ret; + +return devm_add_action_or_reset (dev, st_lsm9ds0_power_disable, lsm9ds0); +} + +static int st_lsm9ds0_probe_accel (struct st_lsm9ds0 *lsm9ds0,struct regmap *regmap) +{ +const struct st_sensor_settings *settings; +struct device *dev = lsm9ds0->dev; +struct st_sensor_data *data; + + settings =st_accel_get_settings (lsm9ds0->name); +if (!settings) { +dev_err (dev,"device name %s not recognized.\n" , lsm9ds0->name); +return -ENODEV ; + } + + lsm9ds0->accel =devm_iio_device_alloc (dev,sizeof (*data)); +if (!lsm9ds0->accel) +return -ENOMEM ; + + lsm9ds0->accel->name = lsm9ds0->name; + + data =iio_priv (lsm9ds0->accel); + data->sensor_settings = (struct st_sensor_settings *)settings; + data->dev = dev; + data->irq = lsm9ds0->irq; + data->regmap = regmap; + data->vdd = lsm9ds0->vdd; + data->vdd_io = lsm9ds0->vdd_io; + +return st_accel_common_probe (lsm9ds0->accel); +} + +static int st_lsm9ds0_probe_magn (struct st_lsm9ds0 *lsm9ds0,struct regmap *regmap) +{ +const struct st_sensor_settings *settings; +struct device *dev = lsm9ds0->dev; +struct st_sensor_data *data; + + settings =st_magn_get_settings (lsm9ds0->name); +if (!settings) { +dev_err (dev,"device name %s not recognized.\n" , lsm9ds0->name); +return -ENODEV ; + } + + lsm9ds0->magn =devm_iio_device_alloc (dev,sizeof (*data)); +if (!lsm9ds0->magn) +return -ENOMEM ; + + lsm9ds0->magn->name = lsm9ds0->name; + + data =iio_priv (lsm9ds0->magn); + data->sensor_settings = (struct st_sensor_settings *)settings; + data->dev = dev; + data->irq = lsm9ds0->irq; + data->regmap = regmap; + data->vdd = lsm9ds0->vdd; + data->vdd_io = lsm9ds0->vdd_io; + +return st_magn_common_probe (lsm9ds0->magn); +} + +int st_lsm9ds0_probe (struct st_lsm9ds0 *lsm9ds0,struct regmap *regmap) +{ +int ret; + + ret =devm_st_lsm9ds0_power_enable (lsm9ds0); +if (ret) +return ret; + +/* Setup accelerometer device */ + ret =st_lsm9ds0_probe_accel (lsm9ds0, regmap); +if (ret) +return ret; + +/* Setup magnetometer device */ + ret =st_lsm9ds0_probe_magn (lsm9ds0, regmap); +if (ret) +st_accel_common_remove (lsm9ds0->accel); + +return ret; +} +EXPORT_SYMBOL_GPL (st_lsm9ds0_probe); + +int st_lsm9ds0_remove (struct st_lsm9ds0 *lsm9ds0) +{ +st_magn_common_remove (lsm9ds0->magn); +st_accel_common_remove (lsm9ds0->accel); + +return 0 ; +} +EXPORT_SYMBOL_GPL (st_lsm9ds0_remove); + +MODULE_AUTHOR ("Andy Shevchenko <[email protected]>" ); +MODULE_DESCRIPTION ("STMicroelectronics LSM9DS0 IMU core driver" ); +MODULE_LICENSE ("GPL v2" );drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_i2c.c new file +84
-0@@ -0,0 +1,84 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* +* STMicroelectronics LSM9DS0 IMU driver +* +* Copyright (C) 2021, Intel Corporation +* +* Author: Andy Shevchenko <[email protected]> +*/ + +#include <linux/i2c.h> +#include <linux/kernel.h> +#include <linux/module.h> +#include <linux/slab.h> + +#include <linux/iio/common/st_sensors_i2c.h> + +#include "st_lsm9ds0.h" + +static const struct of_device_id st_lsm9ds0_of_match[] = { + { + .compatible ="st,lsm9ds0-imu" , + .data =LSM9DS0_IMU_DEV_NAME , + }, + {} +}; +MODULE_DEVICE_TABLE (of, st_lsm9ds0_of_match); + +static const struct i2c_device_id st_lsm9ds0_id_table[] = { + {LSM9DS0_IMU_DEV_NAME }, + {} +}; +MODULE_DEVICE_TABLE (i2c, st_lsm9ds0_id_table); + +static const struct regmap_config st_lsm9ds0_regmap_config = { + .reg_bits =8 , + .val_bits =8 , + .read_flag_mask =0x80 , +}; + +static int st_lsm9ds0_i2c_probe (struct i2c_client *client) +{ +const struct regmap_config *config = &st_lsm9ds0_regmap_config; +struct device *dev = &client->dev; +struct st_lsm9ds0 *lsm9ds0; +struct regmap *regmap; + +st_sensors_dev_name_probe (dev, client->name,sizeof (client->name)); + + lsm9ds0 =devm_kzalloc (dev,sizeof (*lsm9ds0),GFP_KERNEL ); +if (!lsm9ds0) +return -ENOMEM ; + + lsm9ds0->dev = dev; + lsm9ds0->name = client->name; + lsm9ds0->irq = client->irq; + + regmap =devm_regmap_init_i2c (client, config); +if (IS_ERR (regmap)) +return PTR_ERR (regmap); + +i2c_set_clientdata (client, lsm9ds0); + +return st_lsm9ds0_probe (lsm9ds0, regmap); +} + +static int st_lsm9ds0_i2c_remove (struct i2c_client *client) +{ +return st_lsm9ds0_remove (i2c_get_clientdata (client)); +} + +static struct i2c_driver st_lsm9ds0_driver = { + .driver = { + .name ="st-lsm9ds0-i2c" , + .of_match_table = st_lsm9ds0_of_match, + }, + .probe_new = st_lsm9ds0_i2c_probe, + .remove = st_lsm9ds0_i2c_remove, + .id_table = st_lsm9ds0_id_table, +}; +module_i2c_driver (st_lsm9ds0_driver); + +MODULE_AUTHOR ("Andy Shevchenko <[email protected]>" ); +MODULE_DESCRIPTION ("STMicroelectronics LSM9DS0 IMU I2C driver" ); +MODULE_LICENSE ("GPL v2" );
Re: [PATCH v1 6/7] iio: st_sensors: Add lsm9ds0 IMU support
On Sun, Apr 18, 2021 at 2:07 PM Jonathan Cameron <[email protected]> wrote:
Thanks for review, my answers below.
Quoted 10 lines
Quoted 5 lines · On Wed, 14 Apr 2021 22:54:53 +0300 Andy Shevchenko…
We can utilize separate drivers for accelerometer and magnetometer, so here is the glue driver to enable LSM9DS0 IMU support.
The idea was suggested by Crestez Dan Leonard in [1]. The proposed change was sent as RFC due to race condition concerns, which are indeed possible.
If you are going to mention races, good to give some flavour in here!
I meant that the initial idea is racy due to different devices communicating to the same i2c address.
So, any sequence of transfers are not serialized and you may end up with
drv1 -> i2c
drv2 -> i2c
drv1 <- i2c # garbage
Quoted 1 line
This driver makes me very nervous indeed.
Why?! This one is race free as far as I can see. Or maybe I interpret this wrongly and you are talking about initial RFC?
Quoted 6 lines
I haven't 'found' any places
where the fact we'll write the same registers from each of the drivers causes problems (e.g. int pin setup etc) but perhaps I'm missing something.Shall we say that makes me rather keener to get eyes (and thought) on this patch than normal :)
How should I amend the commit message to state:
1. First idea (RFC by the link) *is* racy AFAIU
2. This one *is not* racy.
Quoted 1 line
Quoted 1 line
In order to amend the initial change,
You see, *in order to amend*, so here is the *amended* version.
Quoted 15 lines
I went further by providing a specific
Quoted 10 lines
multi-instantiate probe driver that reuses existing accelerometer and magnetometer.
[1]: https://lore.kernel.org/patchwork/patch/670353/
Suggested-by Crestez Dan Leonard <[email protected]>Cc Matija Podravec <[email protected]>Cc Sergey Borishchenko <[email protected]>Signed-off-by Andy Shevchenko <[email protected]>A few comments in here, though mostly about stuff related to the origin code you are copying so perhaps not tidying them up is preferable because it would complicate comparison of the two cases.
...
Quoted 6 lines
drivers/iio/accel/st_accel_core.c static const struct st_sensor_settings st_accel_sensors_settings[] = { · line 987
Quoted 5 lines
drivers/iio/accel/st_accel_core.c +5
-0+ { + .wai = 0x49, + .wai_addr = ST_SENSORS_DEFAULT_WAI_ADDRESS, + .sensors_supported = { + [0] = LSM9DS0_IMU_DEV_NAME,
Quoted 8 lines
What does the name attribute report for these?
Previously we've had the
_acceletc postfix to differentiate the devices. I don't suppose it matters to much though as easy enough to identify the accelerometer etc from what channels are present.Of course driver may get name from somewhere different anyway, I haven't checked, just noticed this was different and wondered what the affect might be.
Yes, it has a postfix, that's why I leave it like this.
...
Quoted 9 lines
drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_core.c line 24
Quoted 5 lines
drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_core.c new file +5
-0+static int st_lsm9ds0_power_enable (struct device *dev,struct st_lsm9ds0 *lsm9ds0) +{ +int ret; + +/* Regulators not mandatory, but if requested we should enable them. */ That's a bit of a missleading comment though cut and paste from the other driver code. Key is that they will be handled by stub regulators if we don't provide the which is not really what that comment implies.
I see. I will remove it.
Quoted 10 lines
drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_core.c line 32
Quoted 8 lines
drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_core.c new file +8
-0+ lsm9ds0->vdd =devm_regulator_get (dev,"vdd" ); +if (IS_ERR (lsm9ds0->vdd)) { +dev_err (dev,"unable to get Vdd supply\n" ); +return PTR_ERR (lsm9ds0->vdd); + } + ret =regulator_enable (lsm9ds0->vdd); +if (ret) { +dev_warn (dev,"Failed to enable specified Vdd supply\n" );Given we fail to probe if this is true,
dev_warnseems a bit soft.
Right. I'll move to dev_err().
Quoted 4 lines
Quoted 4 lines
drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_core.c new file +4
-0+return ret; + } + + lsm9ds0->vdd_io =devm_regulator_get (dev,"vddio" );
Quoted 8 lines
drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_core.c line 44
Quoted 8 lines
drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_core.c new file +8
-0+if (IS_ERR (lsm9ds0->vdd_io)) { +dev_err (dev,"unable to get Vdd_IO supply\n" ); +regulator_disable (lsm9ds0->vdd); +return PTR_ERR (lsm9ds0->vdd_io); + } + ret =regulator_enable (lsm9ds0->vdd_io); +if (ret) { +dev_warn (dev,"Failed to enable specified Vdd_IO supply\n" );
Ditto.
Quoted 6 lines
Quoted 6 lines
drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_core.c new file +6
-0+regulator_disable (lsm9ds0->vdd); +return ret; + } + +return 0 ; +}
Signature · 2 lines
With Best Regards, Andy Shevchenko
Re: [PATCH v1 6/7] iio: st_sensors: Add lsm9ds0 IMU support
Quoted 33 lines · Andy Shevchenko
On Sun, Apr 18, 2021 at 2:07 PM Jonathan Cameron <[email protected]> wrote:
Thanks for review, my answers below.
Quoted 10 lines
Quoted 5 lines · On Wed, 14 Apr 2021 22:54:53 +0300 Andy Shevchenko…
We can utilize separate drivers for accelerometer and magnetometer, so here is the glue driver to enable LSM9DS0 IMU support.
The idea was suggested by Crestez Dan Leonard in [1]. The proposed change was sent as RFC due to race condition concerns, which are indeed possible.
If you are going to mention races, good to give some flavour in here!
I meant that the initial idea is racy due to different devices communicating to the same i2c address.
So, any sequence of transfers are not serialized and you may end up withdrv1 -> i2c
drv2 -> i2c
drv1 <- i2c # garbageQuoted 1 line
This driver makes me very nervous indeed.
Why?! This one is race free as far as I can see. Or maybe I interpret this wrongly and you are talking about initial RFC?
Quoted 4 lines
I haven't 'found' any places
where the fact we'll write the same registers from each of the drivers causes problems (e.g. int pin setup etc) but perhaps I'm missing something.
Quoted 6 lines
Quoted 2 lines
Shall we say that makes me rather keener to get eyes (and thought) on this patch than normal :)
How should I amend the commit message to state:
1. First idea (RFC by the link) *is* racy AFAIU
2. This one *is not* racy.
I re-read this and now understand better what you meant.
So, it may be that the initial proposal may work without any amendment, but since I haven't investigated much, I should rather use the phrase "potentially racy". In my variant it's using one regmap for both drivers (not two), which makes the register state consistent. Am I wrong?
Do we have some places where we may write to the same register concurrently?
Signature · 2 lines
With Best Regards, Andy Shevchenko
Jonathan Cameron
maintainerRe: [PATCH v1 6/7] iio: st_sensors: Add lsm9ds0 IMU support
Quoted 35 lines · On Sun, 18 Apr 2021 16:59:02 +0300 Andy Shevchenko <[email protected]>…
Quoted 33 lines · Andy Shevchenko
On Sun, Apr 18, 2021 at 2:07 PM Jonathan Cameron <[email protected]> wrote:
Thanks for review, my answers below.
Quoted 10 lines
Quoted 5 lines · On Wed, 14 Apr 2021 22:54:53 +0300 Andy Shevchenko…
We can utilize separate drivers for accelerometer and magnetometer, so here is the glue driver to enable LSM9DS0 IMU support.
The idea was suggested by Crestez Dan Leonard in [1]. The proposed change was sent as RFC due to race condition concerns, which are indeed possible.
If you are going to mention races, good to give some flavour in here!
I meant that the initial idea is racy due to different devices communicating to the same i2c address.
So, any sequence of transfers are not serialized and you may end up withdrv1 -> i2c
drv2 -> i2c
drv1 <- i2c # garbageQuoted 1 line
This driver makes me very nervous indeed.
Why?! This one is race free as far as I can see. Or maybe I interpret this wrongly and you are talking about initial RFC?
Quoted 4 lines
I haven't 'found' any places
where the fact we'll write the same registers from each of the drivers causes problems (e.g. int pin setup etc) but perhaps I'm missing something.
Quoted 6 lines
Quoted 6 lines
Quoted 2 lines
Shall we say that makes me rather keener to get eyes (and thought) on this patch than normal :)
How should I amend the commit message to state:
1. First idea (RFC by the link) *is* racy AFAIU
2. This one *is not* racy.
Great. I read it as meaning they were both potentially racey! This is less worrying.
Quoted 7 lines
I re-read this and now understand better what you meant. So, it may be that the initial proposal may work without any amendment, but since I haven't investigated much, I should rather use the phrase "potentially racy". In my variant it's using one regmap for both drivers (not two), which makes the register state consistent. Am I wrong?
I think this approach is fine. I'd be more worried about the two 'sub' drivers not necessarily being happy that someone else touches state they care about. There are places where I think we write the same value to the same register
twice during setup with this model, but that shouldn't matter. I'm not 100%
sure that there aren't other cases though I think there aren't.
So what you have is probably fine, but more eyes would make me happier ;)
Lots of people care about this particular driver so hopefully we'll get them.
Quoted 2 lines
Do we have some places where we may write to the same register concurrently?
Only ones I can find are the setup ones where it writes the same value twice I think. So *crosses fingers* :)
Given timing (missed merge window) we have masses of time to let this sit on list a while and see if anyone can spot issues neither of us have found.
Jonathan
PATCH 7/7 dt-bindings: iio: st,st-sensors: Add LSM9DS0 compatible string
In reply to Andy ShevchenkoEnumerate LSM9DS0 (accelerometer and magnetometer parts) via 'st,lsm9ds0-imu' compatible string.
--- Documentation/devicetree/bindings/iio/st,st-sensors.yaml | 2 ++ 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/iio/st,st-sensors.yaml +2 -0
@@ -74,6 +74,8 @@ properties: - st,lps33hw - st,lps35hw - st,lps22hh + # IMU + - st,lsm9ds0-imu reg: maxItems: 1
Signature · 1 line
2.30.2
Re: [PATCH v1 7/7] dt-bindings: iio: st,st-sensors: Add LSM9DS0 compatible string
Quoted 8 lines · Andy Shevchenko
Enumerate LSM9DS0 (accelerometer and magnetometer parts) via 'st,lsm9ds0-imu' compatible string.
Signed-off-by Andy Shevchenko <[email protected]>--- Documentation/devicetree/bindings/iio/st,st-sensors.yaml | 2 ++ 1 file changed, 2 insertions(+)
Jonathan Cameron
maintainerRe: [PATCH v1 7/7] dt-bindings: iio: st,st-sensors: Add LSM9DS0 compatible string
In reply to Andy ShevchenkoQuoted 4 lines · On Wed, 14 Apr 2021 22:54:54 +0300 Andy Shevchenko…
Enumerate LSM9DS0 (accelerometer and magnetometer parts) via 'st,lsm9ds0-imu' compatible string.
Signed-off-by Andy Shevchenko <[email protected]>
This one crossed with a cleanup set from Linus so I've adjusted it to match the new style of that file.
Series applied to togreg branch of iio.git and pushed out as testing for the autobuilders to see if we missed anything.
Thanks,
Jonathan
Quoted 17 lines
--- Documentation/devicetree/bindings/iio/st,st-sensors.yaml | 2 ++ 1 file changed, 2 insertions(+)Documentation/devicetree/bindings/iio/st,st-sensors.yaml +2
-0@@ -74,6 +74,8 @@ properties: - st,lps33hw - st,lps35hw - st,lps22hh + # IMU + - st,lsm9ds0-imu reg: maxItems: 1