Skip to contentSkip to conversation

dt-bindings: Add doc for FriendlyARM NanoPi R4S

PATCH Applied Tianling Shen 3 participants 8 messages Mar 19, 2021 – Apr 26, 2021

Subsystems (2)
Device tree bindings Arm Rockchip
lore
Share & tools
lore

Tianling Shen

author
#0 lore raw

PATCH v6 1/2 dt-bindings: Add doc for FriendlyARM NanoPi R4S

Add devicetree binding documentation for the FriendlyARM NanoPi R4S.

Changes in v6:
- Fixed format of LED nodes

Changes in v5:
- Dropped the empty PCIe node
- Dropped useless /delete-property/
- Renamed LED nodes

Changes in v4:
- Correctly dropped display-subsystem node
- Dropped meaningless pwm-fan node
- Dropped wrong sdmmc node
- Disabled i2c4 and uart0 as they don't exist in the design
- Format fixes

Changes in v3:
- Dropped non-existent node display_subsystem

Changes in v2:
- Disable display for NanoPi R4S (reference commit: 74532de460ec)
- Light "sys" LED on NanoPi R4S (reference commit: 833821eeab91)

Signed-off-by Tianling Shen <[email protected]>
---
 Documentation/devicetree/bindings/arm/rockchip.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/arm/rockchip.yaml +1 -0
index c3036f95c7bc..4a6f772c1043 100644
@@ -134,6 +134,7 @@ properties:
               - friendlyarm,nanopi-m4
               - friendlyarm,nanopi-m4b
               - friendlyarm,nanopi-neo4
+              - friendlyarm,nanopi-r4s
           - const: rockchip,rk3399
 
       - description: GeekBuying GeekBox
Signature · 7 lines
2.17.1


_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip
author
#1 lore raw

PATCH v6 2/2 rockchip: rk3399: Add support for FriendlyARM NanoPi R4S

This adds support for the NanoPi R4S from FriendlyArm.

Rockchip RK3399 SoC
1GB DDR3 or 4GB LPDDR4 RAM
Gigabit Ethernet (WAN)
Gigabit Ethernet (PCIe) (LAN)
USB 3.0 Port x 2
MicroSD slot
Reset button
WAN - LAN - SYS LED

[initial DTS file]
Co-developed-by Jensen Huang <[email protected]>
Signed-off-by Jensen Huang <[email protected]>
[minor adjustments]
Co-developed-by Marty Jones <[email protected]>
Signed-off-by Marty Jones <[email protected]>
[further adjustments, fixed format issues]
Signed-off-by Tianling Shen <[email protected]>
---
 arch/arm64/boot/dts/rockchip/Makefile         |   1 +
 .../boot/dts/rockchip/rk3399-nanopi-r4s.dts   | 133 ++++++++++++++++++
 2 files changed, 134 insertions(+)
 create mode 100644 arch/arm64/boot/dts/rockchip/rk3399-nanopi-r4s.dts
arch/arm64/boot/dts/rockchip/Makefile +1 -0
index 62d3abc17a24..c3e00c0e2db7 100644
@@ -36,6 +36,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-nanopc-t4.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-nanopi-m4.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-nanopi-m4b.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-nanopi-neo4.dtb
+dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-nanopi-r4s.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-orangepi.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-pinebook-pro.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-puma-haikou.dtb
arch/arm64/boot/dts/rockchip/rk3399-nanopi-r4s.dts new file +133 -0

133 lines not on this page · raw message

Signature · 7 lines
2.17.1


_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip
maintainer Acked-by Rob Herring on v6 1/2
#2 lore raw
In reply to Tianling Shen

Hi,

Am Freitag, 19. März 2021, 06:16:26 CET schrieb Tianling Shen:

Quoted 17 lines

Add devicetree binding documentation for the FriendlyARM NanoPi R4S.

Changes in v6:
- Fixed format of LED nodes

Changes in v5:
- Dropped the empty PCIe node
- Dropped useless /delete-property/
- Renamed LED nodes

Changes in v4:
- Correctly dropped display-subsystem node
- Dropped meaningless pwm-fan node
- Dropped wrong sdmmc node
- Disabled i2c4 and uart0 as they don't exist in the design
- Format fixes

Quoted 8 lines

Changes in v3:
- Dropped non-existent node display_subsystem

Changes in v2:
- Disable display for NanoPi R4S (reference commit: 74532de460ec)
- Light "sys" LED on NanoPi R4S (reference commit: 833821eeab91)

Signed-off-by Tianling Shen <[email protected]>

In v4 you received a

Acked-by Rob Herring <[email protected]>

Please pick these up and carry them over into new versions of your patchset. Otherwise Rob would needlessly review things multiple times.

Heiko

Quoted 10 lines
---
 Documentation/devicetree/bindings/arm/rockchip.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/arm/rockchip.yaml +0 -0
index c3036f95c7bc..4a6f772c1043 100644

Documentation/devicetree/bindings/arm/rockchip.yaml properties: · line 140

Quoted 7 lines
Documentation/devicetree/bindings/arm/rockchip.yaml +1 -0
@@ -134,6 +134,7 @@ properties:
               - friendlyarm,nanopi-m4
               - friendlyarm,nanopi-m4b
               - friendlyarm,nanopi-neo4
+              - friendlyarm,nanopi-r4s
           - const: rockchip,rk3399
 
       - description: GeekBuying GeekBox

_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip

maintainer Applied
#3 lore raw
In reply to Tianling Shen
Quoted 11 lines · Tianling Shen

Add devicetree binding documentation for the FriendlyARM NanoPi R4S.

Changes in v6:
- Fixed format of LED nodes

Changes in v5:
- Dropped the empty PCIe node
- Dropped useless /delete-property/
- Renamed LED nodes

[...]

Applied, thanks!

[1/2] dt-bindings: Add doc for FriendlyARM NanoPi R4S

      commit: 1003888415e83e15ddb63d1d96189b4f2c5f1d48
[2/2] rockchip: rk3399: Add support for FriendlyARM NanoPi R4S
      commit: db792e9adbf85ffc9d6b0b060ac3c8e3148c8992

Best regards,

Signature · 6 lines
Heiko Stuebner <[email protected]>

_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip
#4 lore raw

Hi!

Quoted 8 lines
Quoted 8 lines

Changes in v6:
- Fixed format of LED nodes

Changes in v5:
- Dropped the empty PCIe node
- Dropped useless /delete-property/
- Renamed LED nodes

Quoted 8 lines
Quoted 1 line

[...]

Applied, thanks!

[1/2] dt-bindings: Add doc for FriendlyARM NanoPi R4S

      commit: 1003888415e83e15ddb63d1d96189b4f2c5f1d48
[2/2] rockchip: rk3399: Add support for FriendlyARM NanoPi R4S
      commit: db792e9adbf85ffc9d6b0b060ac3c8e3148c8992

Sorry for late review, but:

+ label = "red:sys";

This should be red:power based on the discussion in earlier threads.

Thanks,
Pavel

Signature · 1 line
http://www.livejournal.com/~pavelmachek
author
#5 lore raw

Hi Pavel,

Quoted 20 lines · Pavel Machek

Hi!

Quoted 8 lines
Quoted 8 lines

Changes in v6:
- Fixed format of LED nodes

Changes in v5:
- Dropped the empty PCIe node
- Dropped useless /delete-property/
- Renamed LED nodes

Quoted 8 lines
Quoted 1 line

[...]

Applied, thanks!

[1/2] dt-bindings: Add doc for FriendlyARM NanoPi R4S

      commit: 1003888415e83e15ddb63d1d96189b4f2c5f1d48
[2/2] rockchip: rk3399: Add support for FriendlyARM NanoPi R4S
      commit: db792e9adbf85ffc9d6b0b060ac3c8e3148c8992
Quoted 6 lines

Sorry for late review, but:

+ label = "red:sys";

This should be red:power based on the discussion in earlier threads.

However based on the introduction from FriendlyELEC[1], this is not the "power" lamp...
"LEDs: 1 x power LED and 3 x GPIO Controlled LED (SYS, LAN, WAN)"

1. https://wiki.friendlyarm.com/wiki/index.php/NanoPi_R4S#Hardware_Spec

Thanks,
Tianling.

Quoted 5 lines

Thanks,
Pavel
--
http://www.livejournal.com/~pavelmachek

#6 lore raw

Hi!

Quoted 19 lines
Quoted 19 lines
Quoted 7 lines
Quoted 7 lines

- Fixed format of LED nodes

Changes in v5:
- Dropped the empty PCIe node
- Dropped useless /delete-property/
- Renamed LED nodes

Quoted 8 lines
Quoted 1 line

[...]

Applied, thanks!

[1/2] dt-bindings: Add doc for FriendlyARM NanoPi R4S

      commit: 1003888415e83e15ddb63d1d96189b4f2c5f1d48
[2/2] rockchip: rk3399: Add support for FriendlyARM NanoPi R4S
      commit: db792e9adbf85ffc9d6b0b060ac3c8e3148c8992

Sorry for late review, but:

Quoted 7 lines
Quoted 3 lines

+ label = "red:sys";

This should be red:power based on the discussion in earlier threads.

However based on the introduction from FriendlyELEC[1], this is not the "power" lamp...
"LEDs: 1 x power LED and 3 x GPIO Controlled LED (SYS, LAN, WAN)"

It is always on, and "sys" is not a valid function.

I'd suggest labeling it as "red:power". Feel free to make other suggestion but lets keep existing functions.
Pavel

Signature · 1 line
http://www.livejournal.com/~pavelmachek
author
#7 lore raw

Hi,

Quoted 25 lines · Pavel Machek

Hi!

Quoted 23 lines
Quoted 22 lines
Quoted 7 lines
Quoted 7 lines

- Fixed format of LED nodes

Changes in v5:
- Dropped the empty PCIe node
- Dropped useless /delete-property/
- Renamed LED nodes

Quoted 8 lines
Quoted 1 line

[...]

Applied, thanks!

[1/2] dt-bindings: Add doc for FriendlyARM NanoPi R4S

      commit: 1003888415e83e15ddb63d1d96189b4f2c5f1d48
[2/2] rockchip: rk3399: Add support for FriendlyARM NanoPi R4S
      commit: db792e9adbf85ffc9d6b0b060ac3c8e3148c8992

Sorry for late review, but:

+ label = "red:sys";

This should be red:power based on the discussion in earlier threads.

Quoted 8 lines
Quoted 3 lines

However based on the introduction from FriendlyELEC[1], this is not the "power" lamp...
"LEDs: 1 x power LED and 3 x GPIO Controlled LED (SYS, LAN, WAN)"

It is always on, and "sys" is not a valid function.

I'd suggest labeling it as "red:power". Feel free to make other suggestion but lets keep existing functions.

I see, thank you very much!
I'll submit a patch later.

Thanks,
Tianling.

Quoted 3 lines

Pavel
--
http://www.livejournal.com/~pavelmachek