io_uring: Fix uninitialized variable up.resv
Subsystems (3)
PATCH v2 1/1 io_uring: Fix uninitialized variable up.resv
From: Colin Ian King <[email protected]>
The variable up.resv is not initialized and is being checking for a non-zero value in the call to _io_register_rsrc_update. Fix this by explicitly setting up.resv to 0.
Addresses-Coverity: ("Uninitialized scalar variable)"
---
V2: replace "pointer" in commit message with "up.resv"
--- fs/io_uring.c | 1 + 1 file changed, 1 insertion(+)
fs/io_uring.c +1 -0
@@ -5842,6 +5842,7 @@ static int io_files_update(struct io_kiocb *req, unsigned int issue_flags) up.data = req->rsrc_update.arg; up.nr =0 ; up.tags =0 ; + up.resv =0 ;mutex_lock (&ctx->uring_lock); ret = __io_register_rsrc_update(ctx, IORING_RSRC_FILE,
Signature · 1 line
2.30.2
why not:
struct io_uring_rsrc_update up={0};
would be future proof :)
jm2c,
re,
wh
________________________________________
Von: Colin King <[email protected]>
Gesendet: Montag, 26. April 2021 12:13:53
An: Jens Axboe; Pavel Begunkov; [email protected]
Cc: [email protected]; [email protected]
Betreff: [PATCH][next][V2] io_uring: Fix uninitialized variable up.resv
WARNUNG: Diese E-Mail kam von außerhalb der Organisation. Klicken Sie nicht auf Links oder öffnen Sie keine Anhänge, es sei denn, Sie kennen den/die Absender*in und wissen, dass der Inhalt sicher ist.
From: Colin Ian King <[email protected]>
The variable up.resv is not initialized and is being checking for a non-zero value in the call to _io_register_rsrc_update. Fix this by explicitly setting up.resv to 0.
Addresses-Coverity: ("Uninitialized scalar variable)"
---
V2: replace "pointer" in commit message with "up.resv"
--- fs/io_uring.c | 1 + 1 file changed, 1 insertion(+)
fs/io_uring.c +1 -0
@@ -5842,6 +5842,7 @@ static int io_files_update(struct io_kiocb *req, unsigned int issue_flags) up.data = req->rsrc_update.arg; up.nr =0 ; up.tags =0 ; + up.resv =0 ;mutex_lock (&ctx->uring_lock); ret = __io_register_rsrc_update(ctx, IORING_RSRC_FILE,
--
2.30.2