staging: wlan-ng: silence incorrect type in argument 1 (different address spaces)
PATCH v2 1/1 staging: wlan-ng: silence incorrect type in argument 1 (different address spaces)
Corrected data type for variable data adding __user to make it cleaner and silence the Sparse warning. This is version 2 of patch, version 1 can be found at https://lore.kernel.org/linux-staging/20210420090142.GA4086@ashish-NUC8i5BEH/
---
Changes from v1: removed type casting of (void __user *) for req->data and corrected type for data to include __user
--- drivers/staging/wlan-ng/p80211ioctl.h | 2 +- drivers/staging/wlan-ng/p80211netdev.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)
drivers/staging/wlan-ng/p80211ioctl.h +1 -1
@@ -81,7 +81,7 @@struct p80211ioctl_req {char name[WLAN_DEVNAMELEN_MAX ]; -caddr_t data; +char __user *data;u32 magic;u16 len;u32 result;
drivers/staging/wlan-ng/p80211netdev.c +2 -2
@@ -569,7 +569,7 @@ static int p80211knetdev_do_ioctl(struct net_device *dev, goto bail; } - msgbuf =memdup_user ((void __user *)req->data, req->len); + msgbuf =memdup_user (req->data, req->len);if (IS_ERR (msgbuf)) { result =PTR_ERR (msgbuf); goto bail;
@@ -579,7 +579,7 @@ static int p80211knetdev_do_ioctl(struct net_device *dev,if (result ==0 ) {if (copy_to_user - ((void __user *)req->data, msgbuf, req->len)) { + (req->data, msgbuf, req->len)) { result = -EFAULT ; } }
Signature · 1 line
2.25.1
Greg Kroah-Hartman
maintainerQuoted 6 lines · Ashish Kalra
Corrected data type for variable data adding
__userto make it cleaner and silence the Sparse warning. This is version 2 of patch, version 1 can be found at https://lore.kernel.org/linux-staging/20210420090142.GA4086@ashish-NUC8i5BEH/Signed-off-by Ashish Kalra <[email protected]>---
Changes from v1: removed type casting of (void
__user*) forreq->dataand corrected type for data to include__user
Did you send this twice?
And please wrap your changelog text and put proper information in it, not references to previous patches.
thanks,
greg k-h
Quoted 8 lines · Greg Kroah-Hartman
Quoted 6 lines · Ashish Kalra
Corrected data type for variable data adding
__userto make it cleaner and silence the Sparse warning. This is version 2 of patch, version 1 can be found at https://lore.kernel.org/linux-staging/20210420090142.GA4086@ashish-NUC8i5BEH/Signed-off-by Ashish Kalra <[email protected]>---
Changes from v1: removed type casting of (void
__user*) forreq->dataand corrected type for data to include__user
Quoted 8 lines
Did you send this twice?
And please wrap your changelog text and put proper information in it, not references to previous patches.
thanks,
greg k-h
Thanks Greg
Sorry for sending twice due to some issue in To list I have corrected and send again as per your inputs hopefully it will be ok now