Skip to contentSkip to conversation

arm64: meson: select COMMON_CLK

PATCH RESEND Applied Jerome Brunet 5 participants 6 messages Apr 29, 2021 – Jun 8, 2021

Subsystems (2)
lore
Share & tools
lore

Jerome Brunet

author reviewer
#0 lore raw

PATCH RESEND 1/1 arm64: meson: select COMMON_CLK

This fix the recent removal of clock drivers selection.
While it is not necessary to select the clock drivers themselves, we need to select a proper implementation of the clock API, which for the meson, is CCF

Fixes ba66a25536dd ("arm64: meson: ship only the necessary clock controllers")
---
 arch/arm64/Kconfig.platforms | 1 +
 1 file changed, 1 insertion(+)
arch/arm64/Kconfig.platforms +1 -0
index cdfd5fed457f..a3fdffcd1ce8 100644
@@ -168,6 +168,7 @@ config ARCH_MEDIATEK
 
 config ARCH_MESON
 	bool "Amlogic Platforms"
+	select COMMON_CLK
 	select MESON_IRQ_GPIO
 	help
 	  This enables support for the arm64 based Amlogic SoCs
Signature · 1 line
2.31.1
reviewer Reviewed-by on v1 1/1
#1 lore raw
Quoted 9 lines · Jerome Brunet

This fix the recent removal of clock drivers selection.
While it is not necessary to select the clock drivers themselves, we need to select a proper implementation of the clock API, which for the meson, is CCF

Fixes ba66a25536dd ("arm64: meson: ship only the necessary clock controllers")

note to self: ARCH_MULTIPLATFORM for the 32-bit SoCs also selects this

maintainer Applied
#2 lore raw
In reply to Jerome Brunet
Quoted 4 lines · Jerome Brunet

This fix the recent removal of clock drivers selection.
While it is not necessary to select the clock drivers themselves, we need to select a proper implementation of the clock API, which for the meson, is CCF

Applied, thanks!

[1/1] arm64: meson: select COMMON_CLK

      commit: aea7a80ad5effd48f44a7a08c3903168be038a43

Best regards,

Signature · 1 line
Kevin Hilman <[email protected]>
#3 lore raw

Hi Jerome,

Quoted 6 lines · Kevin Hilman
Quoted 4 lines · Jerome Brunet

This fix the recent removal of clock drivers selection.
While it is not necessary to select the clock drivers themselves, we need to select a proper implementation of the clock API, which for the meson, is CCF

Quoted 8 lines

Applied, thanks!

[1/1] arm64: meson: select COMMON_CLK

      commit: aea7a80ad5effd48f44a7a08c3903168be038a43

Best regards,
--
Kevin Hilman <[email protected]>

Why is this needed, and why would this make any difference? COMMON_CLK is always enabled on arm64, as the main ARM64 symbol in arch/arm64/Kconfig selects it.

Gr{oetje,eeting}s,

Geert

Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
author reviewer
#4 lore raw
Quoted 14 lines · Geert Uytterhoeven

Hi Jerome,

Quoted 11 lines · Kevin Hilman
Quoted 4 lines · Jerome Brunet

This fix the recent removal of clock drivers selection.
While it is not necessary to select the clock drivers themselves, we need to select a proper implementation of the clock API, which for the meson, is CCF

Applied, thanks!

[1/1] arm64: meson: select COMMON_CLK

      commit: aea7a80ad5effd48f44a7a08c3903168be038a43
Quoted 7 lines
Quoted 3 lines

Best regards,
--
Kevin Hilman <[email protected]>

Why is this needed, and why would this make any difference? COMMON_CLK is always enabled on arm64, as the main ARM64 symbol in arch/arm64/Kconfig selects it.

Ah indeed. Shortly after commit ba66a25536dd was merged I remember I had problem with COMMON_CLK (or any other clock implementation) being selected. TBH, I don't remember it exactly ...

For sure this was a mistake.
Neil, can you still drop it and do you need a revert ?

Quoted 4 lines

Gr{oetje,eeting}s,

Geert

_______________________________________________
linux-amlogic mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-amlogic

#5 lore raw

Hi,

Quoted 25 lines · Jerome Brunet
Quoted 14 lines · Geert Uytterhoeven

Hi Jerome,

Quoted 11 lines · Kevin Hilman
Quoted 4 lines · Jerome Brunet

This fix the recent removal of clock drivers selection.
While it is not necessary to select the clock drivers themselves, we need to select a proper implementation of the clock API, which for the meson, is CCF

Applied, thanks!

[1/1] arm64: meson: select COMMON_CLK

      commit: aea7a80ad5effd48f44a7a08c3903168be038a43
Quoted 7 lines
Quoted 3 lines

Best regards,
--
Kevin Hilman <[email protected]>

Why is this needed, and why would this make any difference? COMMON_CLK is always enabled on arm64, as the main ARM64 symbol in arch/arm64/Kconfig selects it.

Quoted 6 lines

Ah indeed. Shortly after commit ba66a25536dd was merged I remember I had problem with COMMON_CLK (or any other clock implementation) being selected. TBH, I don't remember it exactly ...

For sure this was a mistake.
Neil, can you still drop it and do you need a revert ?

I can't drop it, it has already been merged.

Please send a revert and I'll push it for 5.14-rc fixes.

Neil

Quoted 6 lines
Quoted 5 lines

Gr{oetje,eeting}s,

Geert