rapidio: remove unused variable in rio_cm.c
PATCH 1/1 rapidio: remove unused variable in rio_cm.c
Remove unused variable 'rc' to fix gcc warning:
drivers/rapidio/rio_cm.c: In function ‘rio_txcq_handler’:
drivers/rapidio/rio_cm.c:673:7: warning: variable ‘rc’ set but not used [-Wunused-but-set-variable]
--- drivers/rapidio/rio_cm.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/rapidio/rio_cm.c +1 -2
@@ -670,12 +670,11 @@ static void rio_txcq_handler(struct cm_dev *cm, int slot)*/ if (!list_empty (&cm->tx_reqs) && (cm->tx_cnt <RIOCM_TX_RING_SIZE )) {struct tx_req *req, *_req; -int rc;list_for_each_entry_safe (req, _req, &cm->tx_reqs, node) {list_del (&req->node); cm->tx_buf[cm->tx_slot] = req->buffer; - rc =rio_add_outb_message (cm->mport, req->rdev, cmbox, +rio_add_outb_message (cm->mport, req->rdev, cmbox, req->buffer, req->len);kfree (req->buffer);kfree (req);
Signature · 6 lines
2.26.2 _______________________________________________ Linux-kernel-mentees mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
Quoted 17 lines · Anirudh Rayabharam
Remove unused variable 'rc' to fix gcc warning:
drivers/rapidio/rio_cm.c: In function ‘rio_txcq_handler’:
drivers/rapidio/rio_cm.c:673:7: warning: variable ‘rc’ set but not used [-Wunused-but-set-variable]Signed-off-by Anirudh Rayabharam <[email protected]>--- drivers/rapidio/rio_cm.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)drivers/rapidio/rio_cm.c +0
-0@@ -670,12 +670,11 @@ static void rio_txcq_handler(struct cm_dev *cm, int slot)*/
drivers/rapidio/rio_cm.c static void rio_txcq_handler(struct cm_dev *cm, int slot) · line 678
Quoted 10 lines
drivers/rapidio/rio_cm.c +1
-2if (!list_empty (&cm->tx_reqs) && (cm->tx_cnt <RIOCM_TX_RING_SIZE )) {struct tx_req *req, *_req; -int rc;list_for_each_entry_safe (req, _req, &cm->tx_reqs, node) {list_del (&req->node); cm->tx_buf[cm->tx_slot] = req->buffer; - rc =rio_add_outb_message (cm->mport, req->rdev, cmbox, +rio_add_outb_message (cm->mport, req->rdev, cmbox, req->buffer, req->len);
Why not handle the potential error sent here?
thanks,
greg k-h
_______________________________________________
Linux-kernel-mentees mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
Quoted 22 lines · Greg KH
Quoted 21 lines · Anirudh Rayabharam
Remove unused variable 'rc' to fix gcc warning:
drivers/rapidio/rio_cm.c: In function ‘rio_txcq_handler’:
drivers/rapidio/rio_cm.c:673:7: warning: variable ‘rc’ set but not used [-Wunused-but-set-variable]Signed-off-by Anirudh Rayabharam <[email protected]>--- drivers/rapidio/rio_cm.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)drivers/rapidio/rio_cm.c +0
-1@@ -670,12 +670,11 @@ static void rio_txcq_handler(struct cm_dev *cm, int slot)*/ if (!list_empty (&cm->tx_reqs) && (cm->tx_cnt <RIOCM_TX_RING_SIZE )) {struct tx_req *req, *_req; -int rc;
Quoted 8 lines
drivers/rapidio/rio_cm.c static void rio_txcq_handler(struct cm_dev *cm, int slot) · line 678
Quoted 6 lines
drivers/rapidio/rio_cm.c +1
-1list_for_each_entry_safe (req, _req, &cm->tx_reqs, node) {list_del (&req->node); cm->tx_buf[cm->tx_slot] = req->buffer; - rc =rio_add_outb_message (cm->mport, req->rdev, cmbox, +rio_add_outb_message (cm->mport, req->rdev, cmbox, req->buffer, req->len);Why not handle the potential error sent here?
I don't know how it should be handled (these functions don't return anything). I assumed that since it is not currently being handled, it's probably not useful.
I'll look into it though. I guess we could simply log it at the very least.
Thanks!
- Anirudh.
_______________________________________________
Linux-kernel-mentees mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees