Skip to contentSkip to conversation

ARM: dts: imx6qdl: pfla02: Update spi-nor naming for kernel compatibility

PATCH In review Yunus Bas 2 participants 5 messages May 3, 2021

Subsystems (2)
lore
Share & tools
lore

Yunus Bas

author
#0 lore raw

PATCH 1/1 ARM: dts: imx6qdl: pfla02: Update spi-nor naming for kernel compatibility

The kernel NVMEM-subsystem prevents the usage of duplicate partition names. Change the SPI-NOR partition names to be compatible with the kernel driver.

Commit 72ba815bf6fe ("ARM: dts: phycore-imx6: change mtd-partition names for compatibility with kernel") applies the change for phyCORE SOMs. The same applies for phyFLEX-modules.

---
 arch/arm/dts/imx6qdl-phytec-pfla02.dtsi | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)
arch/arm/dts/imx6qdl-phytec-pfla02.dtsi +6 -5
index e1aa3183b..6df8d247b 100644
@@ -21,7 +21,7 @@
 
 		environment-spinor {
 			compatible = "barebox,environment";
-			device-path = &som_flash, "partname:barebox-environment";
+			device-path = &som_flash, "partname:nor.barebox-environment";
 			status = "disabled";
 		};
 
@@ -54,28 +54,29 @@
 /delete-node/ &{/memory@10000000};
 
 &som_flash {
+
 	partitions {
 		compatible = "fixed-partitions";
 		#address-cells = <1>;
 		#size-cells = <1>;
 
 		partition@0 {
-			label = "barebox";
+			label = "nor.barebox";
 			reg = <0x0 0x100000>;
 		};
 
 		partition@100000 {
-			label = "barebox-environment";
+			label = "nor.barebox-environment";
 			reg = <0x100000 0x20000>;
 		};
 
 		partition@120000 {
-			label = "oftree";
+			label = "nor.oftree";
 			reg = <0x120000 0x20000>;
 		};
 
 		partition@140000 {
-			label = "kernel";
+			label = "nor.kernel";
 			reg = <0x140000 0x0>;
 		};
 	};
Signature · 7 lines
2.30.0


_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
#1 lore raw

Hello Yunus,

Quoted 3 lines · Yunus Bas

The kernel NVMEM-subsystem prevents the usage of duplicate partition names. Change the SPI-NOR partition names to be compatible with the kernel driver.

I don't mind the change, but I can't follow the reasoning.
These are MTD partitions, so they shouldn't have been registered with the NVMEM framework in the first place?

Cheers,
Ahmad

Quoted 58 lines

Commit 72ba815bf6fe ("ARM: dts: phycore-imx6: change mtd-partition names for compatibility with kernel") applies the change for phyCORE SOMs. The same applies for phyFLEX-modules.

---
 arch/arm/dts/imx6qdl-phytec-pfla02.dtsi | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)
arch/arm/dts/imx6qdl-phytec-pfla02.dtsi +6 -5
index e1aa3183b..6df8d247b 100644
@@ -21,7 +21,7 @@
 
 		environment-spinor {
 			compatible = "barebox,environment";
-			device-path = &som_flash, "partname:barebox-environment";
+			device-path = &som_flash, "partname:nor.barebox-environment";
 			status = "disabled";
 		};
 
@@ -54,28 +54,29 @@
 /delete-node/ &{/memory@10000000};
 
 &som_flash {
+
 	partitions {
 		compatible = "fixed-partitions";
 		#address-cells = <1>;
 		#size-cells = <1>;
 
 		partition@0 {
-			label = "barebox";
+			label = "nor.barebox";
 			reg = <0x0 0x100000>;
 		};
 
 		partition@100000 {
-			label = "barebox-environment";
+			label = "nor.barebox-environment";
 			reg = <0x100000 0x20000>;
 		};
 
 		partition@120000 {
-			label = "oftree";
+			label = "nor.oftree";
 			reg = <0x120000 0x20000>;
 		};
 
 		partition@140000 {
-			label = "kernel";
+			label = "nor.kernel";
 			reg = <0x140000 0x0>;
 		};
 	};
Signature · 9 lines
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
author
#2 lore raw

Hi Ahmad,

The main purpose behind adding MTD-partitions as NVMEM-devices was to have a fast and uncomplicated access on partitions with sensitive data, especially on embedded systems. I think, there is a reasoning for it, but nevertheless, the original kernel patch is from 2018.

To say the truth, there is already an upstream fix for the name- clashing, which registers the NVMEM devices with the unique device names, instead of the MTD-names. I had two options here, one was to revert the first patch with the change for phyCore, the other was to follow up with the phyFLEX-module. I've chosen the latter one, since I felt it has more readability.

Regards,
Yunus

Am Montag, dem 03.05.2021 um 14:38 +0200 schrieb Ahmad Fatoum:

Quoted 80 lines

Hello Yunus,

Quoted 4 lines · Yunus Bas

The kernel NVMEM-subsystem prevents the usage of duplicate partition names.
Change the SPI-NOR partition names to be compatible with the kernel driver.

I don't mind the change, but I can't follow the reasoning. These are MTD partitions, so they shouldn't have been registered with the NVMEM
framework in the first place?

Cheers,
Ahmad

Quoted 63 lines

Commit 72ba815bf6fe ("ARM: dts: phycore-imx6: change mtd-partition names for
compatibility with kernel") applies the change for phyCORE SOMs. The
same applies for phyFLEX-modules.

---
 arch/arm/dts/imx6qdl-phytec-pfla02.dtsi | 11 ++++++-----

 1 file changed, 6 insertions(+), 5 deletions(-)
arch/arm/dts/imx6qdl-phytec-pfla02.dtsi +0 -0
index e1aa3183b..6df8d247b 100644
@@ -21,7 +21,7 @@


                environment-spinor {
                        compatible = "barebox,environment"; -                       device-path = &som_flash, "partname:barebox-environment";
+                       device-path = &som_flash, "partname:nor.barebox-environment";
                        status = "disabled";
                };

arch/arm/dts/imx6qdl-phytec-pfla02.dtsi +0 -0
@@ -54,28 +54,29 @@
  /delete-node/ &{/memory@10000000};


 &som_flash {
+
        partitions {
                compatible = "fixed-partitions"; #address-cells = <1>;
                #size-cells = <1>;

                partition@0 {
-                       label = "barebox";
+                       label = "nor.barebox"; reg = <0x0 0x100000>;
                };

                partition@100000 {
-                       label = "barebox-environment"; +                       label = "nor.barebox-environment"; reg = <0x100000 0x20000>; };

                partition@120000 {
-                       label = "oftree";
+                       label = "nor.oftree";
                        reg = <0x120000 0x20000>; };

                partition@140000 {
-                       label = "kernel";
+                       label = "nor.kernel";
                        reg = <0x140000 0x0>;
                };
        };

Signature · 26 lines
Mit freundlichen Grüßen
Yunus Bas

-Software Engineer-
PHYTEC Messtechnik GmbH
Robert-Koch-Str. 39
55129 Mainz
Germany
Tel.: +49 (0)6131 9221- 466
Web: www.phytec.de

Sie finden uns auch auf: Facebook, LinkedIn, Xing, YouTube

PHYTEC Messtechnik GmbH | Robert-Koch-Str. 39 | 55129 Mainz, Germany
Geschäftsführer: Dipl.-Ing. Michael Mitezki, Dipl.-Ing. Bodo Huber |
Handelsregister Mainz HRB 4656 | Finanzamt Mainz | St.Nr. 266500608, DE
149059855
This E-Mail may contain confidential or privileged information. If you
are not the intended recipient (or have received this E-Mail in error)
please notify the sender immediately and destroy this E-Mail. Any
unauthorized copying, disclosure or distribution of the material in
this E-Mail is strictly forbidden.
_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
#3 lore raw

Hello Yunus,

Quoted 6 lines · Yunus Bas

Hi Ahmad,

The main purpose behind adding MTD-partitions as NVMEM-devices was to have a fast and uncomplicated access on partitions with sensitive data, especially on embedded systems. I think, there is a reasoning for it, but nevertheless, the original kernel patch is from 2018.

So it's a patch you carry with you and not Linux-upstream functionality?

Quoted 6 lines

To say the truth, there is already an upstream fix for the name- clashing, which registers the NVMEM devices with the unique device names, instead of the MTD-names. I had two options here, one was to revert the first patch with the change for phyCore, the other was to follow up with the phyFLEX-module. I've chosen the latter one, since I felt it has more readability.

Thanks for the clarification,
Ahmad

Quoted 86 lines

Regards,
Yunus

Am Montag, dem 03.05.2021 um 14:38 +0200 schrieb Ahmad Fatoum:

Quoted 80 lines

Hello Yunus,

Quoted 4 lines · Yunus Bas

The kernel NVMEM-subsystem prevents the usage of duplicate partition names.
Change the SPI-NOR partition names to be compatible with the kernel driver.

I don't mind the change, but I can't follow the reasoning. These are MTD partitions, so they shouldn't have been registered with the NVMEM
framework in the first place?

Cheers,
Ahmad

Quoted 63 lines

Commit 72ba815bf6fe ("ARM: dts: phycore-imx6: change mtd-partition names for
compatibility with kernel") applies the change for phyCORE SOMs. The
same applies for phyFLEX-modules.

---
 arch/arm/dts/imx6qdl-phytec-pfla02.dtsi | 11 ++++++-----

 1 file changed, 6 insertions(+), 5 deletions(-)
arch/arm/dts/imx6qdl-phytec-pfla02.dtsi +0 -0
index e1aa3183b..6df8d247b 100644
@@ -21,7 +21,7 @@


                environment-spinor {
                        compatible = "barebox,environment"; -                       device-path = &som_flash, "partname:barebox-environment";
+                       device-path = &som_flash, "partname:nor.barebox-environment";
                        status = "disabled";
                };

arch/arm/dts/imx6qdl-phytec-pfla02.dtsi +0 -0
@@ -54,28 +54,29 @@
  /delete-node/ &{/memory@10000000};


 &som_flash {
+
        partitions {
                compatible = "fixed-partitions"; #address-cells = <1>;
                #size-cells = <1>;

                partition@0 {
-                       label = "barebox";
+                       label = "nor.barebox"; reg = <0x0 0x100000>;
                };

                partition@100000 {
-                       label = "barebox-environment"; +                       label = "nor.barebox-environment"; reg = <0x100000 0x20000>; };

                partition@120000 {
-                       label = "oftree";
+                       label = "nor.oftree";
                        reg = <0x120000 0x20000>; };

                partition@140000 {
-                       label = "kernel";
+                       label = "nor.kernel";
                        reg = <0x140000 0x0>;
                };
        };

Signature · 9 lines
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
author
#4 lore raw

Hello Ahmad,

Am Montag, dem 03.05.2021 um 20:36 +0200 schrieb Ahmad Fatoum:

Quoted 13 lines

Hello Yunus,

Quoted 9 lines · Yunus Bas

Hi Ahmad,

The main purpose behind adding MTD-partitions as NVMEM-devices was to
have a fast and uncomplicated access on partitions with sensitive data,
especially on embedded systems. I think, there is a reasoning for it,
but nevertheless, the original kernel patch is from 2018.

Quoted 2 lines

So it's a patch you carry with you and not Linux-upstream functionality?

Registering MTD-partitions as NVMEM devices is Linux-upstream. We just need to adapt the partition names in barebox.

Quoted 10 lines
Quoted 9 lines

To say the truth, there is already an upstream fix for the name- clashing, which registers the NVMEM devices with the unique device names, instead of the MTD-names. I had two options here, one was to revert the first patch with the change for phyCore, the other was to
follow up with the phyFLEX-module. I've chosen the latter one, since I
felt it has more readability.

Quoted 3 lines

Thanks for the clarification,
Ahmad

Maybe it is better to drop this and revert the change on phyCore instead. Prepending the device before the partition would only apply to the NOR flash. Also, this solution doesn't work out in case there are two flash memories of the same kind, e.g. two NOR flashes.

Please drop this patch.

Regards,
Yunus

Quoted 91 lines
Quoted 90 lines

Regards,
Yunus

Am Montag, dem 03.05.2021 um 14:38 +0200 schrieb Ahmad Fatoum:

Quoted 84 lines

Hello Yunus,

Quoted 5 lines · Yunus Bas

The kernel NVMEM-subsystem prevents the usage of duplicate partition names.
Change the SPI-NOR partition names to be compatible with the kernel
driver.

I don't mind the change, but I can't follow the reasoning. These are MTD partitions, so they shouldn't have been registered with
the NVMEM
framework in the first place?

Cheers,
Ahmad

Quoted 65 lines

Commit 72ba815bf6fe ("ARM: dts: phycore-imx6: change mtd- partition
names for
compatibility with kernel") applies the change for phyCORE SOMs.
The
same applies for phyFLEX-modules.

---
 arch/arm/dts/imx6qdl-phytec-pfla02.dtsi | 11 ++++++-----

 1 file changed, 6 insertions(+), 5 deletions(-)
arch/arm/dts/imx6qdl-phytec-pfla02.dtsi +0 -0
index e1aa3183b..6df8d247b 100644
@@ -21,7 +21,7 @@


                environment-spinor {
                        compatible = "barebox,environment"; -                       device-path = &som_flash, "partname:barebox-environment";
+                       device-path = &som_flash, "partname:nor.barebox-environment";
                        status = "disabled";
                };

arch/arm/dts/imx6qdl-phytec-pfla02.dtsi +0 -0
@@ -54,28 +54,29 @@
  /delete-node/ &{/memory@10000000};


 &som_flash {
+
        partitions {
                compatible = "fixed-partitions"; #address-cells = <1>;
                #size-cells = <1>;

                partition@0 {
-                       label = "barebox";
+                       label = "nor.barebox"; reg = <0x0 0x100000>;
                };

                partition@100000 {
-                       label = "barebox-environment"; +                       label = "nor.barebox-environment"; reg = <0x100000 0x20000>; };

                partition@120000 {
-                       label = "oftree";
+                       label = "nor.oftree";
                        reg = <0x120000 0x20000>; };

                partition@140000 {
-                       label = "kernel";
+                       label = "nor.kernel";
                        reg = <0x140000 0x0>;
                };
        };

Signature · 26 lines
Mit freundlichen Grüßen
Yunus Bas

-Software Engineer-
PHYTEC Messtechnik GmbH
Robert-Koch-Str. 39
55129 Mainz
Germany
Tel.: +49 (0)6131 9221- 466
Web: www.phytec.de

Sie finden uns auch auf: Facebook, LinkedIn, Xing, YouTube

PHYTEC Messtechnik GmbH | Robert-Koch-Str. 39 | 55129 Mainz, Germany
Geschäftsführer: Dipl.-Ing. Michael Mitezki, Dipl.-Ing. Bodo Huber |
Handelsregister Mainz HRB 4656 | Finanzamt Mainz | St.Nr. 266500608, DE
149059855
This E-Mail may contain confidential or privileged information. If you
are not the intended recipient (or have received this E-Mail in error)
please notify the sender immediately and destroy this E-Mail. Any
unauthorized copying, disclosure or distribution of the material in
this E-Mail is strictly forbidden.
_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox