Skip to contentSkip to conversation

s390x: Fix vector stfle checks

PATCH In review Janosch Frank 4 participants 4 messages May 3, 2021 KVM

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 s390x: Fix vector stfle checks

134 is for bcd
135 is for the vector enhancements

Not the other way around...

---
 s390x/vector.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
s390x/vector.c +2 -2
index d1b6a571..b052de55 100644
@@ -53,7 +53,7 @@ static void test_add(void)
 /* z14 vector extension test */
 static void test_ext1_nand(void)
 {
-	bool has_vext = test_facility(134);
+	bool has_vext = test_facility(135);
 	static struct prm {
 		__uint128_t a,b,c;
 	} prm __attribute__((aligned(16)));
@@ -79,7 +79,7 @@ static void test_ext1_nand(void)
 /* z14 bcd extension test */
 static void test_bcd_add(void)
 {
-	bool has_bcd = test_facility(135);
+	bool has_bcd = test_facility(134);
 	static struct prm {
 		__uint128_t a,b,c;
 	} prm __attribute__((aligned(16)));
Signature · 1 line
2.27.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 26 lines · Janosch Frank

134 is for bcd
135 is for the vector enhancements

Not the other way around...

---
  s390x/vector.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
s390x/vector.c +1 -1
index d1b6a571..b052de55 100644
@@ -53,7 +53,7 @@ static void test_add(void)
  /* z14 vector extension test */
  static void test_ext1_nand(void)
  {
-	bool has_vext = test_facility(134);
+	bool has_vext = test_facility(135);
  	static struct prm {
  		__uint128_t a,b,c;
  	} prm __attribute__((aligned(16)));

s390x/vector.c static void test_ext1_nand(void) · line 85

Quoted 8 lines
s390x/vector.c +1 -1
@@ -79,7 +79,7 @@ static void test_ext1_nand(void)
  /* z14 bcd extension test */
  static void test_bcd_add(void)
  {
-	bool has_bcd = test_facility(135);
+	bool has_bcd = test_facility(134);
  	static struct prm {
  		__uint128_t a,b,c;
  	} prm __attribute__((aligned(16)));

thanks!

Signature · 3 lines
Thanks,

David / dhildenb
Reviewed-by on v1 1/1
#3 lore raw
In reply to Janosch Frank
Quoted 7 lines · On Mon, 3 May 2021 12:47:13 +0000 Janosch Frank <[email protected]> wrote:

134 is for bcd
135 is for the vector enhancements

Not the other way around...

Quoted 26 lines
---
 s390x/vector.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
s390x/vector.c +2 -2
index d1b6a571..b052de55 100644
@@ -53,7 +53,7 @@ static void test_add(void)
 /* z14 vector extension test */
 static void test_ext1_nand(void)
 {
-	bool has_vext = test_facility(134);
+	bool has_vext = test_facility(135);
 	static struct prm {
 		__uint128_t a,b,c;
 	} prm __attribute__((aligned(16)));
@@ -79,7 +79,7 @@ static void test_ext1_nand(void)
 /* z14 bcd extension test */
 static void test_bcd_add(void)
 {
-	bool has_bcd = test_facility(135);
+	bool has_bcd = test_facility(134);
 	static struct prm {
 		__uint128_t a,b,c;
 	} prm __attribute__((aligned(16)));