Skip to contentSkip to conversation

pinctrl: qcom: spmi-mpp: Add compatible for pmi8994

PATCH In review Bjorn Andersson 3 participants 3 messages Apr 29, 2021 – May 19, 2021

Subsystems (6)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pinctrl: qcom: spmi-mpp: Add compatible for pmi8994

The PMI8994 has 4 multi-purpose-pins, add a compatible for this hardware block to the MPP driver.

---

PS. I see that while the related gpio driver was converted to hierarchical IRQ chips the mpp driver didn't get the same treatment. We should fix this at some point...

 Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.txt | 1 +
 drivers/pinctrl/qcom/pinctrl-spmi-mpp.c                     | 1 +
 2 files changed, 2 insertions(+)
Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.txt +1 -0
index 0ba07bc96c55..5363d44cbb74 100644
@@ -21,6 +21,7 @@ of PMIC's from Qualcomm.
 		    "qcom,pmi8950-mpp",
 		    "qcom,pm8994-mpp",
 		    "qcom,pma8084-mpp",
+		    "qcom,pmi8994-mpp",
 
 		    And must contain either "qcom,spmi-mpp" or "qcom,ssbi-mpp"
 		    if the device is on an spmi bus or an ssbi bus respectively.
drivers/pinctrl/qcom/pinctrl-spmi-mpp.c +1 -0
index 3c213f799feb..2da9b5f68f3f 100644
@@ -920,6 +920,7 @@ static const struct of_device_id pmic_mpp_of_match[] = {
 	{ .compatible = "qcom,pmi8950-mpp" },	/* 4 MPP's */
 	{ .compatible = "qcom,pm8994-mpp" },	/* 8 MPP's */
 	{ .compatible = "qcom,pma8084-mpp" },	/* 8 MPP's */
+	{ .compatible = "qcom,pmi8994-mpp" },	/* 4 MPP's */
 	{ .compatible = "qcom,spmi-mpp" },	/* Generic */
 	{ },
 };
Signature · 1 line
2.29.2
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 6 lines · Bjorn Andersson

The PMI8994 has 4 multi-purpose-pins, add a compatible for this hardware block to the MPP driver.

---

Quoted 8 lines

PS. I see that while the related gpio driver was converted to hierarchical IRQ chips the mpp driver didn't get the same treatment. We should fix this at some point...

 Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.txt | 1 +
 drivers/pinctrl/qcom/pinctrl-spmi-mpp.c                     | 1 +
 2 files changed, 2 insertions(+)
#2 lore raw
In reply to Bjorn Andersson
Quoted 4 lines · Bjorn Andersson

The PMI8994 has 4 multi-purpose-pins, add a compatible for this hardware block to the MPP driver.

Patch applied!

Quoted 3 lines

PS. I see that while the related gpio driver was converted to hierarchical IRQ chips the mpp driver didn't get the same treatment. We should fix this at some point...

Oooups. I think Brian & I discussed that and that we "take GPIO first" or so, and then forgot step 2. It should pretty much be a copy/paste operation of the gitlog of what Brian did with the GPIO driver.

Yours,
Linus Walleij