pinctrl: qcom: spmi-mpp: Add compatible for pmi8994
Subsystems (6)
PATCH 1/1 pinctrl: qcom: spmi-mpp: Add compatible for pmi8994
The PMI8994 has 4 multi-purpose-pins, add a compatible for this hardware block to the MPP driver.
---
PS. I see that while the related gpio driver was converted to hierarchical IRQ chips the mpp driver didn't get the same treatment. We should fix this at some point...
Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.txt | 1 + drivers/pinctrl/qcom/pinctrl-spmi-mpp.c | 1 + 2 files changed, 2 insertions(+)
Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.txt +1 -0
@@ -21,6 +21,7 @@ of PMIC's from Qualcomm. "qcom,pmi8950-mpp", "qcom,pm8994-mpp", "qcom,pma8084-mpp", + "qcom,pmi8994-mpp", And must contain either "qcom,spmi-mpp" or "qcom,ssbi-mpp" if the device is on an spmi bus or an ssbi bus respectively.
drivers/pinctrl/qcom/pinctrl-spmi-mpp.c +1 -0
@@ -920,6 +920,7 @@ static const struct of_device_id pmic_mpp_of_match[] = { { .compatible = "qcom,pmi8950-mpp" }, /* 4 MPP's */ { .compatible = "qcom,pm8994-mpp" }, /* 8 MPP's */ { .compatible = "qcom,pma8084-mpp" }, /* 8 MPP's */ + { .compatible = "qcom,pmi8994-mpp" }, /* 4 MPP's */ { .compatible = "qcom,spmi-mpp" }, /* Generic */ { }, };
Signature · 1 line
2.29.2
Quoted 6 lines · Bjorn Andersson
The PMI8994 has 4 multi-purpose-pins, add a compatible for this hardware block to the MPP driver.
Signed-off-by Bjorn Andersson <[email protected]>---
Quoted 8 lines
PS. I see that while the related gpio driver was converted to hierarchical IRQ chips the mpp driver didn't get the same treatment. We should fix this at some point...
Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.txt | 1 + drivers/pinctrl/qcom/pinctrl-spmi-mpp.c | 1 + 2 files changed, 2 insertions(+)
Quoted 4 lines · Bjorn Andersson
The PMI8994 has 4 multi-purpose-pins, add a compatible for this hardware block to the MPP driver.
Signed-off-by Bjorn Andersson <[email protected]>
Patch applied!
Quoted 3 lines
PS. I see that while the related gpio driver was converted to hierarchical IRQ chips the mpp driver didn't get the same treatment. We should fix this at some point...
Oooups. I think Brian & I discussed that and that we "take GPIO first" or so, and then forgot step 2. It should pretty much be a copy/paste operation of the gitlog of what Brian did with the GPIO driver.
Yours,
Linus Walleij