Skip to contentSkip to conversation

lib/igt_chamelium: Retry DP FSM on Failure

PATCH In review Kunal Joshi 3 participants 5 messages May 4, 2021 – May 6, 2021 Library code

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 lib/igt_chamelium: Retry DP FSM on Failure

We have a thread called chamelium_fsm_mon which monitors HPD events triggered by chamelium, Unfortunately not always the HPD event arrives in a fixed interval (mostly does), Quick fix to this is to retry.

v2: Remove redundant assert (Bhanu)

---
 lib/igt_chamelium.c | 28 ++++++++++++++++++++++++----
 1 file changed, 24 insertions(+), 4 deletions(-)
lib/igt_chamelium.c +24 -4
index 7085122a7..c385534c6 100644
@@ -522,12 +522,32 @@ static xmlrpc_value *chamelium_rpc(struct chamelium *chamelium,
 {
 	xmlrpc_value *res;
 	va_list va_args;
+	int fsm_trials_left = 5;
 
-	va_start(va_args, format_str);
-	res = __chamelium_rpc_va(chamelium, fsm_port, method_name,
-				 format_str, va_args);
-	va_end(va_args);
+	if (strcmp(method_name, "CaptureVideo") == 0) {
+
+		while (fsm_trials_left) {
+
+			va_start(va_args, format_str);
+			res = __chamelium_rpc_va(chamelium, fsm_port,
+						 method_name, format_str,
+						 va_args);
+			va_end(va_args);
 
+			if (!chamelium->env.fault_occurred)
+				break;
+
+			igt_debug("DP FSM failed retrying, tries left %d\n", fsm_trials_left);
+			--fsm_trials_left;
+		}
+	} else {
+
+		va_start(va_args, format_str);
+		res = __chamelium_rpc_va(chamelium, fsm_port, method_name,
+					 format_str, va_args);
+		va_end(va_args);
+	}
+	
 	igt_assert_f(!chamelium->env.fault_occurred,
 		     "Chamelium RPC call failed: %s\n",
 		     chamelium->env.fault_string);
Signature · 6 lines
2.25.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#1 lore raw

[igt-dev] ✓ Fi.CI.BAT: success for lib/igt_chamelium: Retry DP FSM on Failure (rev2)

== Series Details ==

== Series Details ==

Series: lib/igt_chamelium: Retry DP FSM on Failure (rev2)
URL : https://patchwork.freedesktop.org/series/89770/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_10040 -> IGTPW_5780
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/index.html

Known issues
------------

Here are the changes found in IGTPW_5780 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@amdgpu/amd_cs_nop@fork-gfx0:
- fi-tgl-y: NOTRUN -> [SKIP][1] ([fdo#109315] / [i915#2575]) +7 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/fi-tgl-y/igt@amdgpu/[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[k.org#205379]: https://bugzilla.kernel.org/show_bug.cgi?id=205379

Participating hosts (46 -> 40)
------------------------------

Missing (6): fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-ctg-p8600 fi-dg1-1 fi-bdw-samus

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_6077 -> IGTPW_5780

CI-20190529: 20190529
CI_DRM_10040: 6645780dc86cd92b4f56b88a92c2e04cb0811ebc @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_5780: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/index.html
IGT_6077: 126a3f6fc0e97786e2819085efc84e741093aed5 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/index.html

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#2 lore raw

[igt-dev] ✗ Fi.CI.IGT: failure for lib/igt_chamelium: Retry DP FSM on Failure (rev2)

In reply to Kunal Joshi
== Series Details ==

== Series Details ==

Series: lib/igt_chamelium: Retry DP FSM on Failure (rev2)
URL : https://patchwork.freedesktop.org/series/89770/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_10040_full -> IGTPW_5780_full
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with IGTPW_5780_full absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in IGTPW_5780_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/index.html

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_5780_full:

### IGT changes ###

#### Possible regressions ####

* igt@kms_cursor_crc@pipe-a-cursor-128x42-random:
- shard-kbl: NOTRUN -> [FAIL][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-kbl1/igt@[email protected]

Known issues
------------

Here are the changes found in IGTPW_5780_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_ctx_param@set-priority-not-supported:
- shard-tglb: NOTRUN -> [SKIP][2] ([fdo#109314])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-tglb7/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][3] ([fdo#109314])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-iclb4/igt@[email protected]

* igt@gem_ctx_persistence@clone:
- shard-snb: NOTRUN -> [SKIP][4] ([fdo#109271] / [i915#1099]) +8 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-snb6/igt@[email protected]

* igt@gem_eio@unwedge-stress:
- shard-tglb: [PASS][5] -> [TIMEOUT][6] ([i915#2369] / [i915#3063])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10040/shard-tglb3/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-tglb6/igt@[email protected]
- shard-snb: NOTRUN -> [FAIL][7] ([i915#3354])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-snb2/igt@[email protected]

* igt@gem_exec_fair@basic-none@rcs0:
- shard-glk: NOTRUN -> [FAIL][8] ([i915#2842])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-glk8/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-none@vcs0:
- shard-tglb: NOTRUN -> [FAIL][9] ([i915#2842]) +4 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-tglb1/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-none@vecs0:
- shard-iclb: NOTRUN -> [FAIL][10] ([i915#2842]) +3 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-iclb5/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-glk: [PASS][11] -> [FAIL][12] ([i915#2842]) +2 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10040/shard-glk1/igt@gem_exec_fair@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-glk9/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace@vecs0:
- shard-tglb: [PASS][13] -> [FAIL][14] ([i915#2842]) +2 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10040/shard-tglb3/igt@gem_exec_fair@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-tglb3/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-sync@rcs0:
- shard-kbl: [PASS][15] -> [SKIP][16] ([fdo#109271]) +1 similar issue
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10040/shard-kbl3/igt@gem_exec_fair@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-kbl1/igt@gem_exec_fair@[email protected]

* igt@gem_exec_reloc@basic-wide-active@bcs0:
- shard-apl: NOTRUN -> [FAIL][17] ([i915#2389]) +3 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-apl6/igt@gem_exec_reloc@[email protected]

* igt@gem_exec_reloc@basic-wide-active@rcs0:
- shard-snb: NOTRUN -> [FAIL][18] ([i915#2389]) +2 similar issues
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-snb2/igt@gem_exec_reloc@[email protected]

* igt@gem_exec_whisper@basic-queues-forked-all:
- shard-glk: [PASS][19] -> [DMESG-WARN][20] ([i915#118] / [i915#95])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10040/shard-glk3/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-glk8/igt@[email protected]

* igt@gem_mmap_gtt@big-copy-xy:
- shard-glk: [PASS][21] -> [FAIL][22] ([i915#307])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10040/shard-glk5/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-glk7/igt@[email protected]

* igt@gem_mmap_gtt@cpuset-basic-small-copy-xy:
- shard-iclb: [PASS][23] -> [FAIL][24] ([i915#307])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10040/shard-iclb8/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-iclb3/igt@[email protected]

* igt@gem_pread@exhaustion:
- shard-tglb: NOTRUN -> [WARN][25] ([i915#2658])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-tglb2/igt@[email protected]
- shard-glk: NOTRUN -> [WARN][26] ([i915#2658])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-glk2/igt@[email protected]
- shard-apl: NOTRUN -> [WARN][27] ([i915#2658])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-apl1/igt@[email protected]
- shard-iclb: NOTRUN -> [WARN][28] ([i915#2658])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-iclb3/igt@[email protected]
- shard-snb: NOTRUN -> [WARN][29] ([i915#2658])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-snb7/igt@[email protected]
- shard-kbl: NOTRUN -> [WARN][30] ([i915#2658])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-kbl6/igt@[email protected]

* igt@gem_render_copy@y-tiled-mc-ccs-to-vebox-y-tiled:
- shard-iclb: NOTRUN -> [SKIP][31] ([i915#768]) +1 similar issue
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-iclb2/igt@[email protected]

* igt@gem_userptr_blits@dmabuf-sync:
- shard-apl: NOTRUN -> [SKIP][32] ([fdo#109271] / [i915#3323])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-apl2/igt@[email protected]

* igt@gem_userptr_blits@dmabuf-unsync:
- shard-tglb: NOTRUN -> [SKIP][33] ([i915#3297])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-tglb2/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][34] ([i915#3297])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-iclb3/igt@[email protected]

* igt@gem_userptr_blits@vma-merge:
- shard-apl: NOTRUN -> [FAIL][35] ([i915#3318])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-apl7/igt@[email protected]

* igt@gen3_render_tiledx_blits:
- shard-iclb: NOTRUN -> [SKIP][36] ([fdo#109289])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-iclb7/igt@gen3_render_tiledx_blits.html
- shard-tglb: NOTRUN -> [SKIP][37] ([fdo#109289])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-tglb1/igt@gen3_render_tiledx_blits.html

* igt@gen9_exec_parse@allowed-all:
- shard-iclb: NOTRUN -> [SKIP][38] ([fdo#112306]) +1 similar issue
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-iclb5/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][39] ([fdo#112306]) +1 similar issue
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-tglb1/igt@[email protected]

* igt@i915_pm_dc@dc6-psr:
- shard-tglb: NOTRUN -> [FAIL][40] ([i915#454])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-tglb6/igt@[email protected]

* igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp:
- shard-kbl: NOTRUN -> [SKIP][41] ([fdo#109271] / [i915#1937])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-kbl4/igt@i915_pm_lpsp@[email protected]
- shard-apl: NOTRUN -> [SKIP][42] ([fdo#109271] / [i915#1937])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-apl3/igt@i915_pm_lpsp@[email protected]

* igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a:
- shard-glk: NOTRUN -> [SKIP][43] ([fdo#109271] / [i915#1937])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-glk3/igt@i915_pm_lpsp@[email protected]

* igt@i915_suspend@debugfs-reader:
- shard-kbl: [PASS][44] -> [INCOMPLETE][45] ([i915#155])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10040/shard-kbl2/igt@[email protected]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-kbl3/igt@[email protected]

* igt@i915_suspend@fence-restore-untiled:
- shard-apl: NOTRUN -> [INCOMPLETE][46] ([i915#180])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-apl1/igt@[email protected]
- shard-kbl: NOTRUN -> [INCOMPLETE][47] ([i915#155] / [i915#180])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-kbl6/igt@[email protected]

* igt@kms_big_fb@yf-tiled-addfb:
- shard-tglb: NOTRUN -> [SKIP][48] ([fdo#111615]) +4 similar issues
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-tglb3/igt@[email protected]

* igt@kms_chamelium@hdmi-audio-edid:
- shard-kbl: NOTRUN -> [SKIP][49] ([fdo#109271] / [fdo#111827]) +9 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-kbl4/igt@[email protected]

* igt@kms_chamelium@vga-hpd-without-ddc:
- shard-snb: NOTRUN -> [SKIP][50] ([fdo#109271] / [fdo#111827]) +18 similar issues
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-snb6/igt@[email protected]

* igt@kms_color@pipe-a-degamma:
- shard-tglb: NOTRUN -> [FAIL][51] ([i915#1149])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-tglb7/igt@[email protected]
- shard-iclb: NOTRUN -> [FAIL][52] ([i915#1149])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-iclb4/igt@[email protected]

* igt@kms_color_chamelium@pipe-b-ctm-red-to-blue:
- shard-iclb: NOTRUN -> [SKIP][53] ([fdo#109284] / [fdo#111827]) +3 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-iclb1/igt@[email protected]
- shard-glk: NOTRUN -> [SKIP][54] ([fdo#109271] / [fdo#111827]) +3 similar issues
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-glk9/igt@[email protected]

* igt@kms_color_chamelium@pipe-c-ctm-max:
- shard-apl: NOTRUN -> [SKIP][55] ([fdo#109271] / [fdo#111827]) +26 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-apl6/igt@[email protected]

* igt@kms_color_chamelium@pipe-d-ctm-red-to-blue:
- shard-tglb: NOTRUN -> [SKIP][56] ([fdo#109284] / [fdo#111827]) +4 similar issues
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-tglb7/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][57] ([fdo#109278] / [fdo#109284] / [fdo#111827])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-iclb8/igt@[email protected]

* igt@kms_content_protection@lic:
- shard-apl: NOTRUN -> [TIMEOUT][58] ([i915#1319])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-apl6/igt@[email protected]

* igt@kms_cursor_crc@pipe-a-cursor-512x512-offscreen:
- shard-iclb: NOTRUN -> [SKIP][59] ([fdo#109278] / [fdo#109279])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-iclb8/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][60] ([fdo#109279] / [i915#3359])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-tglb3/igt@[email protected]

* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-kbl: NOTRUN -> [DMESG-WARN][61] ([i915#180])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-kbl1/igt@[email protected]

* igt@kms_cursor_crc@pipe-b-cursor-32x32-onscreen:
- shard-tglb: NOTRUN -> [SKIP][62] ([i915#3319]) +1 similar issue
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-tglb6/igt@[email protected]

* igt@kms_cursor_crc@pipe-d-cursor-dpms:
- shard-iclb: NOTRUN -> [SKIP][63] ([fdo#109278]) +9 similar issues
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-iclb7/igt@[email protected]

* igt@kms_cursor_crc@pipe-d-cursor-max-size-rapid-movement:
- shard-tglb: NOTRUN -> [SKIP][64] ([i915#3359])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-tglb7/igt@[email protected]

* igt@kms_cursor_legacy@cursorb-vs-flipa-varying-size:
- shard-iclb: NOTRUN -> [SKIP][65] ([fdo#109274] / [fdo#109278])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-iclb7/igt@[email protected]

* igt@kms_dp_tiled_display@basic-test-pattern-with-chamelium:
- shard-tglb: NOTRUN -> [SKIP][66] ([i915#2065])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-tglb7/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][67] ([i915#2065])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-iclb4/igt@[email protected]

* igt@kms_flip@2x-flip-vs-wf_vblank-interruptible:
- shard-iclb: NOTRUN -> [SKIP][68] ([fdo#109274]) +1 similar issue
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-iclb2/igt@kms_flip@2x-flip-vs-wf_vblank-interruptible.html

* igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a1:
- shard-glk: [PASS][69] -> [FAIL][70] ([i915#79])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10040/shard-glk4/igt@kms_flip@[email protected]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-glk8/igt@kms_flip@[email protected]

* igt@kms_flip@flip-vs-suspend-interruptible@b-dp1:
- shard-apl: NOTRUN -> [DMESG-WARN][71] ([i915#180])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-apl8/igt@kms_flip@[email protected]

* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs:
- shard-tglb: NOTRUN -> [SKIP][72] ([i915#2587])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-tglb6/igt@[email protected]

* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs:
- shard-apl: NOTRUN -> [SKIP][73] ([fdo#109271] / [i915#2672]) +1 similar issue
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-apl6/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs.html

* igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile:
- shard-snb: NOTRUN -> [SKIP][74] ([fdo#109271]) +412 similar issues
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-snb2/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-move:
- shard-glk: [PASS][75] -> [FAIL][76] ([i915#49])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10040/shard-glk9/igt@[email protected]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-glk3/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbcpsr-suspend:
- shard-glk: NOTRUN -> [SKIP][77] ([fdo#109271]) +46 similar issues
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-glk6/igt@[email protected]

* igt@kms_frontbuffer_tracking@psr-2p-primscrn-shrfb-plflip-blt:
- shard-iclb: NOTRUN -> [SKIP][78] ([fdo#109280]) +12 similar issues
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-iclb7/igt@[email protected]

* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-spr-indfb-draw-pwrite:
- shard-tglb: NOTRUN -> [SKIP][79] ([fdo#111825]) +15 similar issues
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-tglb1/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-spr-indfb-draw-pwrite.html

* igt@kms_hdr@static-toggle:
- shard-iclb: NOTRUN -> [SKIP][80] ([i915#1187])
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-iclb4/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][81] ([i915#1187])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-tglb7/igt@[email protected]

* igt@kms_pipe_crc_basic@hang-read-crc-pipe-d:
- shard-apl: NOTRUN -> [SKIP][82] ([fdo#109271] / [i915#533])
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-apl8/igt@[email protected]

* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
- shard-kbl: [PASS][83] -> [DMESG-WARN][84] ([i915#180]) +1 similar issue
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10040/shard-kbl2/igt@[email protected]
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-kbl6/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb:
- shard-apl: NOTRUN -> [FAIL][85] ([fdo#108145] / [i915#265]) +3 similar issues
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-apl1/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-a-alpha-transparent-fb:
- shard-apl: NOTRUN -> [FAIL][86] ([i915#265])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-apl3/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-c-alpha-7efc:
- shard-kbl: NOTRUN -> [FAIL][87] ([fdo#108145] / [i915#265])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-kbl6/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-c-alpha-basic:
- shard-glk: NOTRUN -> [FAIL][88] ([fdo#108145] / [i915#265])
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-glk4/igt@[email protected]

* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4:
- shard-apl: NOTRUN -> [SKIP][89] ([fdo#109271] / [i915#658]) +5 similar issues
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-apl6/igt@[email protected]

* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1:
- shard-iclb: NOTRUN -> [SKIP][90] ([i915#658])
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-iclb8/igt@[email protected]
- shard-glk: NOTRUN -> [SKIP][91] ([fdo#109271] / [i915#658]) +1 similar issue
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-glk6/igt@[email protected]
- shard-kbl: NOTRUN -> [SKIP][92] ([fdo#109271] / [i915#658]) +1 similar issue
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-kbl6/igt@[email protected]

* igt@kms_psr2_su@page_flip:
- shard-tglb: NOTRUN -> [SKIP][93] ([i915#1911])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-tglb6/igt@kms_psr2_su@page_flip.html

* igt@kms_psr@psr2_primary_page_flip:
- shard-iclb: NOTRUN -> [SKIP][94] ([fdo#109441])
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-iclb7/igt@kms_psr@psr2_primary_page_flip.html

* igt@kms_psr@psr2_primary_render:
- shard-iclb: [PASS][95] -> [SKIP][96] ([fdo#109441])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10040/shard-iclb2/igt@kms_psr@psr2_primary_render.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-iclb6/igt@kms_psr@psr2_primary_render.html

* igt@kms_psr@psr2_sprite_render:
- shard-tglb: NOTRUN -> [FAIL][97] ([i915#132]) +1 similar issue
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-tglb3/igt@kms_psr@psr2_sprite_render.html

* igt@kms_setmode@basic:
- shard-snb: NOTRUN -> [FAIL][98] ([i915#31])
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-snb5/igt@[email protected]

* igt@kms_tv_load_detect@load-detect:
- shard-tglb: NOTRUN -> [SKIP][99] ([fdo#109309])
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-tglb6/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][100] ([fdo#109309])
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-iclb2/igt@[email protected]

* igt@kms_writeback@writeback-fb-id:
- shard-apl: NOTRUN -> [SKIP][101] ([fdo#109271] / [i915#2437]) +1 similar issue
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-apl7/igt@[email protected]

* igt@nouveau_crc@pipe-a-source-rg:
- shard-iclb: NOTRUN -> [SKIP][102] ([i915#2530])
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-iclb7/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][103] ([i915#2530]) +1 similar issue
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-tglb1/igt@[email protected]

* igt@nouveau_crc@pipe-d-source-outp-complete:
- shard-iclb: NOTRUN -> [SKIP][104] ([fdo#109278] / [i915#2530])
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-iclb5/igt@[email protected]

* igt@prime_nv_api@i915_nv_reimport_twice_check_flink_name:
- shard-apl: NOTRUN -> [SKIP][105] ([fdo#109271]) +239 similar issues
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-apl7/igt@prime_nv_api@i915_nv_reimport_twice_check_flink_name.html

* igt@prime_nv_api@nv_self_import:
- shard-iclb: NOTRUN -> [SKIP][106] ([fdo#109291]) +1 similar issue
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-iclb3/igt@prime_nv_api@nv_self_import.html

* igt@prime_nv_pcopy@test1_macro:
- shard-tglb: NOTRUN -> [SKIP][107] ([fdo#109291]) +1 similar issue
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-tglb8/igt@prime_nv_pcopy@test1_macro.html

* igt@prime_nv_pcopy@test2:
- shard-kbl: NOTRUN -> [SKIP][108] ([fdo#109271]) +72 similar issues
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-kbl1/igt@[email protected]

* igt@sysfs_clients@create:
- shard-glk: NOTRUN -> [SKIP][109] ([fdo#109271] / [i915#2994])
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-glk7/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][110] ([i915#2994])
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-tglb7/igt@[email protected]
- shard-apl: NOTRUN -> [SKIP][111] ([fdo#109271] / [i915#2994]) +3 similar issues
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-apl3/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][112] ([i915#2994])
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-iclb4/igt@[email protected]
- shard-kbl: NOTRUN -> [SKIP][113] ([fdo#109271] / [i915#2994])
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-kbl3/igt@[email protected]

#### Possible fixes ####

* igt@feature_discovery@psr2:
- shard-iclb: [SKIP][114] ([i915#658]) -> [PASS][115]
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10040/shard-iclb5/igt@[email protected]
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-iclb2/igt@[email protected]

* igt@gem_ctx_persistence@legacy-engines-hostile@vebox:
- shard-iclb: [FAIL][116] ([i915#2410]) -> [PASS][117]
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10040/shard-iclb2/igt@gem_ctx_persistence@[email protected]
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-iclb5/igt@gem_ctx_persistence@[email protected]

* igt@gem_exec_fair@basic-deadline:
- shard-kbl: [FAIL][118] ([i915#2846]) -> [PASS][119]
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10040/shard-kbl2/igt@[email protected]
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-kbl2/igt@[email protected]

* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-iclb: [FAIL][120] ([i915#2842]) -> [PASS][121] +2 similar issues
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10040/shard-iclb3/igt@gem_exec_fair@[email protected]
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-iclb1/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace@bcs0:
- shard-tglb: [FAIL][122] ([i915#2842]) -> [PASS][123] +1 similar issue
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10040/shard-tglb3/igt@gem_exec_fair@[email protected]
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-tglb3/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace@vcs1:
- shard-kbl: [FAIL][124] ([i915#2842]) -> [PASS][125]
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10040/shard-kbl4/igt@gem_exec_fair@[email protected]
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-kbl4/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-iclb: [FAIL][126] ([i915#2849]) -> [PASS][127]
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10040/shard-iclb2/igt@gem_exec_fair@[email protected]
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-iclb2/igt@gem_exec_fair@[email protected]

* igt@gem_huc_copy@huc-copy:
- shard-tglb: [SKIP][128] ([i915#2190]) -> [PASS][129]
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10040/shard-tglb6/igt@[email protected]
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-tglb7/igt@[email protected]

* igt@gem_mmap_gtt@cpuset-medium-copy-xy:
- shard-iclb: [FAIL][130] ([i915#2428]) -> [PASS][131]
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10040/shard-iclb8/igt@[email protected]
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-iclb2/igt@[email protected]

* igt@kms_big_fb@y-tiled-64bpp-rotate-180:
- shard-tglb: [FAIL][132] ([i915#3434]) -> [PASS][133]
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10040/shard-tglb6/igt@[email protected]
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-tglb3/igt@[email protected]

* igt@kms_flip@flip-vs-expired-vblank@b-edp1:
- shard-iclb: [FAIL][134] ([i915#79]) -> [PASS][135]
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10040/shard-iclb5/igt@kms_flip@[email protected]
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-iclb8/igt@kms_flip@[email protected]

* igt@kms_frontbuffer_tracking@psr-rgb101010-draw-mmap-gtt:
- shard-tglb: [DMESG-WARN][136] ([i915#2868]) -> [PASS][137] +1 similar issue
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10040/shard-tglb5/igt@[email protected]
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-tglb1/igt@[email protected]

* igt@kms_hdr@bpc-switch-suspend:
- shard-kbl: [DMESG-WARN][138] ([i915#180]) -> [PASS][139] +2 similar issues
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10040/shard-kbl7/igt@[email protected]
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard-kbl7/igt@[email protected]

* igt@kms_psr@psr2_basic:
- shard-iclb: [SKIP][140] ([fdo#109441]) -> [PASS][141] +1 similar issue
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10040/shard-iclb7/igt@kms_psr@psr2_basic.html
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/shard

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5780/index.html

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Reviewed-by on v1 1/1
#3 lore raw
In reply to Kunal Joshi
Quoted 22 lines · Kunal Joshi

We have a thread called chamelium_fsm_mon which monitors HPD events triggered by chamelium, Unfortunately not always the HPD event arrives in a fixed interval (mostly does), Quick fix to this is to retry.

v2: Remove redundant assert (Bhanu)

---
 lib/igt_chamelium.c | 28 ++++++++++++++++++++++++----
 1 file changed, 24 insertions(+), 4 deletions(-)
lib/igt_chamelium.c +0 -0
index 7085122a7..c385534c6 100644
@@ -522,12 +522,32 @@ static xmlrpc_value *chamelium_rpc(struct chamelium *chamelium,
 {
 	xmlrpc_value *res;
 	va_list va_args;

lib/igt_chamelium.c static xmlrpc_value *chamelium_rpc(struct chamelium *chamelium, · line 530

Quoted 10 lines
lib/igt_chamelium.c +5 -4
+	int fsm_trials_left = 5;
 
-	va_start(va_args, format_str);
-	res = __chamelium_rpc_va(chamelium, fsm_port, method_name,
-				 format_str, va_args);
-	va_end(va_args);
+	if (strcmp(method_name, "CaptureVideo") == 0) {
+
+		while (fsm_trials_left) {
+

Remove this extra empty line.

lib/igt_chamelium.c static xmlrpc_value *chamelium_rpc(struct chamelium *chamelium, · line 538

Quoted 8 lines
lib/igt_chamelium.c +7 -0
+			va_start(va_args, format_str);
+			res = __chamelium_rpc_va(chamelium, fsm_port,
+						 method_name, format_str,
+						 va_args);
+			va_end(va_args);
 
+			if (!chamelium->env.fault_occurred)
+				break;

Ok, I was wondering if you need to clear chamelium->env here but __chamelium_rpc_va does that. Ok.

lib/igt_chamelium.c static xmlrpc_value *chamelium_rpc(struct chamelium *chamelium, · line 544

Quoted 6 lines
lib/igt_chamelium.c +6 -0
+
+			igt_debug("DP FSM failed retrying, tries left %d\n", fsm_trials_left);
+			--fsm_trials_left;
+		}
+	} else {
+

Another extra empty line.

With the extra empty lines removed this is

Is CaptureVideo really the only method that needs this retrying?
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#4 lore raw
Quoted 18 lines
Quoted 11 lines

From: Latvala, Petri <[email protected]>
Sent: Wednesday, May 5, 2021 1:50 PM
To: Joshi, Kunal1 <[email protected]>
Cc: [email protected]; Modem, Bhanuprakash <[email protected]>
Subject: Re: [PATCH i-g-t] lib/igt_chamelium: Retry DP FSM on Failure

On Tue, May 04, 2021 at 07:04:15AM +0000, Kunal Joshi wrote:
We have a thread called chamelium_fsm_mon which monitors HPD events triggered by chamelium, Unfortunately not always the HPD event arrives in a fixed interval (mostly does), Quick fix to this is to retry.

Quoted 6 lines

v2: Remove redundant assert (Bhanu)

Quoted 6 lines

Another extra empty line.
With the extra empty lines removed this is

Is CaptureVideo really the only method that needs this retrying?

CaptureVideo is the only command currently which can trigger DP FSM, There are other commands such as StartVideoCapture but we don't use them, But will add those incase somebody uses it.

Thanks for the review and feedback petri.

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev