Skip to contentSkip to conversation

iio: adc: mxs-lradc-adc: use iio_device_id() helper

PATCH In review Alexandru Ardelean 2 participants 2 messages May 4, 2021 – May 8, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 iio: adc: mxs-lradc-adc: use iio_device_id() helper

The @id field was moved in commit e58bb7a74dca ("iio: core: move @id from struct iio_dev to struct iio_dev_opaque"), however this driver was omitted by accident, because the name of the IIO device is 'iio'.

This was caught by the lkp bot.

Fixes e58bb7a74dca ("iio: core: move @id from struct iio_dev to struct iio_dev_opaque")
---
 drivers/iio/adc/mxs-lradc-adc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/adc/mxs-lradc-adc.c +1 -1
index 30e29f44ebd2..1d99170d3328 100644
@@ -455,7 +455,7 @@ static int mxs_lradc_adc_trigger_init(struct iio_dev *iio)
 	struct mxs_lradc_adc *adc = iio_priv(iio);
 
 	trig = devm_iio_trigger_alloc(&iio->dev, "%s-dev%i", iio->name,
-				      iio->id);
+				      iio_device_id(iio));
 	if (!trig)
 		return -ENOMEM;
 
Signature · 1 line
2.31.1
maintainer
#1 lore raw
Quoted 9 lines · On Tue, 4 May 2021 10:53:04 +0300 Alexandru Ardelean <[email protected]>…

The @id field was moved in commit e58bb7a74dca ("iio: core: move @id from struct iio_dev to struct iio_dev_opaque"), however this driver was omitted by accident, because the name of the IIO device is 'iio'.

This was caught by the lkp bot.

Fixes e58bb7a74dca ("iio: core: move @id from struct iio_dev to struct iio_dev_opaque")

Thanks. I applied this as a fixup as that branch hadn't yet gone out as non rebasing and I don't want to break bisection.

Also chased down how I'd missed this on in my test .config.

Jonathan

Quoted 17 lines
---
 drivers/iio/adc/mxs-lradc-adc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/adc/mxs-lradc-adc.c +1 -1
index 30e29f44ebd2..1d99170d3328 100644
@@ -455,7 +455,7 @@ static int mxs_lradc_adc_trigger_init(struct iio_dev *iio)
 	struct mxs_lradc_adc *adc = iio_priv(iio);
 
 	trig = devm_iio_trigger_alloc(&iio->dev, "%s-dev%i", iio->name,
-				      iio->id);
+				      iio_device_id(iio));
 	if (!trig)
 		return -ENOMEM;