Skip to contentSkip to conversation

net: wireless: zydas: Prefer pr_err over printk error msg

PATCH In review Saurav Girepunje 2 participants 2 messages May 6, 2021 – Jun 15, 2021

Subsystems (3)
Networking Network drivers ZD1211RW wireless driver
lore
Share & tools
lore

Saurav Girepunje

author
#0 lore raw

PATCH 1/1 net: wireless: zydas: Prefer pr_err over printk error msg

In zd_usb.c usb_init we can prefer pr_err() over printk KERN_ERR log level.

Signed-off-by Saurav Girepunje <[email protected]>
---
 drivers/net/wireless/zydas/zd1211rw/zd_usb.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/wireless/zydas/zd1211rw/zd_usb.c +2 -2
index 5c4cd0e1adeb..a7ceef10bf6a 100644
@@ -1544,14 +1544,14 @@ static int __init usb_init(void)
 
 	zd_workqueue = create_singlethread_workqueue(driver.name);
 	if (zd_workqueue == NULL) {
-		printk(KERN_ERR "%s couldn't create workqueue\n", driver.name);
+		pr_err("%s couldn't create workqueue\n", driver.name);
 		return -ENOMEM;
 	}
 
 	r = usb_register(&driver);
 	if (r) {
 		destroy_workqueue(zd_workqueue);
-		printk(KERN_ERR "%s usb_register() failed. Error number %d\n",
+		pr_err("%s usb_register() failed. Error number %d\n",
 		       driver.name, r);
 		return r;
 	}

--
2.25.1

#1 lore raw

Re: zd1211rw: Prefer pr_err over printk error msg

Quoted 4 lines · Saurav Girepunje

In zd_usb.c usb_init we can prefer pr_err() over printk KERN_ERR log level.

Signed-off-by Saurav Girepunje <[email protected]>

Patch applied to wireless-drivers-next.git, thanks.

29d97219f403 zd1211rw: Prefer pr_err over printk error msg

Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/patch/20210506044838.GA7260@user/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches